src/slave/containerizer/mesos/provisioner/backends/aufs.cpp
c2cdd9310e84c94e48f2e72de96ddced5b3d2e41
Diff: https://reviews.apache.org/r/68595/diff/2/
Changes: https://reviews.apache.org/r/68595/diff/1-2/
Testing
---
sudo make check
Thanks,
Jie Yu
agent
recovery.
Diffs
-
src/slave/containerizer/mesos/provisioner/backends/copy.cpp
d3eb6b443d49e1cd6cfd7fa3be1776155e8a1bb0
Diff: https://reviews.apache.org/r/68597/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
,
Jie Yu
y.cpp
e32b9918ac15122477e05ebe701c9425bbefa809
Diff: https://reviews.apache.org/r/68594/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
s.cpp
c2cdd9310e84c94e48f2e72de96ddced5b3d2e41
Diff: https://reviews.apache.org/r/68595/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68562/#review208113
---
Ship it!
Ship It!
- Jie Yu
On Aug. 29, 2018, 8:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67984/#review208108
---
Ship it!
Ship It!
- Jie Yu
On Aug. 6, 2018, 6:46 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68454/#review208107
---
Ship it!
Ship It!
- Jie Yu
On Aug. 28, 2018, 11:26 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67930/#review208106
---
Ship it!
Ship It!
- Jie Yu
On Aug. 25, 2018, 9:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68550/#review208072
---
Ship it!
Ship It!
- Jie Yu
On Aug. 28, 2018, 9:46 p.m
35-937 (patched)
<https://reviews.apache.org/r/68454/#comment291811>
No need for this tmp variable.
src/uri/fetchers/docker.cpp
Lines 982-986 (patched)
<https://reviews.apache.org/r/68454/#comment291812>
Ditto. No need for this tmp variable.
- Jie Yu
On Aug. 25, 2018, 9:57
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/#review208062
---
Ship it!
Ship It!
- Jie Yu
On Aug. 17, 2018, 3:37 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68527/#review207993
---
Ship it!
Ship It!
- Jie Yu
On Aug. 27, 2018, 8:54 p.m
> On Aug. 24, 2018, 5:45 a.m., Jie Yu wrote:
> > src/uri/fetchers/docker.cpp
> > Lines 235 (patched)
> > <https://reviews.apache.org/r/68454/diff/2/?file=2076952#file2076952line235>
> >
> > Can you check with Andy. Let's be consisent on doing
> On Aug. 24, 2018, 5:45 a.m., Jie Yu wrote:
> > src/uri/fetchers/docker.cpp
> > Lines 235 (patched)
> > <https://reviews.apache.org/r/68454/diff/2/?file=2076952#file2076952line235>
> >
> > Can you check with Andy. Let's be consisent on doing
g/r/67930/#comment291399>
We can use a constant like `TEST_REPOSITORY` in the top of this file? lile
`TEST_DIGEST`?
- Jie Yu
On Aug. 6, 2018, 6:46 p.m., Liangyu Zhao wrote:
>
> ---
> This is an automatically genera
<https://reviews.apache.org/r/68454/#comment291397>
Please do j++ to be consistent with i++ above.
src/uri/fetchers/docker.cpp
Lines 1026 (patched)
<https://reviews.apache.org/r/68454/#comment291391>
Let's avoid nesting by dealing with failure first:
```
if (urls
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68455/#review207805
---
Ship it!
Ship It!
- Jie Yu
On Aug. 21, 2018, 9:30 p.m
(), [=](int code) {
if (code == http::Status::OK) {
return Nothing();
}
return _urlFetchBlob(blobUri, directory, authHeaders, urls);
});
}
```
- Jie Yu
On Aug. 21, 2018, 9:30 p.m., Liangyu Zhao wrote:
>
>
i, directory, blobUri, authHeaders, code);
#else
return Failure(
"Unexpected HTTP response '" + http::Status::string(code) + "' "
"when trying to download the blob&quo
s a long chain and might not be
easy to tweak. Feel free to ignore this
src/uri/fetchers/docker.cpp
Lines 897 (patched)
<https://reviews.apache.org/r/68453/#comment291308>
I'd use `.repair` instead
- Jie Yu
On Aug. 21, 2018, 9:29 p.m., Liangyu Zhao wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68451/#review207800
---
Can you add unit test for the validate function?
- Jie Yu
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68451/#review207799
---
Ship it!
Ship It!
- Jie Yu
On Aug. 21, 2018, 9:29 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68450/#review207798
---
Ship it!
Ship It!
- Jie Yu
On Aug. 21, 2018, 9:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68458/#review207703
---
Ship it!
Ship It!
- Jie Yu
On Aug. 21, 2018, 9:42 p.m
----------
On Aug. 21, 2018, 4:45 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68443/
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68448/#review207684
---
Ship it!
Ship It!
- Jie Yu
On Aug. 21, 2018, 7:16 p.m
bcddea2f8606f71fc46a39debca323d85c1d94c1
src/slave/flags.cpp fd208f64416ae865b81c8ba5950b20bde6be00a3
Diff: https://reviews.apache.org/r/68443/diff/2/
Changes: https://reviews.apache.org/r/68443/diff/1-2/
Testing
---
trivial
Thanks,
Jie Yu
/68443/diff/1/
Testing
---
trivial
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68397/#review207638
---
Ship it!
Ship It!
- Jie Yu
On Aug. 20, 2018, 9:38 p.m
Took 55.xxx secs to destroy 1000 containers
After the patch
Took 37.xxx secs to launch 1000 containers
Took 26.xxx secs to destroy 1000 containers
Thanks,
Jie Yu
b80e40b6f4b18e076ebb3c1668f475286c337127
Diff: https://reviews.apache.org/r/68426/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
---
sudo make check
Thanks,
Jie Yu
> On Aug. 16, 2018, 10:34 p.m., Jie Yu wrote:
> > src/uri/fetchers/docker.cpp
> > Lines 682 (patched)
> > <https://reviews.apache.org/r/67931/diff/6/?file=2071252#file2071252line683>
> >
> > I'd rather treating fetching v2 schema 2 manifest as
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68417/#review207551
---
Ship it!
Ship It!
- Jie Yu
On Aug. 17, 2018, 9:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63270/#review207549
---
Ship it!
Ship It!
- Jie Yu
On Aug. 17, 2018, 5:53 p.m
--
>
> (Updated Aug. 17, 2018, 5:53 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin
> Mahler, Greg Mann, and Jie Yu.
>
>
> Bugs: MESOS-8128
> https://issues.apache.org/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63280/#review207527
---
Ship it!
Ship It!
- Jie Yu
On Aug. 17, 2018, 6:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68413/#review207515
---
Ship it!
Ship It!
- Jie Yu
On Aug. 17, 2018, 5:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68396/#review207453
---
Ship it!
Ship It!
- Jie Yu
On Aug. 16, 2018, 11:18 p.m
> On Aug. 16, 2018, 10:34 p.m., Jie Yu wrote:
> > src/uri/fetchers/docker.cpp
> > Lines 682 (patched)
> > <https://reviews.apache.org/r/67931/diff/6/?file=2071252#file2071252line683>
> >
> > I'd rather treating fetching v2 schema 2 manifest as
c code in
`__fetchBlob`. Basically, if you got a 404 on windows, do the extra steps to
fetch the v2_2 manifest, and try to download the uri.
In this way, you don't need to change the core logic.
- Jie Yu
On Aug. 6, 2018, 6:45 p.m., Liangyu Zhao wrote:
>
> ---
> On Aug. 15, 2018, 8:50 p.m., Jie Yu wrote:
> > what’s the filesystem layout for the cache when v2 schema 2 is used?
> > The layout for schema 1 is here:
> > https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/provisioner/docker/paths.hpp#L31-L46
>
> On Aug. 15, 2018, 8:50 p.m., Jie Yu wrote:
> > what’s the filesystem layout for the cache when v2 schema 2 is used?
> > The layout for schema 1 is here:
> > https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/provisioner/docker/paths.hpp#L31-L46
>
used?
The layout for schema 1 is here:
https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/provisioner/docker/paths.hpp#L31-L46
as far as I know, layer_id does not apply to schema 2. What do you use for the
key?
- Jie Yu
On Aug. 6, 2018, 6:45 p.m., Liangyu Zhao wrote
(patched)
<https://reviews.apache.org/r/68355/#comment290694>
Errors must be indicated by a non-zero return code
- Jie Yu
On Aug. 15, 2018, 6:02 a.m., Sergey Urbanovich wrote:
>
> ---
> This is an automatically generated e
s.cpp
Lines 2428 (patched)
<https://reviews.apache.org/r/68355/#comment290642>
No need for this.
- Jie Yu
On Aug. 15, 2018, 1:47 a.m., Sergey Urbanovich wrote:
>
> ---
> This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68054/#review207302
---
Ship it!
Ship It!
- Jie Yu
On Aug. 15, 2018, 1:46 a.m
/containerizer/cni_isolator_tests.cpp
419c94d601cd588c893a5324c4aef71c40ec0f61
Diff: https://reviews.apache.org/r/68335/diff/2/
Changes: https://reviews.apache.org/r/68335/diff/1-2/
Testing
---
sudo make check
Thanks,
Jie Yu
che.org/r/68334/#review207216
---
On Aug. 13, 2018, 11:04 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
256 (patched)
<https://reviews.apache.org/r/68054/#comment290488>
I would like to add the cleanup code to `CniIsolatorTest::cleanup`.
It's possible that the test is ended with sigkill or ctrl+c. And `ip link
add name vethmesostest0 type veth peer name vethmesostestns
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68053/#review207184
---
Ship it!
Ship It!
- Jie Yu
On July 31, 2018, 5:30 p.m
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
f46c962d8f044092aaa113fafc536c6b25bab45c
Diff: https://reviews.apache.org/r/68334/diff/3/
Changes: https://reviews.apache.org/r/68334/diff/2-3/
Testing
---
sudo make check
Thanks,
Jie Yu
sting
---
sudo make check
Thanks,
Jie Yu
/containerizer/cni_isolator_tests.cpp
cb22e73b4215b5b0a49ac610e5f657b73d38963b
Diff: https://reviews.apache.org/r/68335/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
k/cni/cni.cpp
f46c962d8f044092aaa113fafc536c6b25bab45c
Diff: https://reviews.apache.org/r/68334/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
that the cleanup does
not fail in those scenarios.
Diffs
-
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
f46c962d8f044092aaa113fafc536c6b25bab45c
Diff: https://reviews.apache.org/r/68333/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
*
--benchmark
Thanks,
Jie Yu
*
--benchmark
Thanks,
Jie Yu
*
--benchmark
Thanks,
Jie Yu
*
--benchmark
Thanks,
Jie Yu
/mesos_containerizer_benchmarks.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/68266/diff/1/
Testing
---
sudo bin/mesos-tests.sh --gtest_filter=*MesosContainerizer_BENCHMARK_Test*
--benchmark
Thanks,
Jie Yu
://reviews.apache.org/r/68239/diff/2-3/
Testing
---
sudo make check
Thanks,
Jie Yu
```
[ OK ] CniIsolatorPortMapperTest.ROOT_INTERNET_CURL_PortMapper (8827 ms)
```
Thanks,
Jie Yu
> > loop here so not opening an issue.
Good idea!
> On Aug. 6, 2018, 10:35 p.m., Chun-Hung Hsiao wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp
> > Line 2000 (original), 2045-2047 (patched)
> > <https://reviews.apache.org/r/68239/diff/2/?file=2069278#file
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68158/#review206904
-----------
On Aug. 6, 2018, 8:30 p.m., Jie Yu wrote:
>
>
sos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
f1a3d263b7baa3ccbf270426745022d42fcc66ed
Diff: https://reviews.apache.org/r/68158/diff/4/
Changes: https://reviews.apache.org/r/68158/diff/3-4/
Testing
---
sudo make check
```
[ OK ] CniIsolatorPortMapperTest.ROOT_INTERNET_CURL_PortMapper (8827 ms)
```
Thanks,
Jie Yu
/
Testing
---
sudo make check
Thanks,
Jie Yu
(patched)
<https://reviews.apache.org/r/68239/#comment290017>
indent
- Jie Yu
On Aug. 6, 2018, 4:53 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/values.hpp 39487b955fc1a3c963f69de66ba0da869dd3ab2e
src/tests/containerizer/cni_isolator_tests.cpp
90d2d4103c8136d2dd883318acc135f7efca80d8
Diff: https://reviews.apache.org/r/68239/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
erTest.ROOT_INTERNET_CURL_PortMapper (8827 ms)
```
Thanks,
Jie Yu
> On Aug. 5, 2018, 5:46 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/volume/host_path.cpp
> > Lines 318 (patched)
> > <https://reviews.apache.org/r/68203/diff/2/?file=2067547#file2067547line319>
> >
> > I'd suggest we sepa
Lines 318 (patched)
<https://reviews.apache.org/r/68203/#comment289964>
I'd suggest we separate this patch, and have one patch for each isolator
(we might want to backport a few, like host path volume).
Also, add unit test for each isolator.
- Jie Yu
On Aug. 4, 2018, 9:58
twork/cni/plugins/port_mapper/port_mapper.cpp
c40b57f78193520f9f0b901201b5c4c855cde8b3
Diff: https://reviews.apache.org/r/68158/diff/2/
Testing
---
sudo make check
```
[ OK ] CniIsolatorPortMapperTest.ROOT_INTERNET_CURL_PortMapper (8827 ms)
```
Thanks,
Jie Yu
sting
---
sudo make check
```
[ OK ] CniIsolatorPortMapperTest.ROOT_INTERNET_CURL_PortMapper (8827 ms)
```
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68167/#review206806
---
Ship it!
Ship It!
- Jie Yu
On Aug. 2, 2018, 4:30 p.m., Greg
1b5c4c855cde8b3
Diff: https://reviews.apache.org/r/68158/diff/1/
Testing
---
sudo make check
```
[ OK ] CniIsolatorPortMapperTest.ROOT_INTERNET_CURL_PortMapper (8827 ms)
```
Thanks,
Jie Yu
ssage:
```
Previously, we are missing a `-w` option for one iptable command, which will
cause the iptables command to fail if any application is holding the xtables
lock. By using `-w`, the iptables will wait for the xtables lock to be
released, instead of failing.
```
- Jie Yu
On Aug. 1, 2018, 10:2
g/r/68054/#comment289534>
Instead of passing in container network struct, i'd suggest we just pass in
ifName:
```
Try NetworkCniIsolatorProcess::_usage(
const hashmap ifNames)
```
- Jie Yu
On July 27, 2018, 11:36 p.m., Sergey
) If the Process to be resumed on the looper thread is a super busy thread,
meaning that the message queue is never empty, the looper thread won't get a
chance to execute its tasks on its stack.
- Jie Yu
On July 27, 2018, 8:35 p.m., Sergey Urb
s 277 (patched)
<https://reviews.apache.org/r/68053/#comment289523>
Ditto on period.
src/tests/containerizer/ns_tests.cpp
Lines 286 (patched)
<https://reviews.apache.org/r/68053/#comment289524>
Ditto on period.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67936/#review206406
---
Ship it!
Ship It!
- Jie Yu
On July 17, 2018, 8:12 p.m
/port_mapping_tests.cpp
Lines 1826 (patched)
<https://reviews.apache.org/r/67936/#comment289044>
instead of hard code 512 which is fragile, i'd get `ephemeral_ports`
resources, and use more than half of that.
- Jie Yu
On July 16, 2018, 11:14 p.m., Ilya P
caller to call `verify`,
making read/write/create pure helper for writing to cgroup filesystem.
- Jie Yu
On July 16, 2018, 2:03 a.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67892/#review206076
---
Ship it!
Ship It!
- Jie Yu
On July 13, 2018, 6:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67669/#review206068
---
Ship it!
Ship It!
- Jie Yu
On July 10, 2018, 8:31 p.m
/hierarchical.cpp
Line 925 (original), 938 (patched)
<https://reviews.apache.org/r/67876/#comment289018>
indentation should be 4 here since we treat `CHECK_EQ` as a function
- Jie Yu
On July 10, 2018, 9:13 p.m., Chun-Hung Hsiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67881/#review205955
---
Ship it!
Ship It!
- Jie Yu
On July 10, 2018, 11:14 p.m
/network/cni/cni.cpp
Lines 443 (patched)
<https://reviews.apache.org/r/67769/#comment288441>
I would print out LOG(ERROR) in the continuation if cleanup fails.
- Jie Yu
On June 29, 2018, 1:41 a.m., Qian Zhang wrote:
>
> -
440 (original), 442 (patched)
<https://reviews.apache.org/r/67769/#comment288414>
I would use 'await' here so that the agent will still start if cleanup
fails.
- Jie Yu
On June 28, 2018, 1:32 p.m., Qian Zhang wrote:
>
>
-
On June 26, 2018, 5:36 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67737/
> -
b58a9caca136cfa42689159389bfdcb3f92f05ee
Diff: https://reviews.apache.org/r/67737/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67728/#review205314
-----------
On June 25, 2018, 7 p.m., Jie Yu wrote:
>
> --
iff: https://reviews.apache.org/r/67728/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67398/#review205185
---
Ship it!
Ship It!
- Jie Yu
On June 15, 2018, 1 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67596/#review204883
---
Ship it!
Ship It!
- Jie Yu
On June 14, 2018, 3:47 a.m
Lines 1017-1028 (original), 1012-1028 (patched)
<https://reviews.apache.org/r/67398/#comment287214>
Any reason we cannot use a named pipe as well here?
- Jie Yu
On June 7, 2018, 12:40 p.m., Benjamin Bannier wrote:
>
> ---
(patched)
<https://reviews.apache.org/r/67421/#comment287212>
Can you use `DEFAULT_TEST_ROLE` here?
```
flags.resources = strings::format(
"disk(%s):1024",
DEFAULT_TEST_ROLE).get();
```
- Jie Yu
On June 6, 2018, 12:08 a.m.,
> On June 12, 2018, 6:17 p.m., Jie Yu wrote:
> > src/slave/gc.cpp
> > Lines 262 (patched)
> > <https://reviews.apache.org/r/67423/diff/2/?file=2035399#file2035399line262>
> >
> > This is a bit hacky. A better way should be modify `os::rmdir` to
)
<https://reviews.apache.org/r/67423/#comment287207>
This is a bit hacky. A better way should be modify `os::rmdir` to return
`Try`. The second template parameter is the error code.
Can you add a TODO?
- Jie Yu
On June 2, 2018, 5:30 a.m., Zhitao Li
101 - 200 of 4368 matches
Mail list logo
