---
make check
Thanks,
Jie Yu
sting
---
make check
Thanks,
Jie Yu
nation.
Maybe we should create a `staging` directory under `configDir` and write
the tmp file there and then do a rename.
That also means that the daemon has to skip the `staging` directory.
- Jie Yu
On Dec. 8, 2017, 10 p.m., Chun-Hung Hsiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64438/#review193314
---
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2017, 2:58 a.m., Chun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64440/#review193311
---
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2017, 3:59 a.m., Chun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64468/#review193310
---
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2017, 9:59 p.m., Chun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64437/#review193308
---
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2017, 5:54 a.m., Chun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64441/#review193307
---
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2017, 4:56 a.m., Chun
e.cpp 373e393ca1e7c0c30c3474cc9e630e25ad92f235
src/tests/resource_provider_manager_tests.cpp
a6eb4c9a303780029244e069bdf550a8cd9c7bb4
Diff: https://reviews.apache.org/r/64477/diff/1/
Testing
---
make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64457/#review193273
---
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2017, 6:53 p.m., Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64440/#review193222
---
please add some unit test
- Jie Yu
On Dec. 8, 2017, 3:59 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63901/#review193221
---
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2017, 2:56 a.m., Chun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64437/#review193220
---
Please make sure the test file only build on linux.
- Jie Yu
egory`
- Jie Yu
On Dec. 8, 2017, 12:17 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64424/#review193217
---
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2017, 12:17 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64423/#review193218
---
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2017, 12:17 a.m
perations
from all providers as well as agent default resources, while
message.offer_operations is only for agent default resources?
- Jie Yu
On Dec. 8, 2017, 12:17 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatica
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64422/#review193215
---
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2017, 12:17 a.m
(patched)
<https://reviews.apache.org/r/64299/#comment271751>
kill this line?
- Jie Yu
On Dec. 7, 2017, 7:04 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64425/#review193205
---
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2017, 12:17 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64298/#review193131
---
Ship it!
Ship It!
- Jie Yu
On Dec. 4, 2017, 1:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63555/#review193187
---
Ship it!
Ship It!
- Jie Yu
On Dec. 7, 2017, 9:33 a.m., Chun
)
<https://reviews.apache.org/r/64422/#comment271651>
Should we change this to
`optional bytes resource_version_uuid`?
- Jie Yu
On Dec. 7, 2017, 5:49 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63388/#review193180
---
Ship it!
Ship It!
- Jie Yu
On Dec. 7, 2017, 6:38 p.m., Chun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64398/#review193185
---
Ship it!
Ship It!
- Jie Yu
On Dec. 7, 2017, 10:20 p.m
> On Dec. 7, 2017, 6:37 p.m., Jie Yu wrote:
> > src/messages/messages.proto
> > Lines 693-701 (original), 693-701 (patched)
> > <https://reviews.apache.org/r/64422/diff/1/?file=1910528#file1910528line693>
> >
> > So the idea for these fields are for ag
)
<https://reviews.apache.org/r/64423/#comment271664>
Let's use `previousOversubscribedResources` here to be more explicit
src/slave/slave.cpp
Lines 6850 (patched)
<https://reviews.apache.org/r/64423/#comment271660>
fix style issue
- Jie Y
> On Dec. 7, 2017, 6:37 p.m., Jie Yu wrote:
> > src/messages/messages.proto
> > Lines 693-701 (original), 693-701 (patched)
> > <https://reviews.apache.org/r/64422/diff/1/?file=1910528#file1910528line693>
> >
> > So the idea for these fields are for ag
gt;
why optional?
src/messages/messages.proto
Lines 720-721 (patched)
<https://reviews.apache.org/r/64422/#comment271648>
any reason those are optional?
- Jie Yu
On Dec. 7, 2017, 5:49 p.m., Benjamin Bannier wrote:
>
>
too. I saw this
code being duplicated three times in this function :(
- Jie Yu
On Dec. 4, 2017, 1:12 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64400/#review193090
---
Ship it!
Ship It!
- Jie Yu
On Dec. 7, 2017, 3:14 a.m., Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64399/#review193089
---
Ship it!
Ship It!
- Jie Yu
On Dec. 7, 2017, 3:13 a.m., Greg
/reviews.apache.org/r/63555/#comment271578>
I would just use sleep 1000 here.
src/tests/slave_tests.cpp
Lines 8961-8964 (patched)
<https://reviews.apache.org/r/63555/#comment271581>
Can we call `subscribedDefault`?
-
't have to adjust
the tests when we switch to v3 (deprecating v1)
- Jie Yu
On Dec. 6, 2017, 8:06 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64335/#review193072
---
Ship it!
Ship It!
- Jie Yu
On Dec. 5, 2017, 10:59 a.m., Jan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63971/#review193065
---
Ship it!
Ship It!
- Jie Yu
On Dec. 6, 2017, 11:50 p.m
> On Dec. 6, 2017, 6:37 p.m., Jie Yu wrote:
> > include/mesos/resource_provider/volume_profile.hpp
> > Lines 92 (patched)
> > <https://reviews.apache.org/r/63971/diff/3/?file=1909252#file1909252line92>
> >
> > We chatted about having an ability to de
> On Dec. 6, 2017, 8:04 p.m., Jie Yu wrote:
> > include/mesos/resource_provider/volume_profile.hpp
> > Lines 104-105 (patched)
> > <https://reviews.apache.org/r/63971/diff/3/?file=1909252#file1909252line104>
> >
> > Do we intend to use this module
> On Dec. 6, 2017, 8:04 p.m., Jie Yu wrote:
> > include/mesos/resource_provider/volume_profile.hpp
> > Lines 104-105 (patched)
> > <https://reviews.apache.org/r/63971/diff/3/?file=1909252#file1909252line104>
> >
> > Do we intend to use this module
(patched)
<https://reviews.apache.org/r/63971/#comment271552>
I'd suggest we use `ResourceProviderInfo` here so that some module might
choose to match based on provider ID.
- Jie Yu
On Dec. 6, 2017, 11:37 p.m., Jose
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64385/#review193054
---
Ship it!
Ship It!
- Jie Yu
On Dec. 6, 2017, 4:33 p.m
(patched)
<https://reviews.apache.org/r/63022/#comment271532>
We can use `protobuf::createOfferOperation` here.
- Jie Yu
On Dec. 6, 2017, 7:50 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e
> On Dec. 6, 2017, 8:04 p.m., Jie Yu wrote:
> > include/mesos/resource_provider/volume_profile.hpp
> > Lines 104-105 (patched)
> > <https://reviews.apache.org/r/63971/diff/3/?file=1909252#file1909252line104>
> >
> > Do we intend to use this module
ique per RP. Some distribution might choose to
do cluster wide unique, but that's their choice.
With that in mind, maybe include ResourceProviderInfo in the request?
- Jie Yu
On Dec. 5, 2017, 10:06 p.m., Joseph Wu wrote:
>
> --
/type_utils.cpp 1b466fcfd133b6fd0067668c7ba54d1ce80c8702
src/resource_provider/storage/provider.cpp
d35b0d02992e3730ca47906b34c21e1ba9c653e7
src/v1/mesos.cpp 2c81b37468dc27da863eb8a56a213436b94b73de
Diff: https://reviews.apache.org/r/64389/diff/1/
Testing
---
make check
Thanks,
Jie Yu
ailure)?
That means no resource will be sent out using default volume profile
adaptor?
That makes me wondering why we need a default volume provider adaptor. Can
you just make the uri voluem profiler adaptor the default?
- Jie Yu
On Dec. 5, 2017, 10:09 p.m., Joseph Wu
org/r/63971/#comment271485>
We chatted about having an ability to define a default profile. To support
that, maybe `profile` here needs to be Optional?
- Jie Yu
On Dec. 5, 2017, 10:06 p.m., Joseph Wu wrote:
>
> ---
> This is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64351/#review193012
---
Ship it!
Ship It!
- Jie Yu
On Dec. 5, 2017, 10:05 p.m
the interface is something we never do in other places.
I'd suggest we keep track of a hashmap with key being the operation uuid.
- Jie Yu
On Dec. 5, 2017, 2:19 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically
src/resource_provider/storage/provider.cpp
Lines 1636-1640 (patched)
<https://reviews.apache.org/r/63387/#comment271326>
DO you need this?
src/resource_provider/storage/provider.cpp
Lines 1704-1708 (patched)
<https://reviews.apache.org/r/63387/#comment271327>
Do you need th
-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63022/
> -------
>
> (Updated Dec. 5, 2017, 5:5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63022/#review192943
---
Ship it!
Ship It!
- Jie Yu
On Dec. 5, 2017, 5:57 a.m., Chun
)
<https://reviews.apache.org/r/64146/#comment271237>
`operation != nullptr`
- Jie Yu
On Dec. 5, 2017, 7:07 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64143/#review192891
---
Ship it!
Ship It!
- Jie Yu
On Dec. 5, 2017, 7:33 a.m., Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64144/#review192890
---
Ship it!
Ship It!
- Jie Yu
On Dec. 5, 2017, 7:06 a.m., Greg
te a default profile. Please just not set the
profile field.
- Jie Yu
On Dec. 5, 2017, 2:18 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63498/#review192810
---
Ship it!
Ship It!
- Jie Yu
On Dec. 5, 2017, 12:45 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64320/#review192805
---
Ship it!
Ship It!
- Jie Yu
On Dec. 5, 2017, 1:46 a.m., Chun
)
<https://reviews.apache.org/r/63023/#comment271001>
2 lines apart
src/csi/utils.cpp
Lines 68 (patched)
<https://reviews.apache.org/r/63023/#comment271002>
mount flag order is not important.
- Jie Yu
On Nov. 28, 2017, 6 a.m., Chun-Hung
tps://reviews.apache.org/r/64158/#comment271093>
Copy paste error?
Please be extremely careful on this!
- Jie Yu
On Nov. 29, 2017, 1:52 p.m., Jan Schlicht wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64272/#review192753
---
Ship it!
Ship It!
- Jie Yu
On Dec. 1, 2017, 11:37 p.m
(original), 1367-1368 (patched)
<https://reviews.apache.org/r/63498/#comment270995>
This might break some toolings. Let's call out this in the CHANGELOG and
upgrade.md.
- Jie Yu
On Nov. 4, 2017, 1:13 a.m., Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63386/#review192715
---
Ship it!
Ship It!
- Jie Yu
On Dec. 4, 2017, 10:23 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64294/#review192713
---
Ship it!
Ship It!
- Jie Yu
On Dec. 4, 2017, 10:23 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63823/#review192597
---
Ship it!
Ship It!
- Jie Yu
On Dec. 1, 2017, 1:34 a.m., Chun
g the NOne() case here. Might
worth printing a warning or info here.
src/resource_provider/storage/provider.cpp
Line 414 (original), 445 (patched)
<https://reviews.apache.org/r/64075/#comment270844>
Can you handle None() case here? or at least add some comment about why
it's ok t
)
<https://reviews.apache.org/r/64075/#comment270845>
We should update CMake for this
- Jie Yu
On Dec. 1, 2017, 1:47 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
/provider.cpp
Lines 465 (patched)
<https://reviews.apache.org/r/64044/#comment270747>
Let's use csiPluginContainerInfo
- Jie Yu
On Dec. 1, 2017, 1:38 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically genera
)
<https://reviews.apache.org/r/63021/#comment270822>
Can you add a TODO here? This is a bit hacky way to get the v1 operator API
endpoint.
- Jie Yu
On Dec. 1, 2017, 1:36 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64258/#review192572
---
Ship it!
Ship It!
- Jie Yu
On Dec. 1, 2017, 8:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64257/#review192571
---
Ship it!
Ship It!
- Jie Yu
On Dec. 1, 2017, 8:11 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64256/#review192570
---
Ship it!
Ship It!
- Jie Yu
On Dec. 1, 2017, 8:11 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64255/#review192569
---
Ship it!
Ship It!
- Jie Yu
On Dec. 1, 2017, 8:10 p.m
)
<https://reviews.apache.org/r/63021/#comment270749>
I'd rename this to `getCSIPluginContainerInfo`
- Jie Yu
On Dec. 1, 2017, 1:36 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-m
c/resource_provider/storage/provider.cpp
Lines 591 (patched)
<https://reviews.apache.org/r/63021/#comment270735>
You need to return after calling `fatal`
- Jie Yu
On Dec. 1, 2017, 1:36 a.m., Chun-Hung Hsiao wrote:
>
> ---
>
src/resource_provider/storage/provider.cpp
Lines 260 (patched)
<https://reviews.apache.org/r/63823/#comment270597>
why not return a failure if `realpath.isError`?
- Jie Yu
On Dec. 1, 2017, 1:34 a.m., Chun-Hung Hsiao wrote:
>
> --
)
<https://reviews.apache.org/r/63860/#comment270576>
It's weird that user specifies HOST in the API, but we use "nat" instead.
Why can't we use transparent? I don't quite get that from the comments.
- Jie Yu
On Nov. 27, 201
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64236/#review192425
---
Ship it!
Ship It!
- Jie Yu
On Dec. 1, 2017, 1:03 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63277/#review192422
---
Ship it!
Ship It!
- Jie Yu
On Nov. 6, 2017, 11:19 p.m
'd use
```
const Resources resources = containerConfig.resources();
```
Using `{...}` is fragile if we add more fields to `Resources` object.
src/slave/containerizer/mesos/isolators/windows/mem.hpp
Lines 67-68 (patched)
<https://reviews.apache.org/r/63276/#comment270560&g
upported == nsTypes;`
src/linux/ns.cpp
Lines 143 (patched)
<https://reviews.apache.org/r/64226/#comment270516>
We don't print glog warning in helpers. What if we want to use this in
launch helper?
I'd prefer return `Try`
- Jie Yu
On
eadc008fbdc53a95ab80584ffcd9b76a4a67a3c2
Diff: https://reviews.apache.org/r/64233/diff/2/
Changes: https://reviews.apache.org/r/64233/diff/1-2/
Testing
---
make check
Thanks,
Jie Yu
.
Repository: mesos
Description
---
Removed some dead code in the master.
Diffs
-
src/master/master.cpp eadc008fbdc53a95ab80584ffcd9b76a4a67a3c2
Diff: https://reviews.apache.org/r/64233/diff/1/
Testing
---
make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64145/#review192397
---
Ship it!
Ship It!
- Jie Yu
On Nov. 29, 2017, 6 p.m., Greg
tps://reviews.apache.org/r/64144/#comment270508>
Can you add a CHECK here asserting that the slave has RESOURCE_PROVIDER
capability?
- Jie Yu
On Nov. 29, 2017, 5:47 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e
usUpdate`.
If there is a fail over, and the update is lost, the agent will reconcile
with the master during re-registration and master will notice that and call
removeOfferOperation there (in updateSlave handler).
- Jie Yu
On Nov. 29, 2017, 5:56
t's make the code consistent on
naming.
- Jie Yu
On Nov. 29, 2017, 5:50 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
ed status (i.e.,
operation->statuses(latest)) and check if that's terminal.
src/master/master.cpp
Line 7490 (original), 7490 (patched)
<https://reviews.apache.org/r/64144/#comment270495>
Maybe make that a CHECK for now?
- Jie Yu
On
(patched)
<https://reviews.apache.org/r/64142/#comment270456>
Can you move this inside the `else if` block below?
- Jie Yu
On Nov. 29, 2017, 5:42 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e
(patched)
<https://reviews.apache.org/r/63804/#comment270448>
Can you also update v1 proto?
- Jie Yu
On Nov. 30, 2017, 6:20 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
/mesos/resource_provider/resource_provider.proto
Lines 91 (patched)
<https://reviews.apache.org/r/63804/#comment270447>
s/master/resource provieer manager/
- Jie Yu
On Nov. 30, 2017, 6:20 p.m., Greg Mann wrote:
>
> --
).
Diffs (updated)
-
src/tests/cluster.cpp 4ff9faf4e5cae5bca4f050d6f2bc2c60d7ee4e6f
Diff: https://reviews.apache.org/r/64218/diff/2/
Changes: https://reviews.apache.org/r/64218/diff/1-2/
Testing
---
make check
Thanks,
Jie Yu
luster.cpp 4ff9faf4e5cae5bca4f050d6f2bc2c60d7ee4e6f
Diff: https://reviews.apache.org/r/64218/diff/1/
Testing
---
make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64158/#review192238
---
Ship it!
Ship It!
- Jie Yu
On Nov. 29, 2017, 1:52 p.m., Jan
tps://reviews.apache.org/r/64151/#comment270262>
Hum, i think we stop adding v0 operator APIs. We should instead add a v1
operator API `GET_RESOURCE_PROVIDERS`
- Jie Yu
On Nov. 29, 2017, 11:23 a.m., Jan Schlicht wrote:
>
> ---
> This is a
ne way is to use `Uuid`,
or `UUIDInfo`. Or we just use `mesos::UUID` through out.
- Jie Yu
On Nov. 29, 2017, 5:07 p.m., Jan Schlicht wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63997/#review192229
---
Ship it!
Ship It!
- Jie Yu
On Nov. 29, 2017, 4:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64136/#review192227
---
Ship it!
Ship It!
- Jie Yu
On Nov. 29, 2017, 4:27 p.m
> On Nov. 29, 2017, 3:09 a.m., Jie Yu wrote:
> > src/tests/slave_tests.cpp
> > Lines 8900-8923 (patched)
> > <https://reviews.apache.org/r/63843/diff/6/?file=1902759#file1902759line8900>
> >
> > It'll be nice to move this logic here to
> &
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63843/#review192223
---
Ship it!
Ship It!
- Jie Yu
On Nov. 29, 2017, 4:27 p.m
501 - 600 of 4368 matches
Mail list logo
