Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

> On April 23, 2015, 5:20 p.m., Michael Park wrote: > > src/common/parse.hpp, line 46 > > <https://reviews.apache.org/r/33296/diff/2/?file=939522#file939522line46> > > > > nit: `s/template<>/template <>/` > > Alexander Rojas wrote: >

Re: Review Request 32150: Enabled the master to handle reservation operations.

d one of them. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/#review79442 --- On April 27, 2015, 10:10 p.m.

Re: Review Request 32150: Enabled the master to handle reservation operations.

zed. In the absense of an ACL, we allow anyone to unreserve any resources. This is a matter of authorization however, so we wouldn't check for the `prinicpal` matching in `validate` even with ACLs. - Michael ------- Thi

Re: Review Request 32150: Enabled the master to handle reservation operations.

generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/#review81139 ------- On April 27, 2015, 10:10 p.m., Michael Park wrote: > > --- > This

Re: Review Request 32150: Enabled the master to handle reservation operations.

/master_validation_tests.cpp 4f2ad58c3ae0f611fb476c4d91a37dd6a5541395 Diff: https://reviews.apache.org/r/32150/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32150: Enabled the master to handle reservation operations.

Thanks for this! Fixed and added a test `FrameworkMissingPrincipal`. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/#review81139 -------

Re: Review Request 32150: Enabled the master to handle reservation operations.

ps://reviews.apache.org/r/32150/#review81139 ------- On April 28, 2015, 10:21 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32150/ >

Re: Review Request 32150: Enabled the master to handle reservation operations.

/master_validation_tests.cpp 4f2ad58c3ae0f611fb476c4d91a37dd6a5541395 Diff: https://reviews.apache.org/r/32150/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32150: Enabled the master to handle reservation operations.

lt. Do > > we need to check it? Can a framework without a principal reserve resources > > (the answer is no, I suppose, because in the current desgin a principal > > register resources, not a framework)? > > > > DO you mind adding tests for these cases? &g

Re: Review Request 32150: Enabled the master to handle reservation operations.

eviews.apache.org/r/32150/#review81945 --- On April 28, 2015, 10:43 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 32150: Enabled the master to handle reservation operations.

mend passing `Option` here? - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/#review82045 --- On April 28, 2015,

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415 Diff: https://reviews.apache.org/r/32149/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

we did in CREATE/DESTROY)? Do you also want to check if each resource > > is dynamically reserved (i.e., has ReservationInfo, role != `*`)? > > Michael Park wrote: > Both of the checks you mentioned are checked by > > ``` > Option master::validation::operatio

Re: Review Request 32150: Enabled the master to handle reservation operations.

dc25995bf57397d42fcde458414f0402d19bf792 src/tests/master_validation_tests.cpp 4f2ad58c3ae0f611fb476c4d91a37dd6a5541395 Diff: https://reviews.apache.org/r/32150/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32150: Enabled the master to handle reservation operations.

> On April 8, 2015, 10:38 p.m., Jie Yu wrote: > > src/master/validation.cpp, lines 581-584 > > <https://reviews.apache.org/r/32150/diff/5/?file=920955#file920955line581> > > > > Is this necessary, or will be captured by the resources contains check &

Re: Review Request 32150: Enabled the master to handle reservation operations.

s > > for integrity of the `resources` instance, but also for inconsistent state > > related to dynamic reservations. Since `resource::validate` doesn't have > > any comment it's unclear here that it does a related but non-obvious check > > for "*&qu

Re: Review Request 32150: Enabled the master to handle reservation operations.

wrote: > > src/master/validation.cpp, line 598 > > <https://reviews.apache.org/r/32150/diff/8/?file=944524#file944524line598> > > > > No snake_case please:) > > > > Also, instead of using a boolean, can you pass an Option > > princip

Re: Review Request 32150: Enabled the master to handle reservation operations.

here please. Added. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/#review82045 --- On May 2, 2015, 12:27 a.m., Michael Park wrote: > > ---

Re: Review Request 29748: Added tests for dynamic reservation.

/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

93c7c8a807a33ab639be6289535bbd32022aa85b src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

chael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/#review81298 ------- On May 2, 2015, 4:14 a.m., Michael Park wrote: > > -

Re: Review Request 29748: Added tests for dynamic reservation.

rt a > > slave with `"cpus:1;mem:512;disk:0;ports:[]"` resources, while expect > > `"cpus:1;mem:512"` in the offer. > > Michael Park wrote: > The slave resources are specified as `cpus:1;mem:512;disk:0;ports:[]` > because we use `Containerizer:

Re: Review Request 29748: Added tests for dynamic reservation.

> On April 23, 2015, 1:48 p.m., Michael Park wrote: > > As of now, the tests seem to take a long time to complete. We should > > investigate what the issue is before committing this patch. > > Jie Yu wrote: > I suspect this is due to the default allocation interv

Re: Review Request 32398: Persisted the reservation state on the slave.

get it done. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398/#review83027 --- On April 15, 2015, 3:55 p.m., Michael Park wrote: > > --

Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

rs > > for our proto messages in `type_utils.{hpp|cpp}`: > > https://reviews.apache.org/r/31904/. I think we should do the same here for > > consistency (most probably in a separate RR). Also, one more point to > > extract these out to `type_utils`. > > Michael Pa

Re: Review Request 32982: Added reservation user guide.

Diff: https://reviews.apache.org/r/32982/diff/ Testing --- Documentation. Thanks, Michael Park

Re: Review Request 32982: Added reservation user guide.

---------- On May 8, 2015, 6:57 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32982/ > ---

Re: Review Request 29748: Added tests for dynamic reservation.

MESOS-2489 Repository: mesos Description --- See summary. Diffs (updated) - src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

rt a > > slave with `"cpus:1;mem:512;disk:0;ports:[]"` resources, while expect > > `"cpus:1;mem:512"` in the offer. > > Michael Park wrote: > The slave resources are specified as `cpus:1;mem:512;disk:0;ports:[]` > because we use `Containerizer:

Re: Review Request 29748: Added tests for dynamic reservation.

> On April 23, 2015, 1:48 p.m., Michael Park wrote: > > As of now, the tests seem to take a long time to complete. We should > > investigate what the issue is before committing this patch. > > Jie Yu wrote: > I suspect this is due to the default allocation interv

Re: Review Request 31667: Piped hashmap from allocator through to sorter.

cpp 42442353afe7bd3d1a5b43992f8ae191ac19bdcd Diff: https://reviews.apache.org/r/31667/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32398: Persisted the reservation state on the slave.

hanks, Michael Park

Re: Review Request 32398: Persisted the reservation state on the slave.

s.cpp 235930ff2dbb3ea49a3a0696dc070f2bd56fba4b src/common/resources_utils.cpp fe04d57227fa193d6d11d2f76529c46aea74c6a1 src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/32398/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32398: Persisted the reservation state on the slave.

/common/resources_utils.cpp fe04d57227fa193d6d11d2f76529c46aea74c6a1 src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/32398/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32398: Persisted the reservation state on the slave.

tion. I've left a `NOTE` for why we do what we do here, and a `TODO` to consider introducing a `RESERVE_AND_CREATE`. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apach

Re: Review Request 32398: Persisted the reservation state on the slave.

s.cpp 235930ff2dbb3ea49a3a0696dc070f2bd56fba4b src/common/resources_utils.cpp fe04d57227fa193d6d11d2f76529c46aea74c6a1 src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/32398/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32398: Persisted the reservation state on the slave.

Rukletsov wrote: > > src/tests/reservation_tests.cpp, lines 892-893 > > <https://reviews.apache.org/r/32398/diff/2/?file=921005#file921005line892> > > > > Let's expand a comment a bit regarding compatibility. It's a bit hard > > to grasp what'

Re: Review Request 32398: Persisted the reservation state on the slave.

/resources_utils.cpp fe04d57227fa193d6d11d2f76529c46aea74c6a1 src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/32398/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

the case in this file. Fixed. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/#review83313 --- On May 12, 2015, 5:13 p

Re: Review Request 29748: Added tests for dynamic reservation.

src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

sts you mentioned and migrated 2 tests that can be done as master validation to `src/tests/master_validation_tests.cpp`. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/#review83313 -----

Re: Review Request 32398: Persisted the reservation state on the slave.

/common/resources_utils.cpp fe04d57227fa193d6d11d2f76529c46aea74c6a1 src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/32398/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

! docs/mesos-c++-style-guide.md <https://reviews.apache.org/r/33271/#comment134451> Perhaps `s/temporaries/*temporaries*/` to emphasize that it's only temporaries that we disallow? - Michael Park On April 29, 2015, 9:34 p.m., Joris Van Remoo

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

` ```cpp 34: for (const Option& _error = _check(expression); \ ``` `flags/stringifier.hpp` ```cpp 68:const Option& v = f->*flag; ``` - Michael Park On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote: > > ---

Re: Review Request 33272: Fix capture by reference of temporary strings in Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33272/#review83480 --- Ship it! Ship It! - Michael Park On April 22, 2015, 6:11 p.m

Re: Review Request 33274: Fix capture by reference of temporary strings in Libprocess.

` ```cpp 2717: const string& name = tokens.size() > 1 ? tokens[1] : ""; ``` - Michael Park On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

ailed(expression);\ ``` - Michael Park On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

> On May 11, 2015, 10:19 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 155 > > > > > > unique_ptr is not a POD, so this will still try to run the destructor > > of the function during exit of the program. > >

Re: Review Request 32398: Persisted the reservation state on the slave.

r/32398/#review83638 ------- On May 12, 2015, 6:44 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/

Re: Review Request 32982: [WIP] Added reservation user guide.

sting --- Documentation. Thanks, Michael Park

Re: Review Request 32982: Added reservation user guide.

flect the master endpoints as it gets more solified. The purpose of including it was/is to get initial feedback on how it generally works. Diffs - docs/reservation.md PRE-CREATION Diff: https://reviews.apache.org/r/32982/diff/ Testing --- Documentation. Thanks, Michael Park

Review Request 34375: Removed use of namespace aliases.

://reviews.apache.org/r/34375/diff/ Testing --- make check Thanks, Michael Park

Review Request 34378: Fixed the dependency between 'summarize' and 'model'.

s `model(const Slave&)` depend on `summarize(const Slave&)` instead. Diffs - src/master/http.cpp 7fa47a9fa2f5667631169876964dccf7fdcc172e Diff: https://reviews.apache.org/r/34378/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 34193: Refactored common functionality into BaseFlags

> On May 18, 2015, 10:04 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 511 > > > > > > Since we're in an implementation file, we can `using > > std::ostringstream

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

, we segfault here. std::cout << *elem << std::endl; } ``` - Michael Park On May 20, 2015, 9:28 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

> On May 12, 2015, 9:05 p.m., Michael Park wrote: > > I found 2 instances which look like they were missed: > > > > `check.hpp` > > ```cpp > > 34: for (const Option& _error = _check(expression); \ > > ``` > > > > `flags/str

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/#review84619 --- Ship it! Ship It! - Michael Park On May 20, 2015, 10:36 p.m

Re: Review Request 33274: Fix capture by reference of temporary strings in Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33274/#review84621 --- Ship it! Ship It! - Michael Park On May 20, 2015, 10:36 p.m

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33276/#review84620 --- Ship it! Ship It! - Michael Park On May 20, 2015, 10:36 p.m

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33271/#review84622 --- Ship it! Ship It! - Michael Park On May 20, 2015, 10:36 p.m

Re: Review Request 34375: Removed use of namespace aliases.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34375/#review84251 --- On May 18, 2015, 11:13 p.m., Michael Park wrote: > > --

Re: Review Request 13709: Fixed typos and added .gitignore

> On Aug. 22, 2013, 11:38 p.m., Ben Mahler wrote: > > I'm ok with adding these kinds of things to .gitignore. > > Marco Massenzio wrote: > I'm confused here - see comments to https://reviews.apache.org/r/33448 > > Also, what's the relationship with .gitignore-template? are we droppi

Re: Review Request 34529: Add non-const reference version of Option::get.

g nonConstReference`, for example. for - Michael Park On May 31, 2015, 1:13 a.m., Mark Wang wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 34529: Add non-const reference version of Option::get.

On May 31, 2015, 3:15 a.m., Mark Wang wrote: > > for Not sure how this got here. Please ignore. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34529/#review85890 --

Review Request 35253: Enable configure to detect libevent and openssl on Mac OS X.

-level `libevent` and `openssl` disappear. Thanks, Michael Park

Re: Review Request 34703: Added stream manipulators for the Time object.

here to use the `operator<<` since `stringify` uses it. We can simplify to: ``` EXPECT_EQ("Thu, 02 Mar 1989 00:00:00 UTC", stringify(RFC1123(Time::epoch() + Weeks(1000; ``` - Michael Park On June 8, 2015, 3:14 p.m., Alexander Roja

Re: Review Request 34703: Added stream manipulators for the Time object.

rg/r/34703/#comment139937> Formatting: ``` static const char* MONTHS[] = { "Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul"

Re: Review Request 34703: Added stream manipulators for the Time object.

> On June 11, 2015, 11:10 a.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/time.hpp, lines 111-114 > > <https://reviews.apache.org/r/34703/diff/4/?file=980765#file980765line111> > > > > Formatting: > > > > ```static co

Review Request 35395: Improvements to Synchronized.

rocess/3rdparty/stout/include/stout/synchronized.hpp 60eaf263f220b4990aefe4e5d6d2aa1296891e57 Diff: https://reviews.apache.org/r/35395/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35395: Improvements to Synchronized.

Thanks, Michael Park

Re: Review Request 35395: Improvements to Synchronized.

turn x; } } ``` Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp 60eaf263f220b4990aefe4e5d6d2aa1296891e57 Diff: https://reviews.apache.org/r/35395/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35395: Improvements to Synchronized.

an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35395/#review87737 --- On June 12, 2015, 10:01 p.m., Michael Park wrote: > > -

Re: Review Request 29406: Introduce libevent ssl socket.

of(error_buffer) - 1`. > ERR_error_string_n() is a variant of ERR_error_string() that writes at most `len` characters (__including the terminating 0__) and truncates the string if necessary. For ERR_error_string_n(), buf may not be NULL. 3rdparty/libprocess/src/openssl.cpp <

Review Request 35422: stout: Introduce CHECK_NONE and CHECK_ERROR.

--- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 3972383d7de2d6c7afcef0478554fab8da2f64f2 Diff: https://reviews.apache.org/r/35422/diff/ Testing --- `make check` Thanks, Michael Park

Review Request 35423: libprocess: Rebased for _CheckFatal changes in stout.

--- See summary. Diffs - 3rdparty/libprocess/include/process/check.hpp 60989accf3a4d8a9453843015aeff35143b6b737 Diff: https://reviews.apache.org/r/35423/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35423: libprocess: Rebased for _CheckFatal changes in stout.

Hindman. Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/include/process/check.hpp 60989accf3a4d8a9453843015aeff35143b6b737 Diff: https://reviews.apache.org/r/35423/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35422: stout: Introduce CHECK_NONE and CHECK_ERROR.

Hindman. Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 3972383d7de2d6c7afcef0478554fab8da2f64f2 Diff: https://reviews.apache.org/r/35422/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35395: Improvements to Synchronized.

turn x; } } ``` Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp 60eaf263f220b4990aefe4e5d6d2aa1296891e57 Diff: https://reviews.apache.org/r/35395/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35129: Refactor Future::Data to use Result. Remove dynamic allocation.

tps://reviews.apache.org/r/35129/#comment140262> `CHECK_ERROR` exists now :) - Michael Park On June 5, 2015, 1:16 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Review Request 35425: libprocess: Use CHECK_NONE.

` Thanks, Michael Park

Review Request 35426: mesos: Use CHECK_SOME, CHECK_NONE, CHECK_ERROR.

iff: https://reviews.apache.org/r/35426/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35253: Enable configure to detect libevent and openssl on Mac OS X.

--- Ran `configure` and observed that the warnings from OS X system-level `libevent` and `openssl` disappear. Thanks, Michael Park

Re: Review Request 29406: Introduce libevent ssl socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review87834 --- Ship it! Ship It! - Michael Park On June 13, 2015, 9:23 a.m

Re: Review Request 28763: Add configure flag to enable SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28763/#review87833 --- Ship it! Ship It! - Michael Park On June 13, 2015, 8:26 a.m

Review Request 35431: Enable Option to hold a noncopyable type.

/ Testing --- Added tests for `Option` and ran `make check`. Thanks, Michael Park

Review Request 35432: Enable move semantics for Future and Promise.

--- See summary. Diffs - 3rdparty/libprocess/include/process/future.hpp 75cbe122f18d2a8ea919331e7fc91e1ec3bfd28b Diff: https://reviews.apache.org/r/35432/diff/ Testing --- `make check` Thanks, Michael Park

Review Request 35433: CHECK that checkpointed resources exist on the slave.

Description --- No bug was observed (yet), but realized I forgot about this in the dynamic reservations patches. Diffs - src/slave/slave.cpp 9af69d8f0b28c9441c684886c52320378f9b2869 Diff: https://reviews.apache.org/r/35433/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 34375: Removed use of namespace aliases.

ba3858fb3026f2cc7af0523bd1a0c541eeafc34b src/tests/slave_tests.cpp 8dae6e0842c2bedddc13d1c036390e85c7a96df7 Diff: https://reviews.apache.org/r/34375/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 35395: Improvements to the synchronized macro.

Thanks, Michael Park

Review Request 35439: Updated documentation for CentOS 6 and 7.

--- See summary. Diffs - docs/getting-started.md f72650f7fb1b986c058f4d5ee85f73a7314797a3 Diff: https://reviews.apache.org/r/35439/diff/ Testing --- Followed the instructions line by line with fresh `CentOS 6.6` and `CentOS 7.1` docker images. Thanks, Michael Park

Review Request 35455: Update 'Getting Started' documentation.

. Thanks, Michael Park

Re: Review Request 35455: Update 'Getting Started' documentation.

instructions line by line with fresh `Ubuntu 14.04`, `CentOS 6.6` and `CentOS 7.1` docker images. Thanks, Michael Park

Re: Review Request 35455: Update 'Getting Started' documentation.

/diff/ Testing --- Followed the instructions line by line with fresh `Ubuntu 14.04`, `CentOS 6.6` and `CentOS 7.1` docker images. Thanks, Michael Park

Re: Review Request 35455: Update 'Getting Started' documentation.

d the instructions line by line with fresh `Ubuntu 14.04`, `CentOS 6.6` and `CentOS 7.1` docker images. Thanks, Michael Park

Re: Review Request 35433: CHECK that checkpointed resources exist on the slave.

(yet), but realized I forgot about this in the dynamic reservations patches. Diffs (updated) - src/slave/slave.cpp 67732a40ef683cb0188425f0bba8fe8ab83e461c Diff: https://reviews.apache.org/r/35433/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35455: Update 'Getting Started' documentation.

82ff8 Diff: https://reviews.apache.org/r/35455/diff/ Testing --- Followed the instructions line by line with fresh `Ubuntu 14.04`, `CentOS 6.6` and `CentOS 7.1` docker images. Thanks, Michael Park

<    1   2   3   4   5   6   7   8   9   10   >