(Anand): ...
shutdown();
}
```
- Vinod Kone
On Jan. 4, 2017, 12:38 a.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54312/#review160441
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 2, 2016, 5:02 p.m
and
non-PA together at a later time if necessary.
- Vinod Kone
On Dec. 2, 2016, 12:25 a.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
ST on reconciliation. can you remind me why the master
forwards status updates for unknown tasks? looks like it can just drop them if
the reason for doing so is no longer valid.
- Vinod Kone
On Dec. 18, 2016, 11:29 p.m., Neil Conway wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54589/#review159855
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 13, 2016, 3:02 a.m
(line 796)
<https://reviews.apache.org/r/53237/#comment230864>
not yours but can you s/EXPECT/ASSERT/ so that the next line doesn't crash.
- Vinod Kone
On Dec. 19, 2016, 9:15 p.m., Neil Conway wrote:
>
> ---
> This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54901/#review159724
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 20, 2016, 4:09 p.m
5e3fb0d0003878a375bc36b2c9563e16f6ad2e2f
Diff: https://reviews.apache.org/r/54727/diff/
Testing
---
make -j20 check GTEST_FILTER="*Switchboard*" MESOS_VERBOSE=1
Thanks,
Vinod Kone
://reviews.apache.org/r/54720/diff/
Testing
---
make -j20 check GTEST_FILTER="*Switchboard*" MESOS_VERBOSE=1
Thanks,
Vinod Kone
---
I will add a test in the next review.
Thanks,
Vinod Kone
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54720/#review159090
---
On Dec. 13, 2016, 10:20 p.m., Vinod Kone wrote:
>
>
helpers that can be re-used in other tests.
> I plan to use them in subsequent patches.
>
>
> Diffs
> -
>
> src/tests/containerizer/io_switchboard_tests.cpp
> 5bd9dc4a776fe8a0d04ed31aa167f10c394984e6
>
> Diff: https://reviews.apache.org/r/54727/diff/
>
>
> Testing
> ---
>
> make -j20 check GTEST_FILTER="*Switchboard*" MESOS_VERBOSE=1
>
>
> Thanks,
>
> Vinod Kone
>
>
containerizer is recovered. there are
more steps for slave recovery to complete, which i didn't care for in this test.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54720/#re
---
make -j20 check GTEST_FILTER="*Switchboard*" MESOS_VERBOSE=1
Thanks,
Vinod Kone
="*Switchboard*" MESOS_VERBOSE=1
Thanks,
Vinod Kone
://reviews.apache.org/r/54687/diff/
Testing
---
make -j20 check GTEST_FILTER="*Switchboard*" MESOS_VERBOSE=1
Thanks,
Vinod Kone
matically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54686/#review158941
-------
On Dec. 13, 2016, 12:52 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically genera
d.hpp
9f4ce99d09d50b681e01b5d28fb5fc79e1ea85fc
src/slave/containerizer/mesos/io/switchboard.cpp
f900924dd55c42966deb14c65fca380bebc86e2f
Diff: https://reviews.apache.org/r/54686/diff/
Testing
---
make -j20 check GTEST_FILTER="*AgentAPI*:*Switchboard*" MESOS_VERBOSE=1
Thanks,
Vinod Kone
eviews.apache.org/r/54589/#comment229730>
see above.
- Vinod Kone
On Dec. 9, 2016, 5:17 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. T
., GTEST_FILTER="*AgentAPI*"
- Vinod Kone
On Dec. 12, 2016, 8:21 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
iew158816
---
On Dec. 11, 2016, 4:46 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
sues.apache.org/jira/browse/MESOS-6778
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54544/#review158766
---
On Dec.
/r/54544/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
make check
Thanks,
Vinod Kone
: https://reviews.apache.org/r/54516/diff/
Testing
---
Thanks,
Vinod Kone
/54281/diff/
Testing
---
make -j20 check GTEST_FILTER="*LaunchNestedContainerSession*" GLOG_v=1
MESOS_VERBOSE=1
Thanks,
Vinod Kone
/diff/
Testing
---
make check
Thanks,
Vinod Kone
ent229588>
hmm. instead of depending on real time, can you just pause the clock and
use `clock::advance`? otherwise it is going to be flaky depending on the load
of the test machine.
- Vinod Kone
On Dec. 9, 2016, 2:10 a.m., Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54560/#review158789
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 11, 2016, 1:03 a.m
tps://reviews.apache.org/r/54630/#comment229586>
against*
- Vinod Kone
On Dec. 11, 2016, 1:04 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54632/#review158787
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 11, 2016, 12:56 a.m
Description
---
stdin fd should only be closed when a tty is not attached.
Diffs
-
src/slave/containerizer/mesos/io/switchboard.cpp
a354188a3656b5c2fd797b214f6c02714d70ce2c
Diff: https://reviews.apache.org/r/54637/diff/
Testing
---
make check
Thanks,
Vinod Kone
tests/mesos.cpp 73f17a74170dfc81a7c8a38e67d9030c95f1d52c
Diff: https://reviews.apache.org/r/54620/diff/
Testing (updated)
---
make check
Thanks,
Vinod Kone
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/54620/#review158776
-------
On Dec. 10, 2016, 5:08 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews
7a902622237108661107054f01fad27bf459fd72
src/tests/mesos.cpp 73f17a74170dfc81a7c8a38e67d9030c95f1d52c
Diff: https://reviews.apache.org/r/54620/diff/
Testing
---
AttachContainerInput test currently fails. Need to fix before committing.
Thanks,
Vinod Kone
ave to understand what `Duration` means typically.
src/slave/flags.cpp (lines 285 - 286)
<https://reviews.apache.org/r/54560/#comment229399>
The default gets printed out in help. So no need for "The default is 30
seconds".
- Vinod Kone
On Dec. 9, 2016, 1:18 a.m., Kevin Klue
)
<https://reviews.apache.org/r/54182/#comment229392>
s/state/state and have all updates acknowledged/
src/master/master.cpp (line 5408)
<https://reviews.apache.org/r/54182/#comment229393>
neglect to "remove" non-partition-aware?
- Vinod Kone
On Nov. 29, 2016, 10:36 p
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54181/#review158610
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 29, 2016, 10:35 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54180/#review158609
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 29, 2016, 10:35 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54179/#review158607
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 1, 2016, 10:34 p.m
che.org/r/54178/#comment229383>
not sure what this is testing. maybe comment?
also, can you inline `containsZeroValue` since it seems very specific to
this test ?
- Vinod Kone
On Nov. 30, 2016, 9:03 p.m., Neil Conway wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54178/#review158600
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 30, 2016, 9:03 p.m
://reviews.apache.org/r/54544/diff/
Testing
---
make check
Thanks,
Vinod Kone
://reviews.apache.org/r/54516/diff/
Testing
---
Thanks,
Vinod Kone
://reviews.apache.org/r/54508/diff/
Testing
---
make check
Thanks,
Vinod Kone
://reviews.apache.org/r/54281/diff/
Testing
---
make -j20 check GTEST_FILTER="*LaunchNestedContainerSession*" GLOG_v=1
MESOS_VERBOSE=1
Thanks,
Vinod Kone
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54281/#review158473
---
On Dec. 8, 2016, 9:32 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To rep
e.org/r/54281/diff/
Testing
---
make -j20 check GTEST_FILTER="*LaunchNestedContainerSession*" GLOG_v=1
MESOS_VERBOSE=1
Thanks,
Vinod Kone
---
Changed `EXPECT_EQ` to `ASSERRT_EQ` for cases where assertion is more
appropriate.
Diffs
-
src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61
Diff: https://reviews.apache.org/r/54545/diff/
Testing
---
make check
Thanks,
Vinod Kone
Description
---
Tests that when a client is disconnected the container is destroyed.
Diffs
-
src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61
Diff: https://reviews.apache.org/r/54544/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
This test is still valuable to test the case when a containerizer
does not support `attach`, e.g., DockerContainerizer.
Diffs
-
src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61
Diff: https://reviews.apache.org/r/54516/diff/
Testing
---
Thanks,
Vinod Kone
/
Testing
---
make check
Thanks,
Vinod Kone
81c61
Diff: https://reviews.apache.org/r/54281/diff/
Testing
---
make -j20 check GTEST_FILTER="*LaunchNestedContainerSession*" GLOG_v=1
MESOS_VERBOSE=1
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54177/#review158467
---
Ship it!
Thanks for the sweep!
- Vinod Kone
On Dec. 7, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54497/#review158466
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 8, 2016, 12:39 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54387/#review158465
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 5, 2016, 8:05 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54380/#review158464
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 7, 2016, 4:25 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54468/#review158463
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 7, 2016, 4:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54467/#review158461
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 7, 2016, 4:19 a.m
)
<https://reviews.apache.org/r/53897/#comment229237>
nice test!
- Vinod Kone
On Dec. 7, 2016, 7:11 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54495/#review158457
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 7, 2016, 8:04 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54504/#review158444
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 7, 2016, 11:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54502/#review158443
---
Ship it!
Good catch!
- Vinod Kone
On Dec. 7, 2016, 10:25
---
Test verifies that output and error are sent as stdout to client.
Diffs
-
src/tests/api_tests.cpp 6cd1f83a47731ee8c4fb1f022bf585b271b3b966
Diff: https://reviews.apache.org/r/54508/diff/
Testing
---
make check
Thanks,
Vinod Kone
bout
```
// Reads ProcessIO::Data records for the pipe `reader` until EOF is reached
and returns
// merged stdout and stderr as a tuple. Note: It ignores any
ProcessIO::Control records.
Try> getProcessIOData(http::Pipe::Reader reader)
{
}
(line 1102)
<https://reviews.apache.org/r/54496/#comment229146>
do you want to do a VLOG here incase it ever blocks here?
- Vinod Kone
On Dec. 7, 2016, 8:15 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically g
="*LaunchNestedContainerSession*" GLOG_v=1
MESOS_VERBOSE=1
Thanks,
Vinod Kone
this note no longer valid?
src/slave/containerizer/mesos/io/switchboard_main.cpp (line 97)
<https://reviews.apache.org/r/54465/#comment229075>
looks like at this point the server has called `listen` but not `accept`. i
guess that should be ok?
- Vinod Kone
On Dec. 7, 20
> On Dec. 3, 2016, 2:12 a.m., Vinod Kone wrote:
> > src/master/master.cpp, line 7124
> > <https://reviews.apache.org/r/53897/diff/6/?file=1574956#file1574956line7124>
> >
> > CHECK_NOTNULL(framework);
>
> Neil Conway wrote:
> Is there a genera
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53896/#review158105
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 5, 2016, 5:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53895/#review158100
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 2, 2016, 9:50 p.m
tps://reviews.apache.org/r/54381/#comment228801>
why did you change these tests? the idea with the tests was to verify that
`Containerizer::attach()` was getting called from the API handler.
- Vinod Kone
On Dec. 5, 2016, 4:19 p.m., Alexander Rojas
aster/docs/app-framework-development-guide.md
for details about default executor?
docs/nested-container-and-task-group.md (line 209)
<https://reviews.apache.org/r/54013/#comment228593>
mention that only 2 levels of nesting is supported as of 1.1?
- Vinod Kone
On Nov. 30, 2016,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54337/#review157910
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 3, 2016, 7:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54342/#review157909
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 3, 2016, 7:48 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54340/#review157898
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 3, 2016, 6:04 p.m
org/r/54337/#comment228520>
hmm. InternalServerError instead of a BadRequest sounds wrong.
for non-streaming requests, looks like validation error results in
BadRequest(); but not so for streaming requests?
- Vinod Kone
On Dec. 3, 2016, 6:01 a.m., Anand Mazumdar
5)
<https://reviews.apache.org/r/53897/#comment228506>
given the above comments, do we still want to distinguish between
DISCONNECTED and RECOVERED states? if we can get away with it, that would be
conceptually easy to understand.
- Vinod Kone
On Dec. 2, 2016, 8:56 p.m., Neil Con
--
>
> (Updated Nov. 18, 2016, 7:21 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6419
> https://issues.apache.org/jira/browse/MESOS-6419
>
>
> Repository: mesos
>
>
> Description
> ---
>
>
that it breaks
the interface?
- Vinod Kone
On Dec. 1, 2016, 10:16 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53894/#review157829
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 18, 2016, 7:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53893/#review157828
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 18, 2016, 7:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53892/#review157827
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 18, 2016, 7:18 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53891/#review157826
---
Ship it!
Yay! Thanks.
- Vinod Kone
On Nov. 18, 2016, 7:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53890/#review157820
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 21, 2016, 9:26 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53889/#review157818
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 18, 2016, 7:15 p.m
(line 3089)
<https://reviews.apache.org/r/53888/#comment228394>
s/first/completed/
src/tests/slave_recovery_tests.cpp (line 3101)
<https://reviews.apache.org/r/53888/#comment228395>
s/first/completed/
- Vinod Kone
On Nov. 29, 2016, 12:26 a.m., Neil
(line 807)
<https://reviews.apache.org/r/53887/#comment228388>
the new style is to omit "Times(1)" because that's the default.
- Vinod Kone
On Nov. 18, 2016, 7:14 p.m., Neil Conway wrote:
>
> ---
> This i
)
<https://reviews.apache.org/r/53886/#comment228387>
s/first/completed/
- Vinod Kone
On Nov. 18, 2016, 7:13 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53885/#review157781
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 18, 2016, 7:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53310/#review157780
---
Ship it!
Ship It!
- Vinod Kone
On Oct. 31, 2016, 5:20 p.m
https://reviews.apache.org/r/54196/diff/
Testing
---
make check
Added a basic test for now that tests the failure case. Will be adding more
tests in subsequent reviews.
Thanks,
Vinod Kone
use TestContainerizer
because it lets me test more functionality.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54196/#review157616
ea6e037c18fd116eff473ee246faa504ec37b7da
Diff: https://reviews.apache.org/r/54196/diff/
Testing
---
make check
Added a basic test for now that tests the failure case. Will be adding more
tests in subsequent reviews.
Thanks,
Vinod Kone
https://reviews.apache.org/r/54196/diff/
Testing
---
make check
Added a basic test for now that tests the failure case. Will be adding more
tests in subsequent reviews.
Thanks,
Vinod Kone
_tests.cpp ea6e037c18fd116eff473ee246faa504ec37b7da
Diff: https://reviews.apache.org/r/54196/diff/
Testing
---
make check
Added a basic test for now that tests the failure case. Will be adding more
tests in subsequent reviews.
Thanks,
Vinod Kone
/http.cpp ace3575fd3a330f788e678283bc05e806cf9b264
src/slave/slave.hpp cfec9dd5fa3550ba1192fc86b1ff0d73ee1671e0
Diff: https://reviews.apache.org/r/54193/diff/
Testing
---
make check
Thanks,
Vinod Kone
cfec9dd5fa3550ba1192fc86b1ff0d73ee1671e0
Diff: https://reviews.apache.org/r/54245/diff/
Testing
---
make check
Thanks,
Vinod Kone
://reviews.apache.org/r/54196/diff/
Testing
---
make check
Added a basic test for now that tests the failure case. Will be adding more
tests in subsequent reviews.
Thanks,
Vinod Kone
---
make check
Thanks,
Vinod Kone
901 - 1000 of 3244 matches
Mail list logo
