Re: Review Request 44669: Implemented create methods in MasterContender and MasterDetector.

2016-04-06 Thread Anurag Singh
-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-04-06 Thread Anurag Singh
world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-04-06 Thread Anurag Singh
3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-04-06 Thread Anurag Singh
57fc50360eae85819ae6ce714b0c3c4c1867b2b8 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44547: Added functions in promises to the future header.

2016-04-06 Thread Anurag Singh
Diff: https://reviews.apache.org/r/44547/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-04-06 Thread Anurag Singh
9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44289: Added support for contender and detector modules.

2016-04-06 Thread Anurag Singh
://reviews.apache.org/r/44289/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-04-06 Thread Anurag Singh
/contender/contender.cpp PRE-CREATION src/master/detector/detector.hpp PRE-CREATION src/master/detector/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-04-06 Thread Anurag Singh
://reviews.apache.org/r/44288/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-04-06 Thread Anurag Singh
(updated) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-04-06 Thread Anurag Singh
9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44669: Implemented create methods in MasterContender and MasterDetector.

2016-04-06 Thread Anurag Singh
-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-04-06 Thread Anurag Singh
://reviews.apache.org/r/44288/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-04-06 Thread Anurag Singh
57fc50360eae85819ae6ce714b0c3c4c1867b2b8 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44289: Added support for contender and detector modules.

2016-04-06 Thread Anurag Singh
://reviews.apache.org/r/44289/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-04-06 Thread Anurag Singh
world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh

Re: Review Request 44547: Added functions in promises to the future header.

2016-04-06 Thread Anurag Singh
Diff: https://reviews.apache.org/r/44547/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-04-06 Thread Anurag Singh
src/master/contender/contender.cpp PRE-CREATION src/master/detector/detector.hpp PRE-CREATION src/master/detector/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-04-06 Thread Anurag Singh
3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-04-06 Thread Anurag Singh
2c4061d71338f66e432dfa4ac86a9693f3ad38bf Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44547: Added functions in promises to the future header.

2016-04-04 Thread Anurag Singh
) - 3rdparty/libprocess/include/process/future.hpp ae4f2d659f1540c50dc1975f5771c6291c3b0c57 Diff: https://reviews.apache.org/r/44547/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-04-04 Thread Anurag Singh
57fc50360eae85819ae6ce714b0c3c4c1867b2b8 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44669: Implemented create methods in MasterContender and MasterDetector.

2016-04-04 Thread Anurag Singh
/detector.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44289: Added support for contender and detector modules.

2016-04-04 Thread Anurag Singh
://reviews.apache.org/r/44289/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-04-04 Thread Anurag Singh
9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-04-04 Thread Anurag Singh
://reviews.apache.org/r/44288/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-04-04 Thread Anurag Singh
/. Thanks, Anurag Singh

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-04-04 Thread Anurag Singh
3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-04-04 Thread Anurag Singh
(updated) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-04-04 Thread Anurag Singh
world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-04-04 Thread Anurag Singh
the line lenght to increase to 89. - Anurag --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review126356 --- On March 23, 201

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-04-01 Thread Anurag Singh
- On March 23, 2016, 11:05 p.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44544/ > ---

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-31 Thread Anurag Singh
https://reviews.apache.org/r/44287/#review125914 ------- On March 23, 2016, 11:04 p.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44287/ > ---

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-03-21 Thread Anurag Singh
have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-21 Thread Anurag Singh
/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-21 Thread Anurag Singh
/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44547: Added functions in promises to the collect header.

2016-03-21 Thread Anurag Singh
: https://reviews.apache.org/r/44547/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-03-21 Thread Anurag Singh
/contender.cpp PRE-CREATION src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-03-21 Thread Anurag Singh
9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-03-21 Thread Anurag Singh
ea1d776077bf638885db8421194aa4427c772169 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-03-21 Thread Anurag Singh
3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-21 Thread Anurag Singh
://reviews.apache.org/r/44288/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-21 Thread Anurag Singh
) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-20 Thread Anurag Singh
nd I'm > > no expert on leader election.) > > Anurag Singh wrote: > I'll do that and address your comments. > > Anurag Singh wrote: > I haven't seen any comments from the user and developer communities to my > email on these changes. Do you want

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-20 Thread Anurag Singh
nd I'm > > no expert on leader election.) > > Anurag Singh wrote: > I'll do that and address your comments. I haven't seen any comments from the user and developer communities to my email on these changes. Do you want to wait longer? - Anurag

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-19 Thread Anurag Singh
/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-03-19 Thread Anurag Singh
3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-03-19 Thread Anurag Singh
ea1d776077bf638885db8421194aa4427c772169 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-03-19 Thread Anurag Singh
9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44547: Added functions in promises to the collect header.

2016-03-19 Thread Anurag Singh
: https://reviews.apache.org/r/44547/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-03-19 Thread Anurag Singh
/contender.cpp PRE-CREATION src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-19 Thread Anurag Singh
) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-03-19 Thread Anurag Singh
have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh

Re: Review Request 44547: Added functions in promises to the collect header.

2016-03-19 Thread Anurag Singh
s://reviews.apache.org/r/44547/#review124281 ------- On March 18, 2016, 12:29 a.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-03-19 Thread Anurag Singh
nder.hpp' for src/master/contenders/zookeeper.hpp. Similarly for the rest. - Anurag --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/#review124284 --------

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-18 Thread Anurag Singh
://reviews.apache.org/r/44288/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-18 Thread Anurag Singh
-------- On March 18, 2016, 12:29 a.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44287/ > -

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-18 Thread Anurag Singh
/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-18 Thread Anurag Singh
expandtab in my vimrc. Fixing it. - Anurag --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review124274 --- On March 18, 201

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-15 Thread Anurag Singh
/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-03-15 Thread Anurag Singh
9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-15 Thread Anurag Singh
/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44547: Added functions in promises to the collect header.

2016-03-15 Thread Anurag Singh
://reviews.apache.org/r/44547/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-03-15 Thread Anurag Singh
124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44545/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-03-15 Thread Anurag Singh
-CREATION src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-03-15 Thread Anurag Singh
3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-15 Thread Anurag Singh
/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-15 Thread Anurag Singh
bd7b94f3f1fac6705e5bf14c6f6103b540cde56c src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44288/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-03-14 Thread Anurag Singh
have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-14 Thread Anurag Singh
/diff/ Testing --- In addition to all unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-14 Thread Anurag Singh
/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44547: Added functions in promises to the collect header.

2016-03-14 Thread Anurag Singh
: https://reviews.apache.org/r/44547/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-03-14 Thread Anurag Singh
9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-03-14 Thread Anurag Singh
124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-03-14 Thread Anurag Singh
3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-14 Thread Anurag Singh
) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44289/. Thanks, Anurag Singh

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-03-14 Thread Anurag Singh
/contender.cpp PRE-CREATION src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-14 Thread Anurag Singh
bd7b94f3f1fac6705e5bf14c6f6103b540cde56c src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44288/diff/ Testing --- See https://reviews.apache.org/r/44289/. Thanks, Anurag Singh

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-03-14 Thread Anurag Singh
On March 14, 2016, 11:51 p.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44545/ > --

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-14 Thread Anurag Singh
bd7b94f3f1fac6705e5bf14c6f6103b540cde56c src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44288/diff/ Testing --- See https://reviews.apache.org/r/44289/. Thanks, Anurag Singh

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-03-14 Thread Anurag Singh
have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh

Re: Review Request 44547: Added functions in promises to the collect header.

2016-03-14 Thread Anurag Singh
: https://reviews.apache.org/r/44547/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-14 Thread Anurag Singh
matters). Thanks, Anurag Singh

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-14 Thread Anurag Singh
/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-03-14 Thread Anurag Singh
9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-03-14 Thread Anurag Singh
124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-03-14 Thread Anurag Singh
/contender.cpp PRE-CREATION src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-03-14 Thread Anurag Singh
3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-14 Thread Anurag Singh
) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44289/. Thanks, Anurag Singh

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-11 Thread Anurag Singh
iews.apache.org/r/44287/#review122832 --- On March 10, 2016, 11:45 p.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44287/ > -

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-11 Thread Anurag Singh
; > pulling it out into a separate review (rather than hiding it in this > > review). > > > > Also, you'll want to consider making folders "contenders" and > > "detectors". Then renaming this file "standalone.hpp". &

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-10 Thread Anurag Singh
matters). Thanks, Anurag Singh

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-10 Thread Anurag Singh
/44289/. Thanks, Anurag Singh

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-03-10 Thread Anurag Singh
have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-03-10 Thread Anurag Singh
9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-10 Thread Anurag Singh
/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-03-10 Thread Anurag Singh
/contender.cpp PRE-CREATION src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44547: Added functions in promises to the collect header.

2016-03-10 Thread Anurag Singh
: https://reviews.apache.org/r/44547/diff/ Testing --- Thanks, Anurag Singh

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-10 Thread Anurag Singh
) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44289/. Thanks, Anurag Singh

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-03-10 Thread Anurag Singh
124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- Thanks, Anurag Singh

  1   2   >