Re: Review Request 71560: Made the MaintenanceInverseOffers test use only one framework.

2019-09-30 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71560/#review217992
---


Ship it!




I put the same stress on the system I put when commenting here, 
https://issues.apache.org/jira/browse/MESOS-9980?focusedCommentId=16940894=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16940894.
 The test did not fail once in 200 repetitions (failure rate < 10%), where 
before it failed roughly 20-40% of the time.

- Benjamin Bannier


On Sept. 30, 2019, 3:33 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71560/
> ---
> 
> (Updated Sept. 30, 2019, 3:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Meng Zhu.
> 
> 
> Bugs: MESOS-9980
> https://issues.apache.org/jira/browse/MESOS-9980
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch simplifies the test and attepmts to fix MESOS-9980 by
> removing the (potential) flakiness caused by agent2's resources
> being re-offered to framework2.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> a13eb017f7a93ee67c8426e4150858a547175ed6 
> 
> 
> Diff: https://reviews.apache.org/r/71560/diff/1/
> 
> 
> Testing
> ---
> 
> `./bin/mesos-tests.sh --gtest_filter="*MaintenanceInverseOffers*" 
> --gtest_break_on_failure --gtest_repeat=1`
> 
> `./bin/mesos-tests.sh --gtest_filter="*MaintenanceInverseOffers*" 
> --gtest_break_on_failure` fails if I break framework untracking in 
> `Slave::increaseAvailable()` in the allocator.
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>



Review Request 71559: Added early exit in reviewbot if nothing to review.

2019-09-30 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71559/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

The current reviewbot setup always makes sure that the `master` branch
can be built before verifying any reviews. This takes considerable time.

With this patch we now avoid any builds if no reviews need to be
verified. While detecting reviews requiring verification takes some
time, it is currently much faster than building Mesos. With this setup
we should now finish this job much faster in the usual case (nothing
needs verification) while taking only on the order of a minute longer
otherwise.


Diffs
-

  support/jenkins/reviewbot.sh c5b497634cb9754fa19c5af3f579ceae25ab912d 


Diff: https://reviews.apache.org/r/71559/diff/1/


Testing
---

Verified early exit by running locally.


Thanks,

Benjamin Bannier



Re: Review Request 71440: Improved allocator inverse offer test.

2019-09-30 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71440/#review217987
---



This seems to introduce flakiness, 
https://issues.apache.org/jira/browse/MESOS-9980.

- Benjamin Bannier


On Sept. 5, 2019, 11:12 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71440/
> ---
> 
> (Updated Sept. 5, 2019, 11:12 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test is augmented to also check that a framework that
> declined offers from an agent will not get inverse offers
> for that agent.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 2c1d0fe2e3ac08e6443cf8348bb72ac7dae454a8 
> 
> 
> Diff: https://reviews.apache.org/r/71440/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 71388: Introduced automatic lifecycle management in `DynamicLibrary`.

2019-09-27 Thread Benjamin Bannier


> On Sept. 26, 2019, 5:59 p.m., Benjamin Mahler wrote:
> > 3rdparty/stout/include/stout/posix/dynamiclibrary.hpp
> > Lines 70-74 (original), 68-72 (patched)
> > <https://reviews.apache.org/r/71388/diff/2/?file=2166909#file2166909line75>
> >
> > hm.. should maybe release / reset to nullptr if dlclose fails as well?
> > 
> > E.g. if some other part of the program closes it (bug), I guess whether 
> > we reset here will just mean whether we issue an additional bad close call 
> > in the destructor.
> > 
> > Didn't mark as an issue since the error case here already means 
> > something is badly broken.

I think if the close fails it is really hard to recover in some general way 
here. If we did that we'd either implement enough intelligence to understand 
all `dlclose` error scenarios (since `dlclose` does not define its own errors 
it looks like that would involve understanding error messages?). I think 
surfacing the error to the caller instead is a better idea.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71388/#review217951
-------


On Sept. 25, 2019, 11:23 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71388/
> ---
> 
> (Updated Sept. 25, 2019, 11:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This not only simplifies our implementation of `DynamicLibrary`, but
> also removes the potential for accidental file descriptor leaks.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/posix/dynamiclibrary.hpp 
> 6a50592632246b06152bee177e933f65438c07ca 
> 
> 
> Diff: https://reviews.apache.org/r/71388/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71388: Introduced automatic lifecycle management in `DynamicLibrary`.

2019-09-25 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71388/
---

(Updated Sept. 25, 2019, 11:23 p.m.)


Review request for mesos, Benjamin Mahler and Jan Schlicht.


Changes
---

Fix issues raised by Ben


Repository: mesos


Description
---

This not only simplifies our implementation of `DynamicLibrary`, but
also removes the potential for accidental file descriptor leaks.


Diffs (updated)
-

  3rdparty/stout/include/stout/posix/dynamiclibrary.hpp 
6a50592632246b06152bee177e933f65438c07ca 


Diff: https://reviews.apache.org/r/71388/diff/2/

Changes: https://reviews.apache.org/r/71388/diff/1-2/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Re: Review Request 71388: Introduced automatic lifecycle management in `DynamicLibrary`.

2019-09-25 Thread Benjamin Bannier


> On Sept. 25, 2019, 10:01 p.m., Benjamin Mahler wrote:
> > 3rdparty/stout/include/stout/posix/dynamiclibrary.hpp
> > Line 31 (original), 32 (patched)
> > <https://reviews.apache.org/r/71388/diff/1/?file=2163054#file2163054line32>
> >
> > it's ok to dlclose with nullptr if close was already called or open was 
> > never called or open failed?

Ups, thanks for seeing that. 
https://stackoverflow.com/questions/11412943/is-it-safe-to-call-dlclosenull 
seems to suggest that `dlclose`'ing a null handle is likely not a good idea. I 
check for that explicitly now.


> On Sept. 25, 2019, 10:01 p.m., Benjamin Mahler wrote:
> > 3rdparty/stout/include/stout/posix/dynamiclibrary.hpp
> > Line 46 (original), 36 (patched)
> > <https://reviews.apache.org/r/71388/diff/1/?file=2163054#file2163054line47>
> >
> > Hm.. this pattern suggests a `Try create(path)` pattern 
> > to avoid the not-yet-opened or failed open states? I guess we may still 
> > want the explicit close though for error reporting..

Completely agree on `create`. As for `close` I am not sure we can model that 
with RAII or whether this might introduce issues in e.g., library unloading. 
Right now all prod users of this class leak handles.

I didn't tackle this here since my primary concern was to allow move 
construction (and above sugggestion likely would also involve lengthy rewrites 
of test code).


> On Sept. 25, 2019, 10:01 p.m., Benjamin Mahler wrote:
> > 3rdparty/stout/include/stout/posix/dynamiclibrary.hpp
> > Lines 66 (patched)
> > <https://reviews.apache.org/r/71388/diff/1/?file=2163054#file2163054line77>
> >
> > hm.. why is this needed? seems a little non obvious to me

This is needed so we do not invoke the default deleter (which calls `dlclose`) 
when resetting `handle_`. I added a comment.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71388/#review217484
---


On Sept. 25, 2019, 11:23 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71388/
> ---
> 
> (Updated Sept. 25, 2019, 11:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This not only simplifies our implementation of `DynamicLibrary`, but
> also removes the potential for accidental file descriptor leaks.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/posix/dynamiclibrary.hpp 
> 6a50592632246b06152bee177e933f65438c07ca 
> 
> 
> Diff: https://reviews.apache.org/r/71388/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71541: Fixed Javascript linting and IE compatibility of the UI roles tree.

2019-09-25 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71541/#review217937
---


Ship it!




Looks good to me from a linting perspective.

- Benjamin Bannier


On Sept. 25, 2019, 2:11 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71541/
> ---
> 
> (Updated Sept. 25, 2019, 2:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Meng Zhu.
> 
> 
> Bugs: MESOS-8503
> https://issues.apache.org/jira/browse/MESOS-8503
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed Javascript linting and IE compatibility of the UI roles tree.
> 
> 
> Diffs
> -
> 
>   src/webui/app/app.js 24fab090611fb2f8d46bb30c86fc4af052b87bb9 
> 
> 
> Diff: https://reviews.apache.org/r/71541/diff/1/
> 
> 
> Testing
> ---
> 
> tested manually
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>



Re: Review Request 71534: Fixed parsing of HTTP authentication headers.

2019-09-25 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71534/
---

(Updated Sept. 25, 2019, 11:21 a.m.)


Review request for mesos, Benno Evers, Greg Mann, and Till Toenshoff.


Summary (updated)
-

Fixed parsing of HTTP authentication headers.


Bugs: MESOS-9968
https://issues.apache.org/jira/browse/MESOS-9968


Repository: mesos


Description (updated)
---

This patch adds support for quoted strings in `Www-Authenticate` headers
and allows to use spaces when delimiting authentication attributes of
the form `WWW-Autenticate: a=b, c=d`, both of with are allowed by
RFC2617.


Diffs (updated)
-

  3rdparty/libprocess/include/process/http.hpp 
654bbc2221597028b45817b8c3e29dc17515c6fe 
  3rdparty/libprocess/src/http.cpp 0ed41aaac90dff188c424ded8536df03ab80d2ab 
  3rdparty/libprocess/src/tests/http_tests.cpp 
8cb5f163f2fc34baeabfb1ef640fe39bf6709872 


Diff: https://reviews.apache.org/r/71534/diff/2/

Changes: https://reviews.apache.org/r/71534/diff/1-2/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71538: Allowed disabling use of NVML headers.

2019-09-24 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71538/
---

Review request for mesos, Gilbert Song and Kevin Klues.


Bugs: MESOS-9978
https://issues.apache.org/jira/browse/MESOS-9978


Repository: mesos


Description
---

NVML is distributed under a license which is probably not "free" which
can e.g., be aan obstacle when including Mesos using symbols from it in
certain distributions.

This patch adds a configure flag to disable use of the NVML headers
completely. Note that with this flag disabled it is impossible to use
GPU isolation with the Mesos containerizer.


Diffs
-

  3rdparty/CMakeLists.txt 23ef7c1e5c6fe1555b6f2458f2a858471783ae2a 
  3rdparty/Makefile.am 0de005dad9775f9f7e1a77a242e3b345219c7ac3 
  cmake/CompilationConfigure.cmake 62cb23e81abb2c7e4e8e13c83b45afb98708bd30 
  configure.ac f274f34e6982beb0a5a683526f7eb9c4ea744e40 
  docs/configuration/autotools.md 55a5de83729271b043bd1b8de67798ab52b195c6 
  docs/configuration/cmake.md 554c3bf458bc85609225a19ad4843029772ab51c 
  src/CMakeLists.txt ef9382dc77d37fed344b7267119f3251acd3088a 
  src/Makefile.am eff0127a0baa7c112db32aa1bd2b35e0d3cb7aee 
  src/slave/containerizer/mesos/containerizer.cpp 
16149a1428db687b131de08d14893a2dd684ce28 
  src/slave/containerizer/mesos/isolators/gpu/nvml.hpp 
eb5c0b008abc651d826c399f4538ad8916469b86 
  src/slave/containerizer/mesos/isolators/gpu/nvml.cpp 
48a5bf6720e5c9a9ceec24740d47c14f0ad097b7 
  src/tests/environment.cpp c3596fb94020d2433f15e630516b1320875a9fa3 


Diff: https://reviews.apache.org/r/71538/diff/1/


Testing
---

* tested toggle both ways in cmake and autotools build
* wasn't able to test test filter since I don't seem to have access to a dev 
machine with GPUs


Thanks,

Benjamin Bannier



Re: Review Request 71522: Added missing member initialization in `JSON::WriterProxy`.

2019-09-23 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71522/
---

(Updated Sept. 23, 2019, 2:55 p.m.)


Review request for mesos, Benno Evers and Benjamin Mahler.


Repository: mesos


Description
---

Added missing member initialization in `JSON::WriterProxy`.


Diffs (updated)
-

  3rdparty/stout/include/stout/jsonify.hpp 
e5402b788dd8d539a7889c390a66abb3b36faca9 


Diff: https://reviews.apache.org/r/71522/diff/2/

Changes: https://reviews.apache.org/r/71522/diff/1-2/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71534: Properly handled quoted HTTP authentication headers.

2019-09-23 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71534/
---

Review request for mesos, Benno Evers, Greg Mann, and Till Toenshoff.


Bugs: MESOS-9968
https://issues.apache.org/jira/browse/MESOS-9968


Repository: mesos


Description
---

Properly handled quoted HTTP authentication headers.


Diffs
-

  3rdparty/libprocess/include/process/http.hpp 
654bbc2221597028b45817b8c3e29dc17515c6fe 
  3rdparty/libprocess/src/http.cpp 0ed41aaac90dff188c424ded8536df03ab80d2ab 
  3rdparty/libprocess/src/tests/http_tests.cpp 
8cb5f163f2fc34baeabfb1ef640fe39bf6709872 


Diff: https://reviews.apache.org/r/71534/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71533: Cleaned up `HTTPTest.WWWAuthenticateHeader`.

2019-09-23 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71533/
---

Review request for mesos, Benno Evers, Greg Mann, and Till Toenshoff.


Bugs: MESOS-9968
https://issues.apache.org/jira/browse/MESOS-9968


Repository: mesos


Description
---

This patch removes a number of error-prone temporaries previously reused
in the test.


Diffs
-

  3rdparty/libprocess/src/tests/http_tests.cpp 
8cb5f163f2fc34baeabfb1ef640fe39bf6709872 


Diff: https://reviews.apache.org/r/71533/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71523: Bumped mesos-tidy onto upstream release_90.

2019-09-20 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71523/
---

Review request for mesos and Benno Evers.


Repository: mesos


Description
---

Bumped mesos-tidy onto upstream release_90.


Diffs
-

  support/clang-tidy 27879a6eb7b43c767c68315c7d21f007da0c9875 
  support/mesos-tidy/Dockerfile a6ca38a0396fc48ff9f815d52c675eca2eae9ec8 


Diff: https://reviews.apache.org/r/71523/diff/1/


Testing
---

`./support/mesos-tidy.sh` with a locally built image


Thanks,

Benjamin Bannier



Review Request 71522: Added missing member initialization in `JSON::WriterProxy`.

2019-09-20 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71522/
---

Review request for mesos, Benno Evers and Benjamin Mahler.


Repository: mesos


Description
---

Added missing member initialization in `JSON::WriterProxy`.


Diffs
-

  3rdparty/stout/include/stout/jsonify.hpp 
e5402b788dd8d539a7889c390a66abb3b36faca9 


Diff: https://reviews.apache.org/r/71522/diff/1/


Testing
---


Thanks,

Benjamin Bannier



Re: Review Request 71510: Windows: Fixed parallel test execution.

2019-09-19 Thread Benjamin Bannier


> On Sept. 19, 2019, 12:25 p.m., Benjamin Bannier wrote:
> > cmake/MesosConfigure.cmake
> > Lines 55 (patched)
> > <https://reviews.apache.org/r/71510/diff/1/?file=2165728#file2165728line55>
> >
> > A feature of the current parallel test setup is that users can 
> > overwrite `TEST_DRIVER` at configure time (in autotools even at execution 
> > time). With this change we hardcode the assumption that `TEST_DRIVER` is a 
> > Python executable on Windows.
> > 
> > I am not sure how to address this (e.g., setting the default 
> > `TEST_DRIVER` to `python ...` is not possible as CTest would look for a 
> > non-existing executable name `python ...`). Would linking/copying 
> > `mesos-gtest-runner.py` to a file `mesos-gtest-runner.py.exe` in the build 
> > tree at configure time and adjusting the default for `WIN32` be possible?
> > 
> > In any case not an important regression, feel free to drop.
> 
> Joseph Wu wrote:
> It should still be possible to override the `TEST_DRIVER` here.  The 
> reason for the `TEST_RUNNER` temporary variable is to transform the 
> `TEST_DRIVER` into a list on Windows, but keep it as a string on Posix.
> 
> So on Windows, the variable looks like: 
> `python;../support/mesos-gtest-runner.py`.
> 
> If you were to override the value, (i.e. `cmake .. -DTEST_DRIVER=...`) 
> that value should be kept in the cache, like before.

Does it prefix the command with `python` on `WIN32` when executing?


> On Sept. 19, 2019, 12:25 p.m., Benjamin Bannier wrote:
> > src/tests/CMakeLists.txt
> > Lines 390 (patched)
> > <https://reviews.apache.org/r/71510/diff/1/?file=2165729#file2165729line390>
> >
> > In follow-up patches you used a different logic,
> > 
> > 
> > $<$>:$/>stout-tests$<$:.exe>
> > 
> > Why do they need to be different? Is the `CONFIG` part even required 
> > there?
> 
> Joseph Wu wrote:
> The extra stuff around the test name mostly becomes required due to the 
> `mesos-gtest-runner.py` script.  The script checks if the test binary exists 
> before running it.  And the script can't find the test binary unless we 
> prefix with the build config on Windows; and suffix with the actual file name 
> extension.
> 
> Prior to your test runner change, we didn't need the `CONFIG` part.  And 
> I believe that was cmake extending the binary search path automatically.
> 
> Note: On Windows, if you have an executable like `test.exe`, you can run 
> it while omitting the `.exe`.

Okay. Why is that not required in the follow-up stout and libprocess patches? 
In any case, it would go great for maintainability to document that in the 
actual cmake setup.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71510/#review217848
---


On Sept. 19, 2019, 1 a.m., Joseph Wu wrote:
> 
> -------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71510/
> ---
> 
> (Updated Sept. 19, 2019, 1 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since the default 'check' target now uses the parallel test runner,
> there are some changes necessary to use this on Windows.
> 
> In the script itself, references to RLimits need to be removed,
> since those structures do not exist on Windows.
> 
> The TEST_RUNNER variable must include "python" on Windows, since
> '.py' files are not automatically run with Python on Windows.
> 
> The script also needs the full test executable name (+ '.exe').
> We could omit this previously, because you can run executables
> while omitting the extension.  But the script checks if the file
> exists, and that operation requires the full name plus extension.
> 
> 
> Diffs
> -
> 
>   cmake/MesosConfigure.cmake 83d41addcd2c14358fba8bab2ac654475626a3e8 
>   src/tests/CMakeLists.txt 1e53b396569bf3e2f47199956a630afb6197b992 
>   support/mesos-gtest-runner.py 42c0a143477b5ccd411db482a8877e596f520342 
> 
> 
> Diff: https://reviews.apache.org/r/71510/diff/1/
> 
> 
> Testing
> ---
> 
> cmake --build . --target check (Windows)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Review Request 71519: Fixed inefficient `hashmap` access patterns.

2019-09-19 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71519/
---

Review request for mesos, Benno Evers and Benjamin Mahler.


Bugs: MESOS-9948
https://issues.apache.org/jira/browse/MESOS-9948


Repository: mesos


Description
---

This patch fixes some inefficient access patterns around `hashmap::get`.
Since this function returns an `Option` it can be used as a shorthand
for a `contains` check and subsequent creation of a value (`Option`
always contains a value). It was never not intended and is inefficient
for `contains` itself (e.g., via `hashmap::get::isSome`), and for cases
where only access to parts of the value in the `hashmap` is required
(e.g., to read a member of an optional value). In both these cases we
neither want nor need to create a temporary, and should instead either
just use `contains`, or access the value with `hashmap::at` after a
`contains` check since otherwise we might spend a lot of time creating
unnecessary temporary values.

This patch fixes some easily identifiable case found by manually
grooming the result of the following clang-query command:

match cxxMemberCallExpr(
  on(hasType(cxxRecordDecl(hasName("hashmap",
  unless(
hasParent(cxxBindTemporaryExpr(
  hasParent(materializeTemporaryExpr(
hasParent(exprWithCleanups(
  hasParent(varDecl(),
  callee(cxxMethodDecl(hasName("get"

This most probably misses a lot of cases. Given how easy it is to
misuse `hashmap::get` we should consider whether it makes sense to get
rid of it completely in lie of an inlined form trading some additional
lookups for temporary avoidance,

Option x = map.contains(k) ? Some(map.at(k)) : Option::none();


Diffs
-

  src/exec/exec.cpp 67e082e709ef803f49646da5c36147158330f725 
  src/executor/executor.cpp 664a2f1e0723f1afd9220e86e47e86cda67f6b9a 
  src/files/files.cpp f200d5e797084a2a5137ac8f8ede1f6243f12cfb 
  src/master/master.cpp a2c289a8b6e30eac690f77c7fc1b12b16f62f541 
  src/master/metrics.cpp 20d7231888e263cb3c1759407a2476291e515d4a 
  src/slave/containerizer/fetcher.cpp 8ae789a9f260645e574bbe46a108c3b8cab44cc4 
  src/slave/containerizer/mesos/isolators/posix.hpp 
1ff942cfd1f6829bdc3661b9260dd8e53732d023 
  src/slave/containerizer/mesos/launcher.cpp 
413cc621ad49150a6ddaf689bb75b9dc44741563 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
bf3908d274f8b6f4a57998cbb0a62312b71e3856 
  src/slave/slave.cpp 96890d37ec024fc33d2403b32576776888bcd9f7 
  src/state/log.cpp d3bf2ccceff1934785889ddc9507a754cce445fe 
  src/tests/slave_recovery_tests.cpp d99752ab082f1aca9fb77659378d0bca5a0598eb 
  src/tests/task_status_update_manager_tests.cpp 
0c8b0586a760683ff0ab0f11bf658073087eac12 


Diff: https://reviews.apache.org/r/71519/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71520: Fixed inefficient `hashmap` access patterns.

2019-09-19 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71520/
---

Review request for mesos, Benno Evers and Benjamin Mahler.


Bugs: MESOS-9948
https://issues.apache.org/jira/browse/MESOS-9948


Repository: mesos


Description
---

This patch fixes some inefficient access patterns around `hashmap::get`.
Since this function returns an `Option` it can be used as a shorthand
for a `contains` check and subsequent creation of a value (`Option`
always contains a value). It was never not intended and is inefficient
for `contains` itself (e.g., via `hashmap::get::isSome`), and for cases
where only access to parts of the value in the `hashmap` is required
(e.g., to read a member of an optional value). In both these cases we
neither want nor need to create a temporary, and should instead either
just use `contains`, or access the value with `hashmap::at` after a
`contains` check since otherwise we might spend a lot of time creating
unnecessary temporary values.

This patch fixes some easily identifiable case found by manually
grooming the result of the following clang-query command:

match cxxMemberCallExpr(
  on(hasType(cxxRecordDecl(hasName("hashmap",
  unless(
hasParent(cxxBindTemporaryExpr(
  hasParent(materializeTemporaryExpr(
hasParent(exprWithCleanups(
  hasParent(varDecl(),
  callee(cxxMethodDecl(hasName("get"

This most probably misses a lot of cases. Given how easy it is to
misuse `hashmap::get` we should consider whether it makes sense to get
rid of it completely in lie of an inlined form trading some additional
lookups for temporary avoidance,

Option x = map.contains(k) ? Some(map.at(k)) : Option::none();


Diffs
-

  3rdparty/libprocess/src/metrics/metrics.cpp 
623d44adbe838f995ddbe89ee26f5bcc9c600be5 


Diff: https://reviews.apache.org/r/71520/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Re: Review Request 71510: Windows: Fixed parallel test execution.

2019-09-19 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71510/#review217848
---




cmake/MesosConfigure.cmake
Lines 55 (patched)
<https://reviews.apache.org/r/71510/#comment305242>

A feature of the current parallel test setup is that users can overwrite 
`TEST_DRIVER` at configure time (in autotools even at execution time). With 
this change we hardcode the assumption that `TEST_DRIVER` is a Python 
executable on Windows.

I am not sure how to address this (e.g., setting the default `TEST_DRIVER` 
to `python ...` is not possible as CTest would look for a non-existing 
executable name `python ...`). Would linking/copying `mesos-gtest-runner.py` to 
a file `mesos-gtest-runner.py.exe` in the build tree at configure time and 
adjusting the default for `WIN32` be possible?

In any case not an important regression, feel free to drop.



src/tests/CMakeLists.txt
Lines 390 (patched)
<https://reviews.apache.org/r/71510/#comment305243>

In follow-up patches you used a different logic,

$<$>:$/>stout-tests$<$:.exe>

Why do they need to be different? Is the `CONFIG` part even required there?



support/mesos-gtest-runner.py
Lines 39 (patched)
<https://reviews.apache.org/r/71510/#comment305241>

Not a big fan of the magic string here and below.

Since this is only used in some best-effort validation I'd suggest we 
instead do down in `validate_setup`:

```{.python}
try:
import resource

/// reset of validation code
except Exception:  /// Also handles `ImportError`.
print(Bcolors.colorize(
   "Could not check compatibility of ulimit settings", /// Drop 
printing of error.
   Bcolors.WARNING),
 file=sys.stderr)
/// Make this a soft error and remove `sys.exit()`.
```


- Benjamin Bannier


On Sept. 19, 2019, 1 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71510/
> ---
> 
> (Updated Sept. 19, 2019, 1 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since the default 'check' target now uses the parallel test runner,
> there are some changes necessary to use this on Windows.
> 
> In the script itself, references to RLimits need to be removed,
> since those structures do not exist on Windows.
> 
> The TEST_RUNNER variable must include "python" on Windows, since
> '.py' files are not automatically run with Python on Windows.
> 
> The script also needs the full test executable name (+ '.exe').
> We could omit this previously, because you can run executables
> while omitting the extension.  But the script checks if the file
> exists, and that operation requires the full name plus extension.
> 
> 
> Diffs
> -
> 
>   cmake/MesosConfigure.cmake 83d41addcd2c14358fba8bab2ac654475626a3e8 
>   src/tests/CMakeLists.txt 1e53b396569bf3e2f47199956a630afb6197b992 
>   support/mesos-gtest-runner.py 42c0a143477b5ccd411db482a8877e596f520342 
> 
> 
> Diff: https://reviews.apache.org/r/71510/diff/1/
> 
> 
> Testing
> ---
> 
> cmake --build . --target check (Windows)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71507: Windows: Disabled the dist and distcheck targets with a note.

2019-09-18 Thread Benjamin Bannier


> On Sept. 18, 2019, 10:07 p.m., Benjamin Bannier wrote:
> > CMakeLists.txt
> > Lines 100 (patched)
> > <https://reviews.apache.org/r/71507/diff/1/?file=2165720#file2165720line100>
> >
> > This is consistent with how we do it elsewhere, but I wonder: is the 
> > reason we cannot have these targets here due to shell scripts not being 
> > available on the Windows _platform_, or due to the default _generator_ on 
> > Windows not supporting them (i.e., would this e.g., work when building with 
> > Ninja on Windows). Maybe you could leave a comment with a hint why we 
> > disable them here.
> 
> Joseph Wu wrote:
> The default way to handle `add_custom_target(... COMMAND ...)` depends on 
> the platform.  On Windows, it will attempt to run the command with `cmd`, 
> which won't work.  So this doesn't have much to do with the chosen generator.
> 
> It might be possible for a different generator to try appending `bash` 
> instead of `cmd`.  But the existence of `bash` on Windows is not guaranteed.

Great, let's capture the gist of that in a comment in the code.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71507/#review217830
---


On Sept. 18, 2019, 9:26 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71507/
> -------
> 
> (Updated Sept. 18, 2019, 9:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9971
> https://issues.apache.org/jira/browse/MESOS-9971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The targets are implemented with shell scripts, so do not work
> on Windows.  The targets are also currently unneeded for the Windows
> build.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a1ca5c28819b946b10a3533f4793896c676d4682 
> 
> 
> Diff: https://reviews.apache.org/r/71507/diff/1/
> 
> 
> Testing
> ---
> 
> cmake --build . --target dist
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71507: Windows: Disabled the dist and distcheck targets with a note.

2019-09-18 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71507/#review217830
---


Fix it, then Ship it!




In addition to testing the `dist` target, could you also confirm that this 
patch fixes the default workflow (probably: `cmake --build . --target check`)?


CMakeLists.txt
Lines 99 (patched)
<https://reviews.apache.org/r/71507/#comment305226>

Let's move this before the actual targets.



CMakeLists.txt
Lines 100 (patched)
<https://reviews.apache.org/r/71507/#comment305227>

This is consistent with how we do it elsewhere, but I wonder: is the reason 
we cannot have these targets here due to shell scripts not being available on 
the Windows _platform_, or due to the default _generator_ on Windows not 
supporting them (i.e., would this e.g., work when building with Ninja on 
Windows). Maybe you could leave a comment with a hint why we disable them here.


- Benjamin Bannier


On Sept. 18, 2019, 9:26 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71507/
> ---
> 
> (Updated Sept. 18, 2019, 9:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9971
> https://issues.apache.org/jira/browse/MESOS-9971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The targets are implemented with shell scripts, so do not work
> on Windows.  The targets are also currently unneeded for the Windows
> build.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a1ca5c28819b946b10a3533f4793896c676d4682 
> 
> 
> Diff: https://reviews.apache.org/r/71507/diff/1/
> 
> 
> Testing
> ---
> 
> cmake --build . --target dist
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Review Request 71503: Manually created clang-tidy config in mesos-tidy setup.

2019-09-18 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71503/
---

Review request for mesos and Benno Evers.


Repository: mesos


Description
---

Manually created clang-tidy config in mesos-tidy setup.


Diffs
-

  support/mesos-tidy/entrypoint.sh a8408678ec7dfda398a117788d5f5f955e304bc4 


Diff: https://reviews.apache.org/r/71503/diff/1/


Testing
---

Ran `support/mesos-tidy.sh` with local docker image.


Thanks,

Benjamin Bannier



Re: Review Request 65042: Adjusted CSI example framework for recent changes.

2019-09-17 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65042/
---

(Updated Sept. 17, 2019, 3 p.m.)


Review request for mesos, Gastón Kleiman and Till Toenshoff.


Changes
---

Rebase


Repository: mesos


Description
---

This patch adjusts the CSI example framework for recent cleanups to
example frameworks. It now uses generic flag classes which can e.g.,
parse from both the environment and the command line.


Diffs (updated)
-

  src/examples/test_csi_user_framework.cpp 
1bf5d14859be5ec4e7ff351ab34a9b5752080146 


Diff: https://reviews.apache.org/r/65042/diff/4/

Changes: https://reviews.apache.org/r/65042/diff/3-4/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71494: Removed documentation on cquery.

2019-09-17 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71494/
---

Review request for mesos, Andrew Schwartzmeyer, Benno Evers, and Till Toenshoff.


Repository: mesos


Description
---

Cquery is not developed anymore and being replaced by larger LSP
implementation such as clangd. This patch completely removes any
cquery-related documentation instead of updating it to use e.g., clangd.
This is because any documentation related to setting up a LSP pipeline
would be almost exclusively generic to a CMake C++ project and not
specific to Mesos.


Diffs
-

  docs/cquery.md b893bc522561306a2cdf15e1c1876108ec8d329c 
  docs/developer-guide.md 3906275e18801853bd21da18073c9f0e44aba2cd 


Diff: https://reviews.apache.org/r/71494/diff/1/


Testing
---

Test-rendered the documentation


Thanks,

Benjamin Bannier



Re: Review Request 71445: Removed race in `StorageLocalResourceProviderTest.Update`.

2019-09-12 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71445/
---

(Updated Sept. 12, 2019, 11:01 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Changes
---

Simplify the test even more


Repository: mesos


Description
---

The agent might take some time before registering with the master which
could have lead to unexpected retries in this test which the clock was
resumed. This patch simplifies the test so we do not rely on
`UpdateSlaveMessage` anymore.


Diffs (updated)
-

  src/tests/storage_local_resource_provider_tests.cpp 
089aa9787a66d737267179ad461be0c0a99d5c63 


Diff: https://reviews.apache.org/r/71445/diff/2/

Changes: https://reviews.apache.org/r/71445/diff/1-2/


Testing
---

* `make check`
* ran test fixed here in repetition under external stress. Previous failure 
rate ~6%, no failures in >5k runs after


Thanks,

Benjamin Bannier



Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-09-10 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/
---

(Updated Sept. 10, 2019, 12:02 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Do not run pylint on CLI-related files

These files require certain packages to be installed. Previously mesos-style 
solved this by by executing special scripts which set up the virtual envs in 
which pylint could be run. Since pylint is also run as part of the test suite 
of these scripts we now remove the external linting here since it the effort 
exceeds the benefit.


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch switches commit hooks to be orchestrated by the pre-commit
tool mirroring the previous linters invoked through git commit
hooks (orchestrated by `support/mesos-style.py` or standalone hooks).

Using pre-commit removes the burden of maintaining
`support/mesos-style.py`, making sure that hooks have the expected
environment (e.g., Python version, Node installed). Additionally,
upstream provides a number of additional linters which are not hard to
add to Mesos' hooks.


Diffs (updated)
-

  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/pre-commit-config.yaml PRE-CREATION 
  support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71205/diff/12/

Changes: https://reviews.apache.org/r/71205/diff/11-12/


Testing
---

* used successfully for a couple of months


Thanks,

Benjamin Bannier



Re: Review Request 71457: Activated tests for `src/python/lib`.

2019-09-09 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71457/
---

(Updated Sept. 9, 2019, 7:49 p.m.)


Review request for mesos, Armand Grillet, Benno Evers, and Kevin Klues.


Changes
---

Address more comments from Benno


Repository: mesos


Description
---

This directory already had a tox config, but this setup was never
excercised automatically. This patch adds a test running `tox` for that
directory. We require `tox` to be present in the system and add
configure-time checks for that.


Diffs (updated)
-

  cmake/CompilationConfigure.cmake c8da0895d7e932b51b711be0bf28e01548b94bf6 
  configure.ac 1814bc67fd7c683285ed44d20273de02e7a6f251 
  src/CMakeLists.txt 0ec4442245f09afd6a8281f58a4a4d29c2216fe7 
  src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6 
  src/python/lib/CMakeLists.txt PRE-CREATION 


Diff: https://reviews.apache.org/r/71457/diff/4/

Changes: https://reviews.apache.org/r/71457/diff/3-4/


Testing
---

`make check` in both autotools & cmake build


Thanks,

Benjamin Bannier



Re: Review Request 71457: Activated tests for `src/python/lib`.

2019-09-09 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71457/
---

(Updated Sept. 9, 2019, 6:34 p.m.)


Review request for mesos, Armand Grillet, Benno Evers, and Kevin Klues.


Changes
---

Address offline comments from Benno


Repository: mesos


Description
---

This directory already had a tox config, but this setup was never
excercised automatically. This patch adds a test running `tox` for that
directory. We require `tox` to be present in the system and add
configure-time checks for that.


Diffs (updated)
-

  cmake/CompilationConfigure.cmake c8da0895d7e932b51b711be0bf28e01548b94bf6 
  configure.ac 1814bc67fd7c683285ed44d20273de02e7a6f251 
  src/CMakeLists.txt 0ec4442245f09afd6a8281f58a4a4d29c2216fe7 
  src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6 
  src/python/lib/CMakeLists.txt PRE-CREATION 


Diff: https://reviews.apache.org/r/71457/diff/3/

Changes: https://reviews.apache.org/r/71457/diff/2-3/


Testing
---

`make check` in both autotools & cmake build


Thanks,

Benjamin Bannier



Review Request 71457: Activated tests for `src/python/lib`.

2019-09-09 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71457/
---

Review request for mesos, Armand Grillet, Benno Evers, and Kevin Klues.


Repository: mesos


Description
---

This directory already had a tox config, but this setup was never
excercised automatically. This patch adds a test running `tox` for that
directory. We require `tox` to be present in the system and add
configure-time checks for that.


Diffs
-

  cmake/CompilationConfigure.cmake c8da0895d7e932b51b711be0bf28e01548b94bf6 
  configure.ac 1814bc67fd7c683285ed44d20273de02e7a6f251 
  src/CMakeLists.txt 0ec4442245f09afd6a8281f58a4a4d29c2216fe7 
  src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6 
  src/python/lib/CMakeLists.txt PRE-CREATION 


Diff: https://reviews.apache.org/r/71457/diff/1/


Testing
---

`make check` in both autotools & cmake build


Thanks,

Benjamin Bannier



Review Request 71453: Punctually disabled pylint's `cyclic-import` warning.

2019-09-09 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71453/
---

Review request for mesos and Jan Schlicht.


Repository: mesos


Description
---

In certain places in the new CLI we reimport symbols into other modules.


Diffs
-

  src/python/cli_new/lib/cli/__init__.py 
e594b30e76056a7c5dd4438da34e9883c7c9bc2c 
  src/python/cli_new/lib/cli/tests/__init__.py 
144cb338e9453c7f68d74a58620ee9d2345e363d 


Diff: https://reviews.apache.org/r/71453/diff/1/


Testing
---

Before this patch the following test fails,

```
$ cmake .. -DPYTHON_3=python3 -DENABLE_NEW_CLI=ON && make cli-tests && ctest -R 
CLITests
...
4: py3-lint runtests: commands[0] | pylint --score=n 
--rcfile=../../../support/pylint.config lib/cli tests
4: * Module tests.main
4: tests/main.py:1:0: R0401: Cyclic import (cli -> cli.plugins -> 
cli.plugins.base) (cyclic-import)
4: tests/main.py:1:0: R0401: Cyclic import (cli -> cli.config) (cyclic-import)
4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.agent) 
(cyclic-import)
4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.tests) 
(cyclic-import)
4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.task) 
(cyclic-import)
4: ERROR: InvocationError for command 
'/home/bbannier/src/mesos/src/python/cli_new/.tox/py3-lint/bin/pylint --score=n 
--rcfile=../../../support/pylint.config lib/cli tests' (exited with code 8)
4: ___ summary 

4: ERROR:   py3-lint: commands failed
1/1 Test #4: CLITests .***Failed6.02 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   6.03 sec

The following tests FAILED:
  4 - CLITests (Failed)
Errors while running CTest
```

After this patch the test passes,

```
...
4: py3-lint runtests: commands[0] | pylint --score=n 
--rcfile=../../../support/pylint.config lib/cli tests
4: ___ summary 

4:   py3-lint: commands succeeded
4:   congratulations :)
...
```


Thanks,

Benjamin Bannier



Review Request 71452: Bumped Boost to 1.71.0.

2019-09-09 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71452/
---

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
---

Bumped Boost to 1.71.0.


Diffs
-

  3rdparty/stout/3rdparty/Makefile.am 5a90a11c67131f21dc4487222ea1dde228dd 
  3rdparty/stout/Makefile.am 743ae4ddbdcaa41e90424a23cf00e805a09a3795 


Diff: https://reviews.apache.org/r/71452/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71450: Bumped Boost to 1.71.0.

2019-09-09 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71450/
---

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
---

Bumped Boost to 1.71.0.


Diffs
-

  3rdparty/CMakeLists.txt 23ef7c1e5c6fe1555b6f2458f2a858471783ae2a 
  3rdparty/Makefile.am 0de005dad9775f9f7e1a77a242e3b345219c7ac3 
  3rdparty/boost-1.65.0.patch 75be3bc42004e3aa0284c3ad8dda64f1ba6af7a7 
  3rdparty/boost-1.65.0.tar.gz b09d18549d6cb11d7ae8c453cd5e8ae8c2102167 
  3rdparty/boost.md d6e482f84f28d2d22d594e45c30fa05ef0c9f162 
  3rdparty/boost_1_71_0.tar.gz PRE-CREATION 
  3rdparty/cmake/Versions.cmake 93766161da14eab30f4ebf382303073aa2b6d448 
  3rdparty/versions.am 6f6195d8c616695f2077c6c36d96071360b1abb7 
  src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6 
  support/coverage.sh 4fbefa994a6974fb4186b0388b6a11a40eb5dcc9 
  support/mesos-tidy/entrypoint.sh a8408678ec7dfda398a117788d5f5f955e304bc4 


Diff: https://reviews.apache.org/r/71450/diff/1/


Testing
---

This commit does not compile on its own; tested as part of 
https://reviews.apache.org/r/71452/.


Thanks,

Benjamin Bannier



Review Request 71451: Bumped Boost to 1.71.0.

2019-09-09 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71451/
---

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
---

Bumped Boost to 1.71.0.


Diffs
-

  3rdparty/libprocess/3rdparty/Makefile.am 
e148f2dd2470ba973cc3f6d4067be64039299a48 
  3rdparty/libprocess/Makefile.am 641251af5631e9b3928dfb282cdbc266ba76572e 


Diff: https://reviews.apache.org/r/71451/diff/1/


Testing
---

This commit does not compile on its own; tested as part of 
https://reviews.apache.org/r/71452/.


Thanks,

Benjamin Bannier



Review Request 71445: Removed race in `StorageLocalResourceProviderTest.Update`.

2019-09-06 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71445/
---

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Repository: mesos


Description
---

The agent might take some time before registering with the master which
could have lead to unexpected retries in this test which the clock was
resumed. This patch simplifies the test so we do not rely on
`UpdateSlaveMessage` anymore.


Diffs
-

  src/tests/storage_local_resource_provider_tests.cpp 
089aa9787a66d737267179ad461be0c0a99d5c63 


Diff: https://reviews.apache.org/r/71445/diff/1/


Testing
---

* `make check`
* ran test fixed here in repetition under external stress. Previous failure 
rate ~6%, no failures in >5k runs after


Thanks,

Benjamin Bannier



Re: Review Request 71240: Added a `dist` target to the cmake build.

2019-09-06 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/
---

(Updated Sept. 6, 2019, 12:13 p.m.)


Review request for mesos, Benjamin Mahler and Till Toenshoff.


Repository: mesos


Description
---

This patch adds a `dist` target to the cmake build, analogous to the
target provided by the autotools build.

While cmake already provides a `package_source` target to create a
source archive it does not take care of only including relevant files,
but instead adds all files to the archive, e.g., including build or
backup files which should not be part of a release. For that reason this
patch introduces a script which performs a temporary `git clone` from
the checked out git repository and creates the archive from that clean
tree.

This patch also removes a hardcoded list of ignored files which was
by design not exhaustive.


Diffs (updated)
-

  CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a 
  cmake/dist.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71240/diff/3/

Changes: https://reviews.apache.org/r/71240/diff/2-3/


Testing
---

`ninja dist` produces a tarball, no artifacts left around but tarball.


Thanks,

Benjamin Bannier



Re: Review Request 71392: Improved snapshot script to deduce the Mesos version.

2019-09-05 Thread Benjamin Bannier


> On Sept. 2, 2019, 2:41 p.m., Benjamin Bannier wrote:
> > support/snapshot.sh
> > Line 35 (original), 33 (patched)
> > <https://reviews.apache.org/r/71392/diff/1/?file=2163061#file2163061line35>
> >
> > With this change this script becomes really weird. Do we really want to 
> > get `VERSION` from `configure.ac` so we can update the version in 
> > `configure.ac`?
> > 
> > Did you mean to get e.g., get a version from `git` instead? I'd imagine 
> > snapshots like `master-d7286896411` or `1.8.x-d7286896411` could be useful.

I missed that you appended `SNAPSHOT` to `$VERSION` so this isn't fully 
circular. Dropping.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71392/#review217530
---


On Aug. 28, 2019, 6:39 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71392/
> ---
> 
> (Updated Aug. 28, 2019, 6:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-9955
> https://issues.apache.org/jira/browse/MESOS-9955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously the script expected the version to be provided as an
> argument.
> 
> 
> Diffs
> -
> 
>   support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3 
> 
> 
> Diff: https://reviews.apache.org/r/71392/diff/1/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>



Re: Review Request 71385: Added restart logic for failing resource providers.

2019-09-04 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71385/
---

(Updated Sept. 4, 2019, 2:42 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Changes
---

Address issue raised by Jan


Bugs: MESOS-8400
https://issues.apache.org/jira/browse/MESOS-8400


Repository: mesos


Description
---

This patch adds restart logic to the resource provider daemon. We now
watch launched providers and restart them should they become terminal.


Diffs (updated)
-

  src/resource_provider/daemon.cpp 2fd82ad5749e3948c590ce5e9816566a3627b885 
  src/resource_provider/local.hpp 75ce0f2e4a744685f2b701ecce269995f5ddaafb 
  src/resource_provider/storage/provider.hpp 
ccd09dfe826d89c2775939bf132697956429c289 
  src/resource_provider/storage/provider.cpp 
0a8dc26e66db0242474bcbbd0b2ff9cec81c58f5 
  src/tests/storage_local_resource_provider_tests.cpp 
089aa9787a66d737267179ad461be0c0a99d5c63 


Diff: https://reviews.apache.org/r/71385/diff/2/

Changes: https://reviews.apache.org/r/71385/diff/1-2/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Re: Review Request 71385: Added restart logic for failing resource providers.

2019-09-04 Thread Benjamin Bannier


> On Sept. 3, 2019, 3:28 p.m., Jan Schlicht wrote:
> > src/resource_provider/daemon.cpp
> > Lines 536 (patched)
> > <https://reviews.apache.org/r/71385/diff/1/?file=2163045#file2163045line536>
> >
> > Should we restart here? Though the future currently won't be set to 
> > ready, it might do that in the future. If a resource provider is exited 
> > normally, is it supposed to be restarted?

Very good point. I fixed the handling to return early if the container exited 
normally (this will currently not be triggered as nothing makes the `Future` 
ready).


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71385/#review217546
-------


On Sept. 4, 2019, 2:42 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71385/
> ---
> 
> (Updated Sept. 4, 2019, 2:42 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8400
> https://issues.apache.org/jira/browse/MESOS-8400
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds restart logic to the resource provider daemon. We now
> watch launched providers and restart them should they become terminal.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/daemon.cpp 2fd82ad5749e3948c590ce5e9816566a3627b885 
>   src/resource_provider/local.hpp 75ce0f2e4a744685f2b701ecce269995f5ddaafb 
>   src/resource_provider/storage/provider.hpp 
> ccd09dfe826d89c2775939bf132697956429c289 
>   src/resource_provider/storage/provider.cpp 
> 0a8dc26e66db0242474bcbbd0b2ff9cec81c58f5 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 089aa9787a66d737267179ad461be0c0a99d5c63 
> 
> 
> Diff: https://reviews.apache.org/r/71385/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Review Request 71430: Included new Python CLI in distribution tarball.

2019-09-04 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71430/
---

Review request for mesos and Benno Evers.


Bugs: MESOS-9958
https://issues.apache.org/jira/browse/MESOS-9958


Repository: mesos


Description
---

Included new Python CLI in distribution tarball.


Diffs
-

  src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6 


Diff: https://reviews.apache.org/r/71430/diff/1/


Testing
---

* confirmed that the new CLI source files are contained in the distribution 
tarball
* one can currently still not run `make distcheck` with `--enable-new-cli` 
since the Mesos lib egg build process puts output files into the source dir


Thanks,

Benjamin Bannier



Re: Review Request 71241: Added a `distcheck` target to the cmake build.

2019-09-03 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71241/
---

(Updated Sept. 3, 2019, 4:51 p.m.)


Review request for mesos, Benjamin Mahler and Till Toenshoff.


Changes
---

Add a `TODO` on checking `install` target


Repository: mesos


Description
---

This patch adds a `distcheck` target to the cmake build which mimics the
target of the same name provided by the autotools build. `distcheck`
depends on the `dist` target to create a distribution archive and then
ensures that with the distributed sources the `check` targets succeeds.


Diffs (updated)
-

  CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a 
  cmake/distcheck.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71241/diff/3/

Changes: https://reviews.apache.org/r/71241/diff/2-3/


Testing
---

`ninja distcheck` passes, no artifacts left around but tarball.


Thanks,

Benjamin Bannier



Re: Review Request 71240: Added a `dist` target to the cmake build.

2019-09-03 Thread Benjamin Bannier
/README.md
mesos-1.10.0/support/jenkins/reviewbot.sh
mesos-1.10.0/support/jenkins/tidybot.sh
mesos-1.10.0/support/jenkins/websitebot.sh
mesos-1.10.0/support/jenkins/windows-buildbot.bat
mesos-1.10.0/support/jsonurl.py
mesos-1.10.0/support/llvm/
mesos-1.10.0/support/llvm/install.sh
mesos-1.10.0/support/llvm/README.md
mesos-1.10.0/support/mesos-build/
mesos-1.10.0/support/mesos-build/centos-7.dockerfile
mesos-1.10.0/support/mesos-build/enable-devtoolset-4.sh
mesos-1.10.0/support/mesos-build/entrypoint.sh
mesos-1.10.0/support/mesos-build.sh
mesos-1.10.0/support/mesos-build/ubuntu-16.04-arm.dockerfile
mesos-1.10.0/support/mesos-build/ubuntu-16.04.dockerfile
mesos-1.10.0/support/mesos-mini/
mesos-1.10.0/support/mesos-mini/build.sh
mesos-1.10.0/support/mesos-mini/docker_daemon.json
mesos-1.10.0/support/mesos-mini/docker_env.sh
mesos-1.10.0/support/mesos-mini/Dockerfile
mesos-1.10.0/support/mesos-mini/docker.service
mesos-1.10.0/support/mesos-mini/entrypoint.sh
mesos-1.10.0/support/mesos-mini/marathon.service
mesos-1.10.0/support/mesos-mini/marathon.sh
mesos-1.10.0/support/mesos-mini/mesos/
mesos-1.10.0/support/mesos-mini/mesos/agent_environment
mesos-1.10.0/support/mesos-mini/mesos/master_environment
mesos-1.10.0/support/mesos-mini/mesos/modules/
mesos-1.10.0/support/mesos-mini/mesos/modules/uri_disk_profile.json
mesos-1.10.0/support/mesos-mini/mesos/ucr-default-bridge.json
mesos-1.10.0/support/mesos-reviewbot.ps1
mesos-1.10.0/support/mesos-split.py
mesos-1.10.0/support/mesos-style.py
mesos-1.10.0/support/mesos-tidy/
mesos-1.10.0/support/mesos-tidy/Dockerfile
mesos-1.10.0/support/mesos-tidy/entrypoint.sh
mesos-1.10.0/support/mesos-tidy/README.md
mesos-1.10.0/support/mesos-tidy.sh
mesos-1.10.0/support/mesos-website/
mesos-1.10.0/support/mesos-website/build.sh
mesos-1.10.0/support/mesos-website/Dockerfile
mesos-1.10.0/support/mesos-website/entrypoint.sh
mesos-1.10.0/support/mesos-website.sh
mesos-1.10.0/support/packaging/
mesos-1.10.0/support/packaging/bintray.sh
mesos-1.10.0/support/packaging/centos/
mesos-1.10.0/support/packaging/centos/build-docker-centos.sh
mesos-1.10.0/support/packaging/centos/build-docker-rpmbuild.sh
mesos-1.10.0/support/packaging/centos/build-rpm-docker.sh
mesos-1.10.0/support/packaging/centos/build_rpm.sh
mesos-1.10.0/support/packaging/centos/centos6.dockerfile
mesos-1.10.0/support/packaging/centos/centos7.dockerfile
mesos-1.10.0/support/packaging/centos/mesos.spec
mesos-1.10.0/support/packaging/centos/user-init.sh
mesos-1.10.0/support/packaging/common/
mesos-1.10.0/support/packaging/common/mesos
mesos-1.10.0/support/packaging/common/mesos-init-wrapper
mesos-1.10.0/support/packaging/common/mesos-master
mesos-1.10.0/support/packaging/common/mesos-master.service
mesos-1.10.0/support/packaging/common/mesos-master.upstart
mesos-1.10.0/support/packaging/common/mesos-slave
mesos-1.10.0/support/packaging/common/mesos-slave.service
mesos-1.10.0/support/packaging/common/mesos-slave.upstart
mesos-1.10.0/support/packaging/Jenkinsfile
mesos-1.10.0/support/pip-requirements.txt
mesos-1.10.0/support/post-build-result.py
mesos-1.10.0/support/post-reviews.py
mesos-1.10.0/support/push-commits.py
mesos-1.10.0/support/pylint.config
mesos-1.10.0/support/README.md
mesos-1.10.0/support/release.sh
mesos-1.10.0/support/reviewboardrc
mesos-1.10.0/support/snapshot.sh
mesos-1.10.0/support/test-upgrade.py
mesos-1.10.0/support/timed-tests.sh
mesos-1.10.0/support/verify-reviews.py
mesos-1.10.0/support/vote.sh
mesos-1.10.0/support/windows-build.bat

- Benjamin Bannier


On Sept. 3, 2019, 3:52 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71240/
> ---
> 
> (Updated Sept. 3, 2019, 3:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a `dist` target to the cmake build, analogous to the
> target provided by the autotools build.
> 
> While cmake already provides a `package_source` target to create a
> source archive it does not take care of only including relevant files,
> but instead adds all files to the archive, e.g., including build or
> backup files which should not be part of a release. For that reason this
> patch introduces a script which performs a temporary `git clone` from
> the checked out git repository and creates the archive from that clean
> tree.
> 
> This patch also removes a hardcoded list of ignor

Re: Review Request 71241: Added a `distcheck` target to the cmake build.

2019-09-03 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71241/
---

(Updated Sept. 3, 2019, 3:52 p.m.)


Review request for mesos, Benjamin Mahler and Till Toenshoff.


Changes
---

Address issues raised by Benno


Repository: mesos


Description
---

This patch adds a `distcheck` target to the cmake build which mimics the
target of the same name provided by the autotools build. `distcheck`
depends on the `dist` target to create a distribution archive and then
ensures that with the distributed sources the `check` targets succeeds.


Diffs (updated)
-

  CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a 
  cmake/distcheck.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71241/diff/2/

Changes: https://reviews.apache.org/r/71241/diff/1-2/


Testing
---

`ninja distcheck` passes, no artifacts left around but tarball.


Thanks,

Benjamin Bannier



Re: Review Request 71241: Added a `distcheck` target to the cmake build.

2019-09-03 Thread Benjamin Bannier


> On Sept. 3, 2019, 3:08 p.m., Benno Evers wrote:
> > cmake/distcheck.sh
> > Lines 25 (patched)
> > <https://reviews.apache.org/r/71241/diff/1/?file=2159995#file2159995line25>
> >
> > I don't think we should unconditionally override the users environment 
> > like this in a support script - there's no guarantee that `clang` or 
> > `ccache` are even installed.
> > 
> > If we have to specify `CMAKE_CXX_COMPILER` etc. at all, we should 
> > probably use `${CXX}` as default value and make sure that cmake sets the 
> > correct values when invoking the script.

Thanks for catching this. This isn't only not nice, but shouldn't have been 
there at all; I simply forgot implementing this part.

What I do now is to pass a shell variable `DISTCHECK_CMAKE_ARGS` (modelled 
after autoconf's `DISTCHECK_CONFIGURE_ARGS`) which can be filled with the kinds 
of arguments I passed above.

```
cmake .. ${DISTCHECK_CMAKE_FLAGS}
```


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71241/#review217542
-------


On Sept. 3, 2019, 3:52 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71241/
> ---
> 
> (Updated Sept. 3, 2019, 3:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a `distcheck` target to the cmake build which mimics the
> target of the same name provided by the autotools build. `distcheck`
> depends on the `dist` target to create a distribution archive and then
> ensures that with the distributed sources the `check` targets succeeds.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a 
>   cmake/distcheck.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71241/diff/2/
> 
> 
> Testing
> ---
> 
> `ninja distcheck` passes, no artifacts left around but tarball.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71240: Added a `dist` target to the cmake build.

2019-09-03 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/
---

(Updated Sept. 3, 2019, 3:52 p.m.)


Review request for mesos, Benjamin Mahler and Till Toenshoff.


Changes
---

Address issues raised by Benno


Repository: mesos


Description
---

This patch adds a `dist` target to the cmake build, analogous to the
target provided by the autotools build.

While cmake already provides a `package_source` target to create a
source archive it does not take care of only including relevant files,
but instead adds all files to the archive, e.g., including build or
backup files which should not be part of a release. For that reason this
patch introduces a script which performs a temporary `git clone` from
the checked out git repository and creates the archive from that clean
tree.

This patch also removes a hardcoded list of ignored files which was
by design not exhaustive.


Diffs (updated)
-

  CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a 
  cmake/dist.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71240/diff/2/

Changes: https://reviews.apache.org/r/71240/diff/1-2/


Testing
---

`ninja dist` produces a tarball, no artifacts left around but tarball.


Thanks,

Benjamin Bannier



Re: Review Request 71240: Added a `dist` target to the cmake build.

2019-09-03 Thread Benjamin Bannier


> On Sept. 3, 2019, 3:08 p.m., Benno Evers wrote:
> > cmake/dist.sh
> > Lines 8 (patched)
> > <https://reviews.apache.org/r/71240/diff/1/?file=2159993#file2159993line8>
> >
> > Why this restriction if we're going to create the tarball from a clean 
> > checkout anyways?

The purpose of this is to prevent situations where somebody creates a dist 
tarball from a dirty tree only to not have the changes reflected in the created 
tarball. This would be confusing and error-prone behavior.


> On Sept. 3, 2019, 3:08 p.m., Benno Evers wrote:
> > cmake/dist.sh
> > Lines 19 (patched)
> > <https://reviews.apache.org/r/71240/diff/1/?file=2159993#file2159993line19>
> >
> > I'm not sure if this is written down anywhere, but in general it's a 
> > good shell-script best practice to use `SCREAMING_CASE` for variables that 
> > can be overriden from outside and `lower_case` for variables that are 
> > internal to the script.

That sounds reasonable, but would not at all be in line with our current 
convention.

Dropping this for now.


> On Sept. 3, 2019, 3:08 p.m., Benno Evers wrote:
> > cmake/dist.sh
> > Lines 21 (patched)
> > <https://reviews.apache.org/r/71240/diff/1/?file=2159993#file2159993line21>
> >
> > Can we find a more speaking name than `D` for this? Also, since this is 
> > used as a temporary directory it might make sense to use `mktemp -d` rather 
> > than hardcoding the directory name.

Great suggestion on the temp dir (I had modelled this after autotools' `make 
distcheck` always using a fixed output directory in the build directory; now 
that I think about that I am not sure that was ever useful to me and not just 
an opportunity for name collisions in a dirty tree). Went with `WORKDIR` as var 
name.


> On Sept. 3, 2019, 3:08 p.m., Benno Evers wrote:
> > cmake/dist.sh
> > Lines 29 (patched)
> > <https://reviews.apache.org/r/71240/diff/1/?file=2159993#file2159993line29>
> >
> > Can you explain why in-tree builds are not supported, i.e. why do we 
> > need to create a separate build directory here?

TBH, I cannot, but this is a general feature of our cmake setup (I suspect it 
has to do with aspects like generated files).

Dropping.


> On Sept. 3, 2019, 3:08 p.m., Benno Evers wrote:
> > cmake/dist.sh
> > Lines 33 (patched)
> > <https://reviews.apache.org/r/71240/diff/1/?file=2159993#file2159993line33>
> >
> > I assume `nproc` is some magic cmake variable that is set automatically?

`nproc` is part of coreutils which we also assume elsewhere.


- Benjamin


-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/#review217539
---


On Sept. 3, 2019, 3:52 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71240/
> ---
> 
> (Updated Sept. 3, 2019, 3:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a `dist` target to the cmake build, analogous to the
> target provided by the autotools build.
> 
> While cmake already provides a `package_source` target to create a
> source archive it does not take care of only including relevant files,
> but instead adds all files to the archive, e.g., including build or
> backup files which should not be part of a release. For that reason this
> patch introduces a script which performs a temporary `git clone` from
> the checked out git repository and creates the archive from that clean
> tree.
> 
> This patch also removes a hardcoded list of ignored files which was
> by design not exhaustive.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a 
>   cmake/dist.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71240/diff/2/
> 
> 
> Testing
> ---
> 
> `ninja dist` produces a tarball, no artifacts left around but tarball.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71395: Implemented snapshot bot.

2019-09-02 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71395/#review217534
---


Fix it, then Ship it!





support/mesos-snapshot.sh
Lines 23 (patched)
<https://reviews.apache.org/r/71395/#comment304788>

This is weird since we usually only skip these scripts into a Jenkins and 
non-Jenkins part if the script can be run outside of CI.

I'd suggest we get `M2_DIR` via `mvn help:evaluate 
-Dexpression=settings.localRepository | grep -v '[INFO]'`; alternatively inline 
this whole script into the Jenkins script.


- Benjamin Bannier


On Aug. 28, 2019, 6:41 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71395/
> ---
> 
> (Updated Aug. 28, 2019, 6:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-9955
> https://issues.apache.org/jira/browse/MESOS-9955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Dockerized the snapshot building process.
> 
> 
> Diffs
> -
> 
>   support/jenkins/snapshotbot.sh PRE-CREATION 
>   support/mesos-snapshot.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71395/diff/1/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>



Re: Review Request 71394: Skipped GPG signing for snapshot builds.

2019-09-02 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71394/#review217533
---


Ship it!




LGTM, but I think a much preferable approach would have been to sign with a CI 
key. I'd be surprised if that wasn't already part of the ASF CI env (which 
includes lots of Java projects).

- Benjamin Bannier


On Aug. 28, 2019, 6:40 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71394/
> ---
> 
> (Updated Aug. 28, 2019, 6:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-9955
> https://issues.apache.org/jira/browse/MESOS-9955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Skipped GPG signing for snapshot builds.
> 
> 
> Diffs
> -
> 
>   support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3 
> 
> 
> Diff: https://reviews.apache.org/r/71394/diff/1/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>



Re: Review Request 71393: Skiped GPG signing during `maven-install` in Makefile.

2019-09-02 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71393/#review217532
---


Ship it!




LGTM, but I think a much preferable approach would have been to sign with a CI 
key. I'd be surprised if that wasn't already part of the ASF CI env (which 
includes lots of Java projects).

- Benjamin Bannier


On Aug. 28, 2019, 6:40 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71393/
> ---
> 
> (Updated Aug. 28, 2019, 6:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-9955
> https://issues.apache.org/jira/browse/MESOS-9955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> GPG signing is not needed for snapshot JARs (since they are
> typically done by CI). But our snapshot building workflow,
> i.e., support/snapshot.sh, relies on `make maven-install` which forces
> GPG signing to happen. This allows our snapshot script to skip GPG
> signing by doing `mvn deploy -Dgpg.skip`.
> 
> Note that GPG signing still happens for RCs and release JARs (which
> are typically done by humans) when `mvn deploy` (without `-Dgpg.skip`)
> is called (e.g., in support/vote.sh).
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6 
> 
> 
> Diff: https://reviews.apache.org/r/71393/diff/1/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>



Re: Review Request 71392: Improved snapshot script to deduce the Mesos version.

2019-09-02 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71392/#review217530
---




support/snapshot.sh
Line 35 (original), 33 (patched)
<https://reviews.apache.org/r/71392/#comment304787>

With this change this script becomes really weird. Do we really want to get 
`VERSION` from `configure.ac` so we can update the version in `configure.ac`?

Did you mean to get e.g., get a version from `git` instead? I'd imagine 
snapshots like `master-d7286896411` or `1.8.x-d7286896411` could be useful.


- Benjamin Bannier


On Aug. 28, 2019, 6:39 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71392/
> ---
> 
> (Updated Aug. 28, 2019, 6:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-9955
> https://issues.apache.org/jira/browse/MESOS-9955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously the script expected the version to be provided as an
> argument.
> 
> 
> Diffs
> -
> 
>   support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3 
> 
> 
> Diff: https://reviews.apache.org/r/71392/diff/1/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>



Re: Review Request 71391: Fixed sed arg to work on Linux and OSX.

2019-09-02 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71391/#review217529
---


Fix it, then Ship it!





support/snapshot.sh
Line 40 (original), 41-45 (patched)
<https://reviews.apache.org/r/71391/#comment304786>

I am not a big fan of duplicating that complicated substitution around.

What do you think about introducing a oneline helper function, e.g.,

```
SED_I() { [[ "$OSTYPE" == "darwin"* ]] && sed -i '' $@ || sed -i $@; }
SED_I "s/[mesos], [.*]/[mesos], [${TAG}]/" configure.ac
```


- Benjamin Bannier


On Aug. 28, 2019, 6:38 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71391/
> ---
> 
> (Updated Aug. 28, 2019, 6:38 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-9955
> https://issues.apache.org/jira/browse/MESOS-9955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed sed arg to work on Linux and OSX.
> 
> 
> Diffs
> -
> 
>   support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3 
> 
> 
> Diff: https://reviews.apache.org/r/71391/diff/1/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>



Re: Review Request 71390: Fixed the snapshot script to be non-interactive.

2019-09-02 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71390/#review217528
---


Ship it!




Ship It!

- Benjamin Bannier


On Aug. 28, 2019, 6:38 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71390/
> ---
> 
> (Updated Aug. 28, 2019, 6:38 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-9955
> https://issues.apache.org/jira/browse/MESOS-9955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the snapshot script to be non-interactive.
> 
> 
> Diffs
> -
> 
>   support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3 
> 
> 
> Diff: https://reviews.apache.org/r/71390/diff/1/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>



Review Request 71423: Removed legacy docker-build script.

2019-09-02 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71423/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

All existing use cases are covered by `support/mesos-build.sh` now.


Diffs
-

  support/docker-build.sh 0c6988d246dee711bb78580efd7b690940c9bb63 


Diff: https://reviews.apache.org/r/71423/diff/1/


Testing
---

Before we can commit this patch all previous patches should have landed and we 
need to have updated the Jenkins Coverity configuration to use `mesos-build`.


Thanks,

Benjamin Bannier



Review Request 71422: Added Coverity support to mesos-build.

2019-09-02 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71422/
---

Review request for mesos, Benjamin Bannier and Vinod Kone.


Repository: mesos


Description
---

Added Coverity support to mesos-build.


Diffs
-

  support/mesos-build/entrypoint.sh 865c44aef02d5a8b23a8397e8d3cc5eda331a017 


Diff: https://reviews.apache.org/r/71422/diff/1/


Testing
---


Thanks,

Benjamin Bannier



Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.

2019-09-02 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71421/
---

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
---

Switched verify-reviews from docker-build to prepared Docker image.


Diffs
-

  support/verify-reviews.py 045a9ef12eef1cefa5e61938366d814de04835cc 


Diff: https://reviews.apache.org/r/71421/diff/1/


Testing
---


Thanks,

Benjamin Bannier



Review Request 71419: Fixed anchor name in upgrades guide.

2019-09-02 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71419/
---

Review request for mesos, Benjamin Mahler, Meng Zhu, and Jan Schlicht.


Repository: mesos


Description
---

Fixed anchor name in upgrades guide.


Testing
---

* link from the table works
* also confirmed with htmlproofer


Thanks,

Benjamin Bannier



Review Request 71420: Fixed typo in reservation documentation.

2019-09-02 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71420/
---

Review request for mesos and Jan Schlicht.


Repository: mesos


Description
---

Fixed typo in reservation documentation.


Testing
---

N/A


Thanks,

Benjamin Bannier



Review Request 71388: Introduced automatic lifecycle management in `DynamicLibrary`.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71388/
---

Review request for mesos, Benjamin Mahler and Jan Schlicht.


Repository: mesos


Description
---

This not only simplifies our implementation of `DynamicLibrary`, but
also removes the potential for accidental file descriptor leaks.


Diffs
-

  3rdparty/stout/include/stout/posix/dynamiclibrary.hpp 
6a50592632246b06152bee177e933f65438c07ca 


Diff: https://reviews.apache.org/r/71388/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71384: Passed down failures into resource provider fatal handler.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71384/
---

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-8400
https://issues.apache.org/jira/browse/MESOS-8400


Repository: mesos


Description
---

In a follow-up patch we will surface failures up the stack.


Diffs
-

  src/resource_provider/storage/provider.cpp 
f180af8c17f735acb18029b6e4cf2942b5536bf4 


Diff: https://reviews.apache.org/r/71384/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71383: Added stringification for resource provider calls.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71383/
---

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-8400
https://issues.apache.org/jira/browse/MESOS-8400


Repository: mesos


Description
---

Added stringification for resource provider calls.


Diffs
-

  include/mesos/resource_provider/resource_provider.hpp 
36d3e6dc631d1c15582a4a3d66bf98e05a579d3a 
  include/mesos/v1/resource_provider/resource_provider.hpp 
70d81767e762dd8c44084afe05b70356c36397c8 


Diff: https://reviews.apache.org/r/71383/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71382: Removed unused and unimplemented method declaration.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71382/
---

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-8400
https://issues.apache.org/jira/browse/MESOS-8400


Repository: mesos


Description
---

Removed unused and unimplemented method declaration.


Diffs
-

  src/resource_provider/storage/provider.hpp 
ccd09dfe826d89c2775939bf132697956429c289 


Diff: https://reviews.apache.org/r/71382/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71385: Added restart logic for failing resource providers.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71385/
---

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-8400
https://issues.apache.org/jira/browse/MESOS-8400


Repository: mesos


Description
---

This patch adds restart logic to the resource provider daemon. We now
watch launched providers and restart them should they become terminal.


Diffs
-

  src/resource_provider/daemon.cpp 2fd82ad5749e3948c590ce5e9816566a3627b885 
  src/resource_provider/local.hpp 75ce0f2e4a744685f2b701ecce269995f5ddaafb 
  src/resource_provider/storage/provider.hpp 
ccd09dfe826d89c2775939bf132697956429c289 
  src/resource_provider/storage/provider.cpp 
f180af8c17f735acb18029b6e4cf2942b5536bf4 
  src/tests/storage_local_resource_provider_tests.cpp 
05daf2a19145d0da2672bbaa5ae061369b2504f5 


Diff: https://reviews.apache.org/r/71385/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Re: Review Request 71204: Added gitlint config.

2019-08-28 Thread Benjamin Bannier


> On Aug. 27, 2019, 8:02 p.m., Joseph Wu wrote:
> > support/gitlint
> > Lines 18-22 (patched)
> > <https://reviews.apache.org/r/71204/diff/7/?file=2161262#file2161262line18>
> >
> > Is there any reason to keep these commented out chunks?

I believe it is valuable documentation, and does not distract that much.

Dropping this issue; please reopen if you feel strongly about this.


> On Aug. 27, 2019, 8:02 p.m., Joseph Wu wrote:
> > support/gitlint
> > Lines 25-30 (patched)
> > <https://reviews.apache.org/r/71204/diff/7/?file=2161262#file2161262line25>
> >
> > Consider replacing the comment with a mention of the capital letter 
> > rule.
> > 
> > i.e. 
> > ```
> > # A commit title must start with a capital letter
> > # and end with a punctuation mark.
> > ```
> > 
> > Also, what do you think about allowing exclamation marks at the end? :)

Added a comment
```
# Mesos requires commit messages to start with a capital letter and end in a 
period.
```

> Also, what do you think about allowing exclamation marks at the end? :)

Let's discuss this separately.


> On Aug. 27, 2019, 8:02 p.m., Joseph Wu wrote:
> > support/gitlint
> > Lines 35-48 (patched)
> > <https://reviews.apache.org/r/71204/diff/7/?file=2161262#file2161262line35>
> >
> > Do we need these chunks?

It serves as documentation, so not strictly _needed_ but useful nevertheless. 
Note that this file was bootrapped with `gitlint generate-config`.

Dropping; please reopen if you feel strongly about this.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71204/#review217459
---


On Aug. 28, 2019, 11:04 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71204/
> ---
> 
> (Updated Aug. 28, 2019, 11:04 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a config for the gitlint tool which is slated to replace
> a custom commit-msg hook once we switch our hook infrastructure to the
> pre-commit tool.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/gitlint PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71204/diff/8/
> 
> 
> Testing
> ---
> 
> n/a
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/
---

(Updated Aug. 28, 2019, 11:04 a.m.)


Review request for mesos and Till Toenshoff.


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch switches commit hooks to be orchestrated by the pre-commit
tool mirroring the previous linters invoked through git commit
hooks (orchestrated by `support/mesos-style.py` or standalone hooks).

Using pre-commit removes the burden of maintaining
`support/mesos-style.py`, making sure that hooks have the expected
environment (e.g., Python version, Node installed). Additionally,
upstream provides a number of additional linters which are not hard to
add to Mesos' hooks.


Diffs (updated)
-

  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/pre-commit-config.yaml PRE-CREATION 
  support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71205/diff/10/

Changes: https://reviews.apache.org/r/71205/diff/9-10/


Testing
---

* used successfully for a couple of months


Thanks,

Benjamin Bannier



Re: Review Request 71204: Added gitlint config.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71204/
---

(Updated Aug. 28, 2019, 11:04 a.m.)


Review request for mesos and Till Toenshoff.


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch adds a config for the gitlint tool which is slated to replace
a custom commit-msg hook once we switch our hook infrastructure to the
pre-commit tool.


Diffs (updated)
-

  bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
  bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/gitlint PRE-CREATION 


Diff: https://reviews.apache.org/r/71204/diff/8/

Changes: https://reviews.apache.org/r/71204/diff/7-8/


Testing
---

n/a


Thanks,

Benjamin Bannier



Re: Review Request 70096: Moved cpplint configuration into dedicated file.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/
---

(Updated Aug. 28, 2019, 11:04 a.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

With this change we not only reduce the amount of code in
`support/mesos-style.py` in favor of a configuration supported by
upstream, but we also make it easier to interoperate with editor
integrations for cpplint.


Diffs (updated)
-

  bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
  bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/CPPLINT.cfg PRE-CREATION 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 


Diff: https://reviews.apache.org/r/70096/diff/8/

Changes: https://reviews.apache.org/r/70096/diff/7-8/


Testing
---

* confirmed that `./support/mesos-style.py src/executor/executor.cpp` still 
does what is expected
* no new warnings when running over the whole codebase


Thanks,

Benjamin Bannier



Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-08-27 Thread Benjamin Bannier


> On Aug. 26, 2019, 8:51 p.m., Till Toenshoff wrote:
> > When running the script, I noticed this
> > ```
> > [INFO] Installing environment for local.
> > [INFO] Once installed this environment will be reused.
> > [INFO] This may take a few minutes...
> > [INFO] Installing environment for local.
> > [INFO] Once installed this environment will be reused.
> > [INFO] This may take a few minutes...
> > ```
> > Why do we seemingly repeat that step? After this all further steps were non 
> > duplicated.

This is triggered by `pre-commit install-hooks` and seems to be a quirk of how 
`local` environments are set up. I am not sure there is anything we could or 
even should do about it.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/#review217439
-------


On Aug. 27, 2019, 10:08 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71205/
> ---
> 
> (Updated Aug. 27, 2019, 10:08 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch switches commit hooks to be orchestrated by the pre-commit
> tool mirroring the previous linters invoked through git commit
> hooks (orchestrated by `support/mesos-style.py` or standalone hooks).
> 
> Using pre-commit removes the burden of maintaining
> `support/mesos-style.py`, making sure that hooks have the expected
> environment (e.g., Python version, Node installed). Additionally,
> upstream provides a number of additional linters which are not hard to
> add to Mesos' hooks.
> 
> 
> Diffs
> -
> 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/pre-commit-config.yaml PRE-CREATION 
>   support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/setup-dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71205/diff/9/
> 
> 
> Testing
> ---
> 
> * used successfully for a couple of months
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-08-27 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/
---

(Updated Aug. 27, 2019, 10:08 a.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Address comments from Till


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch switches commit hooks to be orchestrated by the pre-commit
tool mirroring the previous linters invoked through git commit
hooks (orchestrated by `support/mesos-style.py` or standalone hooks).

Using pre-commit removes the burden of maintaining
`support/mesos-style.py`, making sure that hooks have the expected
environment (e.g., Python version, Node installed). Additionally,
upstream provides a number of additional linters which are not hard to
add to Mesos' hooks.


Diffs (updated)
-

  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/pre-commit-config.yaml PRE-CREATION 
  support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71205/diff/9/

Changes: https://reviews.apache.org/r/71205/diff/8-9/


Testing
---

* used successfully for a couple of months


Thanks,

Benjamin Bannier



Re: Review Request 71299: Added separate script to install developer setup.

2019-08-27 Thread Benjamin Bannier


> On Aug. 26, 2019, 8:50 p.m., Till Toenshoff wrote:
> > support/setup-dev.sh
> > Lines 29-48 (patched)
> > <https://reviews.apache.org/r/71299/diff/5/?file=2161911#file2161911line29>
> >
> > These still are rather unfortunate, I feel.

This will go away with r/71205.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/#review217434
---


On Aug. 20, 2019, 1:48 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71299/
> ---
> 
> (Updated Aug. 20, 2019, 1:48 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch breaks the installation of developer tools (i.e., linter
> configuration files and git hooks) out of `./bootstrap`. This not only
> simplifies and streamlines the setup, but will allow us to add
> developer-only features without breaking users who are just interested
> in building a distribution tarball.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75 
>   docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76 
>   support/setup-dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71299/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71209: Enabled a number of additional pre-commit checks.

2019-08-27 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71209/
---

(Updated Aug. 27, 2019, 9:57 a.m.)


Review request for mesos and Till Toenshoff.


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description (updated)
---

This patch enables checkers for well-formed YAML and JSON, and a linter
which checks that all executable scripts have a valid shebang line.


Diffs (updated)
-

  support/pre-commit-config.yaml PRE-CREATION 


Diff: https://reviews.apache.org/r/71209/diff/6/

Changes: https://reviews.apache.org/r/71209/diff/5-6/


Testing
---

* used for development for a couple of months
* reports no issues in the current source tree as indentified issues were fixed


Thanks,

Benjamin Bannier



Re: Review Request 71300: Removed mesos-style transition script.

2019-08-26 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71300/
---

(Updated Aug. 26, 2019, 6:40 p.m.)


Review request for mesos, Benno Evers and Till Toenshoff.


Changes
---

Rebase


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

Removed mesos-style transition script.


Diffs (updated)
-

  support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 


Diff: https://reviews.apache.org/r/71300/diff/3/

Changes: https://reviews.apache.org/r/71300/diff/2-3/


Testing
---

n/a

THIS PATCH SHOULD ONLY BE COMMITTED AFTER THE PRECEEDING CHAIN HAS BEEN LANDED 
FOR SOME TIME TO GIVE CONTRIBUTORS A CHANCE TO ADJUST THEIR WORKFLOW.


Thanks,

Benjamin Bannier



Re: Review Request 71368: Updated site's middleman versions.

2019-08-25 Thread Benjamin Bannier


> On Aug. 25, 2019, 11:09 p.m., Benjamin Mahler wrote:
> > site/Gemfile
> > Lines 3-6 (original), 3-6 (patched)
> > <https://reviews.apache.org/r/71368/diff/1/?file=2162893#file2162893line3>
> >
> > Hm.. what's this syntax expressing? Ditto above.

This means "any package version with version 3.x.x", see 
https://bundler.io/v1.5/gemfile.html#gemfiles.

We additionally version-control `Gemfile.lock`, so there is no strong need to 
bind specific versions in this case here. We want to exclude middleman from 
4.x.x upwards though as it is incompatible.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71368/#review217429
-------


On Aug. 25, 2019, 11:20 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71368/
> ---
> 
> (Updated Aug. 25, 2019, 11:20 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated site's middleman versions.
> 
> 
> Diffs
> -
> 
>   site/Gemfile c4920309ce38d4601433674a1c13b3d220b865d5 
>   site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 
> 
> 
> Diff: https://reviews.apache.org/r/71368/diff/1/
> 
> 
> Testing
> ---
> 
> Site still generates.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Review Request 71368: Updated site's middleman versions.

2019-08-25 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71368/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Updated site's middleman versions.


Diffs
-

  site/Gemfile c4920309ce38d4601433674a1c13b3d220b865d5 
  site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 


Diff: https://reviews.apache.org/r/71368/diff/1/


Testing
---

Site still generates.


Thanks,

Benjamin Bannier



Review Request 71367: Updated site's dependencies.

2019-08-25 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71367/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

This bumps e.g., `nokogiri` to a version not affected by CVE-2019-5477
anymore (not that it would have any impact on our use of it).


Diffs
-

  site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 


Diff: https://reviews.apache.org/r/71367/diff/1/


Testing
---

Site still generates.


Thanks,

Benjamin Bannier



Re: Review Request 71351: Sped up `ExampleTest.DiskFullFramework` test.

2019-08-23 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71351/
---

(Updated Aug. 23, 2019, 1:08 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rebase


Bugs: MESOS-9952
https://issues.apache.org/jira/browse/MESOS-9952


Repository: mesos


Description
---

This patch lowers the authentication timeout and increases the disk
watch interval which can speed up the test by about 10s.


Diffs (updated)
-

  src/tests/disk_full_framework_test.sh 
83ae0947d4f5ec0a960e8cefa925cacbe6c6808e 


Diff: https://reviews.apache.org/r/71351/diff/2/

Changes: https://reviews.apache.org/r/71351/diff/1-2/


Testing
---

`make check`

With this and the preceeding patch the test takes <3s on my setup from >17s 
before.


Thanks,

Benjamin Bannier



Re: Review Request 71350: Used `local` master in `ExampleTest.DiskFullFramework`.

2019-08-23 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71350/
---

(Updated Aug. 23, 2019, 1:08 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Address issue raised by Jan


Bugs: MESOS-9952
https://issues.apache.org/jira/browse/MESOS-9952


Repository: mesos


Description
---

This removes up to 4s runtime from the test as we do not have to wait
for the master or agent to be up and running in the script.


Diffs (updated)
-

  cmake/MesosConfigure.cmake 83d41addcd2c14358fba8bab2ac654475626a3e8 
  src/tests/disk_full_framework_test.sh 
83ae0947d4f5ec0a960e8cefa925cacbe6c6808e 


Diff: https://reviews.apache.org/r/71350/diff/2/

Changes: https://reviews.apache.org/r/71350/diff/1-2/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71351: Sped up `ExampleTest.DiskFullFramework` test.

2019-08-22 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71351/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-9952
https://issues.apache.org/jira/browse/MESOS-9952


Repository: mesos


Description
---

This patch lowers the authentication timeout and increases the disk
watch interval which can speed up the test by about 10s.


Diffs
-

  src/tests/disk_full_framework_test.sh 
83ae0947d4f5ec0a960e8cefa925cacbe6c6808e 


Diff: https://reviews.apache.org/r/71351/diff/1/


Testing
---

`make check`

With this and the preceeding patch the test takes <3s on my setup from >17s 
before.


Thanks,

Benjamin Bannier



Review Request 71350: Used `local` master in `ExampleTest.DiskFullFramework`.

2019-08-22 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71350/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-9952
https://issues.apache.org/jira/browse/MESOS-9952


Repository: mesos


Description
---

This removes up to 4s runtime from the test as we do not have to wait
for the master or agent to be up and running in the script.


Diffs
-

  src/tests/disk_full_framework_test.sh 
83ae0947d4f5ec0a960e8cefa925cacbe6c6808e 


Diff: https://reviews.apache.org/r/71350/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Re: Review Request 71341: Validated provider ID use in some resource provider calls.

2019-08-22 Thread Benjamin Bannier


> On Aug. 22, 2019, 2:38 p.m., Jan Schlicht wrote:
> > src/resource_provider/validation.cpp
> > Lines 17 (patched)
> > <https://reviews.apache.org/r/71341/diff/1/?file=2162387#file2162387line17>
> >
> > Include this after `resource_provider/validation.hpp`.

Ups, parsed this as another not public include :D


> On Aug. 22, 2019, 2:38 p.m., Jan Schlicht wrote:
> > src/resource_provider/validation.cpp
> > Lines 98 (patched)
> > <https://reviews.apache.org/r/71341/diff/1/?file=2162387#file2162387line98>
> >
> > s/provider/resource provider/

Note that the field is called `provider_id`, but I guess using _resource_ 
provider here is just more consistent.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71341/#review217376
-------


On Aug. 22, 2019, 3:04 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71341/
> ---
> 
> (Updated Aug. 22, 2019, 3:04 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-9482
> https://issues.apache.org/jira/browse/MESOS-9482
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For some calls we expect resource providers to set provider IDs with the
> calls. While the resource provider manager has always asserted that the
> calls were correct we never validated this.
> 
> With this patch we perform additional validation for calls taking a
> `ResourceProviderInfo` into account. We add both unit tests for the
> validation code and an integration test confirming that the validation
> is actually triggered.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/manager.cpp ceed1225b37d23998f523afcc2184dfaaad60636 
>   src/resource_provider/validation.cpp 
> df55b5efe3543c1dfd8441997302ab76fdd4bcc1 
>   src/tests/resource_provider_manager_tests.cpp 
> bcf6a03aa5d4931feff0299c811faa216efd95b6 
>   src/tests/resource_provider_validation_tests.cpp 
> a9989412ae30bd8244be808fc88fbe70f47d6ad9 
> 
> 
> Diff: https://reviews.apache.org/r/71341/diff/2/
> 
> 
> Testing
> ---
> 
> `ninja check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71341: Validated provider ID use in some resource provider calls.

2019-08-22 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71341/
---

(Updated Aug. 22, 2019, 3:04 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-9482
https://issues.apache.org/jira/browse/MESOS-9482


Repository: mesos


Description
---

For some calls we expect resource providers to set provider IDs with the
calls. While the resource provider manager has always asserted that the
calls were correct we never validated this.

With this patch we perform additional validation for calls taking a
`ResourceProviderInfo` into account. We add both unit tests for the
validation code and an integration test confirming that the validation
is actually triggered.


Diffs (updated)
-

  src/resource_provider/manager.cpp ceed1225b37d23998f523afcc2184dfaaad60636 
  src/resource_provider/validation.cpp df55b5efe3543c1dfd8441997302ab76fdd4bcc1 
  src/tests/resource_provider_manager_tests.cpp 
bcf6a03aa5d4931feff0299c811faa216efd95b6 
  src/tests/resource_provider_validation_tests.cpp 
a9989412ae30bd8244be808fc88fbe70f47d6ad9 


Diff: https://reviews.apache.org/r/71341/diff/2/

Changes: https://reviews.apache.org/r/71341/diff/1-2/


Testing
---

`ninja check`


Thanks,

Benjamin Bannier



Review Request 71340: Allowed passing resource provider infos into call validation.

2019-08-21 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71340/
---

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-9482
https://issues.apache.org/jira/browse/MESOS-9482


Repository: mesos


Description
---

With this patch it becomes possible to take a `ResourceProviderInfo`
into account when validating calls. While this feature is currently
unused, we will add additional validations in a follow-up patch.


Diffs
-

  src/resource_provider/driver.cpp eda019c1ad8893e14acc5979b350af4a099138be 
  src/resource_provider/manager.cpp ceed1225b37d23998f523afcc2184dfaaad60636 
  src/resource_provider/validation.hpp 0068f565b945fae7caf45955caf1067e0a7b7f26 
  src/resource_provider/validation.cpp df55b5efe3543c1dfd8441997302ab76fdd4bcc1 
  src/tests/resource_provider_validation_tests.cpp 
a9989412ae30bd8244be808fc88fbe70f47d6ad9 


Diff: https://reviews.apache.org/r/71340/diff/1/


Testing
---

`ninja check`


Thanks,

Benjamin Bannier



Review Request 71341: Validated provider ID use in some resource provider calls.

2019-08-21 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71341/
---

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-9482
https://issues.apache.org/jira/browse/MESOS-9482


Repository: mesos


Description
---

For some calls we expect resource providers to set provider IDs with the
calls. While the resource provider manager has always asserted that the
calls were correct we never validated this.

With this patch we perform additional validation for calls taking a
`ResourceProviderInfo` into account. We add both unit tests for the
validation code and an integration test confirming that the validation
is actually triggered.


Diffs
-

  src/resource_provider/manager.cpp ceed1225b37d23998f523afcc2184dfaaad60636 
  src/resource_provider/validation.cpp df55b5efe3543c1dfd8441997302ab76fdd4bcc1 
  src/tests/resource_provider_manager_tests.cpp 
bcf6a03aa5d4931feff0299c811faa216efd95b6 
  src/tests/resource_provider_validation_tests.cpp 
a9989412ae30bd8244be808fc88fbe70f47d6ad9 


Diff: https://reviews.apache.org/r/71341/diff/1/


Testing
---

`ninja check`


Thanks,

Benjamin Bannier



Review Request 71339: Refactored resource provider call validation.

2019-08-21 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71339/
---

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-9482
https://issues.apache.org/jira/browse/MESOS-9482


Repository: mesos


Description
---

This patch collects validation of the presence of a resource provider ID
in a resource provider call into a single place.


Diffs
-

  src/resource_provider/validation.cpp df55b5efe3543c1dfd8441997302ab76fdd4bcc1 


Diff: https://reviews.apache.org/r/71339/diff/1/


Testing
---

`ninja check`


Thanks,

Benjamin Bannier



Re: Review Request 71336: Fixed deprecation warning when building against OpenSSL 1.1.x.

2019-08-21 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71336/#review217350
---


Fix it, then Ship it!





3rdparty/libprocess/src/openssl.cpp
Line 889 (original), 889 (patched)
<https://reviews.apache.org/r/71336/#comment304640>

Let's add a comment here correlating this with an "normal" version number. 
Is this 1.0.1 (what patch level)?


- Benjamin Bannier


On Aug. 21, 2019, 1:16 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71336/
> ---
> 
> (Updated Aug. 21, 2019, 1:16 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> OpenSSL 1.1.x deprecates 'ASN1_STRING_get_data' and replaces it
> by 'ASN1_STRING_get0_data'.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.cpp 
> ee9a049d06bdf6365930aa92873dd97af197eba0 
> 
> 
> Diff: https://reviews.apache.org/r/71336/diff/1/
> 
> 
> Testing
> ---
> 
> ```
> cmake .. -DUNBUNDLED_ZOOKEEPER=ON -DUNBUNDLED_LIBEVENT=ON 
> -DUNBUNDLED_LEVELDB=ON -DUNBUNDLED_LIBARCHIVE=ON -DENABLE_SSL=ON 
> -DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl@1.1 
> -DLIBEVENT_ROOT_DIR=/Users/till/usr -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja
> ninja tests -j12
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>



Re: Review Request 71329: Updated CentOS 6 dockerfile to properly install devtoolset-7.

2019-08-20 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71329/#review217333
---


Ship it!




Ship It!

- Benjamin Bannier


On Aug. 20, 2019, 2:52 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71329/
> ---
> 
> (Updated Aug. 20, 2019, 2:52 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previously used yum command was not able to properly install
> the required `devtoolset-7` package since the containing repository
> was only visible after the first `yum` invocation finished.
> 
> This would result in `yum` silently ignoring the package, producing
> a broken CentOS 6 docker image.
> 
> 
> Diffs
> -
> 
>   support/packaging/centos/centos6.dockerfile 
> bb8d591ce6d41a70bde64020d18aac739021e88e 
> 
> 
> Diff: https://reviews.apache.org/r/71329/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 71207: Revert "Updated cpplint.py to be less verbose when there is no linting issue."

2019-08-20 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71207/
---

(Updated Aug. 20, 2019, 1:49 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rebase


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This reverts commit c0f8f56d5a93f3fb870e448fedfd22f1491356ca.

This patch was necessary when we were running cpplint via
`support/mesos-style.py` to prevent it from cluttering up the hook
output. When running under pre-commit linter output is not shown if no
errors occur so we can undo our change to stay closer to upstream.


Diffs (updated)
-

  support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8 


Diff: https://reviews.apache.org/r/71207/diff/3/

Changes: https://reviews.apache.org/r/71207/diff/2-3/


Testing
---

* used for development for a couple of months
* reports no issues in the current source tree


Thanks,

Benjamin Bannier



Re: Review Request 71206: Removed old mesos-style and references.

2019-08-20 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71206/
---

(Updated Aug. 20, 2019, 1:49 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Address comments from bennoe & jpeach offline


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch removes references to `support/mesos-style.py` which was
replaced with a pre-commit setup in a previous commit. We also remove
the tool itself.


Diffs (updated)
-

  docs/c++-style-guide.md 8a48afe780f23736c9b7abeb7337977521cecfa5 
  support/build-virtualenv 7dc03b054f7663979e4eb4b11ad51d759b7f1ad3 
  support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725 
  support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
  support/hooks/pre-commit 519567bf5f20a74b273c8d8514577fe4342dc45d 
  support/mesos-split.py 0a77c257386ffe576abd12f59f926640836ad900 
  support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 


Diff: https://reviews.apache.org/r/71206/diff/5/

Changes: https://reviews.apache.org/r/71206/diff/4-5/


Testing
---

n/a


Thanks,

Benjamin Bannier



Re: Review Request 71299: Added separate script to install developer setup.

2019-08-20 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/
---

(Updated Aug. 20, 2019, 1:48 p.m.)


Review request for mesos, Benno Evers and Till Toenshoff.


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch breaks the installation of developer tools (i.e., linter
configuration files and git hooks) out of `./bootstrap`. This not only
simplifies and streamlines the setup, but will allow us to add
developer-only features without breaking users who are just interested
in building a distribution tarball.


Diffs (updated)
-

  bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
  bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75 
  docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71299/diff/5/

Changes: https://reviews.apache.org/r/71299/diff/4-5/


Testing
---


Thanks,

Benjamin Bannier



Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-08-20 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/
---

(Updated Aug. 20, 2019, 1:48 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rebase


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch switches commit hooks to be orchestrated by the pre-commit
tool mirroring the previous linters invoked through git commit
hooks (orchestrated by `support/mesos-style.py` or standalone hooks).

Using pre-commit removes the burden of maintaining
`support/mesos-style.py`, making sure that hooks have the expected
environment (e.g., Python version, Node installed). Additionally,
upstream provides a number of additional linters which are not hard to
add to Mesos' hooks.


Diffs (updated)
-

  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/pre-commit-config.yaml PRE-CREATION 
  support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71205/diff/8/

Changes: https://reviews.apache.org/r/71205/diff/7-8/


Testing
---

* used successfully for a couple of months


Thanks,

Benjamin Bannier



Re: Review Request 71299: Added separate script to install developer setup.

2019-08-20 Thread Benjamin Bannier


> On Aug. 19, 2019, 12:56 p.m., Benno Evers wrote:
> > docs/advanced-contribution.md
> > Line 69 (original), 69 (patched)
> > <https://reviews.apache.org/r/71299/diff/4/?file=2161403#file2161403line69>
> >
> > This became a bit ambiguous now, i.e. is only the second step or the 
> > whole step only required if building from git?
> > 
> > (also, I'm not sure why we have this qualification at all in a 
> > contributors guide)

I agree, removed the part in parentheses (this seems to have appeared with 
https://reviews.apache.org/r/36472/ w/o much discussion).


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/#review217278
-------


On Aug. 20, 2019, 1:48 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71299/
> ---
> 
> (Updated Aug. 20, 2019, 1:48 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch breaks the installation of developer tools (i.e., linter
> configuration files and git hooks) out of `./bootstrap`. This not only
> simplifies and streamlines the setup, but will allow us to add
> developer-only features without breaking users who are just interested
> in building a distribution tarball.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75 
>   docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76 
>   support/setup-dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71299/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-20 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71151/
---

(Updated Aug. 20, 2019, 11:26 a.m.)


Review request for mesos and Chun-Hung Hsiao.


Changes
---

Address comments from Chun


Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254


Repository: mesos


Description
---

Performed periodic storage local provider reconciliations.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
6d632606f411d3ca99d3573a57c9f68b02ba8072 
  src/tests/storage_local_resource_provider_tests.cpp 
69b59d48ceefebbb7accefe411c54ac5cecff1c3 


Diff: https://reviews.apache.org/r/71151/diff/7/

Changes: https://reviews.apache.org/r/71151/diff/6-7/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Re: Review Request 71150: Factored out storage provider method to update resources.

2019-08-20 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71150/
---

(Updated Aug. 20, 2019, 11:25 a.m.)


Review request for mesos and Chun-Hung Hsiao.


Changes
---

Address comments from Chun


Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254


Repository: mesos


Description
---

Factored out storage provider method to update resources.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
6d632606f411d3ca99d3573a57c9f68b02ba8072 
  src/tests/storage_local_resource_provider_tests.cpp 
69b59d48ceefebbb7accefe411c54ac5cecff1c3 


Diff: https://reviews.apache.org/r/71150/diff/6/

Changes: https://reviews.apache.org/r/71150/diff/5-6/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-19 Thread Benjamin Bannier


> On Aug. 9, 2019, 9:41 a.m., Chun-Hung Hsiao wrote:
> > src/resource_provider/storage/provider.cpp
> > Line 752 (original), 811 (patched)
> > <https://reviews.apache.org/r/71151/diff/4/?file=2159963#file2159963line813>
> >
> > As commented in the previous patch, since we're having two functions, 
> > `reconcileStoragePools` and `reconcileResources`, it's alright to have a 
> > little bit of repeated code and don't introduce an extra function without a 
> > very focused purpose.
> > 
> > In `reconcileResources`, we could have the logic that checks for 
> > `alwaysUpdate`. In `reconcileStoragePools`, since it's only called when 
> > profiles are updated or volumes of a stale profile are deleted, there's no 
> > need for the extra `alwaysUpdate` logic there.

I updated the code in question. I am still not sure I understood what exactly 
you were after, could you have a look?


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71151/#review217143
-------


On Aug. 19, 2019, 1:58 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71151/
> ---
> 
> (Updated Aug. 19, 2019, 1:58 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Performed periodic storage local provider reconciliations.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> 6d632606f411d3ca99d3573a57c9f68b02ba8072 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 69b59d48ceefebbb7accefe411c54ac5cecff1c3 
> 
> 
> Diff: https://reviews.apache.org/r/71151/diff/6/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71150: Factored out storage provider method to update resources.

2019-08-19 Thread Benjamin Bannier


> On Aug. 9, 2019, 9:22 a.m., Chun-Hung Hsiao wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 979-995 (patched)
> > <https://reviews.apache.org/r/71150/diff/3/?file=2159962#file2159962line1016>
> >
> > Sorry for not making my suggestion clear enough. I was actually 
> > thinking about removing `reconcileStoragePools()` and always calling 
> > `reconcileResources()` even when we only want to reconcile storage pools.
> > 
> > This suggestion makes more sense if we don't reconcile storage pools 
> > after destroying a MOUNT disk with a stale profile, as I suggested in the 
> > next patch. But if we want to keep this behavior, then this approach would 
> > introduce an extra `ListVolumes` call.
> > 
> > If you prefer to avoid having this extra grpc call, then adding this 
> > extra function seems only give us a little bit of code reuse, and I'm not 
> > sure if it worths adding an extra function name to the already-long list of 
> > functions in this class. I'd vote for keeping the code in its original 
> > place and avoid introducing a function name that doesn't convey its purpose 
> > clearly.

Updated the code, PTAL.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71150/#review217142
---


On Aug. 19, 2019, 1:58 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71150/
> ---
> 
> (Updated Aug. 19, 2019, 1:58 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Factored out storage provider method to update resources.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> 6d632606f411d3ca99d3573a57c9f68b02ba8072 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 69b59d48ceefebbb7accefe411c54ac5cecff1c3 
> 
> 
> Diff: https://reviews.apache.org/r/71150/diff/5/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-19 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71151/
---

(Updated Aug. 19, 2019, 1:58 p.m.)


Review request for mesos and Chun-Hung Hsiao.


Changes
---

Address issue raised by Chun


Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254


Repository: mesos


Description
---

Performed periodic storage local provider reconciliations.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
6d632606f411d3ca99d3573a57c9f68b02ba8072 
  src/tests/storage_local_resource_provider_tests.cpp 
69b59d48ceefebbb7accefe411c54ac5cecff1c3 


Diff: https://reviews.apache.org/r/71151/diff/6/

Changes: https://reviews.apache.org/r/71151/diff/5-6/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Re: Review Request 71150: Factored out storage provider method to update resources.

2019-08-19 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71150/
---

(Updated Aug. 19, 2019, 1:58 p.m.)


Review request for mesos and Chun-Hung Hsiao.


Changes
---

Address issue raised by Chun


Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254


Repository: mesos


Description
---

Factored out storage provider method to update resources.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
6d632606f411d3ca99d3573a57c9f68b02ba8072 
  src/tests/storage_local_resource_provider_tests.cpp 
69b59d48ceefebbb7accefe411c54ac5cecff1c3 


Diff: https://reviews.apache.org/r/71150/diff/5/

Changes: https://reviews.apache.org/r/71150/diff/4-5/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-08-19 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/
---

(Updated Aug. 19, 2019, 9:20 a.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rebase; install config via link to allow for untracked modifications


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch switches commit hooks to be orchestrated by the pre-commit
tool mirroring the previous linters invoked through git commit
hooks (orchestrated by `support/mesos-style.py` or standalone hooks).

Using pre-commit removes the burden of maintaining
`support/mesos-style.py`, making sure that hooks have the expected
environment (e.g., Python version, Node installed). Additionally,
upstream provides a number of additional linters which are not hard to
add to Mesos' hooks.


Diffs (updated)
-

  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/pre-commit-config.yaml PRE-CREATION 
  support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71205/diff/7/

Changes: https://reviews.apache.org/r/71205/diff/6-7/


Testing
---

* used successfully for a couple of months


Thanks,

Benjamin Bannier



Re: Review Request 71209: Enabled a number of additional pre-commit checks.

2019-08-19 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71209/
---

(Updated Aug. 19, 2019, 9:20 a.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rebase


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

Enabled a number of additional pre-commit checks.


Diffs (updated)
-

  support/pre-commit-config.yaml PRE-CREATION 


Diff: https://reviews.apache.org/r/71209/diff/4/

Changes: https://reviews.apache.org/r/71209/diff/3-4/


Testing
---

* used for development for a couple of months
* reports no issues in the current source tree as indentified issues were fixed


Thanks,

Benjamin Bannier



Re: Review Request 71203: Added check script to check for license headers.

2019-08-19 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71203/
---

(Updated Aug. 19, 2019, 9:20 a.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rename script


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This check adds a script which validates that source files have valid
license headers. This will allow us to reuse this functionality with
e.g., the pre-commit tool.

At the moment the code added here is not invoked from
`support/mesos-style.py` since it will be removed in a follow-up commit.


Diffs (updated)
-

  support/check-license.py PRE-CREATION 


Diff: https://reviews.apache.org/r/71203/diff/5/

Changes: https://reviews.apache.org/r/71203/diff/4-5/


Testing
---

* tested against files with license headers present or absent
* tested against all Python and C++ source files in the repo


Thanks,

Benjamin Bannier



Re: Review Request 71299: Added separate script to install developer setup.

2019-08-19 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/
---

(Updated Aug. 19, 2019, 9:19 a.m.)


Review request for mesos, Benno Evers and Till Toenshoff.


Changes
---

Rename setup script


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch breaks the installation of developer tools (i.e., linter
configuration files and git hooks) out of `./bootstrap`. This not only
simplifies and streamlines the setup, but will allow us to add
developer-only features without breaking users who are just interested
in building a distribution tarball.


Diffs (updated)
-

  bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
  bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75 
  docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71299/diff/4/

Changes: https://reviews.apache.org/r/71299/diff/3-4/


Testing
---


Thanks,

Benjamin Bannier



Review Request 71299: Added separate script to install developer setup.

2019-08-16 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/
---

Review request for mesos, Benno Evers and Till Toenshoff.


Bugs: MESOS-9360
https://issues.apache.org/jira/browse/MESOS-9360


Repository: mesos


Description
---

This patch breaks the installation of developer tools (i.e., linter
configuration files and git hooks) out of `./bootstrap`. This not only
simplifies and streamlines the setup, but will allow us to add
developer-only features without breaking users who are just interested
in building a distribution tarball.


Diffs
-

  bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
  bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75 
  docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76 
  support/setup_dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71299/diff/1/


Testing
---


Thanks,

Benjamin Bannier



Review Request 71300: Removed mesos-style transition script.

2019-08-16 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71300/
---

Review request for mesos, Benno Evers and Till Toenshoff.


Bugs: MESOS-9360
https://issues.apache.org/jira/browse/MESOS-9360


Repository: mesos


Description
---

Removed mesos-style transition script.


Diffs
-

  support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 


Diff: https://reviews.apache.org/r/71300/diff/1/


Testing
---

n/a

THIS PATCH SHOULD ONLY BE COMMITTED AFTER THE PRECEEDING CHAIN HAS BEEN LANDED 
FOR SOME TIME TO GIVE CONTRIBUTORS A CHANCE TO ADJUST THEIR WORKFLOW.


Thanks,

Benjamin Bannier



  1   2   3   4   5   6   7   8   9   10   >