Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109559 --- src/CMakeLists.txt (lines 223 - 226)

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109562 --- src/CMakeLists.txt (lines 267 - 286)

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-09 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 9, 2015, 9:15 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-09 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 9, 2015, 10:48 p.m.) Review request for mesos, Artem

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109620 --- Ship it! Ship It! - Alex Clemmer On Dec. 9, 2015, 10:48 p.m.,

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-08 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 8, 2015, 3:59 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109446 --- Ship it! Ship It! - Joseph Wu On Dec. 8, 2015, 7:59 a.m.,

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-08 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 9, 2015, 3:45 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-07 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109206 --- Ship it! src/CMakeLists.txt (line 222)

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-04 Thread Diana Arroyo
> On Dec. 4, 2015, 9:48 p.m., Joseph Wu wrote: > > Diana, can you add `hausdorff`, `kaysoky`, `hartem`, and `jvanremoortere` > > to this review (and future CMake reviews)? > > > > --- > > > > Ran `cmake .. && make` on OSX. Hit this error: > > ``` > >

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109032 --- Diana, can you add `hausdorff`, `kaysoky`, `hartem`, and

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-04 Thread Diana Arroyo
> On Dec. 4, 2015, 9:48 p.m., Joseph Wu wrote: > > Diana, can you add `hausdorff`, `kaysoky`, `hartem`, and `jvanremoortere` > > to this review (and future CMake reviews)? > > > > --- > > > > Ran `cmake .. && make` on OSX. Hit this error: > > ``` > >

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-04 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 5, 2015, 3:35 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109082 --- Patch looks great! Reviews applied: [40951] Passed command:

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-04 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 4, 2015, 6:30 p.m.) Review request for mesos. Bugs: MESOS-3843