Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review197383 --- Ship it! Would be great to see some TODOs or a ticket to clean

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

> On Feb. 10, 2018, 1:17 a.m., Benjamin Mahler wrote: > > src/tests/mesos.cpp > > Line 391 (original), 400 (patched) > > > > > > I realize this is a copy/paste, but do you know why we don't start() > > when mock is

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

> On Feb. 10, 2018, 1:17 a.m., Benjamin Mahler wrote: > > src/tests/mesos.cpp > > Line 391 (original), 400 (patched) > > > > > > I realize this is a copy/paste, but do you know why we don't start() > > when mock is

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review197315 --- PASS: Mesos patch 65497 was successfully built and tested.

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

> On Feb. 7, 2018, 6:19 p.m., Benjamin Mahler wrote: > > src/tests/mock_slave.cpp > > Lines 107-108 (original), 107-109 (patched) > > > > > > What's going on here? > > Meng Zhu wrote: > For the agent failover

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

> On Feb. 9, 2018, 5:17 p.m., Benjamin Mahler wrote: > > src/tests/mesos.cpp > > Line 391 (original), 400 (patched) > > > > > > I realize this is a copy/paste, but do you know why we don't start() > > when mock is

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/ --- (Updated Feb. 12, 2018, 11:48 a.m.) Review request for mesos and Benjamin

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review197211 --- src/tests/mesos.cpp Line 391 (original), 400 (patched)

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

> On Feb. 8, 2018, 2:19 a.m., Benjamin Mahler wrote: > > src/tests/mock_slave.cpp > > Lines 107-108 (original), 107-109 (patched) > > > > > > What's going on here? > > Meng Zhu wrote: > For the agent failover

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review197156 --- Patch looks great! Reviews applied: [65109, 65110, 65111, 65369,

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review197126 --- PASS: Mesos patch 65497 was successfully built and tested.

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

> On Feb. 7, 2018, 6:19 p.m., Benjamin Mahler wrote: > > src/tests/mock_slave.cpp > > Lines 107-108 (original), 107-109 (patched) > > > > > > What's going on here? For the agent failover test, I need the failed

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review197070 --- Looks good, just a few minor comments. src/tests/mock_slave.cpp

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review196908 --- PASS: Mesos patch 65497 was successfully built and tested.

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review196777 --- FAIL: Failed to apply the dependent review: 65496. Failed