Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

> On Jan. 22, 2016, 5:37 a.m., Joseph Wu wrote: > > General questions: > > > > - Besides removing the possibility for overcommit, does this change give us > > anything else? > > - What happens if a master sends this modified `TaskInfo` to an agent that > > does not have this chain of patches?

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/ --- (Updated Feb. 18, 2016, 7:45 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

> On Jan. 22, 2016, 5:37 a.m., Joseph Wu wrote: > > src/master/master.cpp, lines 3770-3779 > > > > > > It should still be invalid to supply both a CommandInfo and > > ExecutorInfo in the same TaskInfo. The check

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

> On Jan. 22, 2016, 5:37 a.m., Joseph Wu wrote: > > src/master/master.cpp, line 2860 > > > > > > `launcher_dir` is an optional field. > > > > Same for the other fields you added (`sandbox_dir`,

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/#review115703 --- General questions: - Besides removing the possibility for

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/ --- (Updated Jan. 19, 2016, 10:55 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/ --- (Updated Jan. 16, 2016, 1:46 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

> On Dec. 14, 2015, 2:31 p.m., Qian Zhang wrote: > > src/slave/slave.cpp, line 1370 > > > > > > Before trying to get task's executor via `task.executor()`, suggest to > > add a CHECK to ensure the task always has

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/ --- (Updated Jan. 15, 2016, 1:17 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

> On Dec. 14, 2015, 10:47 p.m., Guangya Liu wrote: > > src/master/master.cpp, lines 2829-2845 > > > > > > How does this can resove overcommit issue? I think that the issue is > > still there? Another is that can

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

> On Dec. 14, 2015, 2:31 p.m., Qian Zhang wrote: > > src/master/master.cpp, line 3556 > > > > > > Just wondering why we want to do `task.resources() - > > executor.resources())` here? I think in

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

> On Dec. 14, 2015, 2:31 p.m., Qian Zhang wrote: > > src/master/master.cpp, line 2830 > > > > > > So if task's resources has no cpu, then we will not add cpu to > > executor's resources, right? But I think we

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

> On Dec. 14, 2015, 2:31 p.m., Qian Zhang wrote: > > src/master/master.cpp, line 2830 > > > > > > So if task's resources has no cpu, then we will not add cpu to > > executor's resources, right? But I think we

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

> On Dec. 14, 2015, 2:31 p.m., Qian Zhang wrote: > > src/master/master.cpp, line 2830 > > > > > > So if task's resources has no cpu, then we will not add cpu to > > executor's resources, right? But I think we

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/#review110233 --- src/master/master.cpp (lines 2829 - 2845)

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/#review110166 --- src/master/master.cpp (line 2830)