Re: Review Request 32998: Split committer's guide into code reviewing and committing documents.

> On April 20, 2015, 7:28 p.m., Niklas Nielsen wrote: > > docs/effective-code-reviewing.md, line 19 > > > > > > s/, this is not meant to be a sparring match!/./ Hm.. this was copy/pasted from benh's original committer'

Re: Review Request 32998: Split committer's guide into code reviewing and committing documents.

> On April 9, 2015, 12:51 a.m., Adam B wrote: > > docs/committing.md, line 18 > > > > > > Would like to formalize what kinds of changes you "don't worry about > > going through a review cycle". I'd propose that typo/co

Re: Review Request 32998: Split committer's guide into code reviewing and committing documents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32998/ --- (Updated April 23, 2015, 11:06 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 32998: Split committer's guide into code reviewing and committing documents.

> On April 13, 2015, 6:30 p.m., haosdent huang wrote: > > docs/effective-code-reviewing.md, line 14 > > > > > > Should we add a requirement that "pass unit tests before post reviews" > > here? Thanks! Haven't seen thi