Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/ --- (Updated May 13, 2015, 10:35 p.m.) Review request for mesos, Ben Mahler, Joris

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/ --- (Updated May 13, 2015, 12:23 a.m.) Review request for mesos, Ben Mahler, Joris

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/ --- (Updated May 8, 2015, 8:24 p.m.) Review request for mesos, Ben Mahler, Joris Va

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-08 Thread Jie Yu
> On May 7, 2015, 4:57 p.m., Niklas Nielsen wrote: > > src/slave/resources_estimator.cpp, lines 59-60 > > > > > > Shouldn't we be able to start the process in the constructor and > > forward initialize() to the process

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-08 Thread Jie Yu
> On May 7, 2015, 9:06 p.m., Ben Mahler wrote: > > src/slave/resources_estimator.hpp, line 34 > > > > > > Interesting, what will go in here? I have a hard time seeing a general > > "Mesos"ResourcesEstimator evolve. It

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/#review82905 --- src/slave/resources_estimator.hpp

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-07 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/#review82829 --- Ship it! Looks good! I agree with Vinod about the naming, but apart

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/#review82760 --- LGTM except for the naming. I would call it ResourceEstimator instea

Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/ --- Review request for mesos, Ben Mahler, Joris Van Remoortere, Niklas Nielsen, and