Re: Review Request 34835: Add constexpr to C++ whitelist

2015-08-05 Thread Bernd Mathiske
> On Aug. 4, 2015, 8:03 p.m., Anand Mazumdar wrote: > > docs/mesos-c++-style-guide.md, line 557 > > > > > > This line does not wrap over and muddles up the UI with a scroll bar. > > The other examples for const expres

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-08-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review94172 --- docs/mesos-c++-style-guide.md (line 557)

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review89588 --- Patch looks great! Reviews applied: [34835] All tests passed. - M

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-26 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/ --- (Updated June 26, 2015, 10:36 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-26 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review89559 --- Ship it! docs/mesos-c++-style-guide.md (line 535)

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-25 Thread Bernd Mathiske
> On June 18, 2015, 2:46 a.m., Bernd Mathiske wrote: > > docs/mesos-c++-style-guide.md, line 540 > > > > > > s/,/. Combining these two sentences deemphasizes the general demand of > > the first one. I don't see this

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-25 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review89338 --- Ship it! Ship It! - Bernd Mathiske On June 24, 2015, 2:14 p.m.,

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review89292 --- Patch looks great! Reviews applied: [34835] All tests passed. - M

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-24 Thread Paul Brett
> On June 18, 2015, 9:46 a.m., Bernd Mathiske wrote: > > docs/mesos-c++-style-guide.md, line 555 > > > > > > All "," could be "." here. > > > > "," before "or" missing. I've switched to shorter sentances, but

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-24 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/ --- (Updated June 24, 2015, 9:14 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-18 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review88352 --- docs/mesos-c++-style-guide.md (line 535)

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review87954 --- Patch looks great! Reviews applied: [34835] All tests passed. - M

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-15 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/ --- (Updated June 15, 2015, 5:59 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-01 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review86026 --- docs/mesos-c++-style-guide.md

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-05-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review85850 --- Patch looks great! Reviews applied: [34835] All tests passed. - M

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-05-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review85840 --- Ship it! Ship It! - Vinod Kone On May 29, 2015, 11:23 p.m., Paul

Review Request 34835: Add constexpr to C++ whitelist

2015-05-29 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/ --- Review request for mesos, Benjamin Hindman, Dave Lester, Ian Downes, and Vinod K