Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

> On July 23, 2015, 11:52 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp, line 32 > > > > > > Why not add these to try.hpp like we did with Option? > > Ben Mahler wrote:

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

> On July 23, 2015, 6:01 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp, line 130 > > > > > > Not needed? Yeah, I've restructured the logic to be more clear (now we always tran

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

> On July 23, 2015, 11:52 p.m., Benjamin Hindman wrote: > > The names 'encode' and 'decode' seem weird for the function parameters to > > Encoder and Decoder, since Encoder::encode and Decoder::decode (which are > > named the same thing) are really the things that are "encoding" and > > "decod

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92812 --- The names 'encode' and 'decode' seem weird for the function paramete

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92627 --- Ship it! Nice test! 3rdparty/libprocess/3rdparty/stout/include/st

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92690 --- I'll add a note about "completion" semantics (surface an error when

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/ --- (Updated July 22, 2015, 11:24 p.m.) Review request for mesos, Anand Mazumdar, B

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

> On July 22, 2015, 6:46 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp, lines 54-61 > > > > > > Add comments! Added a javadoc at the top of encoder and decoder to capture t

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92626 --- nice tests! 3rdparty/libprocess/3rdparty/stout/include/stout/recor

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/ --- (Updated July 22, 2015, 6:33 a.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92556 --- Bad patch! Reviews applied: [36677] Failed command: ./support/appl

Review Request 36677: Introduced 'recordio' encoding facilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu. Bugs: M