Re: Review Request 36816: Supported HTTP/HTTPS in health check.

> On Aug. 26, 2016, 12:33 p.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.cpp, line 378 > > > > > > "Killing the HTTP health check process " Also fits one line afterwards. - Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review146941 --- Fix it, then Ship it! src/health-check/health_checker.cpp

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 25, 2016, 1:24 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 25, 2016, 12:34 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 24, 2016, 5:23 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 24, 2016, 4:52 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 24, 2016, 4:50 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

> On Aug. 11, 2016, 3:19 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.hpp, line 330 > > > > > > Why do you need to discard original future here? > > haosdent huang wrote: > I saw we

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

> On Aug. 15, 2016, 12:43 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.cpp, lines 363-367 > > > > > > Why do you think this won't affect ibprocess communication? Actors' > > callbacks are

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

> On Aug. 11, 2016, 3:19 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.hpp, line 330 > > > > > > Why do you need to discard original future here? > > haosdent huang wrote: > I saw we

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review145934 --- src/health-check/health_checker.cpp (lines 362 - 363)

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

> On Aug. 11, 2016, 3:19 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.hpp, line 330 > > > > > > Why do you need to discard original future here? > > haosdent huang wrote: > I saw we

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 15, 2016, 3:42 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review145733 --- src/health-check/health_checker.cpp (lines 363 - 367)

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

> On Aug. 11, 2016, 3:19 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.hpp, line 330 > > > > > > Why do you need to discard original future here? > > haosdent huang wrote: > I saw we

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 14, 2016, 5:05 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 13, 2016, 8:46 a.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 13, 2016, 6:47 a.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

> On Aug. 11, 2016, 3:19 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.hpp, line 280 > > > > > > Do you think we should add "/" if the user has not specified anything? Use "" instead, thx!

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review145451 --- src/health-check/health_checker.hpp (line 275)

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 7, 2016, 6:21 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review144776 --- src/health-check/health_checker.hpp (line 283)

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review144598 --- include/mesos/v1/mesos.proto (line 339)

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review144471 --- src/health-check/health_checker.hpp (lines 283 - 284)

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review144374 --- include/mesos/mesos.proto (lines 324 - 346)

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 1, 2016, 1:15 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 1, 2016, 1:05 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review142496 --- Ship it! Ship It! - Tomasz Janiszewski On July 2, 2016,

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated July 2, 2016, 3:07 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated June 30, 2016, 11:50 a.m.) Review request for mesos, Adam B,

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated June 29, 2016, 9:04 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

> On June 29, 2016, 5:02 a.m., Timothy Chen wrote: > > Can you add a test? @tnachen We have two test cases before. But I think `health_check_tests.cpp` a bit mess up now, I am try to reorganize it to make it more clear. - haosdent ---

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review139934 --- Can you add a test? - Timothy Chen On June 29, 2016, 4:45

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated June 29, 2016, 4:45 a.m.) Review request for mesos, Adam B, Alexander