Re: Review Request 37967: Added Non-Freezeer Task Killer. 36620

2015-09-23 Thread Joerg Schad
> On Sept. 22, 2015, 10:37 p.m., Jie Yu wrote: > > Tests? Also, link the JIRA ticket in the review board. Updated Review 36620, this was only my internal stash, sorry for adding mesos as Group. - Joerg --- This is an automatically gene

Re: Review Request 37967: Added Non-Freezeer Task Killer. 36620

2015-09-23 Thread Joerg Schad
> On Sept. 22, 2015, 10:37 p.m., Jie Yu wrote: > > src/linux/cgroups.hpp, line 666 > > > > > > Any reason you want to expose these two classes in the header? If no > > one is using them right now, please move them t

Re: Review Request 37967: Added Non-Freezeer Task Killer. 36620

2015-09-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37967/#review100082 --- Tests? Also, link the JIRA ticket in the review board. src/linux/

Re: Review Request 37967: Added Non-Freezeer Task Killer. 36620

2015-09-22 Thread Jie Yu
> On Sept. 22, 2015, 10:19 p.m., Cong Wang wrote: > > High level comment: why not just use pid namespace to kill processes since > > we already have it? Because not every one wants to use pid namespace (e.g. it'll break thermos). - Jie ---

Re: Review Request 37967: Added Non-Freezeer Task Killer. 36620

2015-09-22 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37967/#review100070 --- High level comment: why not just use pid namespace to kill processe

Re: Review Request 37967: Added Non-Freezeer Task Killer. 36620

2015-09-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37967/ --- (Updated Sept. 22, 2015, 7:43 p.m.) Review request for mesos and Till Toenshoff