Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-24 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 24, 2015, 4:30 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs
-

  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-23 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review107640
---

Ship it!



src/tests/master_quota_tests.cpp (line 115)


Can we use `process::ID::generate()` here?


- Joris Van Remoortere


On Nov. 20, 2015, 8:48 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 20, 2015, 8:48 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-20 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 20, 2015, 8:48 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Corrected comments. NNTR.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-20 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 20, 2015, 8:20 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Fixed a race.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-20 Thread Alexander Rukletsov 


> On Nov. 20, 2015, 5:58 a.m., Joerg Schad wrote:
> > src/tests/master_quota_tests.cpp, line 222
> > 
> >
> > Shouldn't the expect call happen before StartSlave()? Otherwise the 
> > slave might have started before and we will never satisfy the call...

That's correct, thanks!


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review107306
---


On Nov. 20, 2015, 8:20 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 20, 2015, 8:20 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-19 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review107306
---



src/tests/master_quota_tests.cpp (line 222)


Shouldn't the expect call happen before StartSlave()? Otherwise the slave 
might have started before and we will never satisfy the call...



src/tests/master_quota_tests.cpp (line 270)


move before StartSlave()



src/tests/master_quota_tests.cpp (line 282)


Move before StartSlave()



src/tests/master_quota_tests.cpp (line 332)


Move before StartSlave()



src/tests/master_quota_tests.cpp (line 383)


Shouldn't we have the expect call before StartSlave()? Otherwise this is a 
potential race condition which might lead to the ExpectCall never fullfilled 
(as the slave already started before we started expecting it).



src/tests/master_quota_tests.cpp (line 395)


Same here.


- Joerg Schad


On Nov. 17, 2015, 8:16 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 17, 2015, 8:16 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-17 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 17, 2015, 8:16 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Rebased, added more test ideas.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-16 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 16, 2015, 4:47 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Rebased.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-16 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 16, 2015, 3:21 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Added a todo for rescind test.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-16 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 16, 2015, 12:24 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Removed duplicated code.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-16 Thread Alexander Rukletsov 


> On Nov. 6, 2015, 12:39 a.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 110-112
> > 
> >
> > The resource string you have is equivalent to the resource string from 
> > `CreateSlaveFlags`.  Is there some reason you're re-setting it?
> 
> Alexander Rukletsov wrote:
> One of the comments I got earlier from Bernd is that it is hard to track 
> what resources are available, hence I decided to re-introduce the resources 
> explicitly.
> 
> Joseph Wu wrote:
> Can you add a comment about this to the test?

I have introduced the constant in the `MesosTest` fixture and got rid of this 
fucntion here.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105339
---


On Nov. 14, 2015, 3:46 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 14, 2015, 3:46 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-16 Thread Alexander Rukletsov 


> On Oct. 19, 2015, 10:21 p.m., Joerg Schad wrote:
> > src/tests/master_quota_tests.cpp, line 139
> > 
> >
> > Is there a reason to repeat 'protected:' here
> 
> Alexander Rukletsov wrote:
> It separates methods section from fields. We are inconsitent, see for 
> example `HierarchicalAllocatorTestBase`, `PortMappingIsolatorTest`.

I will leave the extra `protected` because it doesn't hurt and it's self 
documenting code.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review103175
---


On Nov. 14, 2015, 3:46 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 14, 2015, 3:46 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-14 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 14, 2015, 3:46 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

More test ideas.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-10 Thread Alexander Rukletsov 


> On Nov. 6, 2015, 12:39 a.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 147-148
> > 
> >
> > Rather than re-defining this, can you populate it via the result of 
> > `MesosTest::CreateSlaveFlags().resources`?

Do you suggest to call `MesosTest::CreateSlaveFlags()` in the `SetUp()` in 
order to use just the `.resources` artifact? Or you think I should make 
`defaultAgentResources` local in every test?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105339
---


On Nov. 10, 2015, 1:22 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 10, 2015, 1:22 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-10 Thread Joseph Wu 


> On Nov. 5, 2015, 4:39 p.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 110-112
> > 
> >
> > The resource string you have is equivalent to the resource string from 
> > `CreateSlaveFlags`.  Is there some reason you're re-setting it?
> 
> Alexander Rukletsov wrote:
> One of the comments I got earlier from Bernd is that it is hard to track 
> what resources are available, hence I decided to re-introduce the resources 
> explicitly.

Can you add a comment about this to the test?


> On Nov. 5, 2015, 4:39 p.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 147-148
> > 
> >
> > Rather than re-defining this, can you populate it via the result of 
> > `MesosTest::CreateSlaveFlags().resources`?
> 
> Alexander Rukletsov wrote:
> Do you suggest to call `MesosTest::CreateSlaveFlags()` in the `SetUp()` 
> in order to use just the `.resources` artifact? Or you think I should make 
> `defaultAgentResources` local in every test?

This ties in with the above issue.  Given what Bernd/you said, what you have is 
probably ok.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105339
---


On Nov. 10, 2015, 2 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 10, 2015, 2 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-10 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 10, 2015, 10 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-10 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 10, 2015, 12:52 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Updated comments.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-10 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 10, 2015, 1:22 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Formatting.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-09 Thread Alexander Rukletsov 


> On Nov. 6, 2015, 12:39 a.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 110-112
> > 
> >
> > The resource string you have is equivalent to the resource string from 
> > `CreateSlaveFlags`.  Is there some reason you're re-setting it?

One of the comments I got earlier from Bernd is that it is hard to track what 
resources are available, hence I decided to re-introduce the resources 
explicitly.


> On Nov. 6, 2015, 12:39 a.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, line 201
> > 
> >
> > Can you change this comment to more closely match your test?
> > 
> > I find `12 > 11` to be a better sanity check than `100 > 11`.

This comment does not refer to a specific test, it rather illustrates what a 
sanity check may be.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105339
---


On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 5, 2015, 7:27 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-09 Thread Alexander Rukletsov 


> On Nov. 3, 2015, 7:14 a.m., Guangya Liu wrote:
> > src/tests/master_quota_tests.cpp, line 237
> > 
> >
> > move to upper line?

That's what `clang-format` suggests. Also, I think it's slightly readable this 
way.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review104880
---


On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 5, 2015, 7:27 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-09 Thread Alexander Rukletsov 


> On Oct. 8, 2015, 10:21 a.m., Bernd Mathiske wrote:
> > src/tests/master_quota_tests.cpp, line 132
> > 
> >
> > How about adding each test function and have it do nothing, with a TODO 
> > inside, but with a comment of the top what it is supposed to test - instead 
> > of this comment?
> 
> Alexander Rukletsov wrote:
> It's a good idea, I'll do that.

After the second thought, I think a TODO is better. The stubs for tests with 
comments can become outdated in a while, so I would prefer not to invest much 
effort into it.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review101885
---


On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 5, 2015, 7:27 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-09 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 9, 2015, 5:49 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Rebased; updated comments.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-09 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 9, 2015, 5:39 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Rebased.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-06 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105438
---



src/tests/master_quota_tests.cpp (line 170)


Also we usually use 3rd person in test comments.
(see your comment on 39223)

// This test ensures...

or

// This tests that...

or simply

// Tests whether...


- Joerg Schad


On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 5, 2015, 7:27 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-06 Thread Joerg Schad 


> On Nov. 6, 2015, 4:06 p.m., Joerg Schad wrote:
> > src/tests/master_quota_tests.cpp, line 170
> > 
> >
> > Also we usually use 3rd person in test comments.
> > (see your comment on 39223)
> > 
> > 
> > // This test ensures...
> > 
> > or
> > 
> > // This tests that...
> > 
> > or simply
> > 
> > // Tests whether...

What I was trying to ask was whether we should use Tests instead of Verfies


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105438
---


On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 5, 2015, 7:27 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-06 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105454
---



src/tests/master_quota_tests.cpp (line 341)


Please move up below AWAIT_READY(agentTotalResources);


- Joerg Schad


On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 5, 2015, 7:27 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-05 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105339
---



src/tests/master_quota_tests.cpp (lines 110 - 112)


The resource string you have is equivalent to the resource string from 
`CreateSlaveFlags`.  Is there some reason you're re-setting it?



src/tests/master_quota_tests.cpp (lines 147 - 148)


Rather than re-defining this, can you populate it via the result of 
`MesosTest::CreateSlaveFlags().resources`?



src/tests/master_quota_tests.cpp (line 201)


Can you change this comment to more closely match your test?

I find `12 > 11` to be a better sanity check than `100 > 11`.


- Joseph Wu


On Nov. 5, 2015, 11:27 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 5, 2015, 11:27 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-03 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 3, 2015, 3:47 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Michael Park.


Summary (updated)
-

Quota: Added allocator-agnostic tests.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs
-

  src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
  src/master/quota_handler.cpp PRE-CREATION 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov