Re: Review Request 40286: Fix registry puller to return correct rootfs path.

2015-11-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/ --- (Updated Nov. 14, 2015, 1 a.m.) Review request for mesos and Jojy Varghese. R

Re: Review Request 40286: Fix registry puller to return correct rootfs path.

2015-11-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/#review106492 --- Ship it! This patch looks good to me. We should use putLayer() for

Re: Review Request 40286: Fix registry puller to return correct rootfs path.

2015-11-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/#review106468 --- Patch looks great! Reviews applied: [40286] All tests passed. -

Re: Review Request 40286: Fix registry puller to return correct rootfs path.

2015-11-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/ --- (Updated Nov. 13, 2015, 4:46 p.m.) Review request for mesos and Jojy Varghese.

Re: Review Request 40286: Fix registry puller to return correct rootfs path.

2015-11-13 Thread Timothy Chen
> On Nov. 13, 2015, 3:48 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 145 > > > > > > We need root preveliges to untar since it could do "mknod" for device > > fil

Re: Review Request 40286: Fix registry puller to return correct rootfs path.

2015-11-13 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/#review106423 --- src/slave/containerizer/mesos/provisioner/docker/puller.hpp (line

Re: Review Request 40286: Fix registry puller to return correct rootfs path.

2015-11-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/#review106407 --- Patch looks great! Reviews applied: [40286] All tests passed. -

Review Request 40286: Fix registry puller to return correct rootfs path.

2015-11-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/ --- Review request for mesos and Jojy Varghese. Repository: mesos Description ---