Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review114175 --- Ship it! Ship It! - Benjamin Bannier On Jan. 13, 2016, 11:34

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review114168 --- bootstrap (line 15)

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

> On Jan. 13, 2016, 10:04 a.m., Till Toenshoff wrote: > > bootstrap, line 15 > > > > > > This would introduce Python as a hard dependency of the Mesos build > > environment. > > > > We should avoid this. >

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/ --- (Updated Jan. 13, 2016, 10:34 a.m.) Review request for mesos, Benjamin

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

> On Jan. 13, 2016, 10:04 a.m., Till Toenshoff wrote: > > bootstrap, line 15 > > > > > > This would introduce Python as a hard dependency of the Mesos build > > environment. > > > > We should avoid this.

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review114187 --- This recent change breaks the functionality - it hangs now. -

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/ --- (Updated Jan. 13, 2016, 6:41 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

> On Jan. 13, 2016, 12:26 p.m., Till Toenshoff wrote: > > This recent change breaks the functionality - it hangs now. Looks like 'git rev-parse --git-common-dir' sometimes returns the absolute path of the .git directory, and other times it returns a relative path. My relPath() function

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review114341 --- Ship it! bootstrap (line 16)

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

> On Jan. 14, 2016, 12:30 a.m., Till Toenshoff wrote: > > bootstrap, line 16 > > > > > > s/allows/allow/ > > > > fixing while committing... sounds good > On Jan. 14, 2016, 12:30 a.m., Till Toenshoff

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review114301 --- Patch looks great! Reviews applied: [41244, 41243] Passed

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review113902 --- Patch looks great! Reviews applied: [41244, 41243] Passed

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/ --- (Updated Jan. 11, 2016, 7:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/ --- (Updated Jan. 11, 2016, 8:12 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

> On Dec. 17, 2015, 3:42 a.m., Till Toenshoff wrote: > > Ship It! Sorry for the delay -- this patch now needs a rebase. - Till --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/ --- (Updated Dec. 17, 2015, 3:08 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review110883 --- Ship it! Ship It! - Till Toenshoff On Dec. 17, 2015, 3:08

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review110468 --- bootstrap (lines 16 - 23)

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

> On Dec. 15, 2015, 10:43 a.m., Benjamin Bannier wrote: > > I agree with all of your comments, and the code has been updated appropriately. - Kevin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/ --- (Updated Dec. 15, 2015, 3:10 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review110497 --- Ship it! - Benjamin Bannier On Dec. 15, 2015, 3:10 p.m., Kevin

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/ --- (Updated Dec. 15, 2015, 1:09 a.m.) Review request for mesos, Benjamin Hindman,