Re: Review Request 44674: Supported image name specified with private registry prefix.

2016-04-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review126838 --- Ship it! Ship It! - Jie Yu On April 2, 2016, 8:20 p.m., Gilb

Re: Review Request 44674: Supported image name specified with private registry prefix.

2016-04-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review126700 --- src/docker/spec.cpp (lines 103 - 105)

Re: Review Request 44674: Supported image name specified with private registry prefix.

2016-04-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/ --- (Updated April 2, 2016, 1:20 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 44674: Supported image name specified with private registry prefix.

2016-04-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review126668 --- Patch looks great! Reviews applied: [44672, 44673, 44674] Passed

Re: Review Request 44674: Supported image name specified with private registry prefix.

2016-04-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/ --- (Updated April 1, 2016, 3:41 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 44674: Supported image name specified with private registry prefix.

2016-04-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review126657 --- src/docker/spec.cpp (lines 103 - 105)

Re: Review Request 44674: Supported image name specified with private registry prefix.

2016-04-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review126655 --- Patch looks great! Reviews applied: [44672, 44673, 44674] Passed

Re: Review Request 44674: Supported image name specified with private registry prefix.

2016-04-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/ --- (Updated April 1, 2016, 1:25 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 44674: Supported image name specified with private registry prefix.

2016-03-31 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review126465 --- src/slave/containerizer/mesos/provisioner/docker/registry_puller.

Re: Review Request 44674: Supported image name specified with private registry prefix.

2016-03-22 Thread Guangya Liu
> On 三月 22, 2016, 2:23 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 395 > > > > > > Just a question: Where did set the schema was set to `https` for thi

Re: Review Request 44674: Supported image name specified with private registry prefix.

2016-03-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review124893 --- Patch looks great! Reviews applied: [44672, 44673, 44674] Passed

Re: Review Request 44674: Supported image name specified with private registry prefix.

2016-03-22 Thread Gilbert Song
> On March 22, 2016, 7:23 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 395 > > > > > > Just a question: Where did set the schema was set to `https` for

Re: Review Request 44674: Supported image name specified with private registry prefix.

2016-03-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review124793 --- src/slave/containerizer/mesos/provisioner/docker/registry_puller.

Re: Review Request 44674: Supported image name specified with private registry prefix.

2016-03-19 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/ --- (Updated March 17, 2016, 9:57 a.m.) Review request for mesos, Artem Harutyunyan

Review Request 44674: Supported image name specified with private registry prefix.

2016-03-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Reposito