Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review134073 --- Patch looks great! Reviews applied: [47463] Passed command:

Re: Review Request 47463: Added documentation for `network/cni` isolator.

> On May 18, 2016, 6:39 p.m., Vinod Kone wrote: > > docs/cni.md, line 247 > > > > > > and vice versa unless the executor uses HTTP API? > > Avinash sridharan wrote: > Even with the HTTP API the requirement of

Re: Review Request 47463: Added documentation for `network/cni` isolator.

> On May 18, 2016, 6:39 p.m., Vinod Kone wrote: > > docs/cni.md, line 247 > > > > > > and vice versa unless the executor uses HTTP API? > > Avinash sridharan wrote: > Even with the HTTP API the requirement of

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/ --- (Updated May 19, 2016, 6:38 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133937 --- docs/cni.md (line 3)

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133899 --- docs/cni.md (line 5)

Re: Review Request 47463: Added documentation for `network/cni` isolator.

> On May 18, 2016, 6:39 p.m., Vinod Kone wrote: > > docs/cni.md, line 5 > > > > > > Should we make it explicit that this is not supported for > > DockerContainerizer? I don't think we should be explicit about the

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133782 --- Fix it, then Ship it! LGTM. I'm assuming Jie already verified

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133701 --- Patch looks great! Reviews applied: [47463] Passed command:

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/ --- (Updated May 17, 2016, 11:27 p.m.) Review request for mesos, Jie Yu, Kevin

Re: Review Request 47463: Added documentation for `network/cni` isolator.

> On May 17, 2016, 10:17 p.m., Jie Yu wrote: > > docs/cni.md, line 133 > > > > > > I would mention that nsenter can also be used to achieve the same goal. > > One just need to get the pid (which can be get from the

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133640 --- Fix it, then Ship it! docs/cni.md (line 2)

Re: Review Request 47463: Added documentation for `network/cni` isolator.

> On May 17, 2016, 7:47 p.m., Michael Cambria wrote: > > docs/cni.md, line 54 > > > > > > This reads like the plugin is always responsible for creating veth > > pairs. Is this always the case or just applicable for

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133611 --- docs/cni.md (line 54)

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133609 --- docs/cni.md (line 23)

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133606 --- Networking Recipes still lists macvlan as a recipe, prior edit

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133593 --- Patch looks great! Reviews applied: [47463] Passed command:

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133584 --- docs/cni.md (line 47)

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/ --- (Updated May 17, 2016, 3:22 p.m.) Review request for mesos, Jie Yu, Kevin

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/ --- (Updated May 17, 2016, 3:06 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/ --- (Updated May 17, 2016, 3:04 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/ --- (Updated May 17, 2016, 3:02 p.m.) Review request for mesos, Jie Yu and Qian

Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/ --- Review request for mesos, Jie Yu and Qian Zhang. Repository: mesos