----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133937 -----------------------------------------------------------
docs/cni.md (line 3) <https://reviews.apache.org/r/47463/#comment198598> Phrasing is awkward: who is "we", and when "have we introduced" the CNI isolator? Better would be: "The Mesos `network/cni` isolator allows containers launched using the `MesosContainerizer` to be attached to several different types of IP networks." docs/cni.md (line 40) <https://reviews.apache.org/r/47463/#comment198615> Saying "network namespace" three times in one sentence seems regrettable. docs/cni.md (line 57) <https://reviews.apache.org/r/47463/#comment198617> "and" twice. - Neil Conway On May 18, 2016, 1:31 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47463/ > ----------------------------------------------------------- > > (Updated May 18, 2016, 1:31 p.m.) > > > Review request for mesos, Benjamin Mahler, Jie Yu, Kevin Klues, Neil Conway, > Qian Zhang, and Vinod Kone. > > > Bugs: MESOS-4771 > https://issues.apache.org/jira/browse/MESOS-4771 > > > Repository: mesos > > > Description > ------- > > Added documentation for `network/cni` isolator. > > > Diffs > ----- > > docs/cni.md PRE-CREATION > > Diff: https://reviews.apache.org/r/47463/diff/ > > > Testing > ------- > > Build the documentation website and verified the rendering. > > You can review a rendering of the markdown on my github: > https://github.com/asridharan/mesos/blob/MESOS-4771/docs/cni.md > > > Thanks, > > Avinash sridharan > >
