Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51421/#review148414
---


Ship it!




Ship It!

- Jie Yu


On Sept. 9, 2016, 8:07 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51421/
> ---
> 
> (Updated Sept. 9, 2016, 8:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, and Kevin Klues.
> 
> 
> Bugs: MESOS-6067
> https://issues.apache.org/jira/browse/MESOS-6067
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added provisioner appc unit test for recovering nested container.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> b3ba176e506a6d1528290c07a8a0555b12c8cf70 
> 
> Diff: https://reviews.apache.org/r/51421/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51421/
---

(Updated Sept. 9, 2016, 1:07 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
Wu, and Kevin Klues.


Bugs: MESOS-6067
https://issues.apache.org/jira/browse/MESOS-6067


Repository: mesos


Description
---

Added provisioner appc unit test for recovering nested container.


Diffs (updated)
-

  src/tests/containerizer/provisioner_appc_tests.cpp 
b3ba176e506a6d1528290c07a8a0555b12c8cf70 

Diff: https://reviews.apache.org/r/51421/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51421/#review147739
---




src/tests/containerizer/provisioner_appc_tests.cpp (line 497)


missed here?

```
path::join(sandbox.get(), "work_dir");
```



src/tests/containerizer/provisioner_appc_tests.cpp (lines 531 - 534)


how about 

s/ExecutorInfo/`ExecutorInfo`
s/ContainerState/`ContainerState`
s/ContainerInfo/`ContainerInfo`
s/--default_container_info/`--default_container_info`



src/tests/containerizer/provisioner_appc_tests.cpp (line 541)


s/string/const string



src/tests/containerizer/provisioner_appc_tests.cpp (lines 541 - 546)


What about moving this right before #551?

Ditto for #553 to #556


- Guangya Liu


On 八月 29, 2016, 9:20 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51421/
> ---
> 
> (Updated 八月 29, 2016, 9:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, and Kevin Klues.
> 
> 
> Bugs: MESOS-6067
> https://issues.apache.org/jira/browse/MESOS-6067
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added provisioner appc unit test for recovering nested container.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> b3ba176e506a6d1528290c07a8a0555b12c8cf70 
> 
> Diff: https://reviews.apache.org/r/51421/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51421/#review147241
---



Patch looks great!

Reviews applied: [51323, 51343, 51358, 51359, 51392, 51393, 51402, 51503, 
51420, 51421]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 29, 2016, 9:20 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51421/
> ---
> 
> (Updated Aug. 29, 2016, 9:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, and Kevin Klues.
> 
> 
> Bugs: MESOS-6067
> https://issues.apache.org/jira/browse/MESOS-6067
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added provisioner appc unit test for recovering nested container.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> b3ba176e506a6d1528290c07a8a0555b12c8cf70 
> 
> Diff: https://reviews.apache.org/r/51421/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

[Gilbert Song]

> On Aug. 25, 2016, 5:58 p.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_appc_tests.cpp, lines 538-543
> > 
> >
> > Hum, I don't think legitimate case. ContainerState will only container 
> > top level executor containers.
> 
> Gilbert Song wrote:
> I have a different thought on this. According to the prvisioner::recover()
> ```
>   virtual process::Future recover(
>   const std::list& states,
>   const hashset& orphans) const;
> ```
> 
> We are assuming the `orphans` includes all orphaned containers (parent 
> and its sub-containers). Correspondingly, the `state` should do the same. It 
> would depend on more changes in MesosContainerizer::recover() to check the 
> `taskState`. Otherwise, all sub-containers will be destroyed as unknown 
> orphans. There is no way to recognize alive sub-containers.

Let's keep this open. I need some more time to think about it.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51421/#review146901
---


On Aug. 29, 2016, 2:20 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51421/
> ---
> 
> (Updated Aug. 29, 2016, 2:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, and Kevin Klues.
> 
> 
> Bugs: MESOS-6067
> https://issues.apache.org/jira/browse/MESOS-6067
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added provisioner appc unit test for recovering nested container.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> b3ba176e506a6d1528290c07a8a0555b12c8cf70 
> 
> Diff: https://reviews.apache.org/r/51421/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51421/
---

(Updated Aug. 29, 2016, 2:20 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
Wu, and Kevin Klues.


Bugs: MESOS-6067
https://issues.apache.org/jira/browse/MESOS-6067


Repository: mesos


Description
---

Added provisioner appc unit test for recovering nested container.


Diffs (updated)
-

  src/tests/containerizer/provisioner_appc_tests.cpp 
b3ba176e506a6d1528290c07a8a0555b12c8cf70 

Diff: https://reviews.apache.org/r/51421/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

[Gilbert Song]

> On Aug. 25, 2016, 5:58 p.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_appc_tests.cpp, lines 538-543
> > 
> >
> > Hum, I don't think legitimate case. ContainerState will only container 
> > top level executor containers.

I have a different thought on this. According to the prvisioner::recover()
```
  virtual process::Future recover(
  const std::list& states,
  const hashset& orphans) const;
```

We are assuming the `orphans` includes all orphaned containers (parent and its 
sub-containers). Correspondingly, the `state` should do the same. It would 
depend on more changes in MesosContainerizer::recover() to check the 
`taskState`. Otherwise, all sub-containers will be destroyed as unknown 
orphans. There is no way to recognize alive sub-containers.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51421/#review146901
---


On Aug. 29, 2016, 2:20 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51421/
> ---
> 
> (Updated Aug. 29, 2016, 2:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, and Kevin Klues.
> 
> 
> Bugs: MESOS-6067
> https://issues.apache.org/jira/browse/MESOS-6067
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added provisioner appc unit test for recovering nested container.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> b3ba176e506a6d1528290c07a8a0555b12c8cf70 
> 
> Diff: https://reviews.apache.org/r/51421/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51421/#review146901
---




src/tests/containerizer/provisioner_appc_tests.cpp (line 504)


Ditto.



src/tests/containerizer/provisioner_appc_tests.cpp (lines 538 - 543)


Hum, I don't think legitimate case. ContainerState will only container top 
level executor containers.



src/tests/containerizer/provisioner_appc_tests.cpp (lines 547 - 548)


The comment here is confusing. I think you want to see if a container can 
have multiple rootfses (for image volumes), right?



src/tests/containerizer/provisioner_appc_tests.cpp (lines 558 - 567)


I don't know if this check is useful. I think the destroy check below 
sounds sufficient to me.


- Jie Yu


On Aug. 25, 2016, 8:15 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51421/
> ---
> 
> (Updated Aug. 25, 2016, 8:15 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and 
> Kevin Klues.
> 
> 
> Bugs: MESOS-6067
> https://issues.apache.org/jira/browse/MESOS-6067
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added provisioner appc unit test for recovering nested container.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> b3ba176e506a6d1528290c07a8a0555b12c8cf70 
> 
> Diff: https://reviews.apache.org/r/51421/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51421/#review146774
---



Patch looks great!

Reviews applied: [51323, 51343, 51358, 51359, 51392, 51393, 51402, 51420, 51421]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 25, 2016, 8:15 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51421/
> ---
> 
> (Updated Aug. 25, 2016, 8:15 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and 
> Kevin Klues.
> 
> 
> Bugs: MESOS-6067
> https://issues.apache.org/jira/browse/MESOS-6067
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added provisioner appc unit test for recovering nested container.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> b3ba176e506a6d1528290c07a8a0555b12c8cf70 
> 
> Diff: https://reviews.apache.org/r/51421/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 51421: Added provisioner appc unit test for recovering nested container.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51421/
---

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and 
Kevin Klues.


Bugs: MESOS-6067
https://issues.apache.org/jira/browse/MESOS-6067


Repository: mesos


Description
---

Added provisioner appc unit test for recovering nested container.


Diffs
-

  src/tests/containerizer/provisioner_appc_tests.cpp 
b3ba176e506a6d1528290c07a8a0555b12c8cf70 

Diff: https://reviews.apache.org/r/51421/diff/


Testing
---

make check


Thanks,

Gilbert Song