Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160937 --- Patch looks great! Reviews applied: [54996] Passed command:

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- (Updated Jan. 9, 2017, 4:42 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 7, 2017, 6:42 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 72 > > > > > > Please use errno error so that errno are in the error string. > > > > `return ErrnoError("Memory

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- (Updated Jan. 9, 2017, 4:19 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 7, 2017, 6:42 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 72 > > > > > > Please use errno error so that errno are in the error string. > > > > `return ErrnoError("Memory

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160821 --- Fix it, then Ship it!

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160652 --- Patch looks great! Reviews applied: [54996] Passed command:

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- (Updated Jan. 4, 2017, 9:55 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160541 --- 3rdparty/stout/include/stout/os/linux.hpp (line 72)

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:41 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 120 > > > > > > Consider hoisting this into the `Stack` class: > > > > ``` > > void * Stack::start()

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:41 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 63 > > > > > > I'd recommend something like this: > > ``` > > Try allocate(size_t nbytes) { > > int

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:41 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 82 > > > > > > You should explictly delete the copy constructors here to ensure the > > stack can't be leaked if

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:41 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 120 > > > > > > Consider hoisting this into the `Stack` class: > > > > ``` > > void * Stack::start()

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:58 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, lines 57-60 > > > > > > I would actually suggest keep this `create` method, but move the > > allocation logic in `create`.

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- (Updated Jan. 4, 2017, 9:28 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:58 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, lines 57-60 > > > > > > I would actually suggest keep this `create` method, but move the > > allocation logic in `create`.

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:58 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, lines 57-60 > > > > > > I would actually suggest keep this `create` method, but move the > > allocation logic in `create`.

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160513 --- 3rdparty/stout/include/stout/os/linux.hpp (lines 57 - 60)

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:41 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 120 > > > > > > Consider hoisting this into the `Stack` class: > > > > ``` > > void * Stack::start()

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:41 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 120 > > > > > > Consider hoisting this into the `Stack` class: > > > > ``` > > void * Stack::start()

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:41 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 120 > > > > > > Consider hoisting this into the `Stack` class: > > > > ``` > > void * Stack::start()

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160464 --- 3rdparty/stout/include/stout/os/linux.hpp (line 60)

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160454 --- 3rdparty/stout/include/stout/os/linux.hpp (line 68)

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- (Updated Jan. 4, 2017, 12:26 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Dec. 27, 2016, 1:25 p.m., Till Toenshoff wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 81 > > > > > > As you have no further use for the returned value, I guess we could > > simply spare the

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- (Updated Dec. 29, 2016, 7:03 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160279 --- 3rdparty/stout/include/stout/os/linux.hpp (lines 76 - 77)

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160269 --- Patch looks great! Reviews applied: [54996] Passed command:

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160159 --- 3rdparty/stout/include/stout/os/linux.hpp (line 81)

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- (Updated Dec. 22, 2016, 9:24 p.m.) Review request for mesos and Jie Yu.

Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6835