Re: Review Request 56449: Moved health checker closer to container in default executor.

2017-03-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/ --- (Updated March 20, 2017, 11:54 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 56449: Moved health checker closer to container in default executor.

2017-03-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/#review169281 --- Ship it! Ship It! - Vinod Kone On March 16, 2017, 4:48

Re: Review Request 56449: Moved health checker closer to container in default executor.

2017-03-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/#review169265 --- src/launcher/default_executor.cpp Line 873 (original)

Re: Review Request 56449: Moved health checker closer to container in default executor.

2017-03-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/ --- (Updated March 16, 2017, 4:48 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 56449: Moved health checker closer to container in default executor.

2017-03-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/ --- (Updated March 16, 2017, 4:41 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 56449: Moved health checker closer to container in default executor.

2017-03-16 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/#review169155 --- Patch looks great! Reviews applied: [56016, 57394, 56017, 57594,

Re: Review Request 56449: Moved health checker closer to container in default executor.

2017-03-16 Thread Alexander Rukletsov
> On Feb. 15, 2017, 10 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp > > Lines 869 (patched) > > > > > > What's the guarantee that this task is still present in `containers`? > > AFAICT this is a

Re: Review Request 56449: Moved health checker closer to container in default executor.

2017-03-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/#review167861 --- No updates to this diff yet? - Vinod Kone On Feb. 28, 2017,

Re: Review Request 56449: Moved health checker closer to container in default executor.

2017-02-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/ --- (Updated Feb. 28, 2017, 2:35 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 56449: Moved health checker closer to container in default executor.

2017-02-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/#review165770 --- src/launcher/default_executor.cpp (lines 635 - 637)

Re: Review Request 56449: Moved health checker closer to container in default executor.

2017-02-15 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/#review165695 --- Ship it! src/launcher/default_executor.cpp (line 639)

Re: Review Request 56449: Moved health checker closer to container in default executor.

2017-02-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/ --- (Updated Feb. 8, 2017, 4:56 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 56449: Moved health checker closer to container in default executor.

2017-02-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/ --- Review request for mesos, Anand Mazumdar, Gastón Kleiman, and Vinod Kone.