Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-19 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review199422 --- Ship it! Ship It! - Zhitao Li On March 16, 2018, 1:55 p.m.,

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- (Updated March 16, 2018, 1:54 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-15 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review199303 --- src/master/master.cpp Lines 4092-4098 (patched)

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- (Updated March 16, 2018, 12:02 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- (Updated March 16, 2018, 12:01 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-14 Thread Greg Mann
> On March 14, 2018, 3:55 p.m., Benjamin Bannier wrote: > > I am confused why this patch does not add a status update manager for > > master-generated operation status updates. Right now there is no way for > > frameworks to e.g., reconcile failed operations after framework failover > > since

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review199172 --- I am confused why this patch does not add a status update manager

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-13 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review199124 --- Ship it! Ship It! - Gaston Kleiman On March 13, 2018, 2:49 p

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- (Updated March 13, 2018, 9:49 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-13 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review199121 --- src/master/master.cpp Lines 4075-4082 (original), 4111-4117 (patc

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-13 Thread Gaston Kleiman
> On March 7, 2018, 11:21 a.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Line 4136 (original), 4184 (patched) > > > > > > If the operation has an operation ID, we'll always land on this > > `continue` ev

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-13 Thread Greg Mann
> On March 7, 2018, 7:21 p.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Line 4136 (original), 4184 (patched) > > > > > > If the operation has an operation ID, we'll always land on this > > `continue` eve

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- (Updated March 13, 2018, 4:38 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-12 Thread Greg Mann
> On March 7, 2018, 7:21 p.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Line 4136 (original), 4184 (patched) > > > > > > If the operation has an operation ID, we'll always land on this > > `continue` eve

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-07 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review198812 --- src/master/master.cpp Line 4136 (original), 4184 (patched)

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- (Updated March 2, 2018, 10:52 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-02 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review198558 --- Ship it! - Gaston Kleiman On March 2, 2018, 12:07 a.m., Greg

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2018-03-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- (Updated March 2, 2018, 8:07 a.m.) Review request for mesos, Benjamin Bannier,

Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

2017-11-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. Bugs: M