Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated May 1, 2018, 3:35 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review202154 --- Fix it, then Ship it! Overall LGTM. src/master/master.cpp

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 24, 2018, 9:05 p.m., Chun-Hung Hsiao wrote: > > src/master/validation.cpp > > Lines 2332 (patched) > > > > > > Can you add tests for this function in > > `src/tests/master_validation_tests.cpp`? To

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated April 27, 2018, 12:24 p.m.) Review request for mesos, Chun-Hung

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review202032 --- src/master/master.cpp Line 4565 (original), 4563 (patched)

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 16, 2018, 5:38 p.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Lines 4931-4932 (patched) > > > > > > I'd change this to: > > > > > > ``` > > "Agent " + stringify(slave) + "

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review201887 --- Fix it, then Ship it! src/master/master.cpp Lines 4905-4923

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated April 24, 2018, 2:16 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review201779 --- src/common/resources_utils.cpp Lines 708-709 (patched)

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated April 20, 2018, 11:40 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 12, 2018, 5:33 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 4986-4994 (patched) > > > > > > What will happen if these operations are sent to a 1.5 agent which has > > the RESOURCE_PROVIDER

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated April 17, 2018, 9:58 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 16, 2018, 10:38 a.m., Gaston Kleiman wrote: > > src/master/validation.cpp > > Lines 2348-2351 (patched) > > > > > > Isn't it easier to do the following? > > > > ``` > > if

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 14, 2018, 1:52 a.m., Chun-Hung Hsiao wrote: > > src/master/validation.cpp > > Lines 2336 (patched) > > > > > > For consistency, I prefer just `"Invalid resource: "`. > > > > Or if you want to

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 16, 2018, 5:38 p.m., Gaston Kleiman wrote: > > src/master/validation.cpp > > Lines 2348-2351 (patched) > > > > > > Isn't it easier to do the following? > > > > ``` > > if

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 16, 2018, 10:38 a.m., Gaston Kleiman wrote: > > src/master/validation.cpp > > Lines 2348-2351 (patched) > > > > > > Isn't it easier to do the following? > > > > ``` > > if

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 16, 2018, 5:38 p.m., Gaston Kleiman wrote: > > src/master/validation.cpp > > Lines 2348-2351 (patched) > > > > > > Isn't it easier to do the following? > > > > ``` > > if

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 13, 2018, 12:33 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 4986-4994 (patched) > > > > > > What will happen if these operations are sent to a 1.5 agent which has > > the

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 13, 2018, 12:33 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 4986-4994 (patched) > > > > > > What will happen if these operations are sent to a 1.5 agent which has > > the

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review201229 --- src/master/master.cpp Lines 4931-4932 (patched)

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated April 16, 2018, 10:09 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 12, 2018, 5:33 p.m., Greg Mann wrote: > > Will do for any comment not explicitly replied. > On April 12, 2018, 5:33 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 4986-4994 (patched) > > > > >

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated April 16, 2018, 9:42 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 27, 2018, 12:14 p.m., Greg Mann wrote: > > src/common/resources_utils.cpp > > Lines 696-698 (patched) > > > > > > No period at the end of error messages. Here and below. Are you sure? That is not

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 14, 2018, 1:52 a.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 4976 (patched) > > > > > > As we discussed, we should validate that there is only one operation. > > Shouldn't we add the

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review201150 --- src/master/master.cpp Lines 4969 (patched)

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review201055 --- src/master/master.cpp Lines 4949 (patched)

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated April 9, 2018, 9:18 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 27, 2018, 3:24 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 8054-8056 (patched) > > > > > > Looks like we will now run `checkpointResources()` on resource provider > > resources which are

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 26, 2018, 5:37 p.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 8053-8059 (patched) > > > > > > If we checkpoint resources after sending status updates, then say if > > the agent crashes

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 26, 2018, 5:37 p.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 4292-4324 (original), 4292-4342 (patched) > > > > > > Let's do some refactoring here. There are 3 cases: > > > > 1.

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 27, 2018, 10:24 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 8054-8056 (patched) > > > > > > Looks like we will now run `checkpointResources()` on resource provider > > resources which are

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 27, 2018, 12:14 p.m., Greg Mann wrote: > > src/common/resources_utils.cpp > > Lines 203-205 (patched) > > > > > > This is already done in the validation code - do we need to do it again > > here? Ditto

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 27, 2018, 3:24 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Line 4258 (original), 4258 (patched) > > > > > > Could you split the agent changes into a separate patch? This is a > > significant

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated March 28, 2018, 11:26 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review200126 --- Bad patch! Reviews applied: [66050, 66049, 66343, 66342] Failed

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 27, 2018, 7:14 p.m., Greg Mann wrote: > > src/common/resources_utils.cpp > > Lines 203-205 (patched) > > > > > > This is already done in the validation code - do we need to do it again > > here? Ditto

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review200055 --- src/common/resources_utils.cpp Lines 203-205 (patched)

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 27, 2018, 6:32 a.m., Zhitao Li wrote: > > src/slave/slave.cpp > > Lines 8053-8059 (patched) > > > > > > Sorry I'm not following this comment. > > > > From what I can read, the sequence here is:

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 22, 2018, 3:43 p.m., Chun-Hung Hsiao wrote: > > src/master/validation.cpp > > Lines 2354 (patched) > > > > > > Let's do the following in order. > > > > First, general validations: > > -

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 22, 2018, 3:43 p.m., Chun-Hung Hsiao wrote: > > src/common/resources_utils.cpp > > Lines 199-261 (patched) > > > > > > We should not speculatively carve out the conversion here. Let's wait > > for the

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review199818 --- src/master/validation.cpp Lines 2393 (patched)

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review199802 --- Halfway reviewing. Posting some comments first.

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated March 22, 2018, 9:27 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated March 20, 2018, 6:32 p.m.) Review request for mesos, Chun-Hung Hsiao