Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

> On April 2, 2018, 4:21 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 2396-2398 (patched) > > > > > > Looks like we don't need this local variable? You mean passing the whole error message directly to

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/ --- (Updated April 3, 2018, 10:38 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/ --- (Updated April 2, 2018, 5:35 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/#review200325 --- src/slave/slave.cpp Line 2332 (original), 2345 (patched)

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/ --- (Updated April 2, 2018, 10:59 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/#review200216 --- src/slave/slave.cpp Line 2215 (original), 2220-2227 (patched)

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/ --- (Updated March 27, 2018, 6:07 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

> On March 23, 2018, 6 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 2406-2407 (patched) > > > > > > Let's use this opportunity to improve this error message. The precise > > reason for denied

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/#review199859 --- src/slave/slave.cpp Lines 2350 (patched)

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

> On March 21, 2018, 4:22 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 2386 (patched) > > > > > > Let's make this variable a reference instead to avoid the copy: > > > > ``` > > list&

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/ --- (Updated March 22, 2018, 10:26 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/#review199705 --- src/slave/slave.cpp Line 2202 (original), 2203-2204 (patched)

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/ --- (Updated March 20, 2018, 2:47 p.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8624