Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212804 --- Ship it! Ship It! - Benjamin Mahler On Feb. 13, 2019, 3:44 p

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Feb. 13, 2019, 4:44 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212759 --- src/master/allocator/mesos/hierarchical.cpp Lines 2072-2074 (orig

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

> On Feb. 8, 2019, 10:05 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1886-1888 (patched) > > > > > > Ditto the comment left below for the equivalent check in the second loo

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Feb. 11, 2019, 4:46 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212679 --- Looks good, just some minor comments. I suppose you'll need to reb

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Feb. 8, 2019, 12:32 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

> On Feb. 4, 2019, 9:58 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 2058-2060 (original), 2092-2094 (patched) > > > > > > We lost the comment here about why it's safe to br

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212573 --- Much appreciated for having split out the changes! This is nice an

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Feb. 5, 2019, 5:38 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

> On Feb. 4, 2019, 9:58 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 2041-2042 (original), 2075-2076 (patched) > > > > > > Hm.. isn't the framework capability stripping mess

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212536 --- PASS: Mesos patch 69821 was successfully built and tested. Review

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

> On Feb. 4, 2019, 9:58 p.m., Benjamin Mahler wrote: > > Can you split this change apart so that I can review more easily and we can > > land it faster? > > > > (1) The plumbing and storage of the information: this is an easy change > > that doesn't require much thought, it looks good and can

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Feb. 4, 2019, 11:05 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212523 --- Can you split this change apart so that I can review more easily a

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Feb. 4, 2019, 9:37 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212516 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Feb. 4, 2019, 12:14 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

> On Jan. 29, 2019, 8:37 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 2336 (patched) > > > > > > FrameworkEmptyMinAllocatable > > Benjamin Bannier wrote: > Thi

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212484 --- PASS: Mesos patch 69821 was successfully built and tested. Review

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

> On Jan. 29, 2019, 9:37 p.m., Benjamin Mahler wrote: > > The commit description makes it sound like the filter is using the > > **union** of the flag and the per-framework/role override: > > > > > This set is populated with any minimal allocatable resources specified in > > > the allocator's

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Jan. 31, 2019, 4:16 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212456 --- PASS: Mesos patch 69821 was successfully built and tested. Review

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Jan. 30, 2019, 4:08 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212450 --- Patch looks great! Reviews applied: [69818, 69819, 69820, 69821]

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212421 --- The commit description makes it sound like the filter is using the

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212417 --- PASS: Mesos patch 69821 was successfully built and tested. Review

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Jan. 29, 2019, 5:20 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212240 --- PASS: Mesos patch 69821 was successfully built and tested. Review

Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9523 ht