Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55989610
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20513/consoleFull)
for PR 2441 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55989974
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20517/consoleFull)
for PR 2441 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55990116
Overall I think this is better, thanks! One minor issue is that
`hive-thriftserver` is missing from the SQL tests (Sorry, I think I left this
out when you asked).
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2421#issuecomment-55990357
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20518/consoleFull)
for PR 2421 at commit
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55990371
One minor issue is that `hive-thriftserver` is missing from the SQL tests
No problem. Just give me an updated list of arguments to pass to `sbt` when
you just
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55990548
One minor issue is that hive-thriftserver is missing from the SQL tests
No problem. Just give me an updated list of arguments to pass to sbt when
you just
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1658#discussion_r17707338
--- Diff: core/src/main/scala/org/apache/spark/input/RawFileInput.scala ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1658#discussion_r17707347
--- Diff: core/src/main/scala/org/apache/spark/input/RawFileInput.scala ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1658#discussion_r17707360
--- Diff: core/src/main/scala/org/apache/spark/input/RawFileInput.scala ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1658#discussion_r17707399
--- Diff: core/src/main/scala/org/apache/spark/input/RawFileInput.scala ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2427#issuecomment-55990734
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20520/consoleFull)
for PR 2427 at commit
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1658#discussion_r17707460
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -511,6 +511,67 @@ class SparkContext(config: SparkConf) extends Logging {
}
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1658#issuecomment-55990853
Jenkins, add to whitelist and test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2397#discussion_r17707447
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
@@ -166,3 +166,20 @@ case class DescribeCommand(child: SparkPlan,
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1658#discussion_r17707495
--- Diff: core/src/main/scala/org/apache/spark/input/RawFileInput.scala ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1658#issuecomment-55990912
@kmader sorry for the delay on this, but the new version looks pretty good.
Made a few more comments on the API. The other thing I see is that the code
style is not quite
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1658#discussion_r17707506
--- Diff: core/src/main/scala/org/apache/spark/input/RawFileInput.scala ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1658#discussion_r17707520
--- Diff: core/src/main/scala/org/apache/spark/input/RawFileInput.scala ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1658#issuecomment-55990964
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20521/consoleFull)
for PR 1658 at commit
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1658#discussion_r17707533
--- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java ---
@@ -836,6 +838,29 @@ public void sequenceFile() {
Assert.assertEquals(pairs,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-55991087
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20519/consoleFull)
for PR 2379 at commit
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1658#discussion_r17707574
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -511,6 +511,67 @@ class SparkContext(config: SparkConf) extends Logging {
}
Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/2421#issuecomment-55991903
Gosh, the test failed. I looked block generator throttling in
NetworkReceiverSuite.scala but couldn't see why.
---
If your project is set up for it, you can
GitHub user nchammas opened a pull request:
https://github.com/apache/spark/pull/2442
[SPARK-3534] Add hive-thriftserver to SQL tests
Addresses the problem pointed out in [this
comment](https://github.com/apache/spark/pull/2441#issuecomment-55990116).
You can merge this pull
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55992062
Just add `hive-thriftserver/test` to the sbt command for SQL.
Done in #2442.
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2442#issuecomment-55992179
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20522/consoleFull)
for PR 2442 at commit
Github user derrickburns commented on the pull request:
https://github.com/apache/spark/pull/2419#issuecomment-55992818
Tests fixed. Please re-run.
On Wed, Sep 17, 2014 at 7:04 PM, Apache Spark QA notificati...@github.com
wrote:
QA tests have finished
Github user derrickburns commented on the pull request:
https://github.com/apache/spark/pull/2419#issuecomment-55992851
Jenkins, retest this please.
On Wed, Sep 17, 2014 at 9:08 PM, Derrick Burns derrickrbu...@gmail.com
wrote:
Tests fixed. Please re-run.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2419#issuecomment-55992881
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20523/consoleFull)
for PR 2419 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1658#issuecomment-55993418
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20521/consoleFull)
for PR 1658 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2427#issuecomment-55993883
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20520/consoleFull)
for PR 2427 at commit
Github user nchammas closed the pull request at:
https://github.com/apache/spark/pull/2441
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/1658#discussion_r17709043
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -511,6 +511,67 @@ class SparkContext(config: SparkConf) extends Logging {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709067
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -197,4 +201,368 @@ private[mllib] object BLAS extends Serializable {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709059
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -197,4 +201,368 @@ private[mllib] object BLAS extends Serializable {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709070
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -197,4 +201,368 @@ private[mllib] object BLAS extends Serializable {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709063
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -197,4 +201,368 @@ private[mllib] object BLAS extends Serializable {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709076
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -36,9 +37,42 @@ trait Matrix extends Serializable {
/** Converts to
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709072
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -36,9 +37,42 @@ trait Matrix extends Serializable {
/** Converts to
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709058
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -197,4 +201,368 @@ private[mllib] object BLAS extends Serializable {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709060
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -197,4 +201,368 @@ private[mllib] object BLAS extends Serializable {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709065
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -197,4 +201,368 @@ private[mllib] object BLAS extends Serializable {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709081
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -59,11 +93,113 @@ trait Matrix extends Serializable {
*/
class
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709077
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -36,9 +37,42 @@ trait Matrix extends Serializable {
/** Converts to
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709069
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -197,4 +201,368 @@ private[mllib] object BLAS extends Serializable {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709101
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/MatricesSuite.scala ---
@@ -36,4 +36,79 @@ class MatricesSuite extends FunSuite {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709089
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -83,6 +219,24 @@ object Matrices {
}
/**
+ *
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709102
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/MatricesSuite.scala ---
@@ -36,4 +36,79 @@ class MatricesSuite extends FunSuite {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709086
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -59,11 +93,113 @@ trait Matrix extends Serializable {
*/
class
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709099
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/MatricesSuite.scala ---
@@ -36,4 +36,79 @@ class MatricesSuite extends FunSuite {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709094
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/BreezeMatrixConversionSuite.scala
---
@@ -37,4 +37,26 @@ class BreezeMatrixConversionSuite
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709082
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -59,11 +93,113 @@ trait Matrix extends Serializable {
*/
class
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709106
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/MatricesSuite.scala ---
@@ -36,4 +36,79 @@ class MatricesSuite extends FunSuite {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709079
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -59,11 +93,113 @@ trait Matrix extends Serializable {
*/
class
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709096
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/BreezeMatrixConversionSuite.scala
---
@@ -37,4 +37,26 @@ class BreezeMatrixConversionSuite
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709085
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -59,11 +93,113 @@ trait Matrix extends Serializable {
*/
class
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709088
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -59,11 +93,113 @@ trait Matrix extends Serializable {
*/
class
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709092
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -93,9 +247,84 @@ object Matrices {
require(dm.majorStride ==
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709103
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/MatricesSuite.scala ---
@@ -36,4 +36,79 @@ class MatricesSuite extends FunSuite {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709097
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/MatricesSuite.scala ---
@@ -36,4 +36,79 @@ class MatricesSuite extends FunSuite {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709104
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/MatricesSuite.scala ---
@@ -36,4 +36,79 @@ class MatricesSuite extends FunSuite {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709093
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/BLASSuite.scala ---
@@ -126,4 +126,116 @@ class BLASSuite extends FunSuite {
}
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2443#issuecomment-55995060
@srowen may want to review this since he recently modified this
documentation.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user pwendell opened a pull request:
https://github.com/apache/spark/pull/2443
SPARK-3579 Jekyll doc generation is different across environments.
This patch makes some small changes to fix this problem:
1. We document specific versions of Jekyll/Kramdown to use that match
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2427#issuecomment-55995118
Yeah good catch, thanks. I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2427
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2442#issuecomment-55995234
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20522/consoleFull)
for PR 2442 at commit
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2421#issuecomment-55995237
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2443#issuecomment-55995325
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20524/consoleFull)
for PR 2443 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2419#issuecomment-55995342
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20523/consoleFull)
for PR 2419 at commit
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2440#issuecomment-55995502
Hey one potentially controversial idea - what about if we just remove this
metric? It's not very useful because it's an absolute time and AFAIK we don't
record any
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2421#issuecomment-55995533
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20525/consoleFull)
for PR 2421 at commit
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/726#issuecomment-55996007
@ajtulloch any interest in updating? If not, we should close this issue and
can re-open later.
---
If your project is set up for it, you can reply to this email and
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1754#issuecomment-55996182
I don't mind putting this one in (it's simple enough and might lower the
bar for anyone trying to go this route). But the regex needs to be fixed,
otherwise it will
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709652
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -197,4 +201,368 @@ private[mllib] object BLAS extends Serializable {
Github user derrickburns commented on the pull request:
https://github.com/apache/spark/pull/2419#issuecomment-55996597
@mengxr, can someone help me to understand the test failure?
The test task size should be small in both training and prediction in
class
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/2294#discussion_r17709785
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -36,9 +37,42 @@ trait Matrix extends Serializable {
/** Converts to
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2442#issuecomment-55996902
Yeah good call, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2442
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17710004
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -95,6 +100,8 @@ case class Cast(child: Expression,
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17710025
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -140,6 +147,39 @@ case class Cast(child: Expression,
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/2035#discussion_r17710076
--- Diff: core/pom.xml ---
@@ -42,6 +42,10 @@
groupIdjavax.servlet/groupId
artifactIdservlet-api/artifactId
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2326#issuecomment-55997867
Okay thanks, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2326
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
401 - 484 of 484 matches
Mail list logo
