[GitHub] spark pull request: [SPARK-6364] [MLlib] Implement equals and hash...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5081#issuecomment-82808894 [Test build #28781 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28781/consoleFull) for PR 5081 at commit

[GitHub] spark pull request: Bug fix for SPARK-5242: ec2/spark_ec2.py lauc...

2015-03-18 Thread voukka
Github user voukka commented on the pull request: https://github.com/apache/spark/pull/4038#issuecomment-82812271 I will try to update/resolve conflicts today/tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-6364] [MLlib] Implement equals and hash...

2015-03-18 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/5081#issuecomment-82822725 Also, I'm not sure what the failed tests are about. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-6379][SQL] Support an implicit conversi...

2015-03-18 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/5061#issuecomment-82888774 @rxin fixed, and plz check it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-4012] stop SparkContext when the except...

2015-03-18 Thread CodingCat
Github user CodingCat commented on a diff in the pull request: https://github.com/apache/spark/pull/5004#discussion_r26653462 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1156,6 +1158,28 @@ private[spark] object Utils extends Logging { }

[GitHub] spark pull request: [SPARK-6117] [SQL] add describe function to Da...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5073#issuecomment-82907579 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5821] [SQL] JSON CTAS command should th...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4610#issuecomment-82816330 [Test build #28784 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28784/consoleFull) for PR 4610 at commit

[GitHub] spark pull request: [SPARK-6117] [SQL] add describe function to Da...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5073#issuecomment-82907566 [Test build #28790 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28790/consoleFull) for PR 5073 at commit

[GitHub] spark pull request: [SPARK-6364] [MLlib] Implement equals and hash...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5081#issuecomment-82811729 [Test build #28785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28785/consoleFull) for PR 5081 at commit

[GitHub] spark pull request: SPARK-6085 Part. 2 Increase default value for ...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5065#issuecomment-82816654 [Test build #28786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28786/consoleFull) for PR 5065 at commit

[GitHub] spark pull request: [SPARK-6350][Mesos] Make mesosExecutorCores co...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5063#issuecomment-82816664 [Test build #28787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28787/consoleFull) for PR 5063 at commit

[GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...

2015-03-18 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4537#issuecomment-82816799 @koeninger , kafka 0.8.2.1 was [released](https://archive.apache.org/dist/kafka/0.8.2.1/RELEASE_NOTES.html), can it be upgrade this version? --- If your project is set

[GitHub] spark pull request: [SPARK-5821] [SQL] JSON CTAS command should th...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4610#issuecomment-82816363 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6350][Mesos] Make mesosExecutorCores co...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5063#issuecomment-82856154 [Test build #28787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28787/consoleFull) for PR 5063 at commit

[GitHub] spark pull request: [SPARK-6364] [MLlib] Implement equals and hash...

2015-03-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5081#issuecomment-82897129 What's the use case for comparing matrices for equality? I think it's rarer than for vectors. Is it just for testing, mostly? --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-6315] [SQL] Also tries the case class s...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5034#issuecomment-82896062 [Test build #28794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28794/consoleFull) for PR 5034 at commit

[GitHub] spark pull request: SPARK-6085 Part. 2 Increase default value for ...

2015-03-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5065#issuecomment-82895967 Yes MB and MiB are different things. It looks like Mesos says it uses MB so I'd match that, I suppose. Are you saying that Mesos doc is wrong? --- If your project is set

[GitHub] spark pull request: [SPARK-6364] [MLlib] Implement equals and hash...

2015-03-18 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/5081#issuecomment-82901714 Yes, I required it in this PR https://github.com/apache/spark/pull/5048/ to test that the matrices after serializing and deserializing are the same. (Also given the

[GitHub] spark pull request: [SPARK-6392][SQL]Minor fix ClassNotFound excep...

2015-03-18 Thread jeanlyn
Github user jeanlyn commented on the pull request: https://github.com/apache/spark/pull/5079#issuecomment-82908034 Updated, @liancheng @marmbrus I had tried to add a test for this patch,could you take a look for the test? --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [WIP] [SPARK-5654] Integrate SparkR into Apach...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5077#issuecomment-82813238 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5205][Streaming]:Inconsistent behaviour...

2015-03-18 Thread uncleGen
Github user uncleGen commented on the pull request: https://github.com/apache/spark/pull/4135#issuecomment-82844745 @JoshRosen Could you please take a look again, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-5205][Streaming]:Inconsistent behaviour...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4135#issuecomment-82844809 [Test build #28788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28788/consoleFull) for PR 4135 at commit

[GitHub] spark pull request: [SPARK-6350][Mesos] Make mesosExecutorCores co...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5063#issuecomment-82856184 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-6085 Part. 2 Increase default value for ...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5065#issuecomment-82856285 [Test build #28786 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28786/consoleFull) for PR 5065 at commit

[GitHub] spark pull request: SPARK-6085 Part. 2 Increase default value for ...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5065#issuecomment-82856317 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-5068][SQL]Fix bug query data when path ...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5059#issuecomment-82887863 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-5068][SQL]Fix bug query data when path ...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5059#issuecomment-82887857 [Test build #28791 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28791/consoleFull) for PR 5059 at commit

[GitHub] spark pull request: [Spark-5068][SQL]Fix bug query data when path ...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5059#issuecomment-82887730 [Test build #28791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28791/consoleFull) for PR 5059 at commit

[GitHub] spark pull request: [WIP] [SPARK-5654] Integrate SparkR into Apach...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5077#issuecomment-82813218 [Test build #28779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28779/consoleFull) for PR 5077 at commit

[GitHub] spark pull request: [SPARK-6364] [MLlib] Implement equals and hash...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5081#issuecomment-82846862 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6364] [MLlib] Implement equals and hash...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5081#issuecomment-82846851 [Test build #28785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28785/consoleFull) for PR 5081 at commit

[GitHub] spark pull request: [SPARK-6117] [SQL] add describe function to Da...

2015-03-18 Thread azagrebin
Github user azagrebin commented on the pull request: https://github.com/apache/spark/pull/5073#issuecomment-82857943 I have done one aggregation, splitten it locally into resulting DataFrame supplemented with schema and statistic names. I have also created nested version of standard

[GitHub] spark pull request: [SPARK-6397][SQL] Check the missingInput simpl...

2015-03-18 Thread watermen
GitHub user watermen opened a pull request: https://github.com/apache/spark/pull/5082 [SPARK-6397][SQL] Check the missingInput simply You can merge this pull request into a Git repository by running: $ git pull https://github.com/watermen/spark sql-missingInput Alternatively

[GitHub] spark pull request: [MLLib]SPARK-6348:Enable useFeatureScaling in ...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5055#issuecomment-82810886 [Test build #28782 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28782/consoleFull) for PR 5055 at commit

[GitHub] spark pull request: [MLLib]SPARK-6348:Enable useFeatureScaling in ...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5055#issuecomment-82810891 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6315] [SQL] Also tries the case class s...

2015-03-18 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/5034#issuecomment-82832293 Good point. Updating the code and adding the test case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-6117] [SQL] add describe function to Da...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5073#issuecomment-82857207 [Test build #28790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28790/consoleFull) for PR 5073 at commit

[GitHub] spark pull request: [SPARK-6117] [SQL] add describe function to Da...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5073#issuecomment-82862423 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5205][Streaming]:Inconsistent behaviour...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4135#issuecomment-82889057 [Test build #28788 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28788/consoleFull) for PR 4135 at commit

[GitHub] spark pull request: [SPARK-6364] [MLlib] Implement equals and hash...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5081#issuecomment-82808948 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6350][Mesos] Make mesosExecutorCores co...

2015-03-18 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/spark/pull/5063#issuecomment-82812556 @sryza I mean the former one. I agree to your opinion of `spark.executor.frameworkCores`, and I have one more question. Do you think It's good to update

[GitHub] spark pull request: [SPARK-6364] [MLlib] Implement equals and hash...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5081#issuecomment-82812618 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6364] [MLlib] Implement equals and hash...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5081#issuecomment-82812607 [Test build #28783 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28783/consoleFull) for PR 5081 at commit

[GitHub] spark pull request: [SPARK-6350][Mesos] Make mesosExecutorCores co...

2015-03-18 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/spark/pull/5063#issuecomment-82821343 @sryza What do you think of @tnachen's opinion? For avoiding this confusion, I added comments that this configuration is being used on mesos fine-grained mode. Is it

[GitHub] spark pull request: [SPARK-6397][SQL] Check the missingInput simpl...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5082#issuecomment-82875822 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6392][SQL]Minor fix ClassNotFound excep...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5079#issuecomment-82888519 [Test build #28792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28792/consoleFull) for PR 5079 at commit

[GitHub] spark pull request: [SPARK-6315] [SQL] Also tries the case class s...

2015-03-18 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/5034#issuecomment-82895187 Addressed comments and added test case. Thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-6350][Mesos] Make mesosExecutorCores co...

2015-03-18 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/5063#issuecomment-82818930 It is cores allocated for the custom executor that Spark launches with Mesos. We can call it frameworkCores, but what will this mean outside of Mesos context?

[GitHub] spark pull request: [SPARK-5205][Streaming]:Inconsistent behaviour...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4135#issuecomment-82889063 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6315] [SQL] Also tries the case class s...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5034#issuecomment-82891525 [Test build #28793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28793/consoleFull) for PR 5034 at commit

[GitHub] spark pull request: [Spark-5068][SQL]Fix bug query data when path ...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5059#issuecomment-82931839 [Test build #28796 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28796/consoleFull) for PR 5059 at commit

[GitHub] spark pull request: [SPARK-6286][minor] Handle missing Mesos case ...

2015-03-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5000#issuecomment-82964841 LGTM. That's a nice refactoring too to remove the 3x duplication of the 'finished' logic. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-6392][SQL]Minor fix ClassNotFound excep...

2015-03-18 Thread jeanlyn
Github user jeanlyn commented on the pull request: https://github.com/apache/spark/pull/5079#issuecomment-82976538 Ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-6364] [MLlib] Implement equals and hash...

2015-03-18 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5081#discussion_r26664035 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -100,6 +100,50 @@ sealed trait Matrix extends Serializable { *

[GitHub] spark pull request: [SPARK-6364] [MLlib] Implement equals and hash...

2015-03-18 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5081#discussion_r26664038 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -100,6 +100,50 @@ sealed trait Matrix extends Serializable { *

[GitHub] spark pull request: [Spark-5068][SQL]Fix bug query data when path ...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5059#issuecomment-82924647 [Test build #28795 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28795/consoleFull) for PR 5059 at commit

[GitHub] spark pull request: [Spark-5068][SQL]Fix bug query data when path ...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5059#issuecomment-82924201 [Test build #28795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28795/consoleFull) for PR 5059 at commit

[GitHub] spark pull request: [SPARK-4012] stop SparkContext when the except...

2015-03-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5004#issuecomment-82923397 I don't have a strong opinion on this one. I suppose there's a question of what may happen if you stop the `SparkContext` but then immediately kill the calling thread

[GitHub] spark pull request: [SPARK-6315] [SQL] Also tries the case class s...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5034#issuecomment-82945682 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6315] [SQL] Also tries the case class s...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5034#issuecomment-82945663 [Test build #28793 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28793/consoleFull) for PR 5034 at commit

[GitHub] spark pull request: [SPARK-6392][SQL]Minor fix ClassNotFound excep...

2015-03-18 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/5079#issuecomment-82967018 Hm, the problem is that we should also add the source code of `hello.jar` (probably after renaming it to `TestUdf.jar`). But I'm not quite sure where to put it for

[GitHub] spark pull request: [SPARK-6325] [core,yarn] Do not change target ...

2015-03-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5018 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-6371] [build] Update version to 1.4.0-S...

2015-03-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5056#issuecomment-82969854 Paging @ankurdave : `graphx` should not be excluded from MiMa now right? Paging @mengxr : `ml` still needs to be excluded I imagine? --- If your project is set up for

[GitHub] spark pull request: [SPARK-6025] [MLlib] Add helper method evaluat...

2015-03-18 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/4906#issuecomment-82982129 @jkbradley I have a silly query that I cannot refrain from asking. If a point is predicted correctly, then the contribution of log loss due to that point

[GitHub] spark pull request: [SPARK-6392][SQL]Minor fix ClassNotFound excep...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5079#issuecomment-82935967 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4655][Core] Split Stage into ShuffleMap...

2015-03-18 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/4708#issuecomment-82966858 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6315] [SQL] Also tries the case class s...

2015-03-18 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/5034#issuecomment-82968721 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6364] [MLlib] Implement equals and hash...

2015-03-18 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/5081#issuecomment-82979809 The hashCode implementation was taken from Effective Java: http://stackoverflow.com/questions/10915309/need-explanation-for-hashcode-example-in-effective-java-textbook

[GitHub] spark pull request: [SPARK-4229] Create hadoop configuration in a ...

2015-03-18 Thread koeninger
Github user koeninger commented on the pull request: https://github.com/apache/spark/pull/3543#issuecomment-82923505 I think its mostly a question of whether committers are comfortable with a PR that changes all of the uses of new Configuration. At this point it'd probably

[GitHub] spark pull request: [SPARK-6392][SQL]Minor fix ClassNotFound excep...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5079#issuecomment-82935924 [Test build #28792 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28792/consoleFull) for PR 5079 at commit

[GitHub] spark pull request: [Spark-5068][SQL]Fix bug query data when path ...

2015-03-18 Thread lazyman500
Github user lazyman500 commented on the pull request: https://github.com/apache/spark/pull/5059#issuecomment-82946111 Thanks for your review. I feel so sorry to make so much style mistakes. I have added config flag. But how does user know this config? Do I need add some document

[GitHub] spark pull request: [Spark-5068][SQL]Fix bug query data when path ...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5059#issuecomment-82965974 [Test build #28796 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28796/consoleFull) for PR 5059 at commit

[GitHub] spark pull request: [ML][FEATURE] SPARK-5566: RegEx Tokenizer

2015-03-18 Thread aborsu985
Github user aborsu985 commented on the pull request: https://github.com/apache/spark/pull/4504#issuecomment-82969443 Thank you for the tip, I'll look into the java tests next week when I have some time. But in the meantime. I changed the RegexTokenizer to extend from Tokenizer

[GitHub] spark pull request: [SPARK-6207] [YARN] [SQL] Adds delegation toke...

2015-03-18 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/5031#issuecomment-82974636 jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [Core] SPARK-5954: Top by key

2015-03-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5075#issuecomment-82974699 Looking good, but what about the Java / Python APIs too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: SPARK-6338 [CORE] Use standard temp dir mechan...

2015-03-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5029#issuecomment-82981736 Let me see if I can also refactor that bit of code in `TestHive` too, yeah. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-6207] [YARN] [SQL] Adds delegation toke...

2015-03-18 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/5031#issuecomment-82981811 thanks for providing the patch. Which versions of Hive have you tested this with? I'm trying to build with a hive 13 version (not the official 0.13.1 though)

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-18 Thread jeanlyn
Github user jeanlyn commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-82926819 Hi, @marmbrus ,I had update the code as you mentioned about. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-6315] [SQL] Also tries the case class s...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5034#issuecomment-82943937 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6315] [SQL] Also tries the case class s...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5034#issuecomment-82943906 [Test build #28794 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28794/consoleFull) for PR 5034 at commit

[GitHub] spark pull request: [SPARK-6372] [core] Propagate --conf to child ...

2015-03-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5057 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-6374] [MLlib] add get for GeneralizedLi...

2015-03-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/5058#discussion_r26661365 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/GeneralizedLinearAlgorithm.scala --- @@ -142,6 +147,11 @@ abstract class

[GitHub] spark pull request: [SPARK-5750][SPARK-3441][SPARK-5836][CORE] Add...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5074#issuecomment-82970327 [Test build #28799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28799/consoleFull) for PR 5074 at commit

[GitHub] spark pull request: [SPARK-5955][MLLIB] add checkpointInterval to ...

2015-03-18 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5076#discussion_r26662455 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -528,10 +538,22 @@ object ALS extends Logging { itemFactors =

[GitHub] spark pull request: [Core] SPARK-5954: Top by key

2015-03-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/5075#discussion_r26662472 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -163,6 +163,28 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)]) }

[GitHub] spark pull request: SPARK-6389 YARN app diagnostics report doesn't...

2015-03-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5070 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-6286][minor] Handle missing Mesos case ...

2015-03-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5000 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [Spark-5068][SQL]Fix bug query data when path ...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5059#issuecomment-82965990 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4286][MESOS] Add an external shuffle se...

2015-03-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4990#issuecomment-82968423 Hm, since this is adding a bit of a new API / service, I don't feel qualified to merge this myself. I'd prefer to get a second nod from @rxin --- If your project is set

[GitHub] spark pull request: [SPARK-4655][Core] Split Stage into ShuffleMap...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4708#issuecomment-82968381 [Test build #28797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28797/consoleFull) for PR 4708 at commit

[GitHub] spark pull request: [ML][FEATURE] SPARK-5566: RegEx Tokenizer

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4504#issuecomment-82968292 [Test build #28798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28798/consoleFull) for PR 4504 at commit

[GitHub] spark pull request: [SPARK-6392][SQL]Minor fix ClassNotFound excep...

2015-03-18 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/5079#issuecomment-82972253 Your test case itself makes sense. Let's wait for more comments first :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [MLLib]SPARK-6348:Enable useFeatureScaling in ...

2015-03-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5055#issuecomment-82972107 Hm, maybe. I am sort of reluctant to add yet another utility method overload to expose this when we could just add it as a setter. @mengxr did you say you also favored

[GitHub] spark pull request: [SPARK-5955][MLLIB] add checkpointInterval to ...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5076#issuecomment-82977353 [Test build #28801 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28801/consoleFull) for PR 5076 at commit

[GitHub] spark pull request: [SPARK-3533][Core][PySpark] Add saveAsTextFile...

2015-03-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4895#issuecomment-82981094 ``` [error] /home/jenkins/workspace/SparkPullRequestBuilder/core/src/test/scala/org/apache/spark/api/python/PythonRDDSuite.scala:71: class RDDMultipleTextOutputFormat

[GitHub] spark pull request: [Spark-5068][SQL]Fix bug query data when path ...

2015-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5059#issuecomment-82924654 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6315] [SQL] Also tries the case class s...

2015-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5034#issuecomment-82970364 [Test build #28800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28800/consoleFull) for PR 5034 at commit

[GitHub] spark pull request: [SPARK-6392][SQL]Minor fix ClassNotFound excep...

2015-03-18 Thread jeanlyn
Github user jeanlyn commented on the pull request: https://github.com/apache/spark/pull/5079#issuecomment-82970359 Thanks @liancheng for explain.You are right,it need consider more about it.So,should i remove the test? --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-3533][Core][PySpark] Add saveAsTextFile...

2015-03-18 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/4895#issuecomment-82979728 All - any idea why this would be failing? I don't see any specific compilation errors. Attempting to build locally, I see some strange failures both in this branch and

[GitHub] spark pull request: [SPARK-6364] [MLlib] Implement equals and hash...

2015-03-18 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5081#discussion_r26664031 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -100,6 +100,50 @@ sealed trait Matrix extends Serializable { *

  1   2   3   4   5   >