[GitHub] spark pull request: [SPARK-8764][ML] string indexer should take op...

2015-08-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/7266#issuecomment-130005875 LGTM, merging with master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9704] [ML] Made ProbabilisticClassifier...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8004#issuecomment-130005913 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-130005585 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-130005471 [Test build #40480 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40480/console) for PR 7957 at commit [`290ff75`](https://github.

[GitHub] spark pull request: [SPARK-9788][MLlib] Fix LDA Binary Compatibili...

2015-08-11 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8077#issuecomment-130005342 @jkbradley This PR doesn't need a PySpark update. Eventually, `PythonMLLibAPI.scala` will need to be updated to support asymmetric priors, hyperparam optimizations,

[GitHub] spark pull request: [SPARK-9750][MLlib] Improve equals on SparseMa...

2015-08-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8042#issuecomment-130005026 LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-9704] [ML] Made ProbabilisticClassifier...

2015-08-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8004#issuecomment-130004808 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9788][MLlib] Fix LDA Binary Compatibili...

2015-08-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8077#issuecomment-130004579 (Are you updating PySpark in a separate PR?) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-9788][MLlib] Fix LDA Binary Compatibili...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8077#issuecomment-130004735 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9826][Core] Fix cannot use custom class...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8109#issuecomment-130004390 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-9788][MLlib] Fix LDA Binary Compatibili...

2015-08-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8077#issuecomment-130004531 LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-9826][Core] Fix cannot use custom class...

2015-08-11 Thread michellemay
GitHub user michellemay opened a pull request: https://github.com/apache/spark/pull/8109 [SPARK-9826][Core] Fix cannot use custom classes in log4j.properties Refactor Utils class and create ShutdownHookManager. NOTE: Wasn't able to run /dev/run-tests on windows machine.

[GitHub] spark pull request: [SPARK-9673][SQL] Sample standard deviation ag...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8058#issuecomment-130003362 [Test build #40490 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40490/consoleFull) for PR 8058 at commit [`a170f43`](https://gith

[GitHub] spark pull request: [SPARK-9073][ML] spark.ml Models copy() should...

2015-08-11 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7447#discussion_r36779944 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala --- @@ -111,6 +112,22 @@ class CrossValidatorSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-9073][ML] spark.ml Models copy() should...

2015-08-11 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7447#discussion_r36779936 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GBTRegressorSuite.scala --- @@ -89,6 +90,22 @@ class GBTRegressorSuite extends SparkFunSuite w

[GitHub] spark pull request: [SPARK-9073][ML] spark.ml Models copy() should...

2015-08-11 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7447#discussion_r36779924 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala --- @@ -45,6 +46,9 @@ class BucketizerSuite extends SparkFunSuite with MLl

[GitHub] spark pull request: [SPARK-9073][ML] spark.ml Models copy() should...

2015-08-11 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7447#discussion_r36779920 --- Diff: mllib/src/test/scala/org/apache/spark/ml/PipelineSuite.scala --- @@ -92,6 +93,7 @@ class PipelineSuite extends SparkFunSuite { val copied

[GitHub] spark pull request: [SPARK-9073][ML] spark.ml Models copy() should...

2015-08-11 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7447#discussion_r36779933 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala --- @@ -61,6 +62,16 @@ class DecisionTreeRegressorSuite exte

[GitHub] spark pull request: [SPARK-9073][ML] spark.ml Models copy() should...

2015-08-11 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7447#discussion_r36779921 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala --- @@ -19,8 +19,9 @@ package org.apache.spark.ml.class

[GitHub] spark pull request: [SPARK-9073][ML] spark.ml Models copy() should...

2015-08-11 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7447#discussion_r36779949 --- Diff: mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala --- @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-9073][ML] spark.ml Models copy() should...

2015-08-11 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7447#discussion_r36779940 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala --- @@ -71,6 +72,14 @@ class RandomForestRegressorSuite exte

[GitHub] spark pull request: [SPARK-9073][ML] spark.ml Models copy() should...

2015-08-11 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7447#discussion_r36779871 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaDeveloperApiExample.java --- @@ -230,6 +230,7 @@ public Vector predictRaw(Vector features

[GitHub] spark pull request: [SPARK-9073][ML] spark.ml Models copy() should...

2015-08-11 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7447#discussion_r36779874 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/DeveloperApiExample.scala --- @@ -180,6 +180,7 @@ private class MyLogisticRegressionModel(

[GitHub] spark pull request: [SPARK-9788][MLlib] Fix LDA Binary Compatibili...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8077#issuecomment-130002897 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9673][SQL] Sample standard deviation ag...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8058#issuecomment-130002855 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9788][MLlib] Fix LDA Binary Compatibili...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8077#issuecomment-130002846 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9673][SQL] Sample standard deviation ag...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8058#issuecomment-130002898 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-130002906 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9092] Fixed incompatibility when both n...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7657#issuecomment-130002773 [Test build #40489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40489/consoleFull) for PR 7657 at commit [`6da06c4`](https://gith

[GitHub] spark pull request: [SPARK-9788][MLlib] Fix LDA Binary Compatibili...

2015-08-11 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8077#discussion_r36779483 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -455,8 +455,9 @@ class DistributedLDAModel private[clustering] (

[GitHub] spark pull request: [SPARK-9788][MLlib] Fix LDA Binary Compatibili...

2015-08-11 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8077#discussion_r36779393 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDA.scala --- @@ -110,14 +125,17 @@ class LDA private ( this --- End diff -

[GitHub] spark pull request: [SPARK-9704] [ML] Made ProbabilisticClassifier...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8004#issuecomment-130001951 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9788][MLlib] Fix LDA Binary Compatibili...

2015-08-11 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8077#discussion_r36779185 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDA.scala --- @@ -79,7 +79,22 @@ class LDA private ( * * This is the par

[GitHub] spark pull request: [SPARK-9788][MLlib] Fix LDA Binary Compatibili...

2015-08-11 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8077#discussion_r36779192 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDA.scala --- @@ -79,7 +79,22 @@ class LDA private ( * * This is the par

[GitHub] spark pull request: [SPARK-9750][MLlib] Improve equals on SparseMa...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8042#issuecomment-130001690 [Test build #40488 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40488/consoleFull) for PR 8042 at commit [`bb70d5e`](https://gith

[GitHub] spark pull request: [SPARK-9092] Fixed incompatibility when both n...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7657#issuecomment-130001677 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9092] Fixed incompatibility when both n...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7657#issuecomment-130001656 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9750][MLlib] Improve equals on SparseMa...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8042#issuecomment-130001665 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9750][MLlib] Improve equals on SparseMa...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8042#issuecomment-130001633 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9092] Fixed incompatibility when both n...

2015-08-11 Thread neurons
Github user neurons commented on the pull request: https://github.com/apache/spark/pull/7657#issuecomment-130001489 Thank you @vanzin and @andrewor14 for your reviews. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: [SPARK-9704] [ML] Made ProbabilisticClassifier...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8004#issuecomment-130001379 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9704] [ML] Made ProbabilisticClassifier...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8004#issuecomment-130001265 [Test build #40467 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40467/console) for PR 8004 at commit [`7ff0768`](https://github.

[GitHub] spark pull request: [SPARK-9673][SQL] Sample standard deviation ag...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8058#issuecomment-130001192 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9673][SQL] Sample standard deviation ag...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8058#issuecomment-130001176 [Test build #40486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40486/console) for PR 8058 at commit [`29cc149`](https://github.

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-130001073 [Test build #40487 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40487/consoleFull) for PR 7957 at commit [`27e2435`](https://gith

[GitHub] spark pull request: [SPARK-9789] [ML] Added logreg threshold param...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8079#issuecomment-13851 [Test build #40484 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40484/consoleFull) for PR 8079 at commit [`4ea4f2f`](https://gith

[GitHub] spark pull request: [SPARK-9092] Fixed incompatibility when both n...

2015-08-11 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/7657#issuecomment-13800 Alright, LGTM. Let's try jenkins again. retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-9092] Fixed incompatibility when both n...

2015-08-11 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/7657#issuecomment-13846 (I'll try to run some local tests later on too.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-9750][MLlib] Improve equals on SparseMa...

2015-08-11 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8042#discussion_r36778671 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -257,7 +257,7 @@ class DenseMatrix( this(numRows, numCols, va

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-13194 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9704] [ML] Made ProbabilisticClassifier...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8004#issuecomment-13159 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9673][SQL] Sample standard deviation ag...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8058#issuecomment-13117 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-13131 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9673][SQL] Sample standard deviation ag...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8058#issuecomment-13160 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9673][SQL] Sample standard deviation ag...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8058#issuecomment-13319 [Test build #40486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40486/consoleFull) for PR 8058 at commit [`29cc149`](https://gith

[GitHub] spark pull request: [SPARK-9789] [ML] Added logreg threshold param...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8079#issuecomment-13132 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9789] [ML] Added logreg threshold param...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8079#issuecomment-13105 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9704] [ML] Made ProbabilisticClassifier...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8004#issuecomment-13123 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9789] [ML] Added logreg threshold param...

2015-08-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8079#issuecomment-129998730 jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9704] [ML] Made ProbabilisticClassifier...

2015-08-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8004#issuecomment-129998597 Thanks for looking--updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9789] [ML] Added logreg threshold param...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8079#issuecomment-129998395 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-129998144 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9789] [ML] Added logreg threshold param...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8079#issuecomment-129998106 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-129998072 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9789] [ML] Added logreg threshold param...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8079#issuecomment-129998048 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9789] [ML] Added logreg threshold param...

2015-08-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8079#issuecomment-129997308 OK, that update should enforce equivalence when both are set. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-9814][SQL] EqualNotNull not passing to ...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8096#issuecomment-129996473 [Test build #40481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40481/consoleFull) for PR 8096 at commit [`b3fe5d3`](https://gith

[GitHub] spark pull request: [SPARK-8345] [ML] Add an SQL node as a feature...

2015-08-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7465#issuecomment-129996456 LGTM. Merged into master. I think it is okay if the output columns do not contain all input columns. It is not a requirement for transformers in the pipeline API. Thanks

[GitHub] spark pull request: [SPARK-8345] [ML] Add an SQL node as a feature...

2015-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7465 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9439] [wip] [yarn] External shuffle ser...

2015-08-11 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/7943#issuecomment-129994372 This is looking good, just left some minor comments; main thing is documenting what is allowed to be changed when versions are updated, and what is a "major" update. I pr

[GitHub] spark pull request: [SPARK-9439] [wip] [yarn] External shuffle ser...

2015-08-11 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7943#discussion_r36776454 --- Diff: yarn/src/test/scala/org/apache/spark/network/yarn/YarnShuffleServiceSuite.scala --- @@ -0,0 +1,234 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark pull request: [SPARK-9814][SQL] EqualNotNull not passing to ...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8096#issuecomment-129993925 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9814][SQL] EqualNotNull not passing to ...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8096#issuecomment-129993866 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9439] [wip] [yarn] External shuffle ser...

2015-08-11 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7943#discussion_r36776426 --- Diff: yarn/src/test/scala/org/apache/spark/network/yarn/YarnShuffleServiceSuite.scala --- @@ -0,0 +1,234 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark pull request: [SPARK-9704] [ML] Made ProbabilisticClassifier...

2015-08-11 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/spark/pull/8004#discussion_r36776411 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala --- @@ -205,7 +205,11 @@ private[spark] abstract class Pr

[GitHub] spark pull request: [SPARK-9439] [wip] [yarn] External shuffle ser...

2015-08-11 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7943#discussion_r36776361 --- Diff: yarn/src/test/scala/org/apache/spark/network/yarn/YarnShuffleServiceSuite.scala --- @@ -0,0 +1,234 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark pull request: [SPARK-9814][SQL] EqualNotNull not passing to ...

2015-08-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8096#issuecomment-129992683 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-9439] [wip] [yarn] External shuffle ser...

2015-08-11 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7943#discussion_r36775991 --- Diff: network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java --- @@ -252,4 +338,118 @@ public String toString()

[GitHub] spark pull request: [SPARK-9789] [ML] Added logreg threshold param...

2015-08-11 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8079#discussion_r36775475 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -43,36 +42,60 @@ import org.apache.spark.storage.StorageL

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-129990393 cc @marmbrus , I think this solution is better :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: [SPARK-9795] Dynamic allocation: avoid double ...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8078#issuecomment-129990321 [Test build #40479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40479/consoleFull) for PR 8078 at commit [`fb149da`](https://gith

[GitHub] spark pull request: [SPARK-9806] [WEB UI] Don't share ReplayListen...

2015-08-11 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/spark/pull/8088#issuecomment-129990128 Yeah, I noticed that in my other PR as well. :-( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-129989580 [Test build #40480 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40480/consoleFull) for PR 7957 at commit [`290ff75`](https://gith

[GitHub] spark pull request: [SPARK-9795] Dynamic allocation: avoid double ...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8078#issuecomment-129989036 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9795] Dynamic allocation: avoid double ...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8078#issuecomment-129988960 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-129988977 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-129989035 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9795] Dynamic allocation: avoid double ...

2015-08-11 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8078#discussion_r36774914 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -422,16 +422,19 @@ class CoarseGrainedSchedule

[GitHub] spark pull request: [SPARK-8889] [Core]: Fix for OOM for graph cre...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7602#issuecomment-129987009 [Test build #40478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40478/consoleFull) for PR 7602 at commit [`3fb5271`](https://gith

[GitHub] spark pull request: [SPARK-9426][WebUI]Job page DAG visualization ...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8104#issuecomment-129987127 [Test build #40477 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40477/consoleFull) for PR 8104 at commit [`f3119a4`](https://gith

[GitHub] spark pull request: Fix comment error

2015-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8097 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-8889] [Core]: Fix for OOM for graph cre...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7602#issuecomment-129986486 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9795] Dynamic allocation: avoid double ...

2015-08-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8078#issuecomment-129986804 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-8889] [Core]: Fix for OOM for graph cre...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7602#issuecomment-129986450 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9426][WebUI]Job page DAG visualization ...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8104#issuecomment-129986464 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9426][WebUI]Job page DAG visualization ...

2015-08-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8104#issuecomment-129986345 Actually, this LGTM. Thanks for fixing another blocker! I'm going to try this out locally. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-9426][WebUI]Job page DAG visualization ...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8104#issuecomment-129986441 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9426][WebUI]Job page DAG visualization ...

2015-08-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8104#issuecomment-129986380 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: Fix comment error

2015-08-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8097#issuecomment-129986255 yup - merging this. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-8889] [Core]: Fix for OOM for graph cre...

2015-08-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/7602#issuecomment-129985234 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

<    4   5   6   7   8   9   10   11   12   13   >