[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread sureshthalamati
Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140519265 @rxin Thank you for reviewing the patch . Just to make sure tested with out the next() call on MySql, Postgres, and DB2, it worked fine. Updated the pull re

[GitHub] spark pull request: SPARK-10611 Clone Configuration for each task ...

2015-09-15 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/8763#issuecomment-140518870 This seems like it could have a pretty serious perf impact. Are we able to do some benchmarking to assess this? --- If your project is set up for it, you can reply to t

[GitHub] spark pull request: [SPARK-9652][CORE] Added method for Avro file ...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7971#issuecomment-140518956 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9652][CORE] Added method for Avro file ...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7971#issuecomment-140518933 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10595] [ML] [MLLIB] [DOCS] Various ML g...

2015-09-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8752#discussion_r39555841 --- Diff: docs/mllib-feature-extraction.md --- @@ -380,35 +380,37 @@ data2 = labels.zip(normalizer2.transform(features)) -## Feature se

[GitHub] spark pull request: [SPARK-10595] [ML] [MLLIB] [DOCS] Various ML g...

2015-09-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8752#discussion_r39555824 --- Diff: docs/ml-guide.md --- @@ -32,7 +32,18 @@ See the [algorithm guides](#algorithm-guides) section below for guides on sub-pa * This will become a

[GitHub] spark pull request: [SPARK-2788] [STREAMING] Add location filterin...

2015-09-15 Thread sjbrunst
Github user sjbrunst closed the pull request at: https://github.com/apache/spark/pull/1717 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] spark pull request: [DOCS] Small fixes to Spark on Yarn doc

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8762 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [DOCS] Small fixes to Spark on Yarn doc

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8762#issuecomment-140516066 [Test build #1759 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1759/consoleFull) for PR 8762 at commit [`00e36b2`](https://git

[GitHub] spark pull request: [SPARK-3650] Fix TriangleCount handling of rev...

2015-09-15 Thread insidedctm
Github user insidedctm commented on the pull request: https://github.com/apache/spark/pull/2495#issuecomment-140515615 @pwendell can this be opened again? As per my discussion on the the JIRA ticket this is an issue that came up on the mailing list recently. --- If your project is s

[GitHub] spark pull request: [SPARK-8673] [launcher] API and infrastructure...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7052#issuecomment-140515074 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARK-8673] [launcher] API and infrastructure...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7052#issuecomment-140515068 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8673] [launcher] API and infrastructure...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7052#issuecomment-140514928 [Test build #42494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42494/console) for PR 7052 at commit [`bf92906`](https://github.

[GitHub] spark pull request: SPARK-10611 Clone Configuration for each task ...

2015-09-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8763#discussion_r39554934 --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala --- @@ -230,12 +251,16 @@ class NewHadoopRDD[K, V]( super.persist(storageLevel

[GitHub] spark pull request: SPARK-10611 Clone Configuration for each task ...

2015-09-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8763#discussion_r39554743 --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala --- @@ -230,12 +251,16 @@ class NewHadoopRDD[K, V]( super.persist(storageLevel

[GitHub] spark pull request: [SPARK-8341] Significant selector feature tran...

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6795 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-3181][MLLIB]: Add Robust Regression Alg...

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2096 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [STREAMING]There is a dependent package confli...

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8738 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-3181][MLLIB]: Add Robust Regression Alg...

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7722 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: Master

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8767 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-1655][MLLIB] WIP Add option for distrib...

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-8341] Significant selector feature tran...

2015-09-15 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/6795#issuecomment-140508947 @catap I'm going to close this PR for now. Please submit it as a Spark package at http://spark-packages.org if you want to provide this implementation to others. Thanks!

[GitHub] spark pull request: [SPARK-10511][BUILD] Reset git repository befo...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8774#issuecomment-140508915 [Test build #1758 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1758/consoleFull) for PR 8774 at commit [`a954b2a`](https://git

[GitHub] spark pull request: [SPARK-10511][BUILD] Reset git repository befo...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8774#issuecomment-140508663 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-10511][BUILD] Reset git repository befo...

2015-09-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/8774#issuecomment-140508440 This is perfect, thanks. LGTM. Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [PySpark][MLlib][Docs] Replaced addversion wit...

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8773 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [PySpark][MLlib][Docs] Replaced addversion wit...

2015-09-15 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8773#issuecomment-140507819 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10511][BUILD] Reset git repository befo...

2015-09-15 Thread lresende
GitHub user lresende opened a pull request: https://github.com/apache/spark/pull/8774 [SPARK-10511][BUILD] Reset git repository before packaging source distro The calculation of Spark version is downloading Scala and Zinc in the build directory which is inflating the size of

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-15 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8700#discussion_r39553301 --- Diff: python/pyspark/mllib/recommendation.py --- @@ -156,6 +166,18 @@ def recommendProducts(self, user, num): """ return list(self

[GitHub] spark pull request: [PySpark][MLlib][Docs] Replaced addversion wit...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8773#issuecomment-140507521 [Test build #42498 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42498/console) for PR 8773 at commit [`a21e0ca`](https://github.

[GitHub] spark pull request: [PySpark][MLlib][Docs] Replaced addversion wit...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8773#issuecomment-140507660 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [PySpark][MLlib][Docs] Replaced addversion wit...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8773#issuecomment-140507659 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-15 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8700#discussion_r39553213 --- Diff: python/pyspark/mllib/recommendation.py --- @@ -85,6 +85,16 @@ class MatrixFactorizationModel(JavaModelWrapper, JavaSaveable, JavaLoader): >>

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-15 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8700#discussion_r39553076 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/MatrixFactorizationModelWrapper.scala --- @@ -42,4 +42,15 @@ private[python] class MatrixFac

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-15 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8700#discussion_r39553069 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/MatrixFactorizationModelWrapper.scala --- @@ -42,4 +42,15 @@ private[python] class MatrixFac

[GitHub] spark pull request: [PySpark][MLlib][Docs] Replaced addversion wit...

2015-09-15 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8773#issuecomment-140506729 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: [SPARK-10277][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8684#discussion_r39552511 --- Diff: python/pyspark/mllib/regression.py --- @@ -93,8 +101,11 @@ class LinearRegressionModelBase(LinearModel): True >>> abs(lrmb.predi

[GitHub] spark pull request: [SPARK-10593] [SQL] fix resolve output of Gene...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8755#issuecomment-140506048 [Test build #1757 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1757/console) for PR 8755 at commit [`887474e`](https://github

[GitHub] spark pull request: [SPARK-10277][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8684#discussion_r39552470 --- Diff: python/pyspark/mllib/regression.py --- @@ -65,6 +67,8 @@ class LinearModel(object): :param weights: Weights computed for every feat

[GitHub] spark pull request: SPARK-10611 Clone Configuration for each task ...

2015-09-15 Thread mingyukim
Github user mingyukim commented on a diff in the pull request: https://github.com/apache/spark/pull/8763#discussion_r39552283 --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala --- @@ -230,12 +251,16 @@ class NewHadoopRDD[K, V]( super.persist(storageLevel

[GitHub] spark pull request: [SPARK-10277][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8684#discussion_r39552087 --- Diff: python/pyspark/mllib/regression.py --- @@ -42,6 +42,8 @@ class LabeledPoint(object): column matrix) Note: 'label'

[GitHub] spark pull request: SPARK-10611 Clone Configuration for each task ...

2015-09-15 Thread mingyukim
Github user mingyukim commented on a diff in the pull request: https://github.com/apache/spark/pull/8763#discussion_r39552025 --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala --- @@ -230,12 +251,16 @@ class NewHadoopRDD[K, V]( super.persist(storageLevel

[GitHub] spark pull request: [SPARK-9708] [MESOS] Spark should create local...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8358#issuecomment-140504197 [Test build #42492 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42492/console) for PR 8358 at commit [`280a4d7`](https://github.

[GitHub] spark pull request: [SPARK-9708] [MESOS] Spark should create local...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8358#issuecomment-140504282 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9708] [MESOS] Spark should create local...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8358#issuecomment-140504285 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [PySpark][MLlib][Docs] Replaced addversion wit...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8773#issuecomment-140503480 [Test build #42498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42498/consoleFull) for PR 8773 at commit [`a21e0ca`](https://gith

[GitHub] spark pull request: SPARK-10611 Clone Configuration for each task ...

2015-09-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8763#discussion_r39551271 --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala --- @@ -230,12 +251,16 @@ class NewHadoopRDD[K, V]( super.persist(storageLevel

[GitHub] spark pull request: SPARK-10611 Clone Configuration for each task ...

2015-09-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8763#discussion_r39551037 --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala --- @@ -230,12 +251,16 @@ class NewHadoopRDD[K, V]( super.persist(storageLevel

[GitHub] spark pull request: [SPARK-10593] [SQL] fix resolve output of Gene...

2015-09-15 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/8755#discussion_r39550885 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -68,13 +68,47 @@ case class Generate(

[GitHub] spark pull request: [PySpark][MLlib][Docs] Replaced addversion wit...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8773#issuecomment-140500414 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [PySpark][MLlib][Docs] Replaced addversion wit...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8773#issuecomment-140500299 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10593] [SQL] fix resolve output of Gene...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8755#issuecomment-140499831 [Test build #1757 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1757/consoleFull) for PR 8755 at commit [`887474e`](https://git

[GitHub] spark pull request: [PySpark][MLlib][Docs] Replaced addversion wit...

2015-09-15 Thread noel-smith
GitHub user noel-smith opened a pull request: https://github.com/apache/spark/pull/8773 [PySpark][MLlib][Docs] Replaced addversion with versionadded in mllib.random Missed this when reviewing `pyspark.mllib.random` for SPARK-10275. You can merge this pull request into a Git reposito

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8700#issuecomment-140498376 [Test build #1756 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1756/console) for PR 8700 at commit [`bc7dc46`](https://github

[GitHub] spark pull request: [SPARK-10593] [SQL] fix resolve output of Gene...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8755#issuecomment-140497252 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARK-10593] [SQL] fix resolve output of Gene...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8755#issuecomment-140497250 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10593] [SQL] fix resolve output of Gene...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8755#issuecomment-140497114 [Test build #42495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42495/console) for PR 8755 at commit [`887474e`](https://github.

[GitHub] spark pull request: [DOC] Fixed outdated programming-guide link

2015-09-15 Thread terrytangyuan
Github user terrytangyuan commented on the pull request: https://github.com/apache/spark/pull/8772#issuecomment-140494169 Ok, no wonder I saw more invalid links. Thanks though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark pull request: [DOC] Fixed outdated programming-guide link

2015-09-15 Thread terrytangyuan
Github user terrytangyuan closed the pull request at: https://github.com/apache/spark/pull/8772 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-10584][DOC][SQL] Documentation about sp...

2015-09-15 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8739#issuecomment-140493951 @sarutak Looks like they need to be updated. Can you send another PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [DOC] Fixed outdated programming-guide link

2015-09-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8772#issuecomment-140493719 The Spark docs are designed to be viewed via the rendered docs at spark.apache.org, not through GitHub, so the current link is correct. --- If your project is set up

[GitHub] spark pull request: [SPARK-10589] [WEBUI] Add defense against exte...

2015-09-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8745#issuecomment-140493467 @holdenk @falaki @ahirreddy, this should not be an issue for DBC since the framed UI should already be served from the same origin. --- If your project is set up for

[GitHub] spark pull request: [DOC] Fixed outdated programming-guide link

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8772#issuecomment-140493434 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-10276][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8677#discussion_r39547963 --- Diff: python/pyspark/mllib/recommendation.py --- @@ -36,6 +36,8 @@ class Rating(namedtuple("Rating", ["user", "product", "rating"])): (1, 2, 5

[GitHub] spark pull request: [SPARK-10276][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8677#discussion_r39548087 --- Diff: python/pyspark/mllib/recommendation.py --- @@ -157,17 +167,25 @@ def recommendProducts(self, user, num): return list(self.call("recom

[GitHub] spark pull request: [SPARK-10276][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8677#discussion_r39547983 --- Diff: python/pyspark/mllib/recommendation.py --- @@ -111,13 +113,17 @@ class MatrixFactorizationModel(JavaModelWrapper, JavaSaveable, JavaLoader):

[GitHub] spark pull request: [SPARK-9715][ML] Store numFeatures in all ML P...

2015-09-15 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8675#issuecomment-140493169 That's interesting, I don't know why `GBTRegressionModel` has a public constructor (IMO it shouldn't since users should not be directly instantiationg `Model`s), ma

reviews@spark.apache.org

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8544#issuecomment-140492634 [Test build #42496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42496/consoleFull) for PR 8544 at commit [`4dcb78a`](https://gith

[GitHub] spark pull request: [DOC] Fixed outdated programming-guide link

2015-09-15 Thread terrytangyuan
GitHub user terrytangyuan opened a pull request: https://github.com/apache/spark/pull/8772 [DOC] Fixed outdated programming-guide link The link was not working. You can merge this pull request into a Git repository by running: $ git pull https://github.com/terrytangyuan/spark p

[GitHub] spark pull request: [SPARK-10593] [SQL] fix resolve output of Gene...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8755#issuecomment-140491302 [Test build #42495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42495/consoleFull) for PR 8755 at commit [`887474e`](https://gith

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-140491449 [Test build #42497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42497/consoleFull) for PR 7884 at commit [`8d6de99`](https://gith

reviews@spark.apache.org

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8544#issuecomment-140490850 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-140490824 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-140490871 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

reviews@spark.apache.org

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8544#issuecomment-140490819 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9715][ML] Store numFeatures in all ML P...

2015-09-15 Thread sethah
Github user sethah commented on the pull request: https://github.com/apache/spark/pull/8675#issuecomment-140489654 @feynmanliang One thing I'm curious about is if this would still be a problem if all the constructors were private to ml? Right now, GBTs are the only one of the `Predict

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8700#issuecomment-140489529 [Test build #1756 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1756/consoleFull) for PR 8700 at commit [`bc7dc46`](https://git

[GitHub] spark pull request: [SPARK-10593] [SQL] fix resolve output of Gene...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8755#issuecomment-140489684 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10593] [SQL] fix resolve output of Gene...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8755#issuecomment-140489665 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140488344 [Test build #42493 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42493/console) for PR 8761 at commit [`90f7943`](https://github.

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140488398 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140488397 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10593] [SQL] fix resolve output of Gene...

2015-09-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/8755#discussion_r39545697 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala --- @@ -115,8 +114,8 @@ abstract class QueryPlan[PlanType <: TreeNo

[GitHub] spark pull request: [SPARK-10593] [SQL] fix resolve output of Gene...

2015-09-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/8755#discussion_r39544824 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala --- @@ -115,8 +114,8 @@ abstract class QueryPlan[PlanType <: TreeNo

[GitHub] spark pull request: [SPARK-10618] [Mesos] Refactoring coarsed-grai...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8771#issuecomment-140485990 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-10618] [Mesos] Refactoring coarsed-grai...

2015-09-15 Thread SleepyThread
GitHub user SleepyThread opened a pull request: https://github.com/apache/spark/pull/8771 [SPARK-10618] [Mesos] Refactoring coarsed-grained scheduling conditio… …n and adding test for same. This commit just refactored a scheduling condition into the method and adde

[GitHub] spark pull request: [SPARK-8673] [launcher] API and infrastructure...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7052#issuecomment-140483241 [Test build #42494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42494/consoleFull) for PR 7052 at commit [`bf92906`](https://gith

[GitHub] spark pull request: [SPARK-9708] [MESOS] Spark should create local...

2015-09-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8358#discussion_r39543253 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -655,15 +655,19 @@ private[spark] object Utils extends Logging { // created th

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140481364 [Test build #42493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42493/consoleFull) for PR 8761 at commit [`90f7943`](https://gith

[GitHub] spark pull request: [SPARK-8673] [launcher] API and infrastructure...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7052#issuecomment-140480877 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8673] [launcher] API and infrastructure...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7052#issuecomment-140480840 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9987][SQL]Implement the local Aggregate...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8769#issuecomment-140480867 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9987][SQL]Implement the local Aggregate...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8769#issuecomment-140480722 [Test build #42490 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42490/console) for PR 8769 at commit [`640a74e`](https://github.

[GitHub] spark pull request: [SPARK-9987][SQL]Implement the local Aggregate...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8769#issuecomment-140480868 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140480836 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140480856 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-15 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/8700#issuecomment-140479983 @davies ping Can somebody verify this? Jenkins have't started tests for this pull requests --- If your project is set up for it, you can reply to this email and h

[GitHub] spark pull request: [SPARK-10612][SQL] Add prepare to LocalNode.

2015-09-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8761#issuecomment-140480137 OK updated - I put everything in LocalNode. I was initially thinking it might be better to be more explicit - but it seems vast majority of the operators don't need

[GitHub] spark pull request: [SPARK-10300] [build] [tests] Add support for ...

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8437 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9899][SQL] log warning for direct outpu...

2015-09-15 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/8687#issuecomment-140479545 I test it locally with these code: ``` sparkContext.conf.set("spark.speculation", "true") sparkContext.hadoopConfiguration.set("mapred.output.committer.

<    1   2   3   4   5   6   7   8   >