[GitHub] spark pull request: [SPARK-11643] [SQL] parse year with leading ze...

2015-11-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9701#discussion_r45158402 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -381,8 +393,12 @@ object DateTimeUtils { }

[GitHub] spark pull request: [SPARK-11761] Prevent the call to StreamingCon...

2015-11-17 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/9741#issuecomment-157599928 DirectKafkaStreamSuite failed in maven Jenkins: https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-Maven-with-YARN/HADOOP_PROFILE=hadoop-2.4,label=spark-test/

[GitHub] spark pull request: [SPARK-11081] Shade Jersey and javax.rs.ws

2015-11-17 Thread mccheah
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/9615#issuecomment-157599795 Spark-core would depend on the org.spark-project.javax.ws.rs but I would exclude it in my app specifically, as well as anyone who would use Jersey 2. --- If your projec

[GitHub] spark pull request: [SPARK-11081] Shade Jersey and javax.rs.ws

2015-11-17 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9615#issuecomment-157599693 Your app is *one app*. This needs to work for *all apps*. If spark-core doesn't depend on the artifact that has the javax classes, *Spark won't work*. --- If yo

[GitHub] spark pull request: [SPARK-11797][SQL] collect, first, and take sh...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9787#issuecomment-157599650 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11797][SQL] collect, first, and take sh...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9787#issuecomment-157599651 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11081] Shade Jersey and javax.rs.ws

2015-11-17 Thread mccheah
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/9615#issuecomment-157599572 No because my app would replace org.spark-project.javax.ws.rs with its own javax.ws.rs (which is transitively pulled in by Jersey 2 anyways), and those newer javax.ws.rs

[GitHub] spark pull request: [SPARK-11797][SQL] collect, first, and take sh...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9787#issuecomment-157599608 **[Test build #46157 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46157/consoleFull)** for PR 9787 at commit [`9c3bd92`](https://git

[GitHub] spark pull request: [SPARK-11791] Fix flaky test in BatchedWriteAh...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9790#issuecomment-157599524 **[Test build #46163 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46163/consoleFull)** for PR 9790 at commit [`7992777`](https://gith

[GitHub] spark pull request: [SPARK-11804][PYSPARK] Exception raise when us...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9791#issuecomment-157599346 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11804][PYSPARK] Exception raise when us...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9791#issuecomment-157599344 **[Test build #46165 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46165/consoleFull)** for PR 9791 at commit [`a5ba39a`](https://git

[GitHub] spark pull request: [SPARK-11804][PYSPARK] Exception raise when us...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9791#issuecomment-157599347 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11081] Shade Jersey and javax.rs.ws

2015-11-17 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9615#issuecomment-157599373 But it (and spark-core) need to depend on that jar containing the javax stuff... --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] spark pull request: [SPARK-11804][PYSPARK] Exception raise when us...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9791#issuecomment-157599274 **[Test build #46165 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46165/consoleFull)** for PR 9791 at commit [`a5ba39a`](https://gith

[GitHub] spark pull request: [SPARK-11081] Shade Jersey and javax.rs.ws

2015-11-17 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9615#issuecomment-157598997 But it also depends on spark-core, no? You said so above. And spark-core would depend on the spark-specific jersey jar which in your list would have the META-INF classes.

[GitHub] spark pull request: [SPARK-11081] Shade Jersey and javax.rs.ws

2015-11-17 Thread mccheah
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/9615#issuecomment-157599094 No - spark-specific Jersey jar would not have javax.ws.rs classes. That would be in org.spark-project.javax.ws.rs. --- If your project is set up for it, you can reply t

[GitHub] spark pull request: [SPARK-11804][PYSPARK] Exception raise when us...

2015-11-17 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/spark/pull/9791 [SPARK-11804][PYSPARK] Exception raise when using Jdbc predicates opt… …ion in PySpark You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/

[GitHub] spark pull request: [SPARK-11728] Replace example code in ml-ensem...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9716#issuecomment-157598952 **[Test build #46164 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46164/consoleFull)** for PR 9716 at commit [`4d9cffb`](https://gith

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-17 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-157598886 Do you mean bugs in this code? Or in 1.6? If in this code, master will eventually go through stabilization also, and at that point if there are bugs, they'll surface. Whe

[GitHub] spark pull request: [SPARK-11081] Shade Jersey and javax.rs.ws

2015-11-17 Thread mccheah
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/9615#issuecomment-157598877 My app would depend on Jersey 2 only which doesn't package the javax.ws.rs in itself and doesn't have the META-INF/services/javax.ws.rs* stuff. --- If your project is s

[GitHub] spark pull request: [SPARK-11797][SQL] collect, first, and take sh...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9787#issuecomment-157598831 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11797][SQL] collect, first, and take sh...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9787#issuecomment-157598829 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11797][SQL] collect, first, and take sh...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9787#issuecomment-157598727 **[Test build #46141 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46141/consoleFull)** for PR 9787 at commit [`eb24466`](https://git

[GitHub] spark pull request: [SPARK-11081] Shade Jersey and javax.rs.ws

2015-11-17 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9615#issuecomment-157598706 Steps 1 and 4 are both needed for your app, since you're embedding Spark. Basically "org.spark-project.jersey" can't contain either javax.ws classes nor the META-INF fil

[GitHub] spark pull request: [SPARK-11791] Fix flaky test in BatchedWriteAh...

2015-11-17 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/9790 [SPARK-11791] Fix flaky test in BatchedWriteAheadLogSuite stack trace of failure: ``` org.scalatest.exceptions.TestFailedDueToTimeoutException: The code passed to eventually never returned no

[GitHub] spark pull request: [SPARK-11728] Replace example code in ml-ensem...

2015-11-17 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9716#issuecomment-157598377 Fixed, sorry for the carelessness. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11739] [SQL] clear the instantiated SQL...

2015-11-17 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9706#issuecomment-157598316 ping @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark pull request: [SPARK-10745][Core]Separate configs between sh...

2015-11-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9481#discussion_r45157472 --- Diff: core/src/main/scala/org/apache/spark/network/netty/SparkTransportConf.scala --- @@ -40,23 +40,26 @@ object SparkTransportConf { /**

[GitHub] spark pull request: [SPARK-11081] Shade Jersey and javax.rs.ws

2015-11-17 Thread mccheah
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/9615#issuecomment-157598153 So to recap this approach holistically, both from the perspective of my application and from what needs to change Spark side: 1. Create "org.spark-project.jersey

[GitHub] spark pull request: [SPARK-10745][Core]Separate configs between sh...

2015-11-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9481#discussion_r45157404 --- Diff: core/src/main/scala/org/apache/spark/network/netty/SparkTransportConf.scala --- @@ -40,23 +40,26 @@ object SparkTransportConf { /**

[GitHub] spark pull request: [SPARK-11737] [SQL] Fix serialization of UTF8S...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9704 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11728] Replace example code in ml-ensem...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9716#issuecomment-157597885 **[Test build #46162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46162/consoleFull)** for PR 9716 at commit [`2ed613a`](https://gith

[GitHub] spark pull request: [SPARK-11781][SPARKR] SparkR has problem in in...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9769#issuecomment-157597785 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11781][SPARKR] SparkR has problem in in...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9769#issuecomment-157597786 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11781][SPARKR] SparkR has problem in in...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9769#issuecomment-157597709 **[Test build #46159 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46159/consoleFull)** for PR 9769 at commit [`df9bca7`](https://git

[GitHub] spark pull request: [SPARK-11583] [Core]MapStatus Using RoaringBit...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9746#issuecomment-157597503 **[Test build #2083 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2083/consoleFull)** for PR 9746 at commit [`f69061d`](https://git

[GitHub] spark pull request: [SPARK-11583] [Core]MapStatus Using RoaringBit...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9746 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11016] Move RoaringBitmap to explicit K...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9748 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-157595580 I'm mostly thinking it'd make it harder if we found bugs that need to fix. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark pull request: [SPARK-11789] [core] [yarn] Lower severity of ...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9780#issuecomment-157594835 **[Test build #46161 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46161/consoleFull)** for PR 9780 at commit [`a645c11`](https://gith

[GitHub] spark pull request: [SPARK-10745][Core]Separate configs between sh...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9481#issuecomment-157594757 **[Test build #46160 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46160/consoleFull)** for PR 9481 at commit [`523decb`](https://gith

[GitHub] spark pull request: [SPARK-11081] Shade Jersey and javax.rs.ws

2015-11-17 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9615#issuecomment-157593885 Seems like the old jersey-core jar has the javax classes within it, instead of depending on a separate artifact; so you'd need the new javax jar in front of it in the cla

[GitHub] spark pull request: [SPARK-11781][SPARKR] SparkR has problem in in...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9769#issuecomment-157593732 **[Test build #46159 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46159/consoleFull)** for PR 9769 at commit [`df9bca7`](https://gith

[GitHub] spark pull request: [SPARK-10745][Core]Separate configs between sh...

2015-11-17 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9481#issuecomment-157593004 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-17 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-157591720 What's the problem with merging to master? Isn't that why we have branch-1.6? I have changes built on top of this that I'm waiting to send for review. --- If yo

[GitHub] spark pull request: [SPARK-11761] Prevent the call to StreamingCon...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9741#issuecomment-157590941 **[Test build #46158 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46158/consoleFull)** for PR 9741 at commit [`922bf0b`](https://gith

[GitHub] spark pull request: [SPARK-11802][SQL] Kryo-based encoder for opaq...

2015-11-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9789#discussion_r45155505 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoder.scala --- @@ -37,7 +38,33 @@ trait Encoder[T] extends Serializable { def clsTag: Cl

[GitHub] spark pull request: [SPARK-10745][Core]Separate configs between sh...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9481#issuecomment-157590163 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-10186][SQL][follow-up] simplify test

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9783#issuecomment-157590523 **[Test build #46155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46155/consoleFull)** for PR 9783 at commit [`6a10080`](https://gith

[GitHub] spark pull request: [SPARK-10745][Core]Separate configs between sh...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9481#issuecomment-157590160 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11792] [SQL] SizeEstimator cannot provi...

2015-11-17 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9788#issuecomment-157589689 I am running the test. From what I have seen so far, it fixes the problem. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-10155][SQL]Change SqlParser to object t...

2015-11-17 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/8357#issuecomment-157589693 @pankajarora12 could you test in 1.5.1 and see if there is any performance regression? --- If your project is set up for it, you can reply to this email and have your r

[GitHub] spark pull request: [SPARK-11761] Prevent the call to StreamingCon...

2015-11-17 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/9741#issuecomment-157589455 ``` ERROR: Timeout after 15 minutes ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://github.com/apache/s

[GitHub] spark pull request: [SPARK-11781][SPARKR] SparkR has problem in in...

2015-11-17 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9769#issuecomment-157589422 @shivaram, The R raw type is intended to hold raw bytes. while int vector is to hold 32-bit integer values. The R raw type maps to Spark SQL binary type, which is intern

[GitHub] spark pull request: [SPARK-11761] Prevent the call to StreamingCon...

2015-11-17 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/9741#issuecomment-157589468 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-11797][SQL] collect, first, and take sh...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9787#issuecomment-157589317 **[Test build #46157 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46157/consoleFull)** for PR 9787 at commit [`9c3bd92`](https://gith

[GitHub] spark pull request: [SPARK-11797][SQL] collect, first, and take sh...

2015-11-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9787#issuecomment-157589288 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11792] [SQL] SizeEstimator cannot provi...

2015-11-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9788#issuecomment-157589220 LGTM too (assuming it fixes the tpcds problem) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] spark pull request: [SPARK-11761] Prevent the call to StreamingCon...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9741#issuecomment-157589170 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11761] Prevent the call to StreamingCon...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9741#issuecomment-157589171 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11792] [SQL] SizeEstimator cannot provi...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9788#issuecomment-157589067 **[Test build #46154 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46154/consoleFull)** for PR 9788 at commit [`c1a9a4f`](https://gith

[GitHub] spark pull request: [SPARK-11802][SQL] Kryo-based encoder for opaq...

2015-11-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9789#discussion_r45155101 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoder.scala --- @@ -37,7 +38,33 @@ trait Encoder[T] extends Serializable { def clsTag: ClassTa

[GitHub] spark pull request: [SPARK-11802][SQL] Kryo-based encoder for opaq...

2015-11-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9789#discussion_r45155036 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoder.scala --- @@ -37,7 +38,33 @@ trait Encoder[T] extends Serializable { def clsTag: Cl

[GitHub] spark pull request: [SPARK-10745][Core]Separate configs between sh...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9481#issuecomment-157588981 **[Test build #46156 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46156/consoleFull)** for PR 9481 at commit [`523decb`](https://gith

[GitHub] spark pull request: [SPARK-11802][SQL] Kryo-based encoder for opaq...

2015-11-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9789#discussion_r45154972 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoder.scala --- @@ -37,7 +38,33 @@ trait Encoder[T] extends Serializable { def clsTag: Cl

[GitHub] spark pull request: [SPARK-11773][SPARKR] Implement collection fun...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9764#issuecomment-157588711 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11773][SPARKR] Implement collection fun...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9764#issuecomment-157588713 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11773][SPARKR] Implement collection fun...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9764#issuecomment-157588637 **[Test build #46149 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46149/consoleFull)** for PR 9764 at commit [`90aae7f`](https://git

[GitHub] spark pull request: [SPARK-11793][SQL] Dataset should set the reso...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9784#issuecomment-157588532 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11793][SQL] Dataset should set the reso...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9784#issuecomment-157588531 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11797][SQL] collect, first, and take sh...

2015-11-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9787#discussion_r45154801 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -529,7 +530,12 @@ class Dataset[T] private[sql]( * For Java API, use [[collect

[GitHub] spark pull request: [SPARK-11793][SQL] Dataset should set the reso...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9784#issuecomment-157588430 **[Test build #46133 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46133/consoleFull)** for PR 9784 at commit [`ae96866`](https://git

[GitHub] spark pull request: [SPARK-11761] Prevent the call to StreamingCon...

2015-11-17 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/9741#issuecomment-157588328 DirectKafkaStreamSuite passed locally: ``` Run starting. Expected test count is: 6 DirectKafkaStreamSuite: - basic stream receiving with multiple topics and

[GitHub] spark pull request: [SPARK-11793][SQL] Dataset should set the reso...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9784 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10186][SQL][follow-up] simplify test

2015-11-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9783#issuecomment-157588362 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11636] [SQL] Support as for classes def...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9602#issuecomment-157588218 **[Test build #46152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46152/consoleFull)** for PR 9602 at commit [`35cd4f4`](https://gith

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-17 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9779#discussion_r45154680 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskResultGetterSuite.scala --- @@ -119,5 +123,66 @@ class TaskResultGetterSuite extends SparkFunS

[GitHub] spark pull request: [SPARK-11793][SQL] Dataset should set the reso...

2015-11-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9784#issuecomment-157588050 I'm going to merge this and fix the comments in a separate pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-17 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9779#discussion_r45154648 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskResultGetterSuite.scala --- @@ -119,5 +123,66 @@ class TaskResultGetterSuite extends SparkFunS

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-17 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9779#discussion_r45154563 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskResultGetterSuite.scala --- @@ -119,5 +123,66 @@ class TaskResultGetterSuite extends SparkFunS

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-157587696 Alright I looked a bit closer at this. Since it is not mission critical and it is touching some mission critical part, I think it's best to not to merge this in 1.6.

[GitHub] spark pull request: [SPARK-11797][SQL] collect, first, and take sh...

2015-11-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9787#discussion_r45154495 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -529,7 +530,12 @@ class Dataset[T] private[sql]( * For Java API, use [[co

[GitHub] spark pull request: [SPARK-11339][SPARKR] Document the list of fun...

2015-11-17 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9785#issuecomment-157587670 ok, I see. I guess I picked the closer form ``` ## S3 method for class 'data.frame' subset(x, subset, select, drop = FALSE, ...) ``` I'll try/fix t

[GitHub] spark pull request: [SPARK-10745][Core]Separate configs between sh...

2015-11-17 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9481#issuecomment-157586928 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-10186][SQL][follow-up] simplify test

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9783#issuecomment-157586719 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-10186][SQL][follow-up] simplify test

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9783#issuecomment-157586716 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11792] [SQL] SizeEstimator cannot provi...

2015-11-17 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9788#issuecomment-157586644 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request: [SPARK-10186][SQL][follow-up] simplify test

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9783#issuecomment-157586671 **[Test build #46131 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46131/consoleFull)** for PR 9783 at commit [`6a10080`](https://git

[GitHub] spark pull request: [SPARK-11761] Prevent the call to StreamingCon...

2015-11-17 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9741#issuecomment-157586672 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-11792] [SQL] SizeEstimator cannot provi...

2015-11-17 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9788#discussion_r45154129 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala --- @@ -215,6 +217,14 @@ private[joins] final class UnsafeHash

[GitHub] spark pull request: [SPARK-11781][SPARKR] SparkR has problem in in...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9769#issuecomment-157585916 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11781][SPARKR] SparkR has problem in in...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9769#issuecomment-157585922 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11781][SPARKR] SparkR has problem in in...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9769#issuecomment-157585897 **[Test build #46148 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46148/consoleFull)** for PR 9769 at commit [`07a0f33`](https://git

[GitHub] spark pull request: [SPARK-11792] [SQL] SizeEstimator cannot provi...

2015-11-17 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9788#discussion_r45154094 --- Diff: core/src/main/scala/org/apache/spark/util/SizeEstimator.scala --- @@ -32,6 +32,16 @@ import org.apache.spark.annotation.DeveloperApi import o

[GitHub] spark pull request: [SPARK-11793][SQL] Dataset should set the reso...

2015-11-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9784#discussion_r45154095 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -73,6 +73,17 @@ class DatasetSuite extends QueryTest with SharedSQLContext {

[GitHub] spark pull request: [SPARK-11081] Shade Jersey and javax.rs.ws

2015-11-17 Thread mccheah
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/9615#issuecomment-157585464 So I tried the following experiment to simulate what we want to be doing and testing the hypothesis that it doesn't matter what order the Jersey jars are loaded in. What

[GitHub] spark pull request: [SPARK-11793][SQL] Dataset should set the reso...

2015-11-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9784#discussion_r45154097 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -73,6 +73,17 @@ class DatasetSuite extends QueryTest with SharedSQLContext {

[GitHub] spark pull request: [SPARK-11792] [SQL] SizeEstimator cannot provi...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9788#issuecomment-157584728 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11792] [SQL] SizeEstimator cannot provi...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9788#issuecomment-157584736 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11761] Prevent the call to StreamingCon...

2015-11-17 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/9741#issuecomment-157585091 For both 46132 and 46136: ``` [info] StreamingListenerSuite: [info] - batch info reporting (752 milliseconds) [info] - receiver info reporting (369 milliseco

<    1   2   3   4   5   6   7   8   9   10   >