[GitHub] spark pull request: [SPARK-11934][Mllib] Word2VecModel load and sa...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9989#issuecomment-160266672 **[Test build #2126 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2126/consoleFull)** for PR 9989 at commit

[GitHub] spark pull request: [SPARK-11934][Mllib] Word2VecModel load and sa...

2015-11-28 Thread tmnd1991
Github user tmnd1991 commented on the pull request: https://github.com/apache/spark/pull/9989#issuecomment-160266635 Yes, it was wrong, I fixed it, sorry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread uncleGen
Github user uncleGen commented on the pull request: https://github.com/apache/spark/pull/10023#issuecomment-160270490 [info] - failing to fetch classes from HTTP server should not leak resources (SPARK-6209) *** FAILED *** (1 second, 392 milliseconds) [info]

[GitHub] spark pull request: [SPARK-3580][CORE] Add Consistent Method To Ge...

2015-11-28 Thread schot
Github user schot commented on the pull request: https://github.com/apache/spark/pull/9767#issuecomment-160271652 @srowen @JoshRosen PR has been rebased to resolve the conflict on MimaExcludes. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-4452][Core]Shuffle data structures can ...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10024#issuecomment-160271599 **[Test build #46839 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46839/consoleFull)** for PR 10024 at commit

[GitHub] spark pull request: [SPARK-11994][Mllib] Word2VecModel load and sa...

2015-11-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9989#issuecomment-160272037 @MechCoder @rxin any thoughts on this one? looks reasonable unless there's some reason it has to be in 1 partition. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [MINOR] [DOCS] fixed list display in ml-ensemb...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10025#issuecomment-160294528 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [MINOR] [DOCS] fixed list display in ml-ensemb...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10025#issuecomment-160294531 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10004#issuecomment-160295792 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10004#issuecomment-160295756 **[Test build #46841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46841/consoleFull)** for PR 10004 at commit

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10004#issuecomment-160295794 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46080162 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaVectorIndexerExample.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10023#issuecomment-160263827 **[Test build #46836 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46836/consoleFull)** for PR 10023 at commit

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10023#issuecomment-160264139 **[Test build #46837 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46837/consoleFull)** for PR 10023 at commit

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10023#discussion_r46078021 --- Diff: core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala --- @@ -52,16 +52,20 @@ private[spark] object SamplingUtils {

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10023#issuecomment-160270196 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10023#issuecomment-160270845 **[Test build #46838 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46838/consoleFull)** for PR 10023 at commit

[GitHub] spark pull request: [SPARK-11988] [ML] [MLLIB] Update JPMML to 1.2...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9972#issuecomment-160288329 **[Test build #2128 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2128/consoleFull)** for PR 9972 at commit

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46079591 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaStopWordsRemover.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46079594 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaStopWordsRemover.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46079600 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaPCAExample.java --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [MINOR] [DOCS] fixed list display in ml-ensemb...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10025#issuecomment-160294329 **[Test build #46842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46842/consoleFull)** for PR 10025 at commit

[GitHub] spark pull request: [SPARK-11859][Mesos] SparkContext accepts inva...

2015-11-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9886#issuecomment-160267625 LGTM, will merge soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11934][Mllib] Word2VecModel load and sa...

2015-11-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9989#issuecomment-160271073 (The title is still wrong, it's SPARK-11994) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11934][Mllib] Word2VecModel load and sa...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9989#issuecomment-160271099 **[Test build #2127 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2127/consoleFull)** for PR 9989 at commit

[GitHub] spark pull request: [SPARK-11988] [ML] [MLLIB] Update JPMML to 1.2...

2015-11-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9972#issuecomment-160271973 I'm inclined to merge this for 1.6 for reasons in the JIRA, but am leaving this open a bit longer. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

2015-11-28 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/10004#discussion_r46078778 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -422,7 +422,7 @@ abstract class HadoopFsRelation private[sql](

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread somideshmukh
Github user somideshmukh closed the pull request at: https://github.com/apache/spark/pull/9735 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-11988] [ML] [MLLIB] Update JPMML to 1.2...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9972#issuecomment-160288179 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11988] [ML] [MLLIB] Update JPMML to 1.2...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9972#issuecomment-160288180 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11988] [ML] [MLLIB] Update JPMML to 1.2...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9972#issuecomment-160288164 **[Test build #46840 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46840/consoleFull)** for PR 9972 at commit

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/10002#issuecomment-160292049 @somideshmukh This is really a bunch of code. I check some errors as described above for my carelessness and sorry for that. And after fixing those errors, I can get

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/10002#issuecomment-160292101 I think the conflict is due to some changes in `ml-features.md`, but we can leave it for now. After we fix all errors we can fix the conflict. --- If your project is

[GitHub] spark pull request: [SPARK-11898] [MLlib] Use broadcast for the gl...

2015-11-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9878#issuecomment-160265989 @jkbradley OK with merging? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3580][CORE] Add Consistent Method To Ge...

2015-11-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9767#issuecomment-160271315 @schot this'll need a rebase. @JoshRosen are you OK with this for 1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-11994][Mllib] Word2VecModel load and sa...

2015-11-28 Thread tmnd1991
Github user tmnd1991 commented on the pull request: https://github.com/apache/spark/pull/9989#issuecomment-160271736 Something went wrong with the commit. Now should be fine. Never commit before a good coffee! --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-11988] [ML] [MLLIB] Update JPMML to 1.2...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9972#issuecomment-160272101 **[Test build #46840 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46840/consoleFull)** for PR 9972 at commit

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46079612 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaOneHotEncoderExample.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10023#issuecomment-160301333 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10023#issuecomment-160301123 **[Test build #46838 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46838/consoleFull)** for PR 10023 at commit

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10023#issuecomment-160301338 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10023#discussion_r46078033 --- Diff: core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala --- @@ -52,16 +52,20 @@ private[spark] object SamplingUtils {

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10023#issuecomment-160270121 **[Test build #46836 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46836/consoleFull)** for PR 10023 at commit

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10023#issuecomment-160270197 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10023#issuecomment-160271122 **[Test build #46837 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46837/consoleFull)** for PR 10023 at commit

[GitHub] spark pull request: [SPARK-11934][Mllib] Word2VecModel load and sa...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9989#issuecomment-160271184 **[Test build #2127 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2127/consoleFull)** for PR 9989 at commit

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10023#issuecomment-160271154 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10023#issuecomment-160271155 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4452][Core]Shuffle data structures can ...

2015-11-28 Thread lianhuiwang
GitHub user lianhuiwang opened a pull request: https://github.com/apache/spark/pull/10024 [SPARK-4452][Core]Shuffle data structures can starve others on the same thread for memory In #9241 It implemented a mechanism to call spill() on those SQL operators that support spilling if

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46079541 --- Diff: docs/ml-features.md --- @@ -408,37 +278,7 @@ ngramDataFrame.take(3).map(_.getAs[Stream[String]]("ngrams").toList).foreach(pri Refer to the

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46079548 --- Diff: docs/ml-features.md --- @@ -1800,40 +887,7 @@ println(output.select("userFeatures", "features").first()) Refer to the [VectorSlicer Java

[GitHub] spark pull request: [Spark-10625] [SQL] Spark SQL JDBC read/write ...

2015-11-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10020#issuecomment-160265026 This should be closed and be part of https://github.com/apache/spark/pull/8785 or else I'm unclear on the difference? Let's put the change in one place please. --- If

[GitHub] spark pull request: test case demonstrating SPARK-10625:

2015-11-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10022#issuecomment-160264995 Please close this PR. You only open PRs vs master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-11932][Mllib] Word2VecModel load and sa...

2015-11-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9989#issuecomment-160266037 This is tagged to the wrong JIRA right? It's SPARK-11994 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10023#discussion_r46079471 --- Diff: core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala --- @@ -52,16 +52,21 @@ private[spark] object SamplingUtils {

[GitHub] spark pull request: [MINOR] [DOCS] fixed list display in ml-ensemb...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10025#issuecomment-160291931 **[Test build #46842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46842/consoleFull)** for PR 10025 at commit

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

2015-11-28 Thread uncleGen
Github user uncleGen commented on the pull request: https://github.com/apache/spark/pull/10023#issuecomment-160263743 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11932][Mllib] Word2VecModel load and sa...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9989#issuecomment-160266427 **[Test build #2126 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2126/consoleFull)** for PR 9989 at commit

[GitHub] spark pull request: [SPARK-11934][Mllib] Word2VecModel load and sa...

2015-11-28 Thread tmnd1991
Github user tmnd1991 commented on the pull request: https://github.com/apache/spark/pull/9989#issuecomment-160269241 I adjusted the code style. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10004#issuecomment-160277691 **[Test build #46841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46841/consoleFull)** for PR 10004 at commit

[GitHub] spark pull request: [SPARK-4452][Core]Shuffle data structures can ...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10024#issuecomment-160284311 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4452][Core]Shuffle data structures can ...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10024#issuecomment-160284297 **[Test build #46839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46839/consoleFull)** for PR 10024 at commit

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46079574 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaTokenizerExample.java --- @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [MINOR] [DOCS] fixed list display in ml-ensemb...

2015-11-28 Thread BenFradet
GitHub user BenFradet opened a pull request: https://github.com/apache/spark/pull/10025 [MINOR] [DOCS] fixed list display in ml-ensembles The list in ml-ensembles.md wasn't properly formatted and, as a result, was looking like this: ![old](http://i.imgur.com/2ZhELLR.png)

[GitHub] spark pull request: [Doc] Explicitly state that top maintains the ...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10013#issuecomment-160297882 **[Test build #2129 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2129/consoleFull)** for PR 10013 at commit

[GitHub] spark pull request: [SPARK-11988] [ML] [MLLIB] Update JPMML to 1.2...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9972#issuecomment-160305179 **[Test build #2128 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2128/consoleFull)** for PR 9972 at commit

[GitHub] spark pull request: [SPARK-12035] Add more debug information in in...

2015-11-28 Thread yinxusen
GitHub user yinxusen opened a pull request: https://github.com/apache/spark/pull/10026 [SPARK-12035] Add more debug information in include_example tag of Jekyll https://issues.apache.org/jira/browse/SPARK-12035 When we debuging lots of example code files, like in

[GitHub] spark pull request: [SPARK-12035] Add more debug information in in...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10026#issuecomment-160313883 **[Test build #46843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46843/consoleFull)** for PR 10026 at commit

[GitHub] spark pull request: [SPARK-11955][SQL] Mark one side fields in mer...

2015-11-28 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/9940#issuecomment-160317766 ping @liancheng @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46080449 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaElementwiseProductExample.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46080443 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaElementwiseProductExample.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46080515 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaTokenizerExample.java --- @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46080493 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaStringIndexerExample.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [Doc] Explicitly state that top maintains the ...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10013#issuecomment-160314220 **[Test build #2129 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2129/consoleFull)** for PR 10013 at commit

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/10002#issuecomment-160310120 Hi @somideshmukh I have pointed all errors that I found. After you fixing these errors, we can handle the conflict thing. Then we can get this PR merged. --- If your

[GitHub] spark pull request: [SPARK-7857][MLLIB] Prevent IDFModel from retu...

2015-11-28 Thread karlhigley
Github user karlhigley commented on the pull request: https://github.com/apache/spark/pull/9843#issuecomment-160314300 I understand the issue you're pointing out, but it hasn't been a practical problem, even with hundreds of thousands of terms. The inclusion of explicit zeros in the

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46080461 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaElementwiseProductExample.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46080689 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/VectorSlicerExample.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46080696 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/VectorSlicerExample.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12035] Add more debug information in in...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10026#issuecomment-160314701 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12035] Add more debug information in in...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10026#issuecomment-160314683 **[Test build #46843 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46843/consoleFull)** for PR 10026 at commit

[GitHub] spark pull request: [SPARK-12035] Add more debug information in in...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10026#issuecomment-160314702 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46080247 --- Diff: docs/ml-features.md --- @@ -1508,25 +737,7 @@ This example below demonstrates how to transform vectors using a transforming ve Refer to the

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46080243 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/ElementWiseProductExample.scala --- @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46080743 --- Diff: examples/src/main/python/ml/onehot_encoder_example.py --- @@ -0,0 +1,47 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/10002#discussion_r46080753 --- Diff: examples/src/main/python/ml/normalizer_example.py --- @@ -0,0 +1,42 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] spark pull request: test case demonstrating SPARK-10625:

2015-11-28 Thread tribbloid
Github user tribbloid closed the pull request at: https://github.com/apache/spark/pull/10021 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: test case demonstrating SPARK-10625:

2015-11-28 Thread tribbloid
Github user tribbloid closed the pull request at: https://github.com/apache/spark/pull/10022 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: test case demonstrating SPARK-10625:

2015-11-28 Thread tribbloid
Github user tribbloid commented on the pull request: https://github.com/apache/spark/pull/10021#issuecomment-160333768 soorry, should read the how to contribute first --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: test case demonstrating SPARK-10625:

2015-11-28 Thread tribbloid
Github user tribbloid commented on the pull request: https://github.com/apache/spark/pull/10022#issuecomment-160333773 soorry --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-28 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/9654#discussion_r46084064 --- Diff: R/pkg/R/DataFrame.R --- @@ -290,6 +292,121 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-28 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/9654#discussion_r46084477 --- Diff: R/pkg/R/types.R --- @@ -41,3 +41,11 @@ COMPLEX_TYPES <- list( # The full list of data types. DATA_TYPES <-

[GitHub] spark pull request: [Spark-10625] [SQL] Spark SQL JDBC read/write ...

2015-11-28 Thread tribbloid
Github user tribbloid commented on the pull request: https://github.com/apache/spark/pull/10020#issuecomment-160333704 sorry its just a squashed commit, I speculate that PMC will squash rebase it anyway but I'm not so sure, so I requested 2 identical patches --- If your project is

[GitHub] spark pull request: [Spark-10625] [SQL] Spark SQL JDBC read/write ...

2015-11-28 Thread tribbloid
Github user tribbloid closed the pull request at: https://github.com/apache/spark/pull/10020 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11482][SQL] Make maven repo for Hive me...

2015-11-28 Thread xguo27
Github user xguo27 commented on the pull request: https://github.com/apache/spark/pull/9543#issuecomment-160332622 @yhuai I see your latest delivery has conflict with this PR, I have resolved the conflict and re-pushed. @rxin has been reviewing this PR, I figure you might also want

[GitHub] spark pull request: [SPARK-11985][STREAMING][KINESIS][DOCS] Update...

2015-11-28 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/9970#discussion_r46084026 --- Diff: R/pkg/DESCRIPTION --- @@ -18,10 +18,10 @@ Collate: 'schema.R' 'generics.R' 'jobj.R' -'RDD.R' -

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-28 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-160335856 Couple of minor comments, but otherwise change looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-160353817 **[Test build #46845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46845/consoleFull)** for PR 9654 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-160356898 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11955][SQL] Mark one side fields in mer...

2015-11-28 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9940#issuecomment-160360802 I don't really get the idea of this one, what exactly does "oneSide" mean? --- If your project is set up for it, you can reply to this email and have your reply

  1   2   >