[GitHub] spark issue #13758: [SPARK-16043][SQL] Prepare GenericArrayData implementati...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13758 **[Test build #61361 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61361/consoleFull)** for PR 13758 at commit

[GitHub] spark issue #13839: [SPARK-16128][SQL] Allow setting length of characters to...

2016-06-28 Thread ScrapCodes
Github user ScrapCodes commented on the issue: https://github.com/apache/spark/pull/13839 retest this please. Failed tests: (may be flaky.) ``` - missing checkpoint block fails with informative message *** FAILED *** (41 milliseconds) [info] Collect should have

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13680 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61362/ Test PASSed. ---

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13680 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13680 **[Test build #61362 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61362/consoleFull)** for PR 13680 at commit

[GitHub] spark pull request #13858: [SPARK-16148] [Scheduler] Allow for underscores i...

2016-06-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13858#discussion_r68716660 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskLocation.scala --- @@ -64,18 +64,21 @@ private[spark] object TaskLocation { /**

[GitHub] spark pull request #13858: [SPARK-16148] [Scheduler] Allow for underscores i...

2016-06-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13858#discussion_r68716518 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskLocation.scala --- @@ -64,18 +64,21 @@ private[spark] object TaskLocation { /**

[GitHub] spark issue #13806: [SPARK-16044][SQL] Backport input_file_name() for data s...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13806 **[Test build #61368 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61368/consoleFull)** for PR 13806 at commit

[GitHub] spark issue #13858: [SPARK-16148] [Scheduler] Allow for underscores in TaskL...

2016-06-28 Thread tmagrino
Github user tmagrino commented on the issue: https://github.com/apache/spark/pull/13858 I opted to force push a cleaned up version, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #13858: [SPARK-16148] [Scheduler] Allow for underscores in TaskL...

2016-06-28 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13858 You can always revert the commits in question and push, which become new commits, but that's fine. They're all squashed in the end. You can also manually squash and force-push if you like. --- If

[GitHub] spark pull request #11119: [SPARK-10780][ML][WIP] Add initial model to kmean...

2016-06-28 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r68715841 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedGeneralTypeParams.scala --- @@ -0,0 +1,34 @@ +/* --- End diff --

[GitHub] spark issue #13806: [SPARK-16044][SQL] Backport input_file_name() for data s...

2016-06-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13806 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #13806: [SPARK-16044][SQL] Backport input_file_name() for data s...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13806 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13806: [SPARK-16044][SQL] Backport input_file_name() for data s...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13806 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61367/ Test FAILed. ---

[GitHub] spark issue #13806: [SPARK-16044][SQL] Backport input_file_name() for data s...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13806 **[Test build #61367 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61367/consoleFull)** for PR 13806 at commit

[GitHub] spark issue #13806: [SPARK-16044][SQL] Backport input_file_name() for data s...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13806 **[Test build #61367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61367/consoleFull)** for PR 13806 at commit

[GitHub] spark issue #13941: [SPARK-16249][ML] Change visibility of Object ml.cluster...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13941 **[Test build #61366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61366/consoleFull)** for PR 13941 at commit

[GitHub] spark issue #13939: [SPARK-16248][SQL] Whitelist the list of Hive fallback f...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13939 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61365/ Test FAILed. ---

[GitHub] spark issue #13939: [SPARK-16248][SQL] Whitelist the list of Hive fallback f...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13939 **[Test build #61365 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61365/consoleFull)** for PR 13939 at commit

[GitHub] spark issue #13939: [SPARK-16248][SQL] Whitelist the list of Hive fallback f...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13939 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13941: [SPARK-16249][ML] Change visibility of Object ml....

2016-06-28 Thread hhbyyh
GitHub user hhbyyh opened a pull request: https://github.com/apache/spark/pull/13941 [SPARK-16249][ML] Change visibility of Object ml.clustering.LDA to public for loading ## What changes were proposed in this pull request? jira: https://issues.apache.org/jira/browse/SPARK-16249

[GitHub] spark issue #13858: [SPARK-16148] [Scheduler] Allow for underscores in TaskL...

2016-06-28 Thread tmagrino
Github user tmagrino commented on the issue: https://github.com/apache/spark/pull/13858 Ugh, I just saw that I accidentally merged in some other PRs... I'm a bit new to this, apologies. Any idea how I can amend this? --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #13806: [SPARK-16044][SQL] Backport input_file_name() for data s...

2016-06-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13806 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #13858: [SPARK-16148] [Scheduler] Allow for underscores in TaskL...

2016-06-28 Thread tmagrino
Github user tmagrino commented on the issue: https://github.com/apache/spark/pull/13858 My apologies @srowen, I missed the comment somehow! I refactored a little bit to make it more obvious what's going on there (using `stripPrefix` as you suggested). --- If your project is set up

[GitHub] spark issue #13806: [SPARK-16044][SQL] Backport input_file_name() for data s...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13806 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13806: [SPARK-16044][SQL] Backport input_file_name() for data s...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13806 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61357/ Test FAILed. ---

[GitHub] spark issue #13806: [SPARK-16044][SQL] Backport input_file_name() for data s...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13806 **[Test build #61357 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61357/consoleFull)** for PR 13806 at commit

[GitHub] spark issue #13939: [SPARK-16248][SQL] Whitelist the list of Hive fallback f...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13939 **[Test build #61365 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61365/consoleFull)** for PR 13939 at commit

[GitHub] spark issue #11863: [SPARK-12177][Streaming][Kafka] Update KafkaDStreams to ...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11863 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61359/ Test PASSed. ---

[GitHub] spark issue #11863: [SPARK-12177][Streaming][Kafka] Update KafkaDStreams to ...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11863 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #11863: [SPARK-12177][Streaming][Kafka] Update KafkaDStreams to ...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11863 **[Test build #61359 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61359/consoleFull)** for PR 11863 at commit

[GitHub] spark pull request #13816: [SPARK-16114] [SQL] structured streaming network ...

2016-06-28 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13816#discussion_r68712530 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/streaming/NetworkEventTimeWindow.scala --- @@ -0,0 +1,84 @@ +/* + * Licensed to the

[GitHub] spark pull request #13816: [SPARK-16114] [SQL] structured streaming network ...

2016-06-28 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13816#discussion_r68712408 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/streaming/NetworkEventTimeWindow.scala --- @@ -0,0 +1,84 @@ +/* + * Licensed to the

[GitHub] spark pull request #13816: [SPARK-16114] [SQL] structured streaming network ...

2016-06-28 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13816#discussion_r68712352 --- Diff: examples/src/main/java/org/apache/spark/examples/sql/streaming/JavaStructuredNetworkWordCount.java --- @@ -0,0 +1,78 @@ +/* + * Licensed to

[GitHub] spark pull request #13816: [SPARK-16114] [SQL] structured streaming network ...

2016-06-28 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13816#discussion_r68712291 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/streaming/NetworkEventTimeWindow.scala --- @@ -0,0 +1,84 @@ +/* + * Licensed to the

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-06-28 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13891 It may not matter much but your test code is a little different than in the patch, like for copyToTri(). It's optional, but a few comments explaining what addStack does might help readers. ---

[GitHub] spark pull request #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in AL...

2016-06-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13891#discussion_r68711572 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -635,6 +636,15 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in AL...

2016-06-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13891#discussion_r68711415 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -1296,6 +1316,9 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark issue #13940: [SPARK-16241] [ML] model loading backward compatibility ...

2016-06-28 Thread zlpmichelle
Github user zlpmichelle commented on the issue: https://github.com/apache/spark/pull/13940 Thanks @hhbyyh @AmplabJenkins! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #13921: [SPARK-16140][MLlib][SparkR][Docs] Group k-means method ...

2016-06-28 Thread yinxusen
Github user yinxusen commented on the issue: https://github.com/apache/spark/pull/13921 @keypointt You need to add title for `predict` and `write.ml`. Like the first line below. ```Rd #' This is title for write.ml #' @rdname write.ml #' @export

[GitHub] spark issue #13839: [SPARK-16128][SQL] Allow setting length of characters to...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13839 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13839: [SPARK-16128][SQL] Allow setting length of characters to...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13839 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61354/ Test FAILed. ---

[GitHub] spark issue #13839: [SPARK-16128][SQL] Allow setting length of characters to...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13839 **[Test build #61354 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61354/consoleFull)** for PR 13839 at commit

[GitHub] spark issue #13378: [SPARK-15643] [Doc] [ML] Update spark.ml and spark.mllib...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13378 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61364/ Test PASSed. ---

[GitHub] spark pull request #13921: [SPARK-16140][MLlib][SparkR][Docs] Group k-means ...

2016-06-28 Thread keypointt
Github user keypointt commented on a diff in the pull request: https://github.com/apache/spark/pull/13921#discussion_r68707718 --- Diff: R/pkg/R/mllib.R --- @@ -477,24 +480,15 @@ setMethod("write.ml", signature(object = "GeneralizedLinearRegressionModel", pat

[GitHub] spark issue #13378: [SPARK-15643] [Doc] [ML] Update spark.ml and spark.mllib...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13378 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13378: [SPARK-15643] [Doc] [ML] Update spark.ml and spark.mllib...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13378 **[Test build #61364 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61364/consoleFull)** for PR 13378 at commit

[GitHub] spark pull request #13921: [SPARK-16140][MLlib][SparkR][Docs] Group k-means ...

2016-06-28 Thread keypointt
Github user keypointt commented on a diff in the pull request: https://github.com/apache/spark/pull/13921#discussion_r68707667 --- Diff: R/pkg/R/mllib.R --- @@ -358,19 +369,11 @@ setMethod("summary", signature(object = "KMeansModel"), cluster = cluster,

[GitHub] spark issue #13939: [SPARK-16248][SQL] Whitelist the list of Hive fallback f...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13939 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61358/ Test FAILed. ---

[GitHub] spark issue #13939: [SPARK-16248][SQL] Whitelist the list of Hive fallback f...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13939 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13939: [SPARK-16248][SQL] Whitelist the list of Hive fallback f...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13939 **[Test build #61358 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61358/consoleFull)** for PR 13939 at commit

[GitHub] spark issue #13937: [SPARK-16245] [ML] model loading backward compatibility ...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13937 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13937: [SPARK-16245] [ML] model loading backward compatibility ...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13937 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61350/ Test PASSed. ---

[GitHub] spark issue #13937: [SPARK-16245] [ML] model loading backward compatibility ...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13937 **[Test build #61350 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61350/consoleFull)** for PR 13937 at commit

[GitHub] spark issue #13921: [SPARK-16140][MLlib][SparkR][Docs] Group k-means method ...

2016-06-28 Thread keypointt
Github user keypointt commented on the issue: https://github.com/apache/spark/pull/13921 hi @mengxr I tried to modifiy in generics.R ``` #' @rdname spark.kmeans #' @export setGeneric("spark.kmeans", function(data, formula, ...) { standardGeneric("spark.kmeans") })

[GitHub] spark issue #13378: [SPARK-15643] [Doc] [ML] Update spark.ml and spark.mllib...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13378 **[Test build #61364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61364/consoleFull)** for PR 13378 at commit

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13906 **[Test build #61363 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61363/consoleFull)** for PR 13906 at commit

[GitHub] spark issue #13931: [SPARK-16224] [SQL] [PYSPARK] SparkSession builder's con...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13931 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13931: [SPARK-16224] [SQL] [PYSPARK] SparkSession builder's con...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13931 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61360/ Test PASSed. ---

[GitHub] spark issue #13931: [SPARK-16224] [SQL] [PYSPARK] SparkSession builder's con...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13931 **[Test build #61360 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61360/consoleFull)** for PR 13931 at commit

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13680 **[Test build #61362 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61362/consoleFull)** for PR 13680 at commit

[GitHub] spark issue #13758: [SPARK-16043][SQL] Prepare GenericArrayData implementati...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13758 **[Test build #61361 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61361/consoleFull)** for PR 13758 at commit

[GitHub] spark issue #13940: [SPARK-16241] [ML] model loading backward compatibility ...

2016-06-28 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/13940 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

2016-06-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r68703430 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseEmptyPlanSuite.scala --- @@ -0,0 +1,133 @@ +/* + *

[GitHub] spark issue #13858: [SPARK-16148] [Scheduler] Allow for underscores in TaskL...

2016-06-28 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13858 I had an outstanding comment from the previous PR too: https://github.com/apache/spark/pull/13857#discussion_r68134544 --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request #13930: [SPARK-16228][SQL] HiveSessionCatalog should retu...

2016-06-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13930#discussion_r68702737 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -174,6 +175,18 @@ private[sql] class HiveSessionCatalog(

[GitHub] spark issue #13940: [SPARK-16241] [ML] model loading backward compatibility ...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13940 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #13940: [SPARK-16241] [ML] model loading backward compati...

2016-06-28 Thread zlpmichelle
GitHub user zlpmichelle opened a pull request: https://github.com/apache/spark/pull/13940 [SPARK-16241] [ML] model loading backward compatibility for ml NaiveBayes #16241 ## What changes were proposed in this pull request? model loading backward compatibility for ml

[GitHub] spark pull request #13903: [SPARK-16202] [SQL] [DOC] Correct The Description...

2016-06-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13903 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13903: [SPARK-16202] [SQL] [DOC] Correct The Description of Cre...

2016-06-28 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13903 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #13930: [SPARK-16228][SQL] HiveSessionCatalog should retu...

2016-06-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13930#discussion_r68702096 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -174,6 +175,18 @@ private[sql] class HiveSessionCatalog(

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13906 Anyway, thank you for review again, @rxin ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13938: [SPARK-15863][SQL][DOC][FOLLOW-UP] Update SQL programmin...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13938 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13938: [SPARK-15863][SQL][DOC][FOLLOW-UP] Update SQL programmin...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13938 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61355/ Test PASSed. ---

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

2016-06-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r68701978 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1053,6 +1055,41 @@ object PruneFilters extends

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

2016-06-28 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r68701768 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1053,6 +1055,41 @@ object PruneFilters extends

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

2016-06-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r68701793 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseEmptyPlanSuite.scala --- @@ -0,0 +1,133 @@ +/* + *

[GitHub] spark issue #13931: [SPARK-16224] [SQL] [PYSPARK] SparkSession builder's con...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13931 **[Test build #61360 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61360/consoleFull)** for PR 13931 at commit

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

2016-06-28 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r68701620 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseEmptyPlanSuite.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to

<    3   4   5   6   7   8