[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80609718 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,366 @@ +/* + * Licensed to the

[GitHub] spark pull request #15249: [SPARK-17675] [CORE] Expand Blacklist for TaskSet...

2016-09-26 Thread squito
GitHub user squito opened a pull request: https://github.com/apache/spark/pull/15249 [SPARK-17675] [CORE] Expand Blacklist for TaskSets ## What changes were proposed in this pull request? This is a step along the way to SPARK-8425. To enable incremental review, the

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80609252 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,366 @@ +/* + * Licensed to the

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80609099 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,366 @@ +/* + * Licensed to the

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80607976 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala --- @@ -0,0 +1,155 @@ +/* + * Licensed

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80607882 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala --- @@ -0,0 +1,155 @@ +/* + * Licensed

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80607795 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala --- @@ -0,0 +1,155 @@ +/* + * Licensed

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80607406 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala --- @@ -0,0 +1,155 @@ +/* + * Licensed

[GitHub] spark issue #15239: [SPARK-17665][SPARKR][WIP] Support options/mode all for ...

2016-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15239 > I'm a bit worry about the function signature changes - could we have some tests for before/after? @felixcheung just to make sure, you mean some tests like the ones in

[GitHub] spark pull request #15239: [SPARK-17665][SPARKR][WIP] Support options/mode a...

2016-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15239#discussion_r80606823 --- Diff: R/pkg/R/SQLContext.R --- @@ -835,7 +843,7 @@ loadDF <- function(x, ...) { #' @note createExternalTable since 1.4.0

[GitHub] spark pull request #15239: [SPARK-17665][SPARKR][WIP] Support options/mode a...

2016-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15239#discussion_r80606767 --- Diff: R/pkg/R/utils.R --- @@ -334,6 +334,27 @@ varargsToEnv <- function(...) { env } +# Utility function to capture the varargs

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80606631 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -149,6 +160,14 @@ private[kafka010] case class

[GitHub] spark issue #15235: [SPARK-17661][SQL] Consolidate various listLeafFiles imp...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15235 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15235: [SPARK-17661][SQL] Consolidate various listLeafFiles imp...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15235 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65936/ Test PASSed. ---

[GitHub] spark issue #15235: [SPARK-17661][SQL] Consolidate various listLeafFiles imp...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15235 **[Test build #65936 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65936/consoleFull)** for PR 15235 at commit

[GitHub] spark issue #12576: [SPARK-14804][Spark][Graphx] Fix Graph vertexRDD/EdgeRDD...

2016-09-26 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/12576 Actually, correction. Here is a better fix. The key problem here is that the RDD internal logic for computing from checkpoints, depends on a public, override-able API. This is wrong. Either the

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80605915 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the

[GitHub] spark pull request #15239: [SPARK-17665][SPARKR][WIP] Support options/mode a...

2016-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15239#discussion_r80605768 --- Diff: R/pkg/R/DataFrame.R --- @@ -743,8 +743,12 @@ setMethod("toJSON", #' @note write.json since 1.6.0 setMethod("write.json",

[GitHub] spark pull request #13680: [SPARK-15962][SQL] Introduce implementation with ...

2016-09-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13680#discussion_r80605670 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java --- @@ -33,134 +37,213 @@ // The offset

[GitHub] spark pull request #13680: [SPARK-15962][SQL] Introduce implementation with ...

2016-09-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13680#discussion_r80605631 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java --- @@ -33,134 +37,213 @@ // The offset

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-09-26 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/13680 @cloud-fan could you please review this again? I addressed your comments. After rebasing, the performance issue has been solved. --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #12576: [SPARK-14804][Spark][Graphx] Fix Graph vertexRDD/EdgeRDD...

2016-09-26 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/12576 also, ping @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #12576: [SPARK-14804][Spark][Graphx] Fix Graph vertexRDD/EdgeRDD...

2016-09-26 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/12576 This fix is roughly in the right direction. However there are two major concerns. - It changes the behavior of VertexRDD.isCheckpointed() which is a public method. - There must be new tests

[GitHub] spark issue #15102: [SPARK-17346][SQL] Add Kafka source for Structured Strea...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15102 **[Test build #65937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65937/consoleFull)** for PR 15102 at commit

[GitHub] spark issue #15090: [SPARK-17073] [SQL] generate column-level statistics

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15090 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15090: [SPARK-17073] [SQL] generate column-level statistics

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15090 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65935/ Test FAILed. ---

[GitHub] spark issue #15090: [SPARK-17073] [SQL] generate column-level statistics

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15090 **[Test build #65935 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65935/consoleFull)** for PR 15090 at commit

[GitHub] spark issue #15232: [SPARK-17499][SPARKR][FOLLOWUP] Check null first for lay...

2016-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15232 Sure, filed in https://issues.apache.org/jira/browse/SPARK-17674 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15248: [SPARK-17671] Spark 2.0 history server summary page is s...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15248 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15248: [SPARK-17671] Spark 2.0 history server summary pa...

2016-09-26 Thread wgtmac
GitHub user wgtmac opened a pull request: https://github.com/apache/spark/pull/15248 [SPARK-17671] Spark 2.0 history server summary page is slow even set spark.history.ui.maxApplications ## What changes were proposed in this pull request? Added a overloaded method

[GitHub] spark issue #14659: [SPARK-16757] Set up Spark caller context to HDFS and YA...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14659 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14659: [SPARK-16757] Set up Spark caller context to HDFS and YA...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14659 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65934/ Test PASSed. ---

[GitHub] spark issue #14659: [SPARK-16757] Set up Spark caller context to HDFS and YA...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14659 **[Test build #65934 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65934/consoleFull)** for PR 14659 at commit

[GitHub] spark issue #14803: [SPARK-17153][SQL] Should read partition data when readi...

2016-09-26 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/14803 @marmbrus @frreiss @srowen @tdas Thanks for review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80599802 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80599360 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80599175 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80599004 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #14959: [SPARK-17387][PYSPARK] Creating SparkContext() fr...

2016-09-26 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/14959#discussion_r80599035 --- Diff: python/pyspark/conf.py --- @@ -101,13 +101,25 @@ def __init__(self, loadDefaults=True, _jvm=None, _jconf=None): self._jconf =

[GitHub] spark pull request #15231: [SPARK-17658][SPARKR] read.df/write.df API taking...

2016-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15231#discussion_r80598844 --- Diff: R/pkg/R/utils.R --- @@ -698,6 +698,21 @@ isSparkRShell <- function() { grepl(".*shell\\.R$", Sys.getenv("R_PROFILE_USER"), perl = TRUE)

[GitHub] spark issue #15053: [Doc] improve python API docstrings

2016-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15053 Also, I guess this change will be an example and will affect all the Python documentation and worry disagreement from others in the future. So, I'd rather set a clear reason and investigation

[GitHub] spark pull request #15216: [SPARK-17577][Follow-up][SparkR] SparkR spark.add...

2016-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15216 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15053: [Doc] improve python API docstrings

2016-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15053 IMHO, i think the original author intended to avoid creating each dataframe in each method docstring. I am uncertain about doing each method docstring although I do prefer verbose/complete

[GitHub] spark issue #15216: [SPARK-17577][Follow-up][SparkR] SparkR spark.addFile su...

2016-09-26 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/15216 Merged into master, thanks for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15247: [SPARK-17672] Spark 2.0 history server web Ui takes too ...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15247 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15247: [SPARK-17672] Spark 2.0 history server web Ui tak...

2016-09-26 Thread wgtmac
GitHub user wgtmac opened a pull request: https://github.com/apache/spark/pull/15247 [SPARK-17672] Spark 2.0 history server web Ui takes too long for a single application ## What changes were proposed in this pull request? Added a new API getApplicationInfo(appId: String)

[GitHub] spark issue #13998: [SPARK-12177][Streaming][Kafka] limit api surface area

2016-09-26 Thread koeninger
Github user koeninger commented on the issue: https://github.com/apache/spark/pull/13998 Sure I'll give it another look On Sep 26, 2016 3:46 PM, "Tathagata Das" wrote: > @koeninger Could you take a look at this

[GitHub] spark issue #11601: [SPARK-13568] [ML] Create feature transformer to impute ...

2016-09-26 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/11601 I agree we should plan to support multiple columns and Vector columns in the future. The 2 places I noticed may cause problems in the future are: * ```ImputerModel.surrogate```: This is nice

[GitHub] spark pull request #15231: [SPARK-17658][SPARKR] read.df/write.df API taking...

2016-09-26 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15231#discussion_r80596168 --- Diff: R/pkg/R/utils.R --- @@ -698,6 +698,21 @@ isSparkRShell <- function() { grepl(".*shell\\.R$", Sys.getenv("R_PROFILE_USER"), perl = TRUE)

[GitHub] spark pull request #14959: [SPARK-17387][PYSPARK] Creating SparkContext() fr...

2016-09-26 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/spark/pull/14959#discussion_r80596041 --- Diff: python/pyspark/conf.py --- @@ -101,13 +101,25 @@ def __init__(self, loadDefaults=True, _jvm=None, _jconf=None): self._jconf =

[GitHub] spark pull request #11601: [SPARK-13568] [ML] Create feature transformer to ...

2016-09-26 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r80592740 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #11601: [SPARK-13568] [ML] Create feature transformer to ...

2016-09-26 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r80592752 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #11601: [SPARK-13568] [ML] Create feature transformer to ...

2016-09-26 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r80594424 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #11601: [SPARK-13568] [ML] Create feature transformer to ...

2016-09-26 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r80595926 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/ImputerSuite.scala --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #11601: [SPARK-13568] [ML] Create feature transformer to ...

2016-09-26 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r80593819 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #11601: [SPARK-13568] [ML] Create feature transformer to ...

2016-09-26 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r80593061 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #11601: [SPARK-13568] [ML] Create feature transformer to ...

2016-09-26 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r80594974 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #11601: [SPARK-13568] [ML] Create feature transformer to ...

2016-09-26 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r80593916 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #15235: [SPARK-17661][SQL] Consolidate various listLeafFiles imp...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15235 **[Test build #65936 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65936/consoleFull)** for PR 15235 at commit

[GitHub] spark pull request #15231: [SPARK-17658][SPARKR] read.df/write.df API taking...

2016-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15231#discussion_r80594580 --- Diff: R/pkg/R/utils.R --- @@ -698,6 +698,21 @@ isSparkRShell <- function() { grepl(".*shell\\.R$", Sys.getenv("R_PROFILE_USER"), perl = TRUE)

[GitHub] spark issue #15235: [SPARK-17661][SQL] Consolidate various listLeafFiles imp...

2016-09-26 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/15235 I pushed a new version that should address all the outstanding issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80594396 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -82,73 +85,185 @@ class

[GitHub] spark pull request #15238: [SPARK-17653][SQL] Remove unnecessary distincts i...

2016-09-26 Thread srinathshankar
Github user srinathshankar commented on a diff in the pull request: https://github.com/apache/spark/pull/15238#discussion_r80593959 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SetOperationSuite.scala --- @@ -76,4 +77,32 @@ class SetOperationSuite

[GitHub] spark pull request #15238: [SPARK-17653][SQL] Remove unnecessary distincts i...

2016-09-26 Thread srinathshankar
Github user srinathshankar commented on a diff in the pull request: https://github.com/apache/spark/pull/15238#discussion_r80593053 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -579,8 +579,13 @@ object

[GitHub] spark issue #9162: [SPARK-10655][SQL] Adding additional data type mappings t...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9162 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15246 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65933/ Test PASSed. ---

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15246 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #9162: [SPARK-10655][SQL] Adding additional data type mappings t...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9162 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65932/ Test PASSed. ---

[GitHub] spark issue #9162: [SPARK-10655][SQL] Adding additional data type mappings t...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9162 **[Test build #65932 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65932/consoleFull)** for PR 9162 at commit

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15246 **[Test build #65933 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65933/consoleFull)** for PR 15246 at commit

[GitHub] spark issue #11601: [SPARK-13568] [ML] Create feature transformer to impute ...

2016-09-26 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/11601 I'll make a review pass now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15090: [SPARK-17073] [SQL] generate column-level statistics

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15090 **[Test build #65935 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65935/consoleFull)** for PR 15090 at commit

[GitHub] spark issue #15245: [SPARK-17666] Ensure that RecordReaders are closed by da...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15245 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65931/ Test PASSed. ---

[GitHub] spark issue #15245: [SPARK-17666] Ensure that RecordReaders are closed by da...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15245 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15245: [SPARK-17666] Ensure that RecordReaders are closed by da...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15245 **[Test build #65931 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65931/consoleFull)** for PR 15245 at commit

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80590071 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -82,73 +85,185 @@ class

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80588749 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalogSuite.scala --- @@ -0,0 +1,34 @@ +/* + *

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80588596 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -82,73 +85,185 @@ class

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80588669 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -82,73 +85,185 @@ class

[GitHub] spark pull request #15235: [SPARK-17661][SQL] Consolidate various listLeafFi...

2016-09-26 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/15235#discussion_r80588655 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -82,73 +85,185 @@ class

[GitHub] spark issue #15213: [SPARK-17644] [CORE] Do not add failedStages when abortS...

2016-09-26 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/15213 The fix is logically correct; however, the prior code is needlessly complex and not as easy to understand as it should be, and the proposed fix doesn't improve on that. I'd like to take the

[GitHub] spark issue #15196: [SPARK-17614] [SQL] sparkSession.read() .jdbc(***) use t...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15196 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15196: [SPARK-17614] [SQL] sparkSession.read() .jdbc(***) use t...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15196 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65928/ Test PASSed. ---

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80567253 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the

[GitHub] spark issue #15196: [SPARK-17614] [SQL] sparkSession.read() .jdbc(***) use t...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15196 **[Test build #65928 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65928/consoleFull)** for PR 15196 at commit

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80564114 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -0,0 +1,263 @@ +/* + * Licensed to

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80563908 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -0,0 +1,263 @@ +/* + * Licensed to

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80568269 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80568479 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80568553 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -0,0 +1,263 @@ +/* + * Licensed to

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80568624 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -0,0 +1,263 @@ +/* + * Licensed to

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80564169 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -0,0 +1,263 @@ +/* + * Licensed to

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80584097 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80563435 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80562234 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80567477 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80563104 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80563033 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80565318 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -0,0 +1,263 @@ +/* + * Licensed to

[GitHub] spark pull request #15102: [SPARK-17346][SQL] Add Kafka source for Structure...

2016-09-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15102#discussion_r80568036 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -0,0 +1,344 @@ +/* + * Licensed to the

<    1   2   3   4   5   6   >