[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15868 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15868 **[Test build #68641 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68641/consoleFull)** for PR 15868 at commit

[GitHub] spark pull request #15857: [SPARK-18300][SQL] Do not apply foldable propagat...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15857#discussion_r87932854 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -428,43 +428,47 @@ object FoldablePropagation

[GitHub] spark pull request #15857: [SPARK-18300][SQL] Do not apply foldable propagat...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15857#discussion_r87932789 --- Diff: sql/core/src/test/resources/sql-tests/results/group-by.sql.out --- @@ -131,3 +131,11 @@ FROM testData struct

[GitHub] spark pull request #15857: [SPARK-18300][SQL] Do not apply foldable propagat...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15857#discussion_r87932636 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala --- @@ -118,14 +118,30 @@ class

[GitHub] spark pull request #15857: [SPARK-18300][SQL] Do not apply foldable propagat...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15857#discussion_r87932525 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -428,43 +428,47 @@ object FoldablePropagation

[GitHub] spark pull request #15857: [SPARK-18300][SQL] Do not apply foldable propagat...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15857#discussion_r87932494 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -428,43 +428,47 @@ object FoldablePropagation

[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15279 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68646/ Test FAILed. ---

[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15279 **[Test build #68646 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68646/consoleFull)** for PR 15279 at commit

[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15279 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15279 **[Test build #68646 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68646/consoleFull)** for PR 15279 at commit

[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...

Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15279 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...

Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15279 Can you please change the title to have: "SPARK-12347" -> "[SPARK-12347]"? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15880 +1 on the postgres approach --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15880 Ok we need to make a decision here, to follow hive and give a warning message, or to follow postgres and cast string to the type of the other side. Personally I prefer the postgres way, I

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15880 **[Test build #68645 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68645/consoleFull)** for PR 15880 at commit

[GitHub] spark pull request #15877: [SPARK-18429] [SQL] implement a new Aggregate for...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15877#discussion_r87929682 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala --- @@ -0,0 +1,131 @@ +/* + *

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87906133 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala --- @@ -31,13 +31,9 @@ import org.apache.spark.sql.types.StructType /**

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87906309 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala --- @@ -46,21 +42,23 @@ import org.apache.spark.sql.types.StructType

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87844941 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala --- @@ -106,22 +123,24 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]] *

[GitHub] spark pull request #15877: [SPARK-18429] [SQL] implement a new Aggregate for...

Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/15877#discussion_r87929562 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala --- @@ -0,0 +1,131 @@ +/* + *

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87906709 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala --- @@ -46,21 +42,23 @@ import org.apache.spark.sql.types.StructType

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87874869 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala --- @@ -66,10 +66,10 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87878252 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala --- @@ -102,8 +103,7 @@ class MinHashModel private[ml] ( */

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87908012 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala --- @@ -125,11 +125,11 @@ class MinHash(override val uid: String) extends

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87922281 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala --- @@ -179,16 +211,13 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87904353 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/MinHashLSHSuite.scala --- @@ -24,7 +24,7 @@ import org.apache.spark.ml.util.DefaultReadWriteTest

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87875688 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala --- @@ -46,21 +42,23 @@ import org.apache.spark.sql.types.StructType

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87928721 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/BucketedRandomProjectionLSH.scala --- @@ -89,23 +90,25 @@ class RandomProjectionModel private[ml]

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87876322 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala --- @@ -102,8 +103,7 @@ class MinHashModel private[ml] ( */

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87871105 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala --- @@ -106,22 +106,24 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]] *

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87874663 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala --- @@ -35,26 +35,26 @@ private[ml] trait LSHParams extends HasInputCol with

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87910679 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala --- @@ -74,9 +72,12 @@ class MinHashModel private[ml] ( }

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87875995 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala --- @@ -74,9 +72,12 @@ class MinHashModel private[ml] ( }

[GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87844308 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala --- @@ -144,12 +152,12 @@ class MinHash(override val uid: String) extends

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15852 **[Test build #68644 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68644/consoleFull)** for PR 15852 at commit

[GitHub] spark pull request #15877: [SPARK-18429] [SQL] implement a new Aggregate for...

Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/15877#discussion_r87928329 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala --- @@ -0,0 +1,131 @@ +/* + *

[GitHub] spark issue #15885: [SPARK-18440][Structured Streaming] Pass correct query e...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15885 **[Test build #68643 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68643/consoleFull)** for PR 15885 at commit

[GitHub] spark issue #15885: [SPARK-18440][Structured Streaming] Pass correct query e...

Github user tdas commented on the issue: https://github.com/apache/spark/pull/15885 @marmbrus @rxin Can you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #15885: [SPARK-18440][Structured Streaming] Pass correct ...

GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/15885 [SPARK-18440][Structured Streaming] Pass correct query execution to FileFormatWriter ## What changes were proposed in this pull request? SPARK-18012 refactored the file write path in

[GitHub] spark issue #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip instal...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15659 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip instal...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15659 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68638/ Test PASSed. ---

[GitHub] spark issue #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip instal...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15659 **[Test build #68638 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68638/consoleFull)** for PR 15659 at commit

[GitHub] spark pull request #15702: [SPARK-18124] Observed delay based Event Time Wat...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15702 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15702: [SPARK-18124] Observed delay based Event Time Watermarks

Github user tdas commented on the issue: https://github.com/apache/spark/pull/15702 I am merging this to master and 2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15702: [SPARK-18124] Observed delay based Event Time Watermarks

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15702 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15702: [SPARK-18124] Observed delay based Event Time Watermarks

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15702 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68637/ Test PASSed. ---

[GitHub] spark issue #15702: [SPARK-18124] Observed delay based Event Time Watermarks

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15702 **[Test build #68637 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68637/consoleFull)** for PR 15702 at commit

[GitHub] spark issue #15884: [WIP][SPARK-18433][SQL] Improve DataSource option keys t...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15884 **[Test build #68642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68642/consoleFull)** for PR 15884 at commit

[GitHub] spark pull request #15883: [SPARK-18438][SPARKR][ML] spark.mlp should suppor...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15883#discussion_r87924839 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -395,46 +396,56 @@ test_that("spark.mlp", { model2 <- read.ml(modelPath) summary2

[GitHub] spark pull request #15884: [WIP][SPARK-18433][SQL] Improve DataSource option...

GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/15884 [WIP][SPARK-18433][SQL] Improve DataSource option keys to be more case-insensitive ## What changes were proposed in this pull request? This PR aims to improve DataSource option keys

[GitHub] spark pull request #15883: [SPARK-18438][SPARKR][ML] spark.mlp should suppor...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15883#discussion_r87923954 --- Diff: R/pkg/R/mllib.R --- @@ -896,9 +898,10 @@ setMethod("summary", signature(object = "LogisticRegressionModel"), #' summary(savedModel)

[GitHub] spark pull request #15883: [SPARK-18438][SPARKR][ML] spark.mlp should suppor...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15883#discussion_r87923913 --- Diff: R/pkg/R/mllib.R --- @@ -896,9 +898,10 @@ setMethod("summary", signature(object = "LogisticRegressionModel"), #' summary(savedModel)

[GitHub] spark pull request #15883: [SPARK-18438][SPARKR][ML] spark.mlp should suppor...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15883#discussion_r87923822 --- Diff: R/pkg/R/mllib.R --- @@ -896,9 +898,10 @@ setMethod("summary", signature(object = "LogisticRegressionModel"), #' summary(savedModel)

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15868 @gatorsmile , I addressed all comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15868 **[Test build #68641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68641/consoleFull)** for PR 15868 at commit

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15852 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15852 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68639/ Test FAILed. ---

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15852 **[Test build #68639 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68639/consoleFull)** for PR 15852 at commit

[GitHub] spark issue #15878: [SPARK-18430] [SQL] Fixed Exception Messages when Hittin...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15878 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15878: [SPARK-18430] [SQL] Fixed Exception Messages when Hittin...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15878 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68636/ Test PASSed. ---

[GitHub] spark issue #15878: [SPARK-18430] [SQL] Fixed Exception Messages when Hittin...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15878 **[Test build #68636 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68636/consoleFull)** for PR 15878 at commit

[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15704 Thank you, @hvanhovell ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15704 LGTM - pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15704 **[Test build #68640 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68640/consoleFull)** for PR 15704 at commit

[GitHub] spark issue #15868: [SPARK-18413][SQL] Control the number of JDBC connection...

Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15868 Thank you, @gatorsmile ! I'll update this soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #15874: [Spark-18408] API Improvements for LSH

Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15874 Can you please add "[ML]" to the PR title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15817: [SPARK-18366][PYSPARK] Add handleInvalid to Pyspark for ...

Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15817 Can you please add "[ML]" to the PR description? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #15868: [SPARK-18413][SQL] Control the number of JDBC con...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15868#discussion_r87915156 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -667,7 +667,14 @@ object JdbcUtils extends

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r87914133 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -243,7 +243,7 @@ partitionSpec ;

[GitHub] spark pull request #15868: [SPARK-18413][SQL] Control the number of JDBC con...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15868#discussion_r87913599 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -667,7 +667,14 @@ object JdbcUtils extends

[GitHub] spark issue #15868: [SPARK-18413][SQL] Control the number of JDBC connection...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15868 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15682: [SPARK-18169][SQL] Suppress warnings when dropping views...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15682 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68635/ Test PASSed. ---

[GitHub] spark issue #15682: [SPARK-18169][SQL] Suppress warnings when dropping views...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15682 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15682: [SPARK-18169][SQL] Suppress warnings when dropping views...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15682 **[Test build #68635 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68635/consoleFull)** for PR 15682 at commit

[GitHub] spark issue #15868: [SPARK-18413][SQL] Control the number of JDBC connection...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15868 **[Test build #68634 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68634/consoleFull)** for PR 15868 at commit

[GitHub] spark issue #15868: [SPARK-18413][SQL] Control the number of JDBC connection...

Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15868 `numPartitions` might be not a good name for this purpose. How about `maxConnections`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r87910722 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -418,27 +419,58 @@ case class

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r87910682 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -215,8 +215,14 @@ case class

[GitHub] spark pull request #15868: [SPARK-18413][SQL] Control the number of JDBC con...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15868#discussion_r87910285 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -667,7 +667,14 @@ object JdbcUtils extends

[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15704 Thank you for review, again. I'll fix them soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #15868: [SPARK-18413][SQL] Control the number of JDBC con...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15868#discussion_r87909790 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala --- @@ -70,6 +70,9 @@ class JDBCOptions( }

[GitHub] spark pull request #14720: SPARK-12868: Allow Add jar to add jars from hdfs/...

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/14720#discussion_r87908473 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -856,6 +856,17 @@ class HiveQuerySuite extends

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15852 **[Test build #68639 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68639/consoleFull)** for PR 15852 at commit

[GitHub] spark issue #14638: [SPARK-11374][SQL] Support `skip.header.line.count` opti...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14638 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68633/ Test PASSed. ---

[GitHub] spark issue #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip instal...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15659 **[Test build #68638 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68638/consoleFull)** for PR 15659 at commit

[GitHub] spark issue #14638: [SPARK-11374][SQL] Support `skip.header.line.count` opti...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14638 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14638: [SPARK-11374][SQL] Support `skip.header.line.count` opti...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14638 **[Test build #68633 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68633/consoleFull)** for PR 14638 at commit

[GitHub] spark issue #15868: [SPARK-18413][SQL] Control the number of JDBC connection...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15868 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15868: [SPARK-18413][SQL] Control the number of JDBC connection...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15868 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68630/ Test PASSed. ---

[GitHub] spark issue #15840: [SPARK-18398][SQL] Fix nullabilities of MapObjects and o...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15840 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68629/ Test PASSed. ---

[GitHub] spark issue #15868: [SPARK-18413][SQL] Control the number of JDBC connection...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15868 **[Test build #68630 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68630/consoleFull)** for PR 15868 at commit

[GitHub] spark issue #15840: [SPARK-18398][SQL] Fix nullabilities of MapObjects and o...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15840 **[Test build #68629 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68629/consoleFull)** for PR 15840 at commit

[GitHub] spark issue #15702: [SPARK-18124] Observed delay based Event Time Watermarks

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15702 **[Test build #68637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68637/consoleFull)** for PR 15702 at commit

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15880 Below contains a section of `Implicit Data Conversion` in Oracle: https://docs.oracle.com/cd/B19306_01/server.102/b14200/sql_elements002.htm It clearly documents the potential changes in

[GitHub] spark issue #15702: [SPARK-18124] Observed delay based Event Time Watermarks

Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/15702 jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15702: [SPARK-18124] Observed delay based Event Time Watermarks

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15702 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68631/ Test FAILed. ---

[GitHub] spark issue #15702: [SPARK-18124] Observed delay based Event Time Watermarks

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15702 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15702: [SPARK-18124] Observed delay based Event Time Watermarks

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15702 **[Test build #68631 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68631/consoleFull)** for PR 15702 at commit

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r87892226 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -215,8 +215,14 @@ case class

<    1   2   3   4   5   >