[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89654874 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292 @@ +/* + *

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89645958 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292 @@ +/* + *

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89654611 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292 @@ +/* + *

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89647893 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292 @@ +/* + *

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89652140 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292 @@ +/* + *

[GitHub] spark issue #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for unidoc...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16013 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69171/ Test FAILed. ---

[GitHub] spark issue #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for unidoc...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16013 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for unidoc...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16013 **[Test build #69171 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69171/consoleFull)** for PR 16013 at commit

[GitHub] spark issue #15780: [SPARK-18284][SQL] Make ExpressionEncoder.serializer.nul...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15780 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69170/ Test PASSed. ---

[GitHub] spark issue #15780: [SPARK-18284][SQL] Make ExpressionEncoder.serializer.nul...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15780 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15780: [SPARK-18284][SQL] Make ExpressionEncoder.serializer.nul...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15780 **[Test build #69170 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69170/consoleFull)** for PR 15780 at commit

[GitHub] spark issue #15966: [SPARK-18413][SQL][FOLLOW-UP] Use `numPartitions` instea...

2016-11-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15966 Thank you for review and merging, @rxin , @gatorsmile , @cloud-fan ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for unidoc...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16013 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69169/ Test PASSed. ---

[GitHub] spark issue #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for unidoc...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16013 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for unidoc...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16013 **[Test build #69169 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69169/consoleFull)** for PR 16013 at commit

[GitHub] spark issue #16012: [SPARK-17251][SQL] Support `OuterReference` in projectio...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16012 **[Test build #69173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69173/consoleFull)** for PR 16012 at commit

[GitHub] spark issue #15977: [SPARK-18436][SQL] isin causing SQL syntax error with JD...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15977 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69168/ Test PASSed. ---

[GitHub] spark issue #15977: [SPARK-18436][SQL] isin causing SQL syntax error with JD...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15977 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15977: [SPARK-18436][SQL] isin causing SQL syntax error with JD...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15977 **[Test build #69168 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69168/consoleFull)** for PR 15977 at commit

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15913 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15913 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69167/ Test FAILed. ---

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15913 **[Test build #69167 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69167/consoleFull)** for PR 15913 at commit

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89649796 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -262,7 +262,7 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging

[GitHub] spark issue #16011: [SPARK-18587][ML] Remove handleInvalid from QuantileDisc...

2016-11-25 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/16011 Typically the estimator Params are copied to the model though. How do you propose to set the handle invalid param in say a pipeline? On Fri, 25 Nov 2016 at 18:38, Yanbo Liang

[GitHub] spark issue #16007: [SPARK-18583][SQL] Fix nullability of InputFileName.

2016-11-25 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16007 Actually this can be nullable if input file name is not set, isn't it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #15966: [SPARK-18413][SQL][FOLLOW-UP] Use `numPartitions`...

2016-11-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15966 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15916: [SPARK-18487][SQL] Add completion listener to HashAggreg...

2016-11-25 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15916 No it's not needed if you are using exactly the same way as the catch-all to release memory. It is basically just the catch-all itself. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #15966: [SPARK-18413][SQL][FOLLOW-UP] Use `numPartitions` instea...

2016-11-25 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15966 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16003: [SPARK-18482][SQL] make sure Spark can access the table ...

2016-11-25 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16003 The main thing I'd add is to add comment explaining what version of Spark would generate those table props. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #15960: [SPARK-18521] Add `NoRedundantStringInterpolator` Scala ...

2016-11-25 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15960 It doesn't really hurt my eyes, but I can see why it hurts yours. GitHub doesn't even show the diff on all the files, and a large change like this is really easy to miss something wrong (e.g. one

[GitHub] spark issue #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuffer impl...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15736 **[Test build #69172 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69172/consoleFull)** for PR 15736 at commit

[GitHub] spark issue #15717: [SPARK-17910][SQL] Allow users to update the comment of ...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15717 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69166/ Test PASSed. ---

[GitHub] spark issue #15717: [SPARK-17910][SQL] Allow users to update the comment of ...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15717 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15717: [SPARK-17910][SQL] Allow users to update the comment of ...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15717 **[Test build #69166 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69166/consoleFull)** for PR 15717 at commit

[GitHub] spark issue #16012: [SPARK-17251][SQL] Support `OuterReference` in projectio...

2016-11-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16012 Thank you, @hvanhovell ! I'll fix like that! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for unidoc...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16013 **[Test build #69171 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69171/consoleFull)** for PR 16013 at commit

[GitHub] spark issue #15780: [SPARK-18284][SQL] Make ExpressionEncoder.serializer.nul...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15780 **[Test build #69170 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69170/consoleFull)** for PR 15780 at commit

[GitHub] spark issue #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for unidoc...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16013 **[Test build #69169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69169/consoleFull)** for PR 16013 at commit

[GitHub] spark issue #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for unidoc...

2016-11-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16013 cc @srowen, this PR finally resolves the issue and makes `sbt unidoc` working fine with Java 8! Let me try to double check and leave some comments. --- If your project is set up for it, you

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-25 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/16013 [WIP][SPARK-3359][DOCS] Make javadoc8 working for unidoc/genjavadoc compatibility in API Java documentation ## What changes were proposed in this pull request? This PR make `sbt

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89645855 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,201 @@ +/* + *

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89644591 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292 @@ +/* + *

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89644918 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292 @@ +/* + *

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89644764 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292 @@ +/* + *

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89645138 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292 @@ +/* + *

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89644268 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292 @@ +/* + *

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89644178 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,201 @@ +/* + *

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89616284 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292 @@ +/* + *

[GitHub] spark issue #15977: [SPARK-18436][SQL] isin causing SQL syntax error with JD...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15977 **[Test build #69168 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69168/consoleFull)** for PR 15977 at commit

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15913 **[Test build #69167 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69167/consoleFull)** for PR 15913 at commit

[GitHub] spark issue #16011: [SPARK-18587][ML] Remove handleInvalid from QuantileDisc...

2016-11-25 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/16011 @MLnick Your description is totally correct. However, the ```model``` you used in your example is type of ```Bucketizer```. I will keep ```handleInvalid``` in ```Bucketizer```. In the current ML

[GitHub] spark issue #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuffer impl...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15736 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69165/ Test PASSed. ---

[GitHub] spark issue #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuffer impl...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15736 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuffer impl...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15736 **[Test build #69165 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69165/consoleFull)** for PR 15736 at commit

[GitHub] spark issue #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuffer impl...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15736 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuffer impl...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15736 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69164/ Test PASSed. ---

[GitHub] spark issue #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuffer impl...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15736 **[Test build #69164 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69164/consoleFull)** for PR 15736 at commit

[GitHub] spark issue #15717: [SPARK-17910][SQL] Allow users to update the comment of ...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15717 **[Test build #69166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69166/consoleFull)** for PR 15717 at commit

[GitHub] spark issue #15717: [SPARK-17910][SQL] Allow users to update the comment of ...

2016-11-25 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/15717 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuff...

2016-11-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15736#discussion_r89632807 --- Diff: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala --- @@ -74,6 +74,31 @@ private[spark] object

[GitHub] spark pull request #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuff...

2016-11-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15736#discussion_r89632292 --- Diff: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala --- @@ -74,6 +74,31 @@ private[spark] object

[GitHub] spark pull request #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuff...

2016-11-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15736#discussion_r89631867 --- Diff: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala --- @@ -74,6 +74,31 @@ private[spark] object

[GitHub] spark pull request #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuff...

2016-11-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15736#discussion_r89632234 --- Diff: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala --- @@ -74,6 +74,31 @@ private[spark] object

[GitHub] spark pull request #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuff...

2016-11-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15736#discussion_r89632750 --- Diff: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala --- @@ -74,6 +74,31 @@ private[spark] object

[GitHub] spark pull request #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuff...

2016-11-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15736#discussion_r89632043 --- Diff: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala --- @@ -74,6 +74,31 @@ private[spark] object

[GitHub] spark pull request #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuff...

2016-11-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15736#discussion_r89631815 --- Diff: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala --- @@ -74,6 +74,31 @@ private[spark] object

[GitHub] spark pull request #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuff...

2016-11-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15736#discussion_r89632769 --- Diff: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala --- @@ -74,6 +74,31 @@ private[spark] object

[GitHub] spark pull request #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuff...

2016-11-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15736#discussion_r89631952 --- Diff: core/src/main/scala/org/apache/spark/util/collection/PartitionedPairBuffer.scala --- @@ -74,8 +74,8 @@ private[spark] class

[GitHub] spark pull request #13460: [SPARK-15615] [SQL] Support Json input from Datas...

2016-11-25 Thread pjfanning
Github user pjfanning closed the pull request at: https://github.com/apache/spark/pull/13460 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16012: [SPARK-17251][SQL] Support `OuterReference` in projectio...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16012 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16012: [SPARK-17251][SQL] Support `OuterReference` in projectio...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16012 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69163/ Test PASSed. ---

[GitHub] spark issue #16012: [SPARK-17251][SQL] Support `OuterReference` in projectio...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16012 **[Test build #69163 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69163/consoleFull)** for PR 16012 at commit

[GitHub] spark issue #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuffer impl...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15736 **[Test build #69165 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69165/consoleFull)** for PR 15736 at commit

[GitHub] spark issue #15736: [SPARK-18224] [CORE] Optimise PartitionedPairBuffer impl...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15736 **[Test build #69164 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69164/consoleFull)** for PR 15736 at commit

[GitHub] spark pull request #15977: [SPARK-18436][SQL] isin causing SQL syntax error ...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15977#discussion_r89618869 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -120,6 +120,7 @@ object JDBCRDD extends Logging {

[GitHub] spark pull request #15977: [SPARK-18436][SQL] isin causing SQL syntax error ...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15977#discussion_r89618580 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -114,10 +114,14 @@ object

[GitHub] spark issue #15977: [SPARK-18436][SQL] isin causing SQL syntax error with JD...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15977 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69161/ Test PASSed. ---

[GitHub] spark issue #15977: [SPARK-18436][SQL] isin causing SQL syntax error with JD...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15977 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15977: [SPARK-18436][SQL] isin causing SQL syntax error with JD...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15977 **[Test build #69161 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69161/consoleFull)** for PR 15977 at commit

[GitHub] spark issue #15717: [SPARK-17910][SQL] Allow users to update the comment of ...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15717 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69162/ Test FAILed. ---

[GitHub] spark issue #15717: [SPARK-17910][SQL] Allow users to update the comment of ...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15717 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15717: [SPARK-17910][SQL] Allow users to update the comment of ...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15717 **[Test build #69162 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69162/consoleFull)** for PR 15717 at commit

[GitHub] spark pull request #15965: [SPARK-18356] [ML] Improve MLKmeans Performance

2016-11-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15965 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15965: [SPARK-18356] [ML] Improve MLKmeans Performance

2016-11-25 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15965 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #16012: [SPARK-17251][SQL] Support `OuterReference` in pr...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16012#discussion_r89615090 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala --- @@ -356,10 +356,17 @@ case class

[GitHub] spark pull request #16012: [SPARK-17251][SQL] Support `OuterReference` in pr...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16012#discussion_r89615403 --- Diff: sql/core/src/test/resources/sql-tests/inputs/correlated.sql --- @@ -0,0 +1,18 @@ +CREATE TEMPORARY VIEW t1 AS SELECT * FROM VALUES 1, 2 AS

[GitHub] spark pull request #15990: [SPARK-18559] [SQL] Fix HLL++ with small relative...

2016-11-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15990 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15990: [SPARK-18559] [SQL] Fix HLL++ with small relative error

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15990 LGTM - merging to master/2.1. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15913 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69160/ Test FAILed. ---

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15913 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15913 **[Test build #69160 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69160/consoleFull)** for PR 15913 at commit

[GitHub] spark issue #15965: [SPARK-18356] [ML] Improve MLKmeans Performance

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15965 **[Test build #3438 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3438/consoleFull)** for PR 15965 at commit

[GitHub] spark pull request #15817: [SPARK-18366][PYSPARK][ML] Add handleInvalid to P...

2016-11-25 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/15817#discussion_r89609989 --- Diff: python/pyspark/ml/feature.py --- @@ -158,21 +158,28 @@ class Bucketizer(JavaTransformer, HasInputCol, HasOutputCol, JavaMLReadable, Jav

[GitHub] spark issue #16011: [SPARK-18587][ML] Remove handleInvalid from QuantileDisc...

2016-11-25 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/16011 I don't think this is correct. The idea is `QuantileDiscretizer` skips NaN when creating the buckets, but there will still be an error thrown during `transform` (rather than `fit`) if NaNs are in

[GitHub] spark issue #16012: [SPARK-17251][SQL] Support `OuterReference` in projectio...

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16012 **[Test build #69163 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69163/consoleFull)** for PR 16012 at commit

[GitHub] spark issue #13775: [SPARK-16060][SQL] Vectorized Orc reader

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13775 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69156/ Test PASSed. ---

[GitHub] spark issue #13775: [SPARK-16060][SQL] Vectorized Orc reader

2016-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13775 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16012: [SPARK-17251][SQL] Support `OuterReference` in pr...

2016-11-25 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/16012 [SPARK-17251][SQL] Support `OuterReference` in projection list of a correlated subquery ## What changes were proposed in this pull request? Currently, correlated subqueries does not

[GitHub] spark issue #13775: [SPARK-16060][SQL] Vectorized Orc reader

2016-11-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13775 **[Test build #69156 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69156/consoleFull)** for PR 13775 at commit

[GitHub] spark pull request #15999: [SPARK-3359][BUILD][DOCS] More changes to resolve...

2016-11-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15999 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

<    1   2   3   >