[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-03-17 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r106726296 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -780,19 +788,33 @@ class LogisticRegressionModel private[s

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-03-17 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r106726508 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1394,13 +1575,13 @@ class BinaryLogisticRegressionSummary

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-03-17 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r106727670 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1086,83 +1115,124 @@ private[classification] class MultiC

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-03-17 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r106534308 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1197,7 +1267,7 @@ class BinaryLogisticRegressionSummary

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-03-17 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r106728259 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -780,19 +788,33 @@ class LogisticRegressionModel private[s

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-03-17 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r106726431 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1242,11 +1312,122 @@ class BinaryLogisticRegressionSummar

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-03-17 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r106725472 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -813,9 +835,16 @@ class LogisticRegressionModel private[sp

[GitHub] spark issue #17216: [SPARK-19873][SS] Record num shuffle partitions in offse...

2017-03-17 Thread kunalkhamar
Github user kunalkhamar commented on the issue: https://github.com/apache/spark/pull/17216 @zsxwing Will change cloning of listener manager in a new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #17216: [SPARK-19873][SS] Record num shuffle partitions in offse...

2017-03-17 Thread kunalkhamar
Github user kunalkhamar commented on the issue: https://github.com/apache/spark/pull/17216 @uncleGen Not sure what that means, could you please elaborate? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark issue #17216: [SPARK-19873][SS] Record num shuffle partitions in offse...

2017-03-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17216 **[Test build #74754 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74754/testReport)** for PR 17216 at commit [`3ae4414`](https://github.com/apache/spark/commit/3a

[GitHub] spark pull request #17216: [SPARK-19873][SS] Record num shuffle partitions i...

2017-03-17 Thread kunalkhamar
Github user kunalkhamar commented on a diff in the pull request: https://github.com/apache/spark/pull/17216#discussion_r106724958 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLogSuite.scala --- @@ -29,12 +30,32 @@ class OffsetSeqLogSuite exte

[GitHub] spark pull request #17216: [SPARK-19873][SS] Record num shuffle partitions i...

2017-03-17 Thread kunalkhamar
Github user kunalkhamar commented on a diff in the pull request: https://github.com/apache/spark/pull/17216#discussion_r106724948 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -549,9 +581,15 @@ class StreamExecution(

[GitHub] spark issue #17311: [SPARK-19970][SQL] Table owner should be USER instead of...

2017-03-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17311 **[Test build #74753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74753/testReport)** for PR 17311 at commit [`258ff8d`](https://github.com/apache/spark/commit/25

[GitHub] spark issue #17311: [SPARK-19970][SQL] Table owner should be USER instead of...

2017-03-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17311 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74748/ Test PASSed. ---

[GitHub] spark issue #17311: [SPARK-19970][SQL] Table owner should be USER instead of...

2017-03-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17311 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17311: [SPARK-19970][SQL] Table owner should be USER instead of...

2017-03-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17311 **[Test build #74748 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74748/testReport)** for PR 17311 at commit [`2959d98`](https://github.com/apache/spark/commit/2

[GitHub] spark pull request #17246: [SPARK-19906][SS][DOCS] Documentation describing ...

2017-03-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17246#discussion_r106722579 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -373,11 +375,204 @@ The following configurations are optional: +## Produci

[GitHub] spark pull request #17246: [SPARK-19906][SS][DOCS] Documentation describing ...

2017-03-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17246#discussion_r106722231 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -373,11 +375,204 @@ The following configurations are optional: +## Produci

[GitHub] spark pull request #17246: [SPARK-19906][SS][DOCS] Documentation describing ...

2017-03-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17246#discussion_r106722120 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -373,11 +375,204 @@ The following configurations are optional: +## Produci

[GitHub] spark pull request #17246: [SPARK-19906][SS][DOCS] Documentation describing ...

2017-03-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17246#discussion_r106721924 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -3,9 +3,9 @@ layout: global title: Structured Streaming + Kafka Integration Guide (Kafka br

[GitHub] spark pull request #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence...

2017-03-17 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17336#discussion_r106721298 --- Diff: mllib/src/test/scala/org/apache/spark/ml/fpm/FPGrowthSuite.scala --- @@ -95,28 +125,17 @@ class FPGrowthSuite extends SparkFunSuite with MLlibTest

[GitHub] spark pull request #17246: [SPARK-19906][SS][DOCS] Documentation describing ...

2017-03-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17246#discussion_r106721185 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -373,11 +375,204 @@ The following configurations are optional: +## Produci

[GitHub] spark pull request #17246: [SPARK-19906][SS][DOCS] Documentation describing ...

2017-03-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17246#discussion_r106721109 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -373,11 +375,204 @@ The following configurations are optional: +## Produci

[GitHub] spark pull request #17246: [SPARK-19906][SS][DOCS] Documentation describing ...

2017-03-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17246#discussion_r106720890 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -373,11 +375,204 @@ The following configurations are optional: +## Produci

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-03-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17336 **[Test build #74752 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74752/testReport)** for PR 17336 at commit [`3398d62`](https://github.com/apache/spark/commit/33

[GitHub] spark pull request #17246: [SPARK-19906][SS][DOCS] Documentation describing ...

2017-03-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17246#discussion_r106720832 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -373,11 +375,204 @@ The following configurations are optional: +## Produci

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-03-17 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/17336 ping @jkbradley and @srowen to be aware of the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence...

2017-03-17 Thread hhbyyh
GitHub user hhbyyh opened a pull request: https://github.com/apache/spark/pull/17336 [SPARK-20003] [ML] FPGrowthModel setMinConfidence should affect rules generation and transform ## What changes were proposed in this pull request? jira: https://issues.apache.org/jira/brows

[GitHub] spark pull request #17246: [SPARK-19906][SS][DOCS] Documentation describing ...

2017-03-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17246#discussion_r106720658 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -373,11 +375,204 @@ The following configurations are optional: +## Produci

[GitHub] spark pull request #17246: [SPARK-19906][SS][DOCS] Documentation describing ...

2017-03-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17246#discussion_r106720722 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -373,11 +375,204 @@ The following configurations are optional: +## Produci

[GitHub] spark issue #17320: [SPARK-19967][SQL] Add from_json in FunctionRegistry

2017-03-17 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/17320 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] spark pull request #17246: [SPARK-19906][SS][DOCS] Documentation describing ...

2017-03-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17246#discussion_r106720282 --- Diff: docs/structured-streaming-kafka-integration.md --- @@ -373,11 +375,204 @@ The following configurations are optional: +## Produci

[GitHub] spark issue #17166: [SPARK-19820] [core] Allow reason to be specified for ta...

2017-03-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17166 **[Test build #74751 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74751/testReport)** for PR 17166 at commit [`8f7ffb3`](https://github.com/apache/spark/commit/8f

[GitHub] spark issue #17166: [SPARK-19820] [core] Allow reason to be specified for ta...

2017-03-17 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/17166 jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-03-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r106717092 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2598,4 +2598,26 @@ class SQLQuerySuite extends QueryTest with SharedS

[GitHub] spark issue #17320: [SPARK-19967][SQL] Add from_json in FunctionRegistry

2017-03-17 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17320 LGTM cc @ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] spark pull request #17323: [SPARK-19986][Tests]Make pyspark.streaming.tests....

2017-03-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #17323: [SPARK-19986][Tests]Make pyspark.streaming.tests.Checkpo...

2017-03-17 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/17323 LGTM. Merging to master and 2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] spark issue #17311: [SPARK-19970][SQL] Table owner should be USER instead of...

2017-03-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17311 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74750/ Test FAILed. ---

[GitHub] spark issue #17311: [SPARK-19970][SQL] Table owner should be USER instead of...

2017-03-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17311 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17311: [SPARK-19970][SQL] Table owner should be USER instead of...

2017-03-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17311 **[Test build #74750 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74750/testReport)** for PR 17311 at commit [`5efdf8b`](https://github.com/apache/spark/commit/5

[GitHub] spark pull request #17216: [SPARK-19873][SS] Record num shuffle partitions i...

2017-03-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17216#discussion_r106709281 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -549,9 +581,15 @@ class StreamExecution(

[GitHub] spark pull request #17216: [SPARK-19873][SS] Record num shuffle partitions i...

2017-03-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17216#discussion_r106709791 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLogSuite.scala --- @@ -29,12 +30,32 @@ class OffsetSeqLogSuite extends

[GitHub] spark issue #9518: [SPARK-11574][Core] Add metrics StatsD sink

2017-03-17 Thread knoguchi
Github user knoguchi commented on the issue: https://github.com/apache/spark/pull/9518 why is this PR left untouched more than a year? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark issue #17311: [SPARK-19970][SQL] Table owner should be USER instead of...

2017-03-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17311 **[Test build #74750 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74750/testReport)** for PR 17311 at commit [`5efdf8b`](https://github.com/apache/spark/commit/5e

[GitHub] spark issue #17088: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-03-17 Thread kayousterhout
Github user kayousterhout commented on the issue: https://github.com/apache/spark/pull/17088 One meta question here: why aren't we getting a SlaveLost message in this case? I'm asking since there's already code in #14931 to un-register shuffle service files when we get a SlaveLost me

[GitHub] spark issue #17327: [SPARK-19721][SS][BRANCH-2.1] Good error message for ver...

2017-03-17 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/17327 LGTM. Merging to 2.1. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] spark pull request #15363: [SPARK-17791][SQL] Join reordering using star sch...

2017-03-17 Thread ioana-delaney
Github user ioana-delaney commented on a diff in the pull request: https://github.com/apache/spark/pull/15363#discussion_r106706226 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -167,8 +167,8 @@ object ExtractFiltersAndInnerJoin

[GitHub] spark pull request #17311: [SPARK-19970][SQL] Table owner should be USER ins...

2017-03-17 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/17311#discussion_r106706282 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -851,7 +851,7 @@ private[hive] object HiveClientImpl {

[GitHub] spark issue #15363: [SPARK-17791][SQL] Join reordering using star schema det...

2017-03-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15363 **[Test build #74749 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74749/testReport)** for PR 15363 at commit [`15bc13d`](https://github.com/apache/spark/commit/15

[GitHub] spark pull request #17311: [SPARK-19970][SQL] Table owner should be USER ins...

2017-03-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17311#discussion_r106705542 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -851,7 +851,7 @@ private[hive] object HiveClientImpl {

[GitHub] spark pull request #17311: [SPARK-19970][SQL] Table owner should be USER ins...

2017-03-17 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/17311#discussion_r106704898 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -851,7 +851,7 @@ private[hive] object HiveClientImpl {

[GitHub] spark issue #16305: [SPARK-18895][TESTS] Fix resource-closing-related and pa...

2017-03-17 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/16305 yeah... there's really not much we can do about this. thanks for bringing it to my attention tho. On Fri, Mar 17, 2017 at 12:40 AM, Hyukjin Kwon wrote: > @shaneknapp

[GitHub] spark issue #17311: [SPARK-19970][SQL] Table owner should be USER instead of...

2017-03-17 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17311 I fixed that, @vanzin . Thank you again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #17306: [SPARK-19979][MLLIB] Allow multiple pipelines when tunin...

2017-03-17 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/17306 Thanks @leifker for the PR, this is a good idea. I think though it can already be accomplished with the current param grid builder. Since the stages of a pipeline are actually a param, you can

[GitHub] spark issue #17311: [SPARK-19970][SQL] Table owner should be USER instead of...

2017-03-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17311 **[Test build #74748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74748/testReport)** for PR 17311 at commit [`2959d98`](https://github.com/apache/spark/commit/29

[GitHub] spark pull request #17311: [SPARK-19970][SQL] Table owner should be USER ins...

2017-03-17 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/17311#discussion_r106701151 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -851,7 +851,7 @@ private[hive] object HiveClientImpl {

[GitHub] spark pull request #17311: [SPARK-19970][SQL] Table owner should be USER ins...

2017-03-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17311#discussion_r106700799 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -851,7 +851,7 @@ private[hive] object HiveClientImpl {

[GitHub] spark pull request #17311: [SPARK-19970][SQL] Table owner should be USER ins...

2017-03-17 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/17311#discussion_r106700592 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -851,7 +851,7 @@ private[hive] object HiveClientImpl {

[GitHub] spark pull request #17311: [SPARK-19970][SQL] Table owner should be USER ins...

2017-03-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17311#discussion_r106700241 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -851,7 +851,7 @@ private[hive] object HiveClientImpl {

[GitHub] spark pull request #17335: [SPARK-19995][Hive][Yarn] Using real user to init...

2017-03-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17335#discussion_r106700053 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -353,6 +354,25 @@ class SparkHadoopUtil extends Logging { }

[GitHub] spark pull request #17311: [SPARK-19970][SQL] Table owner should be USER ins...

2017-03-17 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/17311#discussion_r106699621 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -851,7 +851,7 @@ private[hive] object HiveClientImpl {

[GitHub] spark issue #14617: [SPARK-17019][Core] Expose on-heap and off-heap memory u...

2017-03-17 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/14617 hi @jerryshao sorry this went unnoticed for so long, if you bring this up to date I'll keep an eye on it. Before this change, is off-heap storage completely ignored in the UI? Or does the U

[GitHub] spark pull request #17311: [SPARK-19970][SQL] Table owner should be USER ins...

2017-03-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17311#discussion_r106697544 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -851,7 +851,7 @@ private[hive] object HiveClientImpl {

[GitHub] spark issue #17170: [SPARK-19825][R][ML] spark.ml R API for FPGrowth

2017-03-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17170 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17170: [SPARK-19825][R][ML] spark.ml R API for FPGrowth

2017-03-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17170 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74747/ Test PASSed. ---

[GitHub] spark issue #17170: [SPARK-19825][R][ML] spark.ml R API for FPGrowth

2017-03-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17170 **[Test build #74747 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74747/testReport)** for PR 17170 at commit [`7635afc`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

2017-03-17 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/16867 @jinxing64 would you mind repeating your performance experiments with the lastest version? Both for `checkSpeculatableTasks` and also for inserting the duration on each task completion? --- If you

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106691642 --- Diff: core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala --- @@ -63,12 +83,40 @@ private[spark] object CryptoStreamUtils extends Loggi

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106691384 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -73,55 +86,219 @@ private[spark] class DiskStore(conf: SparkConf, diskManager:

[GitHub] spark issue #17333: [SPARK-19997] [SQL]fix proxy ugi could not get tgt to ca...

2017-03-17 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17333 You and @jerryshao need to flip a coin (#17335). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark issue #17088: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-03-17 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/17088 One thing which I noticed while making sense of what was going in the code (even before) -- IIRC, spark standalone is a bit of a special case. I think it used to be the case that to run multiple exe

[GitHub] spark pull request #17295: [SPARK-19556][core] Do not encrypt block manager ...

2017-03-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17295#discussion_r106691863 --- Diff: core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala --- @@ -102,4 +150,34 @@ private[spark] object CryptoStreamUtils extends Log

[GitHub] spark issue #17295: [SPARK-19556][core] Do not encrypt block manager data in...

2017-03-17 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17295 > shall we also transfer shuffle blocks after decryption? No. That's explained in the PR description. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark pull request #17088: [SPARK-19753][CORE] Un-register all shuffle outpu...

2017-03-17 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17088#discussion_r106669055 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1390,7 +1401,34 @@ class DAGScheduler( } } else {

[GitHub] spark pull request #17088: [SPARK-19753][CORE] Un-register all shuffle outpu...

2017-03-17 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17088#discussion_r106684005 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1390,7 +1401,34 @@ class DAGScheduler( } } else {

[GitHub] spark pull request #17088: [SPARK-19753][CORE] Un-register all shuffle outpu...

2017-03-17 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17088#discussion_r106670128 --- Diff: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala --- @@ -394,6 +394,68 @@ class DAGSchedulerSuite extends SparkFunSuite with

[GitHub] spark pull request #17088: [SPARK-19753][CORE] Un-register all shuffle outpu...

2017-03-17 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17088#discussion_r106668930 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1365,18 +1369,25 @@ class DAGScheduler( */ private[schedul

[GitHub] spark pull request #17088: [SPARK-19753][CORE] Un-register all shuffle outpu...

2017-03-17 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17088#discussion_r106677939 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1390,7 +1401,34 @@ class DAGScheduler( } } else {

[GitHub] spark issue #17251: [SPARK-19910][SQL] `stack` should not reject NULL values...

2017-03-17 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17251 Hi, @cloud-fan . Could you review `stack` PR? If there is anything to do, please let me know. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] spark issue #17311: [SPARK-19970][SQL] Table owner should be USER instead of...

2017-03-17 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17311 Hi, @gatorsmile . Could you review this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #17311: [SPARK-19970][SQL] Table owner should be USER ins...

2017-03-17 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/17311#discussion_r106685501 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -851,7 +851,7 @@ private[hive] object HiveClientImpl {

[GitHub] spark issue #17170: [SPARK-19825][R][ML] spark.ml R API for FPGrowth

2017-03-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17170 **[Test build #74747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74747/testReport)** for PR 17170 at commit [`7635afc`](https://github.com/apache/spark/commit/76

[GitHub] spark issue #17335: [SPARK-19995][Hive][Yarn] Using real user to initialize ...

2017-03-17 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17335 Thank you, @jerryshao . I'll test on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive ser...

2017-03-17 Thread xwu0226
Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r106682311 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -175,6 +178,98 @@ case class AlterTableRenameCommand( }

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive ser...

2017-03-17 Thread xwu0226
Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r106682210 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala --- @@ -450,6 +451,26 @@ abstract class SessionCatalo

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive ser...

2017-03-17 Thread xwu0226
Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r106682149 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala --- @@ -450,6 +451,26 @@ abstract class SessionCatalo

[GitHub] spark pull request #17315: [SPARK-19949][SQL] unify bad record handling in C...

2017-03-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17315#discussion_r106650196 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/FailureSafeParser.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the A

[GitHub] spark pull request #17315: [SPARK-19949][SQL] unify bad record handling in C...

2017-03-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17315#discussion_r106664841 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/FailureSafeParser.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the A

[GitHub] spark pull request #17315: [SPARK-19949][SQL] unify bad record handling in C...

2017-03-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17315#discussion_r106664412 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/FailureSafeParser.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the A

[GitHub] spark pull request #17319: [SPARK-19765][SPARK-18549][SPARK-19093][SPARK-197...

2017-03-17 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/17319 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17315: [SPARK-19949][SQL] unify bad record handling in C...

2017-03-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17315#discussion_r106655740 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala --- @@ -233,81 +187,39 @@ class UnivocityParser(

[GitHub] spark pull request #17315: [SPARK-19949][SQL] unify bad record handling in C...

2017-03-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17315#discussion_r106653556 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -55,108 +52,6 @@ class JacksonParser( privat

[GitHub] spark pull request #17315: [SPARK-19949][SQL] unify bad record handling in C...

2017-03-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17315#discussion_r106648055 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/FailureSafeParser.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the A

[GitHub] spark issue #17334: [SPARK-19998][Block Manager]BlockRDD block not found Exc...

2017-03-17 Thread jianran
Github user jianran commented on the issue: https://github.com/apache/spark/pull/17334 @srowen Use string interpolation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark issue #17307: [SPARK-13369] Make number of consecutive fetch failures ...

2017-03-17 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/17307 merged to master (slightly reworded the first line of the commit msg so it all fit). thanks @sitalkedia, especially for sticking with this despite the delays, our nitpickiness, and the flaky

[GitHub] spark pull request #17307: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17307 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #17170: [SPARK-19825][R][ML] spark.ml R API for FPGrowth

2017-03-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17170 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74746/ Test PASSed. ---

[GitHub] spark issue #17170: [SPARK-19825][R][ML] spark.ml R API for FPGrowth

2017-03-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17170 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17170: [SPARK-19825][R][ML] spark.ml R API for FPGrowth

2017-03-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17170 **[Test build #74746 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74746/testReport)** for PR 17170 at commit [`89a5815`](https://github.com/apache/spark/commit/8

<    1   2   3   4   5   >