[GitHub] spark pull request #17640: [SPARK-17608][SPARKR]:Long type has incorrect ser...

2017-04-28 Thread wangmiao1981
Github user wangmiao1981 commented on a diff in the pull request: https://github.com/apache/spark/pull/17640#discussion_r113972686 --- Diff: R/pkg/R/serialize.R --- @@ -83,6 +83,7 @@ writeObject <- function(con, object, writeType = TRUE) { Date = writeDate(con, object)

[GitHub] spark pull request #17711: [SPARK-19951][SQL] Add string concatenate operato...

2017-04-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17711#discussion_r113972077 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -547,6 +547,10 @@ valueExpression | left=valueExpr

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113971968 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures +t

[GitHub] spark pull request #17800: [SPARK-20459][SQL] JdbcUtils throws IllegalStateE...

2017-04-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17800#discussion_r113971640 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -653,7 +653,13 @@ object JdbcUtils extends Logg

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17804 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17804 **[Test build #76275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76275/testReport)** for PR 17804 at commit [`4ad21fe`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17804 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76275/ Test PASSed. ---

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113970275 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures +t

[GitHub] spark issue #17790: [SPARK-20514][CORE] Upgrade Jetty to 9.3.11.v20160721

2017-04-28 Thread markgrover
Github user markgrover commented on the issue: https://github.com/apache/spark/pull/17790 Thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113969133 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures +t

[GitHub] spark issue #17803: [SPARK-20523][BUILD] Clean up build warnings for 2.2.0 r...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17803 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17803: [SPARK-20523][BUILD] Clean up build warnings for 2.2.0 r...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17803 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76269/ Test FAILed. ---

[GitHub] spark issue #17803: [SPARK-20523][BUILD] Clean up build warnings for 2.2.0 r...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17803 **[Test build #76269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76269/testReport)** for PR 17803 at commit [`bd3de24`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #17785: [SPARK-20493][R] De-duplicate parse logics for DDL-like ...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17785 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17785: [SPARK-20493][R] De-duplicate parse logics for DDL-like ...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17785 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76270/ Test PASSed. ---

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17804 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] spark issue #17785: [SPARK-20493][R] De-duplicate parse logics for DDL-like ...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17785 **[Test build #76270 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76270/testReport)** for PR 17785 at commit [`e9d672a`](https://github.com/apache/spark/commit/e

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113967945 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures +t

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17804 **[Test build #76275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76275/testReport)** for PR 17804 at commit [`4ad21fe`](https://github.com/apache/spark/commit/4a

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread anabranch
Github user anabranch commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113966339 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -108,6 +111,22 @@ class KafkaSinkSuite extends

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread anabranch
Github user anabranch commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113966362 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -108,6 +111,22 @@ class KafkaSinkSuite extends

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread anabranch
Github user anabranch commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113966304 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -108,6 +111,22 @@ class KafkaSinkSuite extends

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread anabranch
Github user anabranch commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113966089 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -26,13 +26,16 @@ import org.scalatest.time.Spa

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread anabranch
Github user anabranch commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113966069 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -26,13 +26,16 @@ import org.scalatest.time.Spa

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113965109 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -108,6 +111,22 @@ class KafkaSinkSuite extends St

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113965237 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -108,6 +111,22 @@ class KafkaSinkSuite extends St

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113965269 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -108,6 +111,22 @@ class KafkaSinkSuite extends St

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113965053 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -26,13 +26,16 @@ import org.scalatest.time.SpanSu

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113965033 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -26,13 +26,16 @@ import org.scalatest.time.SpanSu

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread anabranch
Github user anabranch commented on the issue: https://github.com/apache/spark/pull/17804 yeah it's broken in both, only visible in 1. Not sure if that needs to be in 2 PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17804 @hvanhovell We need this fix in master as well. It somehow works magically in master, but is broken for sure in 2.1 --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17804 @anabranch can you open this against branch-2.1 instead of master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #17680: [SPARK-20364][SQL] Support Parquet predicate pushdown on...

2017-04-28 Thread ash211
Github user ash211 commented on the issue: https://github.com/apache/spark/pull/17680 Any further thoughts on this? It was quite surprising for one of our users so I wanted to make sure it was fixed in a future Apache release --- If your project is set up for it, you can reply to th

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113962864 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures +t

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15009 **[Test build #76274 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76274/testReport)** for PR 15009 at commit [`7ee465f`](https://github.com/apache/spark/commit/7e

[GitHub] spark issue #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17802 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17802 **[Test build #76273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76273/testReport)** for PR 17802 at commit [`affcbc0`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17802 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76273/ Test FAILed. ---

[GitHub] spark issue #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17802 **[Test build #76273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76273/testReport)** for PR 17802 at commit [`affcbc0`](https://github.com/apache/spark/commit/af

[GitHub] spark issue #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17802 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cache...

2017-04-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17802#discussion_r113957644 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala --- @@ -420,6 +422,18 @@ class CatalogImpl(sparkSession: SparkSession)

[GitHub] spark pull request #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cache...

2017-04-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17802#discussion_r113957718 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala --- @@ -420,6 +422,18 @@ class CatalogImpl(sparkSession: SparkSession)

[GitHub] spark pull request #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cache...

2017-04-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17802#discussion_r113957314 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala --- @@ -420,6 +422,18 @@ class CatalogImpl(sparkSession: SparkSession)

[GitHub] spark pull request #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cache...

2017-04-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17802#discussion_r113957208 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala --- @@ -477,6 +477,18 @@ abstract class Catalog { def cacheTable(tabl

[GitHub] spark pull request #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cache...

2017-04-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17802#discussion_r113957106 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala --- @@ -477,6 +477,18 @@ abstract class Catalog { def cacheTable(tabl

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17804 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17804 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76272/ Test PASSed. ---

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17804 **[Test build #76272 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76272/testReport)** for PR 17804 at commit [`77e25f1`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17804 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17804 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76271/ Test PASSed. ---

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17804 **[Test build #76271 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76271/testReport)** for PR 17804 at commit [`05f17c6`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15435 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76268/ Test PASSed. ---

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15435 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15435 **[Test build #76268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76268/testReport)** for PR 15435 at commit [`527b0eb`](https://github.com/apache/spark/commit/5

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113950929 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures +t

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113950943 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures +t

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-04-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r113950840 --- Diff: docs/cloud-integration.md --- @@ -0,0 +1,512 @@ +--- +layout: global +displayTitle: Integration with Cloud Infrastructures +t

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-04-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r113950702 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1231,6 +1295,109 @@ class BinaryLogisticRegressionSummary

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17804 **[Test build #76272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76272/testReport)** for PR 17804 at commit [`77e25f1`](https://github.com/apache/spark/commit/77

[GitHub] spark issue #17790: [SPARK-20514][CORE] Upgrade Jetty to 9.3.11.v20160721

2017-04-28 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17790 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread anabranch
Github user anabranch commented on the issue: https://github.com/apache/spark/pull/17804 cc @brkyvz this should be good to go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17804 **[Test build #76271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76271/testReport)** for PR 17804 at commit [`05f17c6`](https://github.com/apache/spark/commit/05

[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread anabranch
GitHub user anabranch opened a pull request: https://github.com/apache/spark/pull/17804 [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed Plans ## What changes were proposed in this pull request? We didn't enforce analyzed plans in Spark 2.1 when writing out to Kafka.

[GitHub] spark issue #17459: [SPARK-20109][MLlib] Rewrote toBlockMatrix method on Ind...

2017-04-28 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17459 @johnc1231 Thanks for updating this. I'll review it in the weekend. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark issue #17785: [SPARK-20493][R] De-duplicate parse logics for DDL-like ...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17785 **[Test build #76270 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76270/testReport)** for PR 17785 at commit [`e9d672a`](https://github.com/apache/spark/commit/e9

[GitHub] spark pull request #17801: [MINOR][SQL][DOCS] Improve unix_timestamp's scala...

2017-04-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17801#discussion_r113937642 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2657,22 +2661,27 @@ object functions { /** * Converts

[GitHub] spark issue #17803: [SPARK-20523][BUILD] Clean up build warnings for 2.2.0 r...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17803 **[Test build #76269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76269/testReport)** for PR 17803 at commit [`bd3de24`](https://github.com/apache/spark/commit/bd

[GitHub] spark pull request #17803: [SPARK-20523][BUILD] Clean up build warnings for ...

2017-04-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17803#discussion_r113934080 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/streaming/GroupStateTimeout.java --- @@ -37,7 +37,9 @@ * `map/flatMapGroupsWithState` by c

[GitHub] spark pull request #17803: [SPARK-20523][BUILD] Clean up build warnings for ...

2017-04-28 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/17803 [SPARK-20523][BUILD] Clean up build warnings for 2.2.0 release ## What changes were proposed in this pull request? Fix build warnings primarily related to Breeze 0.13 operator changes, "Pro

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-28 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/15435 `update v7` fix previous `LogisticRegressionSuite` conflicts and `fix nits` commit for some nits update. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark pull request #17785: [SPARK-20493][R] De-duplicate parse logics for DD...

2017-04-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113932971 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -92,48 +93,8 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark issue #17714: [SPARK-20428][Core]REST interface about 'v1/submissions/...

2017-04-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17714 I guess I am not used to this code path. Git blame says @tnachen changed the codes lately. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #17702: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2017-04-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17702 Not sure. Probably, @cloud-fan or @gatorsmile ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-28 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113927479 --- Diff: R/pkg/R/column.R --- @@ -302,3 +301,65 @@ setMethod("otherwise", jc <- callJMethod(x@jc, "otherwise", value) colu

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15435 **[Test build #76268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76268/testReport)** for PR 15435 at commit [`527b0eb`](https://github.com/apache/spark/commit/52

[GitHub] spark issue #17801: [MINOR][SQL][DOCS] Improve unix_timestamp's scaladoc (an...

2017-04-28 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17801 Are the errors (that led to `fails to generate documentation`) after my change? Look very weird to me. ``` [error] /home/jenkins/workspace/SparkPullRequestBuilder/core/target/jav

[GitHub] spark issue #12614: [SPARK-14730][ML] Expose ColumnPruner as feature transfo...

2017-04-28 Thread davireis
Github user davireis commented on the issue: https://github.com/apache/spark/pull/12614 Just weighting in the motivations: https://0xdata.atlassian.net/browse/SW-224 http://apache-spark-developers-list.1001551.n3.nabble.com/spark-ml-Why-is-private-class-ColumnPruner-td168

[GitHub] spark issue #17800: [SPARK-20459][SQL] JdbcUtils throws IllegalStateExceptio...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17800 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17800: [SPARK-20459][SQL] JdbcUtils throws IllegalStateExceptio...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17800 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76265/ Test PASSed. ---

[GitHub] spark issue #17800: [SPARK-20459][SQL] JdbcUtils throws IllegalStateExceptio...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17800 **[Test build #76265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76265/testReport)** for PR 17800 at commit [`ad38533`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-28 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17793 You have some javadoc errors . See the full log --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17795 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76262/ Test PASSed. ---

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17795 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17795 **[Test build #76262 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76262/testReport)** for PR 17795 at commit [`3fdba11`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-28 Thread danielyli
Github user danielyli commented on the issue: https://github.com/apache/spark/pull/17793 How do I fix the “fails to generate documentation” error? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r113894646 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -791,32 +813,43 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark issue #17801: [MINOR][SQL][DOCS] Improve unix_timestamp's scaladoc (an...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17801 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76267/ Test FAILed. ---

[GitHub] spark issue #17801: [MINOR][SQL][DOCS] Improve unix_timestamp's scaladoc (an...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17801 **[Test build #76267 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76267/testReport)** for PR 17801 at commit [`c3cc96b`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #17801: [MINOR][SQL][DOCS] Improve unix_timestamp's scaladoc (an...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17801 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17736: [SPARK-20399][SQL] Can't use same regex pattern between ...

2017-04-28 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17736 Btw, I think the rules in `unescapeSQLString` are also inconsistent too. `\u` and `\000` don't follow others. I think we should fix this inconsistency between 1.6 and 2.0 if there is no

[GitHub] spark issue #17801: [MINOR][SQL][DOCS] Improve unix_timestamp's scaladoc (an...

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17801 **[Test build #76267 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76267/testReport)** for PR 17801 at commit [`c3cc96b`](https://github.com/apache/spark/commit/c3

[GitHub] spark issue #17742: [Spark-11968][ML][MLLIB]Optimize MLLIB ALS recommendForA...

2017-04-28 Thread mpjlu
Github user mpjlu commented on the issue: https://github.com/apache/spark/pull/17742 Thanks @MLnick. Please go ahead for ML API optimization. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark issue #17799: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17799 Opened new one #17802 with cleaner commit history. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark issue #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17802 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cache...

2017-04-28 Thread phatak-dev
GitHub user phatak-dev opened a pull request: https://github.com/apache/spark/pull/17802 [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable API ## What changes were proposed in this pull request? Currently cacheTable API only supports MEMORY_AND_DISK. This PR adds additional

[GitHub] spark issue #17796: [SPARK-20519][SQL][CORE]Modify to prevent some possible ...

2017-04-28 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/17796 ok, thanks for review it@srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark issue #17798: [SPARK-20521][DOC][CORE]

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17798 **[Test build #3680 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3680/testReport)** for PR 17798 at commit [`b32b753`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #17799: [SPARK-20495][SQL][CORE]Add StorageLevel to cache...

2017-04-28 Thread phatak-dev
Github user phatak-dev closed the pull request at: https://github.com/apache/spark/pull/17799 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17801: [MINOR][SQL][DOCS] Improve unix_timestamp's scala...

2017-04-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17801#discussion_r113879810 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2487,19 +2487,21 @@ object functions { */ def current_timestamp(

[GitHub] spark issue #17798: [SPARK-20521][DOC][CORE]

2017-04-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17798 **[Test build #3680 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3680/testReport)** for PR 17798 at commit [`b32b753`](https://github.com/apache/spark/commit/b

<    1   2   3   4   >