Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19148
LGTM except two minor comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19148#discussion_r137683665
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
---
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19129
Thank you for review, @gatorsmile , @HyukjinKwon , @maropu .
In this issue, I've learned how to track the unused stuff correctly. Thank
you again.
---
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19148#discussion_r137682740
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
---
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19148#discussion_r137682115
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
---
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19148
Less than 2 mins to finish the suite. It looks pretty good!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.or
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18956
LGTM except two minor comments
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-m
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137681045
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -64,6 +64,14 @@ abstract class RuleExecutor[TreeType
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137680999
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -64,6 +64,14 @@ abstract class RuleExecutor[TreeType
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137680545
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -534,4 +534,176 @@ class InsertIntoHiveTableSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137680153
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -360,6 +360,31 @@ case class Insert
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19129
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19129
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137678987
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerSICheckerSuite.scala
---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137679007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -64,6 +64,14 @@ abstract class RuleExecutor[TreeType <:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18956
**[Test build #81529 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81529/testReport)**
for PR 18956 at commit
[`d1db7cf`](https://github.com/apache/spark/commit/d1
Github user vanzin closed the pull request at:
https://github.com/apache/spark/pull/19046
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19046
I'm going to close this; when I find some free time I might take a closer
at the issue described in Wilfred's message.
---
-
To u
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19148#discussion_r137663570
--- Diff: sql/hive/pom.xml ---
@@ -177,6 +177,10 @@
libfb303
+ org.apache.derby
+ derby
--- End di
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19148
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81524/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19148
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19148
**[Test build #81524 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81524/testReport)**
for PR 19148 at commit
[`08dcf22`](https://github.com/apache/spark/commit/0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17589
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19129
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19129
**[Test build #81525 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81525/testReport)**
for PR 19129 at commit
[`8e3d8fe`](https://github.com/apache/spark/commit/8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17589
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81527/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19129
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81525/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17589
**[Test build #81527 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81527/testReport)**
for PR 17589 at commit
[`cbf8a22`](https://github.com/apache/spark/commit/c
Github user redsanket closed the pull request at:
https://github.com/apache/spark/pull/19103
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18975
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81528/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18975
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18975
**[Test build #81528 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81528/testReport)**
for PR 18975 at commit
[`4a5ff29`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19157
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19157
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81526/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19157
**[Test build #81526 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81526/testReport)**
for PR 19157 at commit
[`8b38300`](https://github.com/apache/spark/commit/8
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19155#discussion_r137650844
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -659,62 +659,67 @@ class HiveDDLSuite
}
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19129
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19129
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81523/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19129
**[Test build #81523 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81523/testReport)**
for PR 19129 at commit
[`40ed9ff`](https://github.com/apache/spark/commit/4
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/19130
sorry probably wont' get to this today, will look tomorrow.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19155
Since it's a big patch, `+408 â359`, we had better have a JIRA issue with
'TRIVIAL` priority.
---
-
To unsubscribe, e-ma
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19155#discussion_r137638893
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -1603,7 +1617,7 @@ class SQLQuerySuite extends Query
Github user ajbozarth commented on a diff in the pull request:
https://github.com/apache/spark/pull/19153#discussion_r137637831
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala ---
@@ -478,10 +476,11 @@ private[ui] class SQLStageMetrics(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19155#discussion_r137637931
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -370,21 +370,24 @@ class HiveQuerySuite extends Hiv
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19155#discussion_r137637228
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -349,21 +351,23 @@ class SQLQuerySuite extends Query
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19155#discussion_r137637074
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -116,69 +116,71 @@ class SQLQuerySuite extends Query
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19155#discussion_r137636117
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala
---
@@ -461,19 +471,23 @@ class InsertIntoHiveTableSuite e
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16578
@snir It's hard to pin down exactly where the problem is and how to fix it.
We removed the `NullIntolerant` trait from the implementations of the
`ExtractValue` trait in `complexTypeExtractors.scala
Github user snir commented on the issue:
https://github.com/apache/spark/pull/16578
@mallman Yes, the issue is only reproducible with codegen on. However the
performance improvement by codegen is too significant to disable. I managed to
fix it with some changes to the codegen (Added
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18975
**[Test build #81528 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81528/testReport)**
for PR 18975 at commit
[`4a5ff29`](https://github.com/apache/spark/commit/4a
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137629284
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -534,4 +534,150 @@ class InsertIntoHiveTableSuite extends QueryTest
Github user zhouyejoe closed the pull request at:
https://github.com/apache/spark/pull/18941
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17589
**[Test build #81527 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81527/testReport)**
for PR 17589 at commit
[`cbf8a22`](https://github.com/apache/spark/commit/cb
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19157
**[Test build #81526 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81526/testReport)**
for PR 19157 at commit
[`8b38300`](https://github.com/apache/spark/commit/8b
Github user dhruve commented on the issue:
https://github.com/apache/spark/pull/19157
Reopened this because CI was having issues with the previous PR.
[18950](https://github.com/apache/spark/pull/18950)
---
-
To uns
Github user dhruve commented on the issue:
https://github.com/apache/spark/pull/19157
@squito @markhamstra @tgravescs Can you review this PR. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user dhruve opened a pull request:
https://github.com/apache/spark/pull/19157
[SPARK-20589][Core][Scheduler] Allow limiting task concurrency per job group
## What changes were proposed in this pull request?
This change allows the user to specify the maximum no. of tasks ru
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19129
**[Test build #81525 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81525/testReport)**
for PR 19129 at commit
[`8e3d8fe`](https://github.com/apache/spark/commit/8e
Github user dhruve commented on the issue:
https://github.com/apache/spark/pull/18950
CI is having issues downloading my repo. Closing this PR and opening a new
one.
---
-
To unsubscribe, e-mail: reviews-unsubscr...
Github user dhruve closed the pull request at:
https://github.com/apache/spark/pull/18950
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19129#discussion_r137622298
--- Diff: docs/sql-programming-guide.md ---
@@ -1587,6 +1580,10 @@ options.
Note that this is different from the Hive behavior.
- A
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19129#discussion_r137621847
--- Diff: docs/sql-programming-guide.md ---
@@ -1587,6 +1580,10 @@ options.
Note that this is different from the Hive behavior.
- A
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19148#discussion_r137621549
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
---
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19148#discussion_r137621065
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogBackwardCompatibilitySuite.scala
---
@@ -1,260 +0,0 @@
-/*
- * Lic
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19148#discussion_r137621130
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -1354,31 +1354,4 @@ class MetastoreDataSourcesSuite ex
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19129#discussion_r137621009
--- Diff: docs/sql-programming-guide.md ---
@@ -1587,6 +1580,10 @@ options.
Note that this is different from the Hive behavior.
- A
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19148#discussion_r137620814
--- Diff: sql/hive/pom.xml ---
@@ -177,6 +177,10 @@
libfb303
+ org.apache.derby
+ derby
--- End diff -
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19129#discussion_r137620763
--- Diff: docs/sql-programming-guide.md ---
@@ -1587,6 +1580,10 @@ options.
Note that this is different from the Hive behavior.
- A
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19129#discussion_r137620489
--- Diff: docs/sql-programming-guide.md ---
@@ -1587,6 +1580,10 @@ options.
Note that this is different from the Hive behavior.
- A
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19148
**[Test build #81524 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81524/testReport)**
for PR 19148 at commit
[`08dcf22`](https://github.com/apache/spark/commit/08
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19129#discussion_r137619510
--- Diff: docs/sql-programming-guide.md ---
@@ -1587,6 +1580,10 @@ options.
Note that this is different from the Hive behavior.
- As a
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19129#discussion_r137619452
--- Diff: docs/sql-programming-guide.md ---
@@ -1587,6 +1580,10 @@ options.
Note that this is different from the Hive behavior.
- A
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19129#discussion_r137619209
--- Diff: docs/sql-programming-guide.md ---
@@ -1587,6 +1580,10 @@ options.
Note that this is different from the Hive behavior.
- As a
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19129#discussion_r137617487
--- Diff: docs/sql-programming-guide.md ---
@@ -1587,6 +1580,10 @@ options.
Note that this is different from the Hive behavior.
- A
Github user erikerlandson commented on the issue:
https://github.com/apache/spark/pull/19041
I have been thinking about a different but related [use
case](https://github.com/apache-spark-on-k8s/spark/issues/261); supporting the
ability to operate in dynamic allocation mode without req
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19129#discussion_r137616632
--- Diff: docs/sql-programming-guide.md ---
@@ -1587,6 +1580,10 @@ options.
Note that this is different from the Hive behavior.
- As a
Github user parente commented on a diff in the pull request:
https://github.com/apache/spark/pull/18339#discussion_r137616450
--- Diff: python/pyspark/java_gateway.py ---
@@ -33,14 +33,18 @@
from pyspark.serializers import read_int
-def launch_gateway(conf=None)
Github user parente commented on a diff in the pull request:
https://github.com/apache/spark/pull/18339#discussion_r137616353
--- Diff: python/pyspark/java_gateway.py ---
@@ -33,14 +33,18 @@
from pyspark.serializers import read_int
-def launch_gateway(conf=None)
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19148
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19148
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81520/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19148
**[Test build #81520 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81520/testReport)**
for PR 19148 at commit
[`3d827f9`](https://github.com/apache/spark/commit/3
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19129
**[Test build #81523 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81523/testReport)**
for PR 19129 at commit
[`40ed9ff`](https://github.com/apache/spark/commit/40
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137613115
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -64,6 +64,14 @@ abstract class RuleExecutor[TreeType
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137611075
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -93,6 +101,13 @@ abstract class RuleExecutor[TreeTyp
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137610235
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerSICheckerSuite.scala
---
@@ -0,0 +1,60 @@
+/*
+ * License
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137609405
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -93,6 +101,13 @@ abstract class RuleExecutor[TreeTyp
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19147
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81519/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19147
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137607929
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
---
@@ -0,0 +1,81 @@
+/*
+ * Licen
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19147
**[Test build #81519 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81519/testReport)**
for PR 19147 at commit
[`2f929d8`](https://github.com/apache/spark/commit/2
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137607749
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
---
@@ -0,0 +1,81 @@
+/*
+ * Licen
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137607545
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed to t
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137607475
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed to t
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19129
The PR title resolved two issues under title
`[SPARK-15639][SPARK-16321][SQL] Push down filter at RowGroups level for
parquet reader` I'll add like the following. Is it enough?
```
-
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137606401
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed to t
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137605940
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTmpPath.scala
---
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Sof
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137605602
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala ---
@@ -366,4 +367,43 @@ class InsertSuite extends DataSourceTest with
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137605509
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -140,6 +143,14 @@ case class DataSourceAnal
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137605311
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala
---
@@ -524,6 +525,50 @@ class DDLParserSuite extends Plan
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18956
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
101 - 200 of 385 matches
Mail list logo
