Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/19240#discussion_r139042816
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2256,7 +2256,10 @@ object CleanupAliases extends
Github user goldmedal commented on the issue:
https://github.com/apache/spark/pull/19223
@HyukjinKwon Thanks for triggering AppVeyor. In normal case, will AppVeyor
be triggered automatically?
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19240
**[Test build #81801 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81801/testReport)**
for PR 19240 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81797/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19239
**[Test build #81797 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81797/testReport)**
for PR 19239 at commit
GitHub user tdas opened a pull request:
https://github.com/apache/spark/pull/19240
[SPARK-22018][SQL]Preserve top-level alias metadata when collapsing projects
## What changes were proposed in this pull request?
If there are two projects like as follows.
```
Project
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19223
D'oh, yes. I wonder why it was not triggered. I manually triggered via my
account:
Build started: [SparkR] `ALL`
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19130#discussion_r139041065
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -897,6 +897,76 @@ class SparkSubmitSuite
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19231
**[Test build #81800 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81800/testReport)**
for PR 19231 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19227
Hi @vanzin thanks a lot for your comments. Would you please elaborate more?
I'm not sure if I really understand your comment. According to this PR I don't
think I ship the keytab around in
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19237
**[Test build #81799 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81799/testReport)**
for PR 19237 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19235
I agree with you. Okay. I'll refocus this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19226
(BTW, `list` on a list is not a no-op. It makes a copy up to my knowledge)
---
-
To unsubscribe, e-mail:
Github user hhbyyh commented on the issue:
https://github.com/apache/spark/pull/19208
It's OK to me to include the "dump model to disk"
https://github.com/apache/spark/pull/18313 in this or other PR (or not).
After reading the discussion, I feel it's an overkill to support a
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139036524
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/19211
I did a read-through of your code and didn't find any glaring issues, but
I'd like to go through it a bit more before passing judgment. Overall a nice
new feature though.
---
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/19207
Just a heads up I am planning on looking at this and just haven't had time
yet.
---
-
To unsubscribe, e-mail:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139036217
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139036315
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19231
**[Test build #81798 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81798/testReport)**
for PR 19231 at commit
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139035990
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139035867
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19226#discussion_r139035222
--- Diff: python/pyspark/tests.py ---
@@ -644,6 +644,18 @@ def test_cartesian_chaining(self):
set([(x, (y, y)) for x in range(10) for y
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/12646
This is pretty close to be merged. Thanks for your work!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139034626
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1179,6 +1179,26 @@ class AstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139034519
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1179,6 +1179,26 @@ class AstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139034536
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1179,6 +1179,26 @@ class AstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139034349
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -503,69 +504,307 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139034232
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -503,69 +504,307 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139034183
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -503,69 +504,307 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139034057
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -130,6 +130,13 @@ class StreamExecution(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139034043
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -503,69 +504,307 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139033482
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139034032
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -503,69 +504,307 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139033287
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -503,69 +504,307 @@ case class
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19235
> I wanted to raise this issue of convertMetastoreXXX things since
convertMetastoreXXX seems not to be tested completly
That's fine, but that's not what your change is proposing. If you look
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139033208
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139032904
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -535,6 +585,51 @@ public UTF8String trimRight() {
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139032875
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -535,6 +585,51 @@ public UTF8String trimRight() {
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139031227
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -503,69 +504,307 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19226#discussion_r139032001
--- Diff: python/pyspark/serializers.py ---
@@ -343,6 +343,8 @@ def _load_stream_without_unbatching(self, stream):
key_batch_stream =
Github user hhbyyh commented on the issue:
https://github.com/apache/spark/pull/18313
That's all right. Please just proceed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19238
Why not directly connecting to Hive metastore?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19180
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81796/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19180
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19180
**[Test build #81796 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81796/testReport)**
for PR 19180 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139027636
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -522,6 +537,41 @@ public UTF8String trimLeft() {
}
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139029401
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -560,13 +567,24 @@ class StreamExecution(
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139029187
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -130,6 +130,13 @@ class StreamExecution(
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139028613
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139027407
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -503,69 +504,307 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r139027297
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -503,69 +504,307 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139026379
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139026066
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139025952
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -560,13 +567,24 @@ class StreamExecution(
}
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139025814
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -130,6 +130,13 @@ class StreamExecution(
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139025554
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala
---
@@ -39,7 +39,7 @@ class IncrementalExecution(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19239
**[Test build #81797 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81797/testReport)**
for PR 19239 at commit
GitHub user joseph-torres opened a pull request:
https://github.com/apache/spark/pull/19239
[SPARK-22017] Take minimum of all watermark execs in StreamExecution.
## What changes were proposed in this pull request?
Take the minimum of all watermark exec nodes as the "real"
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19238
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19211
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81795/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19211
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user danielfx90 opened a pull request:
https://github.com/apache/spark/pull/19238
[SPARK-22016][SQL] Add HiveDialect for JDBC connection to Hive
## What changes were proposed in this pull request?
Added a HiveDialect for JDBC connection to Hive.
It overrides two
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19211
**[Test build #81795 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81795/testReport)**
for PR 19211 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19180
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19180
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81794/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19180
**[Test build #81794 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81794/testReport)**
for PR 19180 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19235
I'm not sure where I hit this before. But, I updated 'WHERE' clause
examples. Maybe, there was discussion on this difference.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12646
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12646
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81792/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12646
**[Test build #81792 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81792/testReport)**
for PR 12646 at commit
Github user brad-kaiser commented on a diff in the pull request:
https://github.com/apache/spark/pull/19041#discussion_r139005849
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -314,6 +314,7 @@ private[spark] class TaskSchedulerImpl(
Github user brad-kaiser commented on a diff in the pull request:
https://github.com/apache/spark/pull/19041#discussion_r139005783
--- Diff: core/src/main/scala/org/apache/spark/RecoverCacheShutdown.scala
---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software
Github user brad-kaiser commented on a diff in the pull request:
https://github.com/apache/spark/pull/19041#discussion_r139005809
--- Diff: core/src/main/scala/org/apache/spark/RecoverCacheShutdown.scala
---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software
Github user brad-kaiser commented on a diff in the pull request:
https://github.com/apache/spark/pull/19041#discussion_r139005738
--- Diff: core/src/main/scala/org/apache/spark/RecoverCacheShutdown.scala
---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software
Github user brad-kaiser commented on a diff in the pull request:
https://github.com/apache/spark/pull/19041#discussion_r139005649
--- Diff: core/src/main/scala/org/apache/spark/RecoverCacheShutdown.scala
---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software
Github user brad-kaiser commented on a diff in the pull request:
https://github.com/apache/spark/pull/19041#discussion_r139005697
--- Diff: core/src/main/scala/org/apache/spark/RecoverCacheShutdown.scala
---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software
Github user brad-kaiser commented on a diff in the pull request:
https://github.com/apache/spark/pull/19041#discussion_r139004878
--- Diff: core/src/main/scala/org/apache/spark/RecoverCacheShutdown.scala
---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software
Github user brad-kaiser commented on a diff in the pull request:
https://github.com/apache/spark/pull/19041#discussion_r139004913
--- Diff: core/src/main/scala/org/apache/spark/RecoverCacheShutdown.scala
---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software
Github user brad-kaiser commented on a diff in the pull request:
https://github.com/apache/spark/pull/19041#discussion_r139004286
--- Diff: core/src/main/scala/org/apache/spark/RecoverCacheShutdown.scala
---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software
Github user brad-kaiser commented on a diff in the pull request:
https://github.com/apache/spark/pull/19041#discussion_r139004156
--- Diff: core/src/main/scala/org/apache/spark/RecoverCacheShutdown.scala
---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81793/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #81793 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81793/testReport)**
for PR 19222 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81791/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19237
**[Test build #81791 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81791/testReport)**
for PR 19237 at commit
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/19194#discussion_r138993979
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -758,11 +812,58 @@ private[spark] class ExecutorAllocationManager(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19135#discussion_r138993630
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -325,6 +325,10 @@ private[spark] class MemoryStore(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19180
**[Test build #81796 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81796/testReport)**
for PR 19180 at commit
Github user original-brownbear commented on a diff in the pull request:
https://github.com/apache/spark/pull/19180#discussion_r138991030
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -1097,10 +1100,23 @@ public UTF8String copy() {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r138990593
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/UnsafeMemoryAllocator.java
---
@@ -19,28 +19,61 @@
import
Github user original-brownbear commented on a diff in the pull request:
https://github.com/apache/spark/pull/19180#discussion_r138990727
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -1097,10 +1100,23 @@ public UTF8String copy() {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r138990687
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/ByteArray.java ---
@@ -18,6 +18,7 @@
package org.apache.spark.unsafe.types;
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r138990652
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r138990731
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -46,6 +47,42 @@ public static int
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r138990513
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -46,6 +47,42 @@ public static int
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r138990552
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r138990440
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -75,67 +76,131 @@ public static boolean unaligned() {
return
101 - 200 of 456 matches
Mail list logo
