Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r156373480
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExpressionCodegenSuite.scala
---
@@ -0,0 +1,168 @@
+/*
+ *
Github user ferdonline commented on the issue:
https://github.com/apache/spark/pull/19805
Existing checkpoint tests applied to localCheckpoint as well, all working
well. Please verify.
I'm getting an unrelated fail in SparkR, did anything change n the build
system?
---
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r156363603
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -55,8 +55,45 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r156363168
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExpressionCodegenSuite.scala
---
@@ -0,0 +1,168 @@
+/*
+
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r156360136
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -55,8 +55,45 @@ import
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156360608
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -60,38 +60,32 @@ object
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156360583
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -60,38 +60,32 @@ object
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19916
LGTM, pending jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user danielvdende commented on the issue:
https://github.com/apache/spark/pull/19911
@srowen Sorry, should have been clearer, I meant the triggering of the
tests (I see they're running now, thanks! )
---
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19911
**[Test build #4007 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4007/testReport)**
for PR 19911 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19911
@danielvdende test don't pass yet. I've retriggered them. I don't see a
particularly long response cycle here.
---
-
To
Github user danielvdende commented on the issue:
https://github.com/apache/spark/pull/19911
Forgive my impatience, but is it supposed to take this long? @dongjoon-hyun
@gatorsmile
---
-
To unsubscribe, e-mail:
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r156356881
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -107,11 +107,11 @@ private[feature] trait
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19946#discussion_r156352778
--- Diff: sbin/build-push-docker-images.sh ---
@@ -0,0 +1,67 @@
+#!/usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF) under
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19949
Ah, I just checked the log and seems quite short. I take my words back. I
am fine.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19944
**[Test build #84768 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84768/testReport)**
for PR 19944 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19944
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19944
Yup, it looks passing fine now (roughly just a couple(?) of hours ago).
Seems the problem is this one(?)
```
* checking CRAN incoming feasibility ...Error in
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156349126
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1179,6 +1257,18 @@ object
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19904#discussion_r156348973
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -146,25 +147,18 @@ class CrossValidator @Since("1.2.0")
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156348687
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -203,18 +267,35 @@ class
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19944
To clarify it looks like SparkR test is failing in other PRs.
---
-
To unsubscribe, e-mail:
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/19946
Jenkins OK to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19944
Yes this seems unrelated - itâs just saying you need the package e1071 to
run the test.
Anyone know why SparkR tests are failing all of a sudden? There is nothing
in the log file
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156347570
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +189,64 @@ class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156347355
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +189,64 @@ class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156346890
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +189,64 @@ class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156346593
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +189,64 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19916
**[Test build #84767 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84767/testReport)**
for PR 19916 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19792
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84764/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19792
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19792
**[Test build #84764 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84764/testReport)**
for PR 19792 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19916
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19951
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84766/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19951
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19951
**[Test build #84766 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84766/testReport)**
for PR 19951 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19951
**[Test build #84766 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84766/testReport)**
for PR 19951 at commit
Github user KaiXinXiaoLei closed the pull request at:
https://github.com/apache/spark/pull/19945
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user KaiXinXiaoLei opened a pull request:
https://github.com/apache/spark/pull/19951
[SPARK-22760][CORE][YARN] When sc.stop() is called, set stopped is true
before removing executors
## What changes were proposed in this pull request?
When the number of executors is
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19811
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19811
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84761/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19950
**[Test build #84765 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84765/testReport)**
for PR 19950 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19811
**[Test build #84761 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84761/testReport)**
for PR 19811 at commit
GitHub user zhengruifeng opened a pull request:
https://github.com/apache/spark/pull/19950
[SPARK-22450][Core][MLLib][FollowUp] safely register class for mllib -
LabeledPoint/VectorWithNorm/TreePoint
## What changes were proposed in this pull request?
register following classes
Github user smurakozi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19599#discussion_r156339663
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -435,6 +435,43 @@ class BooleanParam(parent: String, name: String, doc:
Github user smurakozi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19599#discussion_r155782239
--- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala
---
@@ -139,6 +139,17 @@ class ParamsSuite extends SparkFunSuite {
Github user smurakozi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19599#discussion_r156086625
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -435,6 +435,43 @@ class BooleanParam(parent: String, name: String, doc:
Github user smurakozi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19599#discussion_r156339373
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -224,8 +222,8 @@ class LinearRegression @Since("1.3.0")
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19916
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84762/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19916
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19916
**[Test build #84762 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84762/testReport)**
for PR 19916 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r156340749
--- Diff: python/pyspark/sql/types.py ---
@@ -1083,7 +1083,8 @@ def _infer_schema(row):
elif hasattr(row, "_fields"): # namedtuple
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19792
**[Test build #84764 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84764/testReport)**
for PR 19792 at commit
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r156339240
--- Diff: python/pyspark/sql/types.py ---
@@ -1083,7 +1083,8 @@ def _infer_schema(row):
elif hasattr(row, "_fields"): # namedtuple
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r156338937
--- Diff: python/pyspark/sql/types.py ---
@@ -1083,7 +1083,8 @@ def _infer_schema(row):
elif hasattr(row, "_fields"): # namedtuple
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r156337091
--- Diff: python/pyspark/sql/types.py ---
@@ -1083,7 +1083,8 @@ def _infer_schema(row):
elif hasattr(row, "_fields"): # namedtuple
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19893
**[Test build #84763 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84763/testReport)**
for PR 19893 at commit
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19893
@vanzin I've fixed the SQL test flow and additionally I've made the
implementation less invasive by extracting the logic into a trait.
---
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r15602
--- Diff: python/pyspark/sql/types.py ---
@@ -1083,7 +1083,8 @@ def _infer_schema(row):
elif hasattr(row, "_fields"): # namedtuple
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19813
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84760/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19813
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19813
**[Test build #84760 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84760/testReport)**
for PR 19813 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19949
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19949
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84757/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19949
**[Test build #84757 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84757/testReport)**
for PR 19949 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19941
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84759/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19941
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19941
**[Test build #84759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84759/testReport)**
for PR 19941 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19949
To be clear, I am not against this change. I am asking this because simply
I remember I was working on another stuff related with tests but the elapsed
time concern was raised before.
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19855
just FYI; this pr is too cool! cuz this fix improved many tpcds queries
(e.g., `q94` got more than 10x faster than
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r156323615
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -168,20 +168,13 @@ final class QuantileDiscretizer
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19948
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84758/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19948
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19948
**[Test build #84758 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84758/testReport)**
for PR 19948 at commit
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/19927#discussion_r156314727
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -156,54 +153,22 @@ final class OneVsRestModel private[ml] (
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19861
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156313853
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -203,18 +267,35 @@ class CodegenContext
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19811
Can you add a test to generate the initialization code for the compacted
states? IIUC the current tests in this pr don't have the test.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19916
**[Test build #84762 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84762/testReport)**
for PR 19916 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19811
**[Test build #84761 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84761/testReport)**
for PR 19811 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19811
@cloud-fan Could you please review this?
I will address an argument issue in another PR after merging this.
---
-
To
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156300746
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/GeneratedProjectionSuite.scala
---
@@ -219,4 +219,55 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r156297739
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -55,8 +55,45 @@ import
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r156297517
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -236,4 +237,24 @@ class WholeStageCodegenSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r156297038
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -236,4 +237,24 @@ class WholeStageCodegenSuite extends
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19811
I think this failure due to package issue, not due to this PR
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18390#discussion_r156292467
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/MulticlassClassificationEvaluator.scala
---
@@ -38,17 +38,39 @@ class
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18390#discussion_r156295173
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/MulticlassClassificationEvaluator.scala
---
@@ -80,17 +102,42 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19864#discussion_r156294941
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
---
@@ -60,7 +62,8 @@ case class InMemoryRelation(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19864#discussion_r156294973
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
---
@@ -60,7 +62,8 @@ case class InMemoryRelation(
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19949
@HyukjinKwon see: https://issues.apache.org/jira/browse/SPARK-22722
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r156293395
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -55,8 +55,45 @@ import
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19948
**[Test build #84758 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84758/testReport)**
for PR 19948 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19949
**[Test build #84757 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84757/testReport)**
for PR 19949 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19941
**[Test build #84759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84759/testReport)**
for PR 19941 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19813
**[Test build #84760 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84760/testReport)**
for PR 19813 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19170
It's not a big improvement but makes the code base more consistent.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19170
if SHS is the only user of `JsonProtocol`, then we should ignore
BlockStatus update events in `JsonProtocol` as SHS doesn't need it at all.
---
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/19941
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user abhaynahar commented on the issue:
https://github.com/apache/spark/pull/16578
sorry for spamming, but @rxin @marmbrus @ericl @cloud-fan @liancheng can
you please help taking this forward ? @viirya has reviewed it closely and is
looking for someone else to review this as
601 - 700 of 714 matches
Mail list logo
