[GitHub] spark issue #19929: [SPARK-22629][PYTHON] Add deterministic flag to pyspark ...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19929 **[Test build #85309 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85309/testReport)** for PR 19929 at commit [`187ff9a`](https://github.com/apache/spark/commit/1

[GitHub] spark pull request #19591: [SPARK-11035][core] Add in-process Spark app laun...

2017-12-22 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19591#discussion_r158509926 --- Diff: launcher/src/main/java/org/apache/spark/launcher/InProcessAppHandle.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19683 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85312/ Test FAILed. ---

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19683 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19683 **[Test build #85312 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85312/testReport)** for PR 19683 at commit [`8ef78af`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #19929: [SPARK-22629][PYTHON] Add deterministic flag to pyspark ...

2017-12-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19929 `UDFRegistration.registerFunction` needs a minor update for the log --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apa

[GitHub] spark pull request #19929: [SPARK-22629][PYTHON] Add deterministic flag to p...

2017-12-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19929#discussion_r158504556 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/PythonUDF.scala --- @@ -29,9 +29,12 @@ case class PythonUDF( func: Pytho

[GitHub] spark pull request #20034: [SPARK-22846][SQL] Fix table owner is null when c...

2017-12-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20034#discussion_r158501959 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -186,7 +186,7 @@ private[hive] class HiveClientImpl(

[GitHub] spark issue #19977: [SPARK-22771][SQL] Concatenate binary inputs into a bina...

2017-12-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19977 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apa

[GitHub] spark pull request #19977: [SPARK-22771][SQL] Concatenate binary inputs into...

2017-12-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19977#discussion_r158501454 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2171,7 +2171,8 @@ object functions { def base64(e: Column): Column =

[GitHub] spark issue #19813: [SPARK-22600][SQL] Fix 64kb limit for deeply nested expr...

2017-12-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19813 > it also means the chained evaluation of expressions needs to be run at every occurrence. We can introduce some mechanism to save statement to local variables if it's going to be re-comp

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

2017-12-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158500070 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -451,6 +451,11 @@ object ColumnPruning extends Rule[

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

2017-12-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158499618 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -451,6 +451,11 @@ object ColumnPruning extends Rule[

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20020 **[Test build #85314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85314/testReport)** for PR 20020 at commit [`787e677`](https://github.com/apache/spark/commit/78

[GitHub] spark pull request #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2017-12-22 Thread fjh100456
Github user fjh100456 commented on a diff in the pull request: https://github.com/apache/spark/pull/19218#discussion_r158492627 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -35,7 +39,7 @@ case class TestData(key: Int, value: String) case

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20036 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85307/ Test PASSed. ---

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20036 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20020 **[Test build #85313 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85313/testReport)** for PR 20020 at commit [`b60f4ec`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20020 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85313/ Test FAILed. ---

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20036 **[Test build #85307 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85307/testReport)** for PR 20036 at commit [`8d8b669`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20020 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20018: SPARK-22833 [Improvement] in SparkHive Scala Examples

2017-12-22 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20018 @HyukjinKwon @srowen Kindly review now, if looks good do merge. Thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20020 **[Test build #85313 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85313/testReport)** for PR 20020 at commit [`b60f4ec`](https://github.com/apache/spark/commit/b6

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

2017-12-22 Thread uzadude
Github user uzadude commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158488942 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -451,6 +451,11 @@ object ColumnPruning extends Rule[Lo

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19683 **[Test build #85312 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85312/testReport)** for PR 19683 at commit [`8ef78af`](https://github.com/apache/spark/commit/8e

[GitHub] spark issue #20056: [SPARK-22878] [CORE] Count totalDroppedEvents for LiveLi...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20056 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20046: [SPARK-22362][SQL] Add unit test for Window Aggregate Fu...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20046 **[Test build #85311 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85311/testReport)** for PR 20046 at commit [`7290ec4`](https://github.com/apache/spark/commit/72

[GitHub] spark pull request #20056: [SPARK-22878] [CORE] Count totalDroppedEvents for...

2017-12-22 Thread Ngone51
GitHub user Ngone51 opened a pull request: https://github.com/apache/spark/pull/20056 [SPARK-22878] [CORE] Count totalDroppedEvents for LiveListenerBus ## What changes were proposed in this pull request? Count total dropped events from all queues' numDroppedEvents for LiveL

[GitHub] spark issue #20031: [SPARK-22844][R] Adds date_trunc in R API

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20031 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85308/ Test PASSed. ---

[GitHub] spark issue #20031: [SPARK-22844][R] Adds date_trunc in R API

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20031 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20031: [SPARK-22844][R] Adds date_trunc in R API

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20031 **[Test build #85308 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85308/testReport)** for PR 20031 at commit [`6aa835e`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #20046: [SPARK-22362][SQL] Add unit test for Window Aggregate Fu...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20046 **[Test build #85310 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85310/testReport)** for PR 20046 at commit [`00f50c0`](https://github.com/apache/spark/commit/00

[GitHub] spark issue #19929: [SPARK-22629][PYTHON] Add deterministic flag to pyspark ...

2017-12-22 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19929 @gatorsmile I added the test, but I didn't get what needs to be updated in `registerPython`. May you explain me please? Thanks. --- ---

[GitHub] spark issue #19929: [SPARK-22629][PYTHON] Add deterministic flag to pyspark ...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19929 **[Test build #85309 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85309/testReport)** for PR 19929 at commit [`187ff9a`](https://github.com/apache/spark/commit/18

[GitHub] spark issue #20031: [SPARK-22844][R] Adds date_trunc in R API

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20031 **[Test build #85308 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85308/testReport)** for PR 20031 at commit [`6aa835e`](https://github.com/apache/spark/commit/6a

[GitHub] spark pull request #20031: [SPARK-22844][R] Adds date_trunc in R API

2017-12-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20031#discussion_r158481310 --- Diff: R/pkg/R/functions.R --- @@ -40,10 +40,17 @@ NULL #' #' @param x Column to compute on. In \code{window}, it must be a time Column of

[GitHub] spark pull request #20031: [SPARK-22844][R] Adds date_trunc in R API

2017-12-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20031#discussion_r158480821 --- Diff: R/pkg/R/functions.R --- @@ -40,10 +40,17 @@ NULL #' #' @param x Column to compute on. In \code{window}, it must be a time Column of

[GitHub] spark issue #19977: [SPARK-22771][SQL] Concatenate binary inputs into a bina...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19977 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19977: [SPARK-22771][SQL] Concatenate binary inputs into a bina...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19977 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85302/ Test PASSed. ---

[GitHub] spark issue #19977: [SPARK-22771][SQL] Concatenate binary inputs into a bina...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19977 **[Test build #85302 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85302/testReport)** for PR 19977 at commit [`9f5157c`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #20023: [SPARK-22036][SQL] Decimal multiplication with high prec...

2017-12-22 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20023 @gatorsmile I answered to your comments about DB2 in the e-mail. @cloud-fan that would help, but not solve the problem. It would just make the problem being generated by bigger numbers.

[GitHub] spark pull request #20034: [SPARK-22846][SQL] Fix table owner is null when c...

2017-12-22 Thread BruceXu1991
Github user BruceXu1991 commented on a diff in the pull request: https://github.com/apache/spark/pull/20034#discussion_r158472814 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -186,7 +186,7 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #20054: [SPARK-22874][PYSPARK][SQL] Modify checking panda...

2017-12-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20054 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20054 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark pull request #20045: [Spark-22360][SQL] Add unit tests for Window Spec...

2017-12-22 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/20045#discussion_r158300159 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala --- @@ -32,6 +32,209 @@ import org.apache.spark.unsafe.types

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20054 Still LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@s

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20054 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85306/ Test PASSed. ---

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20054 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20054 **[Test build #85306 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85306/testReport)** for PR 20054 at commit [`7ef6887`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20036 **[Test build #85307 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85307/testReport)** for PR 20036 at commit [`8d8b669`](https://github.com/apache/spark/commit/8d

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-22 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20036 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20054 **[Test build #85306 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85306/testReport)** for PR 20054 at commit [`7ef6887`](https://github.com/apache/spark/commit/7e

[GitHub] spark pull request #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2017-12-22 Thread fjh100456
Github user fjh100456 commented on a diff in the pull request: https://github.com/apache/spark/pull/19218#discussion_r158460931 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala --- @@ -35,7 +39,7 @@ case class TestData(key: Int, value: String) case

[GitHub] spark pull request #20054: [SPARK-22874][PYSPARK][SQL] Modify checking panda...

2017-12-22 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20054#discussion_r158460651 --- Diff: python/pyspark/sql/utils.py --- @@ -112,6 +112,15 @@ def toJArray(gateway, jtype, arr): return jarr +def _require_minimum_p

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20036 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85301/ Test FAILed. ---

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20036 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20036 **[Test build #85301 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85301/testReport)** for PR 20036 at commit [`8d8b669`](https://github.com/apache/spark/commit/8

[GitHub] spark pull request #20054: [SPARK-22874][PYSPARK][SQL] Modify checking panda...

2017-12-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20054#discussion_r158459861 --- Diff: python/pyspark/sql/utils.py --- @@ -112,6 +112,15 @@ def toJArray(gateway, jtype, arr): return jarr +def _require_mini

[GitHub] spark pull request #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2017-12-22 Thread fjh100456
Github user fjh100456 commented on a diff in the pull request: https://github.com/apache/spark/pull/19218#discussion_r158459550 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveOptions.scala --- @@ -102,4 +111,18 @@ object HiveOptions { "collectio

[GitHub] spark pull request #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2017-12-22 Thread fjh100456
Github user fjh100456 commented on a diff in the pull request: https://github.com/apache/spark/pull/19218#discussion_r158458747 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveOptions.scala --- @@ -102,4 +111,18 @@ object HiveOptions { "collectio

[GitHub] spark pull request #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2017-12-22 Thread fjh100456
Github user fjh100456 commented on a diff in the pull request: https://github.com/apache/spark/pull/19218#discussion_r158458003 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveOptions.scala --- @@ -19,7 +19,16 @@ package org.apache.spark.sql.hive.executio

[GitHub] spark pull request #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2017-12-22 Thread fjh100456
Github user fjh100456 commented on a diff in the pull request: https://github.com/apache/spark/pull/19218#discussion_r158457806 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetOptions.scala --- @@ -42,8 +43,15 @@ private[parquet] class P

[GitHub] spark pull request #20046: [SPARK-22362][SQL] Add unit test for Window Aggre...

2017-12-22 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/20046#discussion_r158456767 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala --- @@ -154,6 +154,217 @@ class DataFrameWindowFunctionsSuit

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20054 **[Test build #85305 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85305/testReport)** for PR 20054 at commit [`677f6bc`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20054 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85305/ Test PASSed. ---

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20054 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20052: [SPARK-20694][EXAMPLES]Update SQLDataSourceExample.scala

2017-12-22 Thread CNRui
Github user CNRui commented on the issue: https://github.com/apache/spark/pull/20052 peopleDF.show() ++---+ | age| name| ++---+ |null|Michael| | 30| Andy| | 19| Justin| ++---+ peopleDF .write .partiti

[GitHub] spark pull request #20018: SPARK-22833 [Improvement] in SparkHive Scala Exam...

2017-12-22 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20018#discussion_r158454282 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala --- @@ -102,8 +101,41 @@ object SparkHiveExample {

[GitHub] spark pull request #20018: SPARK-22833 [Improvement] in SparkHive Scala Exam...

2017-12-22 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20018#discussion_r158454291 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala --- @@ -102,8 +101,41 @@ object SparkHiveExample {

[GitHub] spark pull request #20018: SPARK-22833 [Improvement] in SparkHive Scala Exam...

2017-12-22 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20018#discussion_r158454275 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala --- @@ -102,8 +101,41 @@ object SparkHiveExample {

[GitHub] spark pull request #20018: SPARK-22833 [Improvement] in SparkHive Scala Exam...

2017-12-22 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20018#discussion_r158454240 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala --- @@ -102,8 +101,41 @@ object SparkHiveExample {

[GitHub] spark pull request #20018: SPARK-22833 [Improvement] in SparkHive Scala Exam...

2017-12-22 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20018#discussion_r158454252 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala --- @@ -102,8 +101,41 @@ object SparkHiveExample {

[GitHub] spark pull request #20018: SPARK-22833 [Improvement] in SparkHive Scala Exam...

2017-12-22 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20018#discussion_r158454265 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala --- @@ -102,8 +101,41 @@ object SparkHiveExample {

[GitHub] spark pull request #20018: SPARK-22833 [Improvement] in SparkHive Scala Exam...

2017-12-22 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20018#discussion_r158454218 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala --- @@ -102,8 +101,41 @@ object SparkHiveExample {

[GitHub] spark pull request #20018: SPARK-22833 [Improvement] in SparkHive Scala Exam...

2017-12-22 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20018#discussion_r158454228 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala --- @@ -102,8 +101,41 @@ object SparkHiveExample {

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20054 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85304/ Test FAILed. ---

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20054 **[Test build #85304 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85304/testReport)** for PR 20054 at commit [`21d2d49`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20054 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20055: [SPARK-22875][BUILD] Assembly build fails for a high use...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20055 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20055: [SPARK-22875][BUILD] Assembly build fails for a h...

2017-12-22 Thread gerashegalov
GitHub user gerashegalov opened a pull request: https://github.com/apache/spark/pull/20055 [SPARK-22875][BUILD] Assembly build fails for a high user id ## What changes were proposed in this pull request? Add tarLongFileMode=posix configuration for the assembly plugin

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20054 **[Test build #85305 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85305/testReport)** for PR 20054 at commit [`677f6bc`](https://github.com/apache/spark/commit/67

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20054 **[Test build #85304 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85304/testReport)** for PR 20054 at commit [`21d2d49`](https://github.com/apache/spark/commit/21

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20054 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85303/ Test FAILed. ---

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20054 **[Test build #85303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85303/testReport)** for PR 20054 at commit [`9f67936`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20054 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19929: [SPARK-22629][PYTHON] Add deterministic flag to pyspark ...

2017-12-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19929 We need test cases. Manual tests are not enough. I will try to review this tomorrow. Thanks! --- - To unsubscribe, e-

[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20054 **[Test build #85303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85303/testReport)** for PR 20054 at commit [`9f67936`](https://github.com/apache/spark/commit/9f

[GitHub] spark pull request #19943: [SPARK-16060][SQL] Support Vectorized ORC Reader

2017-12-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19943#discussion_r158447937 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala --- @@ -0,0 +1,432 @@ +/* + * Licen

[GitHub] spark pull request #19943: [SPARK-16060][SQL] Support Vectorized ORC Reader

2017-12-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19943#discussion_r158447746 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala --- @@ -0,0 +1,432 @@ +/* + * Licen

[GitHub] spark pull request #20054: [SPARK-22874][PYSPARK][SQL] Modify checking panda...

2017-12-22 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/20054 [SPARK-22874][PYSPARK][SQL] Modify checking pandas version to use LooseVersion. ## What changes were proposed in this pull request? Currently we check pandas version by capturing if `Import

[GitHub] spark issue #20029: [SPARK-22793][SQL]Memory leak in Spark Thrift Server

2017-12-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20029 cc @liufengdb --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..

[GitHub] spark issue #19813: [SPARK-22600][SQL] Fix 64kb limit for deeply nested expr...

2017-12-22 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19813 > What about future? Will we need to output statement for some reason? like reducing the usage of local variables? I think that we won't have strong motivation to use output statement. The r

[GitHub] spark issue #19977: [SPARK-22771][SQL] Concatenate binary inputs into a bina...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19977 **[Test build #85302 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85302/testReport)** for PR 19977 at commit [`9f5157c`](https://github.com/apache/spark/commit/9f

[GitHub] spark issue #19977: [SPARK-22771][SQL] Concatenate binary inputs into a bina...

2017-12-22 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19977 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark issue #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compression.co...

2017-12-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19218 Could you also add another test scenario? For the existing Hive tables (created by Hive), does our Spark respect it? Do we use the existing compression configuration? ---

[GitHub] spark issue #20024: [SPARK-22825][SQL] Fix incorrect results of Casting Arra...

2017-12-22 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20024 ok, I'll brush up based on your suggestion. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comm

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20036 **[Test build #85301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85301/testReport)** for PR 20036 at commit [`8d8b669`](https://github.com/apache/spark/commit/8d

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-22 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20036 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

[GitHub] spark pull request #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2017-12-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19218#discussion_r158445027 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala --- @@ -68,6 +68,12 @@ private[hive] trait SaveAsHiveFile ext

[GitHub] spark pull request #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2017-12-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19218#discussion_r158444388 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveOptions.scala --- @@ -19,7 +19,16 @@ package org.apache.spark.sql.hive.executi

<    1   2   3   4   >