[GitHub] spark pull request #21078: [SPARK-23990][ML] Instruments logging improvement...

2018-04-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/21078#discussion_r182833420 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala --- @@ -150,3 +156,35 @@ private[spark] object Instrumentation { }

[GitHub] spark pull request #21078: [SPARK-23990][ML] Instruments logging improvement...

2018-04-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/21078#discussion_r182833731 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala --- @@ -150,3 +156,35 @@ private[spark] object Instrumentation { }

[GitHub] spark issue #21069: [SPARK-23920][SQL]add array_remove to remove all element...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21069 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2494/

[GitHub] spark issue #21069: [SPARK-23920][SQL]add array_remove to remove all element...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21069 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21069: [SPARK-23920][SQL]add array_remove to remove all element...

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21069 **[Test build #89583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89583/testReport)** for PR 21069 at commit

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20938 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20938 **[Test build #89575 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89575/testReport)** for PR 20938 at commit

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20938 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89575/ Test FAILed. ---

[GitHub] spark issue #21106: [SPARK-23711][SQL][WIP] Add fallback logic for UnsafePro...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21106 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89578/ Test PASSed. ---

[GitHub] spark issue #21106: [SPARK-23711][SQL][WIP] Add fallback logic for UnsafePro...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21106 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20938 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20938 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89574/ Test FAILed. ---

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20938 **[Test build #89574 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89574/testReport)** for PR 20938 at commit

[GitHub] spark issue #21106: [SPARK-23711][SQL][WIP] Add fallback logic for UnsafePro...

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21106 **[Test build #89578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89578/testReport)** for PR 21106 at commit

[GitHub] spark pull request #21097: [SPARK-14682][ML] Provide evaluateEachIteration m...

2018-04-19 Thread wangmiao1981
Github user wangmiao1981 commented on a diff in the pull request: https://github.com/apache/spark/pull/21097#discussion_r182829257 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala --- @@ -365,6 +365,20 @@ class GBTClassifierSuite extends

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89577/ Test PASSed. ---

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21021 **[Test build #89577 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89577/testReport)** for PR 21021 at commit

[GitHub] spark pull request #20350: [SPARK-23179][SQL] Support option to throw except...

2018-04-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20350#discussion_r182820983 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala --- @@ -80,30 +80,44 @@ case class

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89576/ Test PASSed. ---

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21021 **[Test build #89576 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89576/testReport)** for PR 21021 at commit

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-04-19 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20636 @kiszk Why do we need to allocate a large array several times? I thought the objective of this test is to check if we can safely grow to int max? I don't really see the need for resetting the

[GitHub] spark pull request #20046: [SPARK-22362][SQL] Add unit test for Window Aggre...

2018-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20046 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21031: [SPARK-23923][SQL] Add cardinality function

2018-04-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21031#discussion_r182816541 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -407,6 +407,7 @@ object FunctionRegistry {

[GitHub] spark issue #20046: [SPARK-22362][SQL] Add unit test for Window Aggregate Fu...

2018-04-19 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20046 LGTM - merging to master. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-19 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/21094 @gatorsmile we are in the process of adding more structure to code generation, see https://github.com/apache/spark/commit/7c1654e2159662e7e663ba141719d755002f770a. This should eliminate this

[GitHub] spark issue #20858: [SPARK-23736][SQL] Extending the concat function to supp...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20858 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20858: [SPARK-23736][SQL] Extending the concat function to supp...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20858 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89573/ Test PASSed. ---

[GitHub] spark issue #21093: [SPARK-23340][SQL][BRANCH-2.3] Upgrade Apache ORC to 1.4...

2018-04-19 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21093 Thanks! Merged to 2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21093: [SPARK-23340][SQL][BRANCH-2.3] Upgrade Apache ORC...

2018-04-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21093#discussion_r182814133 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala --- @@ -208,4 +208,14 @@ class HiveOrcQuerySuite extends

[GitHub] spark issue #20858: [SPARK-23736][SQL] Extending the concat function to supp...

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20858 **[Test build #89573 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89573/testReport)** for PR 20858 at commit

[GitHub] spark issue #20140: [SPARK-19228][SQL] Introduce tryParseDate method to proc...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20140 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20140: [SPARK-19228][SQL] Introduce tryParseDate method to proc...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20140 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89572/ Test FAILed. ---

[GitHub] spark issue #20140: [SPARK-19228][SQL] Introduce tryParseDate method to proc...

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20140 **[Test build #89572 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89572/testReport)** for PR 20140 at commit

[GitHub] spark pull request #21093: [SPARK-23340][SQL][BRANCH-2.3] Upgrade Apache ORC...

2018-04-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21093#discussion_r182813427 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala --- @@ -208,4 +208,14 @@ class HiveOrcQuerySuite extends

[GitHub] spark pull request #21090: [SPARK-24026][ML] Add Power Iteration Clustering ...

2018-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21090 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped tests f...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21107 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89581/ Test PASSed. ---

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20938 **[Test build #89582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89582/testReport)** for PR 20938 at commit

[GitHub] spark issue #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped tests f...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21107 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped tests f...

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21107 **[Test build #89581 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89581/testReport)** for PR 21107 at commit

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-19 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20938 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21090: [SPARK-15784][ML] Add Power Iteration Clustering to spar...

2018-04-19 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/21090 Thanks for reviewing this and for the LGTM @wangmiao1981 ! I'll merge with master now, with you as the primary author. ---

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20146 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89571/ Test FAILed. ---

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20146 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20146 **[Test build #89571 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89571/testReport)** for PR 20146 at commit

[GitHub] spark issue #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped tests f...

2018-04-19 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21107 @viirya, @ueshin, @BryanCutler, @holdenk, @felixcheung, @cloud-fan, @JoshRosen, @yhuai and @bersprockets. It's actually about SPARK-23300. WDYT? There was an actual issue, SPARK-23300,

[GitHub] spark issue #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped tests f...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21107 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2493/

[GitHub] spark issue #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped tests f...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21107 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped tests f...

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21107 **[Test build #89581 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89581/testReport)** for PR 21107 at commit

[GitHub] spark pull request #21101: [SPARK-23989][SQL] exchange should copy data befo...

2018-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21101 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21101: [SPARK-23989][SQL] exchange should copy data before non-...

2018-04-19 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/21101 Merging to master, 2.3 and 2.2. Let me know if more further backports are needed. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #21106: [SPARK-23711][SQL][WIP] Add fallback logic for Un...

2018-04-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/21106#discussion_r182794729 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodegenObjectFactory.scala --- @@ -0,0 +1,63 @@ +/* + *

[GitHub] spark issue #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped tests f...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21107 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped tests f...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21107 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89580/ Test PASSed. ---

[GitHub] spark issue #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped tests f...

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21107 **[Test build #89580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89580/testReport)** for PR 21107 at commit

[GitHub] spark issue #20757: [SPARK-23595][SQL] ValidateExternalType should support i...

2018-04-19 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20757 @maropu can you update the PR? I have one trivial comment. LGTM otherwise. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-04-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r182787533 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1615,13 +1616,50 @@ case class

[GitHub] spark issue #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped tests f...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21107 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2492/

[GitHub] spark issue #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped tests f...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21107 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21085: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-19 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/21085 whoops, thanks for the reminder @jiangxb1987 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21085: [SPARK-23948] Trigger mapstage's job listener in ...

2018-04-19 Thread squito
Github user squito closed the pull request at: https://github.com/apache/spark/pull/21085 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped ...

2018-04-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21107#discussion_r182779626 --- Diff: python/run-tests.py --- @@ -109,7 +111,24 @@ def run_individual_python_test(test_name, pyspark_python): # this code is

[GitHub] spark pull request #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped ...

2018-04-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21107#discussion_r182779098 --- Diff: python/run-tests.py --- @@ -152,65 +171,17 @@ def parse_opts(): return opts -def _check_dependencies(python_exec,

[GitHub] spark issue #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped tests f...

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21107 **[Test build #89580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89580/testReport)** for PR 21107 at commit

[GitHub] spark pull request #21107: [DO-NOT-MERGE][WIP] Explicitly print out skipped ...

2018-04-19 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/21107 [DO-NOT-MERGE][WIP] Explicitly print out skipped tests from unittest module ## What changes were proposed in this pull request? This PR proposes to remove duplicated dependency

[GitHub] spark issue #21105: [SPARK-24022][TEST] Make SparkContextSuite not flaky

2018-04-19 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/21105 Yes, please see SPARK-22764. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21105: [SPARK-24022][TEST] Make SparkContextSuite not flaky

2018-04-19 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21105 QQ: Have we observed the test case being flaky before? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #21085: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-19 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21085 Should we manually close this PR? @squito --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21088: [SPARK-24003][CORE] Add support to provide spark.executo...

2018-04-19 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21088 Assuming the {{APP_ID}}/{{EXECUTOR_ID}} would be useful under some meaningful scenarios, the changes looks fine. --- - To

[GitHub] spark pull request #21088: [SPARK-24003][CORE] Add support to provide spark....

2018-04-19 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/21088#discussion_r182765201 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala --- @@ -142,7 +142,14 @@ private[deploy] class ExecutorRunner(

[GitHub] spark issue #20640: [SPARK-19755][Mesos] Blacklist is always active for Meso...

2018-04-19 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20640 Hi Everyone, just wanted to let you know that SPARK-16630 is progressing now https://github.com/apache/spark/pull/21068 and after some discussion, the implementation will actually need to live

[GitHub] spark issue #21073: [SPARK-23936][SQL] Implement map_concat

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21073 **[Test build #89579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89579/testReport)** for PR 21073 at commit

[GitHub] spark issue #21068: [SPARK-16630][YARN] Blacklist a node if executors won't ...

2018-04-19 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/21068 @tgravescs on the blacklist ratio for task-based blacklisting -- there is nothing, but there are some related jiras: [SPARK-22148](https://issues.apache.org/jira/browse/SPARK-22148) &

[GitHub] spark issue #21106: [SPARK-23711][SQL][WIP] Add fallback logic for UnsafePro...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21106 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2491/

[GitHub] spark issue #21106: [SPARK-23711][SQL][WIP] Add fallback logic for UnsafePro...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21106 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21106: [SPARK-23711][SQL][WIP] Add fallback logic for UnsafePro...

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21106 **[Test build #89578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89578/testReport)** for PR 21106 at commit

[GitHub] spark issue #21106: [SPARK-23711][SQL][WIP] Add fallback logic for UnsafePro...

2018-04-19 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21106 cc @hvanhovell --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21106: [SPARK-23711][SQL][WIP] Add fallback logic for Un...

2018-04-19 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/21106 [SPARK-23711][SQL][WIP] Add fallback logic for UnsafeProjection ## What changes were proposed in this pull request? This is WIP work for adding fallback to interpreted execution logic.

[GitHub] spark pull request #21104: [SPARK-24021][CORE] fix bug in BlacklistTracker's...

2018-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21104 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21018 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20980 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21018 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89563/ Test FAILed. ---

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20980 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89564/ Test FAILed. ---

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20980 **[Test build #89564 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89564/testReport)** for PR 20980 at commit

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21018 **[Test build #89563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89563/testReport)** for PR 21018 at commit

[GitHub] spark issue #21105: [SPARK-24022][TEST] Make SparkContextSuite not flaky

2018-04-19 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/21105 @jiangxb1987 Here it's possible to create a separate context. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21104: [SPARK-24021][CORE] fix bug in BlacklistTracker's update...

2018-04-19 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/21104 merged to master & 2.3.1, thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21105: [SPARK-24022][TEST] Make SparkContextSuite not flaky

2018-04-19 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/21105 cc @vanzin @jiangxb1987 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2490/

[GitHub] spark issue #21104: [SPARK-24021][CORE] fix bug in BlacklistTracker's update...

2018-04-19 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/21104 lgtm, good catch --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21105: [SPARK-24022][TEST] Make SparkContextSuite not flaky

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21105 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89568/ Test PASSed. ---

[GitHub] spark issue #21105: [SPARK-24022][TEST] Make SparkContextSuite not flaky

2018-04-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21105 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21105: [SPARK-24022][TEST] Make SparkContextSuite not flaky

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21105 **[Test build #89568 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89568/testReport)** for PR 21105 at commit

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21021 **[Test build #89577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89577/testReport)** for PR 21021 at commit

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-19 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21021 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19033: [SPARK-21811][SQL]Inconsistency when finding the ...

2018-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19033 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21074: [SPARK-21811][SQL] Fix the inconsistency behavior...

2018-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21074 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21074: [SPARK-21811][SQL] Fix the inconsistency behavior when f...

2018-04-19 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21074 Seems missed out. I merged this to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

<    1   2   3   4   5   >