[GitHub] spark pull request #22490: [SPARK-25481][SQL][TEST] Refactor ColumnarBatchBe...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22490 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22545 @cloud-fan, do we target this 2.4? Looks it might break an existing app, in particular, when a Python shell creates a session and another shell (like Zeppelin) or another session depends on a co

[GitHub] spark issue #22490: [SPARK-25481][SQL][TEST] Refactor ColumnarBatchBenchmark...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22490 Thank you, @yucai . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark issue #22490: [SPARK-25481][SQL][TEST] Refactor ColumnarBatchBenchmark...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22490 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revie

[GitHub] spark issue #22490: [SPARK-25481][SQL][TEST] Refactor ColumnarBatchBenchmark...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22490 This passes the test already and the last merge is due to updating `ColumnarBatchBenchmark-results.txt` only. --- - To uns

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22455 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96645/ Test PASSed. ---

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22455 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22455 **[Test build #96645 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96645/testReport)** for PR 22455 at commit [`df582fc`](https://github.com/apache/spark/commit/d

[GitHub] spark pull request #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf fo...

2018-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22545#discussion_r220784330 --- Diff: python/pyspark/sql/session.py --- @@ -181,17 +181,11 @@ def getOrCreate(self): sparkConf.set(key, value)

[GitHub] spark issue #22563: [SPARK-24341][SQL][followup] remove duplicated error che...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22563 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22563: [SPARK-24341][SQL][followup] remove duplicated error che...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22563 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3513/

[GitHub] spark issue #22563: [SPARK-24341][SQL][followup] remove duplicated error che...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22563 cc @mgaido91 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@

[GitHub] spark pull request #22563: [SPARK-24341][SQL][followup] remove duplicated er...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22563#discussion_r220783617 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -155,37 +155,35 @@ case class InSubquery(values:

[GitHub] spark issue #22563: [SPARK-24341][SQL][followup] remove duplicated error che...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22563 **[Test build #96662 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96662/testReport)** for PR 22563 at commit [`d810e0d`](https://github.com/apache/spark/commit/d8

[GitHub] spark pull request #22563: [SPARK-24341][SQL][followup] remove duplicated er...

2018-09-26 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/22563 [SPARK-24341][SQL][followup] remove duplicated error checking ## What changes were proposed in this pull request? There are 2 places we check for problematic `InSubquery`: the rule `Reso

[GitHub] spark issue #22562: [SPARK-25541][SQL][FOLLOWUP] Remove overriding filterKey...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22562 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apa

[GitHub] spark issue #22552: [SPARK-25540][SQL][PYSPARK] Make HiveContext in PySpark ...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22552 This is part of the bug fix PR: #22545 . I asked @ueshin to separate it since this one is self-contained. --- - To unsubscribe

[GitHub] spark issue #22552: [SPARK-25540][SQL][PYSPARK] Make HiveContext in PySpark ...

2018-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22552 hm, why did we merge this into 2.4 btw? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional com

[GitHub] spark issue #22562: [SPARK-25541][SQL][FOLLOWUP] Remove overriding filterKey...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22562 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22562: [SPARK-25541][SQL][FOLLOWUP] Remove overriding filterKey...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22562 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3512/

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96644/ Test PASSed. ---

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96644 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96644/testReport)** for PR 22544 at commit [`9b12969`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #22562: [SPARK-25541][SQL][FOLLOWUP] Remove overriding filterKey...

2018-09-26 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22562 @zsxwing @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: re

[GitHub] spark pull request #22562: [SPARK-25541][SQL][FOLLOWUP] Remove overriding fi...

2018-09-26 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/22562 [SPARK-25541][SQL][FOLLOWUP] Remove overriding filterKeys in CaseInsensitiveMap ## What changes were proposed in this pull request? As per the discussion in https://github.com/apach

[GitHub] spark issue #22562: [SPARK-25541][SQL][FOLLOWUP] Remove overriding filterKey...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22562 **[Test build #96661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96661/testReport)** for PR 22562 at commit [`10d89f4`](https://github.com/apache/spark/commit/10

[GitHub] spark issue #22528: [SPARK-25513][SQL] Read zipped CSV and JSON

2018-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22528 The limitation is quite clear - multi line mode only and single file. We don't have to rush about this - looks @MaxGekk has a clear idea on this. Another concern here is, we have another place t

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22545 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22545 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96655/ Test PASSed. ---

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22545 **[Test build #96655 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96655/testReport)** for PR 22545 at commit [`d8c60cb`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96660/testReport)** for PR 22544 at commit [`69c78d7`](https://github.com/apache/spark/commit/69

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3511/

[GitHub] spark pull request #22087: [SPARK-25097][ML] Support prediction on single in...

2018-09-26 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/22087#discussion_r220779540 --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/GaussianMixtureSuite.scala --- @@ -268,6 +268,13 @@ class GaussianMixtureSuite extends

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22326 **[Test build #96659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96659/testReport)** for PR 22326 at commit [`2b6977d`](https://github.com/apache/spark/commit/2b

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-26 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220777535 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala --- @@ -100,6 +105,29 @@ class BatchEvalPythonE

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3510/

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-26 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220777383 --- Diff: python/pyspark/sql/tests.py --- @@ -552,6 +552,96 @@ def test_udf_in_filter_on_top_of_join(self): df = left.crossJoin(right).filt

[GitHub] spark issue #17086: [SPARK-24101][ML][MLLIB] ML Evaluators should use weight...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17086 **[Test build #96658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96658/testReport)** for PR 17086 at commit [`a416fa0`](https://github.com/apache/spark/commit/a4

[GitHub] spark issue #17086: [SPARK-24101][ML][MLLIB] ML Evaluators should use weight...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17086 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #17086: [SPARK-24101][ML][MLLIB] ML Evaluators should use weight...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17086 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3509/

[GitHub] spark issue #17086: [SPARK-24101][ML][MLLIB] ML Evaluators should use weight...

2018-09-26 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/17086 I've updated the PR to latest master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comm

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22545 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apa

[GitHub] spark issue #22493: [SPARK-25485][SQL][TEST] Refactor UnsafeProjectionBenchm...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22493 **[Test build #96657 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96657/testReport)** for PR 22493 at commit [`004b69f`](https://github.com/apache/spark/commit/00

[GitHub] spark issue #22561: [SPARK-25548][SQL]In the PruneFileSourcePartitions optim...

2018-09-26 Thread eatoncys
Github user eatoncys commented on the issue: https://github.com/apache/spark/pull/22561 cc @gatorsmile @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: r

[GitHub] spark issue #22493: [SPARK-25485][SQL][TEST] Refactor UnsafeProjectionBenchm...

2018-09-26 Thread yucai
Github user yucai commented on the issue: https://github.com/apache/spark/pull/22493 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

[GitHub] spark issue #22493: [SPARK-25485][SQL][TEST] Refactor UnsafeProjectionBenchm...

2018-09-26 Thread yucai
Github user yucai commented on the issue: https://github.com/apache/spark/pull/22493 @dongjoon-hyun could you help review? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #22490: [SPARK-25481][SQL][TEST] Refactor ColumnarBatchBenchmark...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22490 **[Test build #96656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96656/testReport)** for PR 22490 at commit [`06311fc`](https://github.com/apache/spark/commit/06

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22545 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22545 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3508/

[GitHub] spark issue #22561: [SPARK-25548][SQL]In the PruneFileSourcePartitions optim...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22561 **[Test build #96654 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96654/testReport)** for PR 22561 at commit [`6acb460`](https://github.com/apache/spark/commit/6a

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22545 **[Test build #96655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96655/testReport)** for PR 22545 at commit [`d8c60cb`](https://github.com/apache/spark/commit/d8

[GitHub] spark issue #22561: [SPARK-25548][SQL]In the PruneFileSourcePartitions optim...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22561 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22561: [SPARK-25548][SQL]In the PruneFileSourcePartitions optim...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22561 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3507/

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22545 @dongjoon-hyun I'm sorry that I haven't shared the context, but I talked with @cloud-fan about https://github.com/apache/spark/pull/22545#discussion_r220414608 off-line, and he wanted to separate t

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22543 **[Test build #96653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96653/testReport)** for PR 22543 at commit [`e033694`](https://github.com/apache/spark/commit/e0

[GitHub] spark pull request #22561: [SPARK-25548][SQL]In the PruneFileSourcePartition...

2018-09-26 Thread eatoncys
GitHub user eatoncys opened a pull request: https://github.com/apache/spark/pull/22561 [SPARK-25548][SQL]In the PruneFileSourcePartitions optimizer, replace the nonPartitionOps field with true in the And(partitionOps, nonPartitionOps) to make the partition can be pruned ## What cha

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22543 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3506/

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22543 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21688: [SPARK-21809] : Change Stage Page to use datatables to s...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21688 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21688: [SPARK-21809] : Change Stage Page to use datatables to s...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21688 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96643/ Test FAILed. ---

[GitHub] spark issue #21688: [SPARK-21809] : Change Stage Page to use datatables to s...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21688 **[Test build #96643 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96643/testReport)** for PR 21688 at commit [`2e88030`](https://github.com/apache/spark/commit/2

[GitHub] spark pull request #22552: [SPARK-25540][SQL][PYSPARK] Make HiveContext in P...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22552 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22543 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark issue #22552: [SPARK-25540][SQL][PYSPARK] Make HiveContext in PySpark ...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22552 thanks, merging to master/2.4! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-ma

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21669 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3504/

[GitHub] spark issue #22010: [SPARK-21436][CORE] Take advantage of known partitioner ...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22010 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21669 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22010: [SPARK-21436][CORE] Take advantage of known partitioner ...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22010 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3505/

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21669 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3504/ --- --

[GitHub] spark pull request #22544: [SPARK-25522][SQL] Improve type promotion for inp...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22544#discussion_r220772034 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2140,21 +2140,34 @@ case class Element

[GitHub] spark issue #22516: [SPARK-25468][WEBUI] Highlight current page index in the...

2018-09-26 Thread Adamyuanyuan
Github user Adamyuanyuan commented on the issue: https://github.com/apache/spark/pull/22516 @dongjoon-hyun OK, modified. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-m

[GitHub] spark issue #22010: [SPARK-21436][CORE] Take advantage of known partitioner ...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22010 **[Test build #96652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96652/testReport)** for PR 22010 at commit [`95357cf`](https://github.com/apache/spark/commit/95

[GitHub] spark issue #22010: [SPARK-21436][CORE] Take advantage of known partitioner ...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22010 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21669 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3504/ ---

[GitHub] spark issue #22556: [MINOR] Remove useless InSubquery expression

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22556 LGTM, +1 for creating a JIRA --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-26 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/21669 This PR is now ready for another round of review as the login logic has been refactored and simplified and docs have been added. ---

[GitHub] spark pull request #22553: [SPARK-25541][SQL] CaseInsensitiveMap should be s...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22553#discussion_r220770689 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CaseInsensitiveMap.scala --- @@ -42,7 +42,11 @@ class CaseInsensitiveMap[T] priv

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-09-26 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r220770479 --- Diff: docs/security.md --- @@ -722,6 +722,62 @@ with encryption, at least. The Kerberos login will be periodically renewed using the provided cr

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22326 LGTM except some unnecessary end-to-end tests. +1 for @mgaido91 's idea about unit test, something like the test suites under `org.apache.spark.sql.catalyst.optimizer`. I'm ok to do it in

[GitHub] spark pull request #22553: [SPARK-25541][SQL] CaseInsensitiveMap should be s...

2018-09-26 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22553#discussion_r220770316 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CaseInsensitiveMap.scala --- @@ -42,7 +42,11 @@ class CaseInsensitiveMap[T]

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21669 **[Test build #96651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96651/testReport)** for PR 21669 at commit [`5f52a1a`](https://github.com/apache/spark/commit/5f

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220770012 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala --- @@ -100,6 +105,29 @@ class BatchEvalPythonExec

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220769336 --- Diff: python/pyspark/sql/tests.py --- @@ -552,6 +552,96 @@ def test_udf_in_filter_on_top_of_join(self): df = left.crossJoin(right).filter(

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22455 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22455 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96647/ Test FAILed. ---

[GitHub] spark issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support par...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20999 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support par...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20999 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3503/

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22455 **[Test build #96647 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96647/testReport)** for PR 22455 at commit [`d156277`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21669 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3502/

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21669 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3502/ --- --

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21669 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22555: [SPARK-25536][CORE]metric value for METRIC_OUTPUT_RECORD...

2018-09-26 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22555 Sorry @dongjoon-hyun --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark pull request #22544: [SPARK-25522][SQL] Improve type promotion for inp...

2018-09-26 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22544#discussion_r220766294 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -974,6 +974,25 @@ object TypeCoercion {

[GitHub] spark pull request #22494: [SPARK-25454][SQL] add a new config for picking m...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22494 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21669 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3502/ ---

[GitHub] spark pull request #22544: [SPARK-25522][SQL] Improve type promotion for inp...

2018-09-26 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22544#discussion_r220765052 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -974,6 +974,25 @@ object TypeCoercion {

[GitHub] spark issue #22555: [SPARK-25536][CORE]metric value for METRIC_OUTPUT_RECORD...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22555 Ur, @wangyum . https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96646/ is triggered already for that hanged `Test build #96638`. --- --

[GitHub] spark issue #22555: [SPARK-25536][CORE]metric value for METRIC_OUTPUT_RECORD...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22555 **[Test build #96649 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96649/testReport)** for PR 22555 at commit [`332adef`](https://github.com/apache/spark/commit/33

<    1   2   3   4   5   6   7   >