Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22718
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: rev
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22263#discussion_r225005803
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -288,6 +297,69 @@ class CachedTableSuite extends QueryTest with
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22662
Hi, @tdas and @zsxwing .
Could you review this PR which aims to reduce the test time greatly?
---
-
To unsubscribe, e-m
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22597#discussion_r225004937
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
---
@@ -383,4 +384,15 @@ class OrcFilterSuite e
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22714
@gengliangwang Sorry, I didn't see the PR. Yes, that PR also for refreshing
functionality for the webui.
I have taken the patch and checked the functionality, and it seems fine.
Below is
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22597#discussion_r225001748
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
---
@@ -383,4 +384,15 @@ class OrcFilterSuite e
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22662#discussion_r225000849
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/ContinuousSuite.scala
---
@@ -259,10 +259,10 @@ class ContinuousStressSuite exten
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22714
BTW there is another approach: https://github.com/apache/spark/pull/21512
---
-
To unsubscribe, e-mail: reviews-unsubscr...
Github user stczwd commented on the issue:
https://github.com/apache/spark/pull/22575
cc @xuanyuanking
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21537
@HyukjinKwon sorry for being late. I was swampped with several things. I
have just submitted it. Looking forward to seeing feedback.
---
-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22662#discussion_r224994803
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/ContinuousSuite.scala
---
@@ -259,10 +259,10 @@ class ContinuousStressSuite exte
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22219
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22219
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97363/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22219
**[Test build #97363 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97363/testReport)**
for PR 22219 at commit
[`ffafd62`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22713
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97361/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22713
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22713
**[Test build #97361 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97361/testReport)**
for PR 22713 at commit
[`64aafc5`](https://github.com/apache/spark/commit/6
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22636
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22636
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97362/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97360/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22636
**[Test build #97362 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97362/testReport)**
for PR 22636 at commit
[`e40d79c`](https://github.com/apache/spark/commit/e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97360 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97360/testReport)**
for PR 22309 at commit
[`10618a3`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22503
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22503
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97359/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22503
**[Test build #97359 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97359/testReport)**
for PR 22503 at commit
[`695f676`](https://github.com/apache/spark/commit/6
Github user shivusondur commented on the issue:
https://github.com/apache/spark/pull/22668
@felixcheung
OK. Thank you.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22263
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97358/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22263
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22263
**[Test build #97358 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97358/testReport)**
for PR 22263 at commit
[`8457d8b`](https://github.com/apache/spark/commit/8
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r224985980
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -3854,6 +3854,38 @@ object functions {
@scala.annotation.varargs
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22219
**[Test build #97363 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97363/testReport)**
for PR 22219 at commit
[`ffafd62`](https://github.com/apache/spark/commit/ff
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22219
nope not yet. It needs some more review iterations.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For ad
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22219
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@s
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22501#discussion_r224985471
--- Diff:
core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala ---
@@ -48,15 +48,11 @@ abstract class BenchmarkBase {
if (!file
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22029
Thanks for you comment @HyukjinKwon. Yes sure, I'll update the PR
description, thanks.
Yes, the previous behavior is the same as Hive behavior. What I wanted to
highlight there, though, is
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21990#discussion_r224985166
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -1136,4 +1121,27 @@ object SparkSession extends Logging {
Sp
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22713
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3962/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22713
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21990#discussion_r224985023
--- Diff: python/pyspark/sql/tests.py ---
@@ -3563,6 +3563,48 @@ def
test_query_execution_listener_on_collect_with_arrow(self):
"Th
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22636
**[Test build #97362 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97362/testReport)**
for PR 22636 at commit
[`e40d79c`](https://github.com/apache/spark/commit/e4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22713
**[Test build #97361 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97361/testReport)**
for PR 22713 at commit
[`64aafc5`](https://github.com/apache/spark/commit/64
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22713
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22636
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22713
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3960/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22636
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3961/
GitHub user wangyum reopened a pull request:
https://github.com/apache/spark/pull/22636
[SPARK-25629][TEST] Reduce ParquetFilterSuite: filter pushdown test time
costs in Jenkins
## What changes were proposed in this pull request?
Only test these 4 cases is enough:
http
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22713
Thanks @gatorsmile, I agree. Then I reduced the scope to only the analyzer
rules and added the UT for the only rule changed (other than the
`AliasViewChild` one which is tested with the code provid
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21990#discussion_r224984813
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -86,6 +86,7 @@ class SparkSession private(
private[sql] de
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21990#discussion_r224984761
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -1136,4 +1121,27 @@ object SparkSession extends Logging {
Sp
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21990#discussion_r224984751
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -86,6 +86,7 @@ class SparkSession private(
private[sql] de
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21990#discussion_r224984675
--- Diff: python/pyspark/sql/session.py ---
@@ -219,6 +219,7 @@ def __init__(self, sparkContext, jsparkSession=None):
jsparkSession
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22458
Late LGTM too
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h..
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97360 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97360/testReport)**
for PR 22309 at commit
[`10618a3`](https://github.com/apache/spark/commit/10
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22309
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22029
@mgaido91, mind if I ask add few notes about
https://github.com/apache/spark/pull/22029#issuecomment-411473227? For
instance, which DBMS follows the current change. And sounds the previous
beha
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22597
> I haven't looked into, but the parquet record-level filtering is disabled
by default, so if we remove predicates from spark side, the result can be wrong
even if the predicates are pushed ro p
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22597#discussion_r224984073
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
---
@@ -383,4 +384,15 @@ class OrcFilterSuite ext
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22597#discussion_r224983962
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
---
@@ -383,4 +384,15 @@ class OrcFilterSuite ext
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20877
@justinuang are you interested in taking over
https://github.com/apache/spark/pull/20877#issuecomment-429182740 ?
---
-
To u
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22503
I haven't checked what `setLineSeparatorDetectionEnabled` does explicitly
yet in Univocity parser. Is this exactly same behaviour when we read it via
Hadoop's `LineRecordReader`? Also how does i
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22503
**[Test build #97359 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97359/testReport)**
for PR 22503 at commit
[`695f676`](https://github.com/apache/spark/commit/69
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22503
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@s
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22295#discussion_r224983583
--- Diff: python/pyspark/sql/session.py ---
@@ -231,6 +231,7 @@ def __init__(self, sparkContext, jsparkSession=None):
or SparkSessio
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22295#discussion_r224983437
--- Diff: python/pyspark/sql/session.py ---
@@ -252,6 +253,22 @@ def newSession(self):
"""
return self.__class__(self._sc, self
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22295#discussion_r224983406
--- Diff: python/pyspark/sql/functions.py ---
@@ -2633,6 +2633,23 @@ def sequence(start, stop, step=None):
_to_java_column(start), _to_j
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22636
@wangyum, can you reopen this? I don't think we should just close this.
Fixing tests to actually test what the previous change targeted sounds
definitely an improvement although it's minor. I wo
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22703#discussion_r224983014
--- Diff: python/pyspark/streaming/tests.py ---
@@ -1047,259 +1046,6 @@ def check_output(n):
self.ssc.stop(True, True)
-clas
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22717
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22717
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22263
**[Test build #97358 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97358/testReport)**
for PR 22263 at commit
[`8457d8b`](https://github.com/apache/spark/commit/84
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22263
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3959/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22263
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22263
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22718
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97355/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22263
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97356/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22718
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22719
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22263
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22263
**[Test build #97356 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97356/testReport)**
for PR 22263 at commit
[`8457d8b`](https://github.com/apache/spark/commit/8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22719
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97357/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22717
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22718
**[Test build #97355 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97355/testReport)**
for PR 22718 at commit
[`8303483`](https://github.com/apache/spark/commit/8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22717
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97353/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22717
**[Test build #97353 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97353/testReport)**
for PR 22717 at commit
[`f9f1a14`](https://github.com/apache/spark/commit/f
101 - 185 of 185 matches
Mail list logo
