Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r237971092
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/PartitionTransforms.java
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache S
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23189
Sounds ok.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/23086
@cloud-fan, thanks for getting this done! I'll wait for the equivalent
write-side PR.
---
-
To unsubscribe, e-mail: reviews-unsub
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/23189
@vanzin Ah, I see. Thanks for pointing it out!
But I am now thinking overriding `logError` by calling
`printMessage("Error...")`. What do you think?
---
--
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/23086
> I still do not think we should mix the catalog support with the data
source APIs
We are trying to keep these separate. `Table` is the only overlap between
the two. If you prefer more separ
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23174
> The way it's written now
Code can change after it's written...
> If this change is merged into 3.x without any other changes, users will
be forced to use the K8s secret based
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r237966508
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/FPGrowthExample.scala ---
@@ -64,4 +64,3 @@ object FPGrowthExample {
spark.stop()
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/23086#discussion_r237966188
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/Scan.java ---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Founda
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
> There doesn't need to be a single solution. This patch going in does not
preclude adding more features later, one of which might be reading this from a
pre-defined secret.
The way it's wr
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23189
> The logWarning call as the other handler below is also not overridden:
It is. I even copied & pasted the code. I made the change locally and this
is what happens:
```
$ ./bin/s
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23166
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23189
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23189
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99514/
Test PASSed.
---
Github user rezasafi commented on the issue:
https://github.com/apache/spark/pull/22612
The test is flaky and not related to my change. It passed when we re run it
last time. Jenkins retest this please.
---
-
To uns
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/23186#discussion_r237963856
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -345,15 +346,18 @@ object PartitioningUti
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23189
**[Test build #99514 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99514/testReport)**
for PR 23189 at commit
[`158d421`](https://github.com/apache/spark/commit/1
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/23055
+1 once the docs are updated to note that resource requests still include
python memory, even in Windows.
---
-
To unsubscribe, e
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/23166
thanks @redsanket @squito, committed master, 2.4, and 2.3.2
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/23055#discussion_r237963488
--- Diff: docs/configuration.md ---
@@ -190,6 +190,8 @@ of the most common options to set are:
and it is up to the application to avoid exceeding the
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23174
> while leaving it an exercise for the reader to understand how to properly
run spark such that the secrets are actually secured.
I don't think that's an exercise for the user, but for the ad
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/23189
@vanzin The `logWarning` call as the other handler below is also not
overridden:
```
case e: NoClassDefFoundError =>
logWarning(s"Failed to load $childMainClass: ${e.g
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22612
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99515/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22612
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22612
**[Test build #99515 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99515/testReport)**
for PR 22612 at commit
[`ef4be38`](https://github.com/apache/spark/commit/e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23181
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23181
**[Test build #99524 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99524/testReport)**
for PR 23181 at commit
[`63ea05a`](https://github.com/apache/spark/commit/63
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23181
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5588/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23181
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23181
**[Test build #99523 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99523/testReport)**
for PR 23181 at commit
[`0406b92`](https://github.com/apache/spark/commit/04
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23181
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5587/
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/23181
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user shahidki31 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23181#discussion_r237959492
--- Diff:
core/src/test/scala/org/apache/spark/status/AppStatusListenerSuite.scala ---
@@ -1274,47 +1274,69 @@ class AppStatusListenerSuite extends Spark
Github user shahidki31 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23181#discussion_r237959457
--- Diff:
core/src/test/scala/org/apache/spark/status/AppStatusListenerSuite.scala ---
@@ -1274,47 +1274,69 @@ class AppStatusListenerSuite extends Spark
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r237956662
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/FPGrowthExample.scala ---
@@ -64,4 +64,3 @@ object FPGrowthExample {
spark.sto
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22957
**[Test build #99522 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99522/testReport)**
for PR 22957 at commit
[`5bca5e3`](https://github.com/apache/spark/commit/5b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5586/
Github user gdearment commented on the issue:
https://github.com/apache/spark/pull/23174
The issue with requiring the use of secrets is quite a bit of work must be
done in order to secure a cluster to ensure that the secrets are themselves
secured. Most of the high level concerns are
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23181#discussion_r237952522
--- Diff:
core/src/test/scala/org/apache/spark/status/AppStatusListenerSuite.scala ---
@@ -1274,47 +1274,69 @@ class AppStatusListenerSuite extends SparkFunS
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23181#discussion_r237952479
--- Diff:
core/src/test/scala/org/apache/spark/status/AppStatusListenerSuite.scala ---
@@ -1274,47 +1274,69 @@ class AppStatusListenerSuite extends SparkFunS
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23189
Actually the problem is here:
```
case e: ClassNotFoundException =>
logWarning(s"Failed to load $childMainClass.", e)
```
That particular `logWarning` is not
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23177
Oh, @kiszk . Could you update AppVoyer script together? AppVoyer still uses
a static version number unlike with `build/mvn`.
-
https://github.com/apache/spark/blob/master/dev/appveyor-inst
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r237948799
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -186,6 +186,54 @@ abstract class OrcSuit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23177#discussion_r237945252
--- Diff: pom.xml ---
@@ -114,7 +114,7 @@
1.8
${java.version}
${java.version}
-3.5.4
+3.6.0
--- End diff
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23177
Thank you for pinging me, @HyukjinKwon .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20788
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20788
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99521/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20788
**[Test build #99521 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99521/testReport)**
for PR 20788 at commit
[`00a4888`](https://github.com/apache/spark/commit/0
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/23153#discussion_r237944306
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -155,19 +155,20 @@ object EliminateOuterJoin extends Ru
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23055#discussion_r237941472
--- Diff: docs/configuration.md ---
@@ -190,6 +190,8 @@ of the most common options to set are:
and it is up to the application to avoid exceeding the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20788
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20788
**[Test build #99521 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99521/testReport)**
for PR 20788 at commit
[`00a4888`](https://github.com/apache/spark/commit/00
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20788
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5585/
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20788
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99518/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22957
**[Test build #99518 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99518/testReport)**
for PR 22957 at commit
[`6eee1e4`](https://github.com/apache/spark/commit/6
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23159
**[Test build #99520 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99520/testReport)**
for PR 23159 at commit
[`a5e82f7`](https://github.com/apache/spark/commit/a5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23159
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5584/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23159
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23173
**[Test build #99519 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99519/testReport)**
for PR 23173 at commit
[`6165e1a`](https://github.com/apache/spark/commit/61
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23173
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23173
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5583/
Github user juliuszsompolski commented on the issue:
https://github.com/apache/spark/pull/23152
This reproes it:
```
sql("create table all_null (attr1 int, attr2 int)")
sql("insert into all_null values (null, null)")
sql("analyze table all_null co
Github user juliuszsompolski commented on the issue:
https://github.com/apache/spark/pull/23152
While at it, could we kill one more potential for a bug?
In `FilterEstimation.evaluateBinaryForTwoColumns` there is a
```
attrLeft.dataType match {
case StringType |
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5582/
Github user shahidki31 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23160#discussion_r237907702
--- Diff: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
---
@@ -610,7 +610,8 @@ $(document).ready(function () {
$(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5581/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23183
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23183
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5580/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22957
**[Test build #99518 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99518/testReport)**
for PR 22957 at commit
[`6eee1e4`](https://github.com/apache/spark/commit/6e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22957#discussion_r237905754
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -780,6 +780,23 @@ class PlannerSuite extends SharedSQLContext {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99517/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22957
**[Test build #99517 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99517/testReport)**
for PR 22957 at commit
[`5c6b9fc`](https://github.com/apache/spark/commit/5
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22957
**[Test build #99517 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99517/testReport)**
for PR 22957 at commit
[`5c6b9fc`](https://github.com/apache/spark/commit/5c
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23183
**[Test build #99516 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99516/testReport)**
for PR 23183 at commit
[`eb7d194`](https://github.com/apache/spark/commit/eb
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23184#discussion_r237896514
--- Diff: R/pkg/R/functions.R ---
@@ -202,8 +202,9 @@ NULL
#' \itemize{
#' \item \code{from_json}: a structType object to use as t
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23184#discussion_r237898787
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala
---
@@ -225,4 +225,10 @@ private[sql] object SQLUtils extends Logging {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23184#discussion_r237899057
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala
---
@@ -225,4 +225,10 @@ private[sql] object SQLUtils extends Logging {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22612
**[Test build #99515 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99515/testReport)**
for PR 22612 at commit
[`ef4be38`](https://github.com/apache/spark/commit/ef
Github user kjmrknsn commented on the issue:
https://github.com/apache/spark/pull/23185
Thanks for checking and merging. I used a spell checker software and
checked its result.
---
-
To unsubscribe, e-mail: reviews-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18406
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99510/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99510 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99510/testReport)**
for PR 23150 at commit
[`f3f46c7`](https://github.com/apache/spark/commit/f
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23185
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23185
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23186#discussion_r237889346
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -345,15 +346,18 @@ object PartitioningUtils {
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23186#discussion_r237889521
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileIndexSuite.scala
---
@@ -65,6 +65,34 @@ class FileIndexSuite extends Shar
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23186#discussion_r237888926
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -345,15 +346,18 @@ object PartitioningUtils {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23146#discussion_r237888294
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/loss/DifferentiableRegularizationSuite.scala
---
@@ -16,9 +16,13 @@
*/
package org.apach
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23146#discussion_r237888645
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -250,6 +250,66 @@ private[classification] trait LogisticRe
Github user pgandhi999 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23160#discussion_r237843584
--- Diff: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
---
@@ -610,7 +610,8 @@ $(document).ready(function () {
$(
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23146#discussion_r237888349
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/loss/DifferentiableRegularizationSuite.scala
---
@@ -16,9 +16,13 @@
*/
package org.apach
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23146#discussion_r237888585
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -250,6 +250,66 @@ private[classification] trait LogisticRe
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22957#discussion_r237887275
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -780,6 +780,23 @@ class PlannerSuite extends SharedSQLContext {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23151#discussion_r237886340
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -105,5 +105,16 @@ abstract class SparkFunSuite
logInfo(s"\n\n= FINISH
201 - 300 of 429 matches
Mail list logo