[GitHub] [spark] cloud-fan commented on a change in pull request #25771: [SPARK-28970][SQL] Implement USE CATALOG/NAMESPACE for Data Source V2

2019-09-18 Thread GitBox
cloud-fan commented on a change in pull request #25771: [SPARK-28970][SQL] Implement USE CATALOG/NAMESPACE for Data Source V2 URL: https://github.com/apache/spark/pull/25771#discussion_r325965604 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/Delega

[GitHub] [spark] wangyum commented on issue #25841: [MINOR][BUILD][2.4] Fix build errors after upgrading genjavadoc to 0.14

2019-09-18 Thread GitBox
wangyum commented on issue #25841: [MINOR][BUILD][2.4] Fix build errors after upgrading genjavadoc to 0.14 URL: https://github.com/apache/spark/pull/25841#issuecomment-532937261 cc @dongjoon-hyun This is an automated message

[GitHub] [spark] wangyum opened a new pull request #25841: [MINOR][BUILD][2.4] Fix build errors after upgrading genjavadoc to 0.14

2019-09-18 Thread GitBox
wangyum opened a new pull request #25841: [MINOR][BUILD][2.4] Fix build errors after upgrading genjavadoc to 0.14 URL: https://github.com/apache/spark/pull/25841 ### What changes were proposed in this pull request? This PR backport https://github.com/apache/spark/pull/24443 to fix er

[GitHub] [spark] HyukjinKwon commented on issue #20958: [SPARK-23844][SS] Fix socket source honors recovered offsets issue

2019-09-18 Thread GitBox
HyukjinKwon commented on issue #20958: [SPARK-23844][SS] Fix socket source honors recovered offsets issue URL: https://github.com/apache/spark/pull/20958#issuecomment-532937015 It's up to you. I just quickly skimmed the comments and looked close to go so I pinged you :-).

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25775: [WIP][SPARK-29015][SQL][test-hadoop3.2] fix bug for jdk11, can't use 'add jar' jar's class as create table serde

2019-09-18 Thread GitBox
AngersZh commented on a change in pull request #25775: [WIP][SPARK-29015][SQL][test-hadoop3.2] fix bug for jdk11, can't use 'add jar' jar's class as create table serde URL: https://github.com/apache/spark/pull/25775#discussion_r325049959 ## File path: sql/hive/src/main/scala/o

[GitHub] [spark] AmplabJenkins removed a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-532936744 Test PASSed. Refer to this link for build results (access rights to CI ser

[GitHub] [spark] AmplabJenkins commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-532936744 Test PASSed. Refer to this link for build results (access rights to CI server need

[GitHub] [spark] AmplabJenkins removed a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-532936738 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-532936738 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-18 Thread GitBox
SparkQA removed a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-532883191 **[Test build #110938 has started](https://amplab.cs.berkeley.edu/jenkins/job/Spar

[GitHub] [spark] SparkQA commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-18 Thread GitBox
SparkQA commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-532936332 **[Test build #110938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRe

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

2019-09-18 Thread GitBox
cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-532935452 @rdblue I agree with the behavior you posted, but like you said I don't want to mix with SPARK-29014 so I intentional

[GitHub] [spark] AmplabJenkins removed a comment on issue #25681: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25681: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25681#issuecomment-532934842 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/j

[GitHub] [spark] AmplabJenkins removed a comment on issue #25681: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25681: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25681#issuecomment-532934840 Merged build finished. Test PASSed. This is an automated mes

[GitHub] [spark] AmplabJenkins commented on issue #25681: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25681: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25681#issuecomment-532934840 Merged build finished. Test PASSed. This is an automated message fro

[GitHub] [spark] AmplabJenkins commented on issue #25681: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25681: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25681#issuecomment-532934842 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//

[GitHub] [spark] SparkQA removed a comment on issue #25681: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-18 Thread GitBox
SparkQA removed a comment on issue #25681: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25681#issuecomment-532861301 **[Test build #110933 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110933/testReport)** for PR

[GitHub] [spark] SparkQA commented on issue #25681: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-18 Thread GitBox
SparkQA commented on issue #25681: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25681#issuecomment-532934380 **[Test build #110933 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110933/testReport)** for PR 25681 at

[GitHub] [spark] jerryshao commented on issue #20958: [SPARK-23844][SS] Fix socket source honors recovered offsets issue

2019-09-18 Thread GitBox
jerryshao commented on issue #20958: [SPARK-23844][SS] Fix socket source honors recovered offsets issue URL: https://github.com/apache/spark/pull/20958#issuecomment-532933204 Yes, I can merge, but are we still going to proceed this PR? This has been staled for a long time. ---

[GitHub] [spark] colinmjj commented on a change in pull request #25759: [SPARK-19147][CORE] Gracefully handle error in task after executor is stopped

2019-09-18 Thread GitBox
colinmjj commented on a change in pull request #25759: [SPARK-19147][CORE] Gracefully handle error in task after executor is stopped URL: https://github.com/apache/spark/pull/25759#discussion_r325961757 ## File path: core/src/main/scala/org/apache/spark/executor/Executor.scala

[GitHub] [spark] maropu edited a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-18 Thread GitBox
maropu edited a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-532916337 > Oh, this is good point. I think it is only said that aggregate function's buffer a

[GitHub] [spark] maropu edited a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-18 Thread GitBox
maropu edited a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-532916337 > Oh, this is good point. I think it is only said that aggregate function's buffer a

[GitHub] [spark] maropu edited a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-18 Thread GitBox
maropu edited a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-532916337 > Oh, this is good point. I think it is only said that aggregate function's buffer a

[GitHub] [spark] cloud-fan commented on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT

2019-09-18 Thread GitBox
cloud-fan commented on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT URL: https://github.com/apache/spark/pull/25835#issuecomment-532932030 @dongjoon-hyun do you know how to re-trigger the github checks?

[GitHub] [spark] zhengruifeng commented on issue #25815: [SPARK-29118][ML] Avoid redundant computation in transform of GMM & GLR

2019-09-18 Thread GitBox
zhengruifeng commented on issue #25815: [SPARK-29118][ML] Avoid redundant computation in transform of GMM & GLR URL: https://github.com/apache/spark/pull/25815#issuecomment-532930612 @srowen Thanks for reviewing! This is an a

[GitHub] [spark] AmplabJenkins removed a comment on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532930462 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.

[GitHub] [spark] AmplabJenkins commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532930462 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley

[GitHub] [spark] AmplabJenkins removed a comment on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532930457 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532930457 Merged build finished. Test PASSed. This is an automate

[GitHub] [spark] HyukjinKwon commented on issue #25006: [SPARK-28208][BUILD][SQL] Upgrade to ORC 1.5.6 including closing the ORC readers

2019-09-18 Thread GitBox
HyukjinKwon commented on issue #25006: [SPARK-28208][BUILD][SQL] Upgrade to ORC 1.5.6 including closing the ORC readers URL: https://github.com/apache/spark/pull/25006#issuecomment-532930280 https://github.com/apache/spark/pull/25006#discussion_r298788206 is a valid comment. Can we fix it

[GitHub] [spark] SparkQA commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
SparkQA commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532930208 **[Test build #110957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110957/testReport)** fo

[GitHub] [spark] HyukjinKwon commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
HyukjinKwon commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532929816 retest this please This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table URL: https://github.com/apache/spark/pull/25840#issuecomment-532929110 Test PASSed. Refer to this link for build results (access rights to C

[GitHub] [spark] AmplabJenkins removed a comment on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table URL: https://github.com/apache/spark/pull/25840#issuecomment-532929108 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table URL: https://github.com/apache/spark/pull/25840#issuecomment-532929110 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table URL: https://github.com/apache/spark/pull/25840#issuecomment-532929108 Merged build finished. Test PASSed. ---

[GitHub] [spark] SparkQA commented on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table

2019-09-18 Thread GitBox
SparkQA commented on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table URL: https://github.com/apache/spark/pull/25840#issuecomment-532928833 **[Test build #110955 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPu

[GitHub] [spark] AmplabJenkins removed a comment on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table URL: https://github.com/apache/spark/pull/25840#issuecomment-532927771 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table URL: https://github.com/apache/spark/pull/25840#issuecomment-532927775 Test PASSed. Refer to this link for build results (access rights to C

[GitHub] [spark] SparkQA commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
SparkQA commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532928842 **[Test build #110956 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110

[GitHub] [spark] HeartSaVioR commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
HeartSaVioR commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532928279 retest this, please This is an autom

[GitHub] [spark] HeartSaVioR commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
HeartSaVioR commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532928221 "metadata not propagated" not relevant to this patch. ---

[GitHub] [spark] AmplabJenkins commented on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table URL: https://github.com/apache/spark/pull/25840#issuecomment-532927775 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table URL: https://github.com/apache/spark/pull/25840#issuecomment-532927771 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package URL: https://github.com/apache/spark/pull/25022#issuecomment-532927155 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package URL: https://github.com/apache/spark/pull/25022#issuecomment-532927147 Build finished. Test FAILed.

[GitHub] [spark] LantaoJin opened a new pull request #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table

2019-09-18 Thread GitBox
LantaoJin opened a new pull request #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table URL: https://github.com/apache/spark/pull/25840 ### What changes were proposed in this pull request? Dynamic partition in Hive table has some res

[GitHub] [spark] AmplabJenkins commented on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package URL: https://github.com/apache/spark/pull/25022#issuecomment-532927155 Test FAILed. Refer to this link for build results (access rights to CI server needed): http

[GitHub] [spark] AmplabJenkins commented on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package URL: https://github.com/apache/spark/pull/25022#issuecomment-532927147 Build finished. Test FAILed. Thi

[GitHub] [spark] cloud-fan commented on a change in pull request #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

2019-09-18 Thread GitBox
cloud-fan commented on a change in pull request #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#discussion_r325956805 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.s

[GitHub] [spark] cloud-fan commented on a change in pull request #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

2019-09-18 Thread GitBox
cloud-fan commented on a change in pull request #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#discussion_r325956805 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.s

[GitHub] [spark] SparkQA removed a comment on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package

2019-09-18 Thread GitBox
SparkQA removed a comment on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package URL: https://github.com/apache/spark/pull/25022#issuecomment-532896210 **[Test build #110943 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestB

[GitHub] [spark] SparkQA commented on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package

2019-09-18 Thread GitBox
SparkQA commented on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package URL: https://github.com/apache/spark/pull/25022#issuecomment-532926852 **[Test build #110943 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/

[GitHub] [spark] cloud-fan commented on issue #25620: [SPARK-25341][Core] Support rolling back a shuffle map stage and re-generate the shuffle files

2019-09-18 Thread GitBox
cloud-fan commented on issue #25620: [SPARK-25341][Core] Support rolling back a shuffle map stage and re-generate the shuffle files URL: https://github.com/apache/spark/pull/25620#issuecomment-532926287 @squito @vanzin @jiangxb1987 do you have any more comments? This looks good to me now a

[GitHub] [spark] AmplabJenkins removed a comment on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532925822 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #23634: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows

2019-09-18 Thread GitBox
SparkQA commented on issue #23634: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows URL: https://github.com/apache/spark/pull/23634#issuecomment-532926101 **[Test build #110954 has started](https://amplab.cs.berkeley.edu/jenkins/job/S

[GitHub] [spark] AmplabJenkins removed a comment on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532925815 Merged build finished. Test FAILed. ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #25839: [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25839: [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10 URL: https://github.com/apache/spark/pull/25839#issuecomment-532925515 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley

[GitHub] [spark] AmplabJenkins commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532925822 Test FAILed. Refer to this link for build results (access rights to CI server needed): https:

[GitHub] [spark] SparkQA removed a comment on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
SparkQA removed a comment on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532899510 **[Test build #110945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBui

[GitHub] [spark] AmplabJenkins commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532925815 Merged build finished. Test FAILed. ---

[GitHub] [spark] SparkQA removed a comment on issue #25839: [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10

2019-09-18 Thread GitBox
SparkQA removed a comment on issue #25839: [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10 URL: https://github.com/apache/spark/pull/25839#issuecomment-532922045 **[Test build #110952 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110952/testReport)** f

[GitHub] [spark] AmplabJenkins removed a comment on issue #25839: [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25839: [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10 URL: https://github.com/apache/spark/pull/25839#issuecomment-532925513 Merged build finished. Test FAILed. This is an automat

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
dongjoon-hyun commented on a change in pull request #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#discussion_r325955656 ## File path: core/src/main/scala/org/apache/spark/scheduler/LiveListenerB

[GitHub] [spark] SparkQA commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
SparkQA commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532925610 **[Test build #110945 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/11

[GitHub] [spark] SparkQA commented on issue #25839: [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10

2019-09-18 Thread GitBox
SparkQA commented on issue #25839: [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10 URL: https://github.com/apache/spark/pull/25839#issuecomment-532925482 **[Test build #110952 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110952/testReport)** for PR 2

[GitHub] [spark] AmplabJenkins commented on issue #25839: [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25839: [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10 URL: https://github.com/apache/spark/pull/25839#issuecomment-532925515 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jen

[GitHub] [spark] AmplabJenkins commented on issue #25839: [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25839: [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10 URL: https://github.com/apache/spark/pull/25839#issuecomment-532925513 Merged build finished. Test FAILed. This is an automated messa

[GitHub] [spark] AmplabJenkins removed a comment on issue #25702: [SPARK-29001][CORE] Print events that take too long time to process

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25702: [SPARK-29001][CORE] Print events that take too long time to process URL: https://github.com/apache/spark/pull/25702#issuecomment-532925104 Merged build finished. Test PASSed. T

[GitHub] [spark] AmplabJenkins removed a comment on issue #25702: [SPARK-29001][CORE] Print events that take too long time to process

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25702: [SPARK-29001][CORE] Print events that take too long time to process URL: https://github.com/apache/spark/pull/25702#issuecomment-532925108 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://a

[GitHub] [spark] AmplabJenkins commented on issue #25702: [SPARK-29001][CORE] Print events that take too long time to process

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25702: [SPARK-29001][CORE] Print events that take too long time to process URL: https://github.com/apache/spark/pull/25702#issuecomment-532925104 Merged build finished. Test PASSed. This is a

[GitHub] [spark] AmplabJenkins commented on issue #25702: [SPARK-29001][CORE] Print events that take too long time to process

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25702: [SPARK-29001][CORE] Print events that take too long time to process URL: https://github.com/apache/spark/pull/25702#issuecomment-532925108 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs

[GitHub] [spark] SparkQA removed a comment on issue #25702: [SPARK-29001][CORE] Print events that take too long time to process

2019-09-18 Thread GitBox
SparkQA removed a comment on issue #25702: [SPARK-29001][CORE] Print events that take too long time to process URL: https://github.com/apache/spark/pull/25702#issuecomment-532881025 **[Test build #110937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110937

[GitHub] [spark] SparkQA commented on issue #25702: [SPARK-29001][CORE] Print events that take too long time to process

2019-09-18 Thread GitBox
SparkQA commented on issue #25702: [SPARK-29001][CORE] Print events that take too long time to process URL: https://github.com/apache/spark/pull/25702#issuecomment-532924637 **[Test build #110937 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110937/testRe

[GitHub] [spark] dongjoon-hyun closed pull request #25839: [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10

2019-09-18 Thread GitBox
dongjoon-hyun closed pull request #25839: [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10 URL: https://github.com/apache/spark/pull/25839 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] dongjoon-hyun commented on issue #25839: [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10

2019-09-18 Thread GitBox
dongjoon-hyun commented on issue #25839: [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10 URL: https://github.com/apache/spark/pull/25839#issuecomment-532923317 Thank you, @wangyum ! This is an automated message from

[GitHub] [spark] maropu edited a comment on issue #25831: [SPARK-29122][SQL] Propagate all the SQL conf to executors in SQLQueryTestSuite

2019-09-18 Thread GitBox
maropu edited a comment on issue #25831: [SPARK-29122][SQL] Propagate all the SQL conf to executors in SQLQueryTestSuite URL: https://github.com/apache/spark/pull/25831#issuecomment-532923090 I'm diging into the failures now.

[GitHub] [spark] maropu edited a comment on issue #25831: [SPARK-29122][SQL] Propagate all the SQL conf to executors in SQLQueryTestSuite

2019-09-18 Thread GitBox
maropu edited a comment on issue #25831: [SPARK-29122][SQL] Propagate all the SQL conf to executors in SQLQueryTestSuite URL: https://github.com/apache/spark/pull/25831#issuecomment-532923090 I'm digging into the failures now. ---

[GitHub] [spark] maropu commented on issue #25831: [SPARK-29122][SQL] Propagate all the SQL conf to executors in SQLQueryTestSuite

2019-09-18 Thread GitBox
maropu commented on issue #25831: [SPARK-29122][SQL] Propagate all the SQL conf to executors in SQLQueryTestSuite URL: https://github.com/apache/spark/pull/25831#issuecomment-532923090 I'm dig into the failures now. This is a

[GitHub] [spark] dongjoon-hyun commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
dongjoon-hyun commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532922929 Thank you for the opinion, @srowen . I'll take a look more. BTW, the Jenkins failed with the following. It looks i

[GitHub] [spark] AmplabJenkins removed a comment on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT URL: https://github.com/apache/spark/pull/25835#issuecomment-532889148 Can one of the admins verify this patch? -

[GitHub] [spark] AmplabJenkins removed a comment on issue #25839: [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25839: [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10 URL: https://github.com/apache/spark/pull/25839#issuecomment-532920967 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.

[GitHub] [spark] SparkQA commented on issue #25839: [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10

2019-09-18 Thread GitBox
SparkQA commented on issue #25839: [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10 URL: https://github.com/apache/spark/pull/25839#issuecomment-532922045 **[Test build #110952 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110952/testReport)** fo

[GitHub] [spark] AmplabJenkins removed a comment on issue #25839: [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25839: [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10 URL: https://github.com/apache/spark/pull/25839#issuecomment-532920962 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT

2019-09-18 Thread GitBox
SparkQA commented on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT URL: https://github.com/apache/spark/pull/25835#issuecomment-532922053 **[Test build #110953 has started](https://amplab.cs.berkeley.edu

[GitHub] [spark] maropu commented on issue #25693: [SPARK-28989][SQL] Add `spark.sql.ansi.enabled`

2019-09-18 Thread GitBox
maropu commented on issue #25693: [SPARK-28989][SQL] Add `spark.sql.ansi.enabled` URL: https://github.com/apache/spark/pull/25693#issuecomment-532921410 Looks ok to me, too. This is an automated message from the Apache Git Se

[GitHub] [spark] AmplabJenkins commented on issue #25839: [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25839: [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10 URL: https://github.com/apache/spark/pull/25839#issuecomment-532920967 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley

[GitHub] [spark] AmplabJenkins commented on issue #25839: [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25839: [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10 URL: https://github.com/apache/spark/pull/25839#issuecomment-532920962 Merged build finished. Test PASSed. This is an automate

[GitHub] [spark] wangyum opened a new pull request #25839: [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10

2019-09-18 Thread GitBox
wangyum opened a new pull request #25839: [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10 URL: https://github.com/apache/spark/pull/25839 ### What changes were proposed in this pull request? This PR backport https://github.com/apache/spark/pull/25404 to branch-2.4.

[GitHub] [spark] dongjoon-hyun closed pull request #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
dongjoon-hyun closed pull request #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828 This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] maropu commented on issue #25835: [SPARK-XXXXX][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT

2019-09-18 Thread GitBox
maropu commented on issue #25835: [SPARK-X][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT URL: https://github.com/apache/spark/pull/25835#issuecomment-532920062 cc: @cloud-fan @viirya --

[GitHub] [spark] maropu commented on a change in pull request #25835: [SPARK-XXXXX][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT

2019-09-18 Thread GitBox
maropu commented on a change in pull request #25835: [SPARK-X][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT URL: https://github.com/apache/spark/pull/25835#discussion_r325950610 ## File path: sql/catalyst/src/main/sca

[GitHub] [spark] AmplabJenkins removed a comment on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions URL: https://github.com/apache/spark/pull/24939#issuecomment-532919717 Test PASSed. Refer to this link for build results (access rights to CI server needed): htt

[GitHub] [spark] HeartSaVioR commented on issue #25835: [SPARK-XXXXX][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT

2019-09-18 Thread GitBox
HeartSaVioR commented on issue #25835: [SPARK-X][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT URL: https://github.com/apache/spark/pull/25835#issuecomment-532919621 OK I'll file one. Thanks for the guide. -

[GitHub] [spark] AmplabJenkins commented on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828#issuecomment-532919697 Merged build finished. Test PASSed. This is an a

[GitHub] [spark] AmplabJenkins commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions URL: https://github.com/apache/spark/pull/24939#issuecomment-532919712 Merged build finished. Test PASSed. Thi

[GitHub] [spark] maropu commented on issue #25835: [SPARK-XXXXX][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT

2019-09-18 Thread GitBox
maropu commented on issue #25835: [SPARK-X][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT URL: https://github.com/apache/spark/pull/25835#issuecomment-532919705 Thanks! --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828#issuecomment-532919697 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions URL: https://github.com/apache/spark/pull/24939#issuecomment-532919717 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amp

[GitHub] [spark] AmplabJenkins removed a comment on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828#issuecomment-532919700 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amp

<    1   2   3   4   5   6   7   8   9   10   >