[GitHub] [spark] HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558424184 cc. @dongjoon-hyun @gatorsmile @gengliangwang @zsxwing - this is the PR to revert both commits. Once this is merged I'll raise a separate PR for

[GitHub] [spark] beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r350511432 ## File path:

[GitHub] [spark] HeartSaVioR opened a new pull request #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
HeartSaVioR opened a new pull request #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671 ### What changes were proposed in this pull request? This reverts commit 31c4fab (#23052) and 0d3d46d (#26639) ### Why are the changes needed?

[GitHub] [spark] AmplabJenkins removed a comment on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558422833 Merged build finished. Test PASSed.

[GitHub] [spark] beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r350510597 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558422836 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] gengliangwang commented on a change in pull request #26637: [SPARK-29997][WEBUI] Show job name for empty jobs in WebUI

2019-11-25 Thread GitBox
gengliangwang commented on a change in pull request #26637: [SPARK-29997][WEBUI] Show job name for empty jobs in WebUI URL: https://github.com/apache/spark/pull/26637#discussion_r350510507 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ##

[GitHub] [spark] AmplabJenkins commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558422833 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558422836 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] Ngone51 commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions

2019-11-25 Thread GitBox
Ngone51 commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions URL: https://github.com/apache/spark/pull/26629#discussion_r350510233 ## File path:

[GitHub] [spark] beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r350510034 ## File path:

[GitHub] [spark] viirya commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions

2019-11-25 Thread GitBox
viirya commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions URL: https://github.com/apache/spark/pull/26629#discussion_r350509590 ## File path:

[GitHub] [spark] Ngone51 commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions

2019-11-25 Thread GitBox
Ngone51 commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions URL: https://github.com/apache/spark/pull/26629#discussion_r350509027 ## File path:

[GitHub] [spark] Ngone51 commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions

2019-11-25 Thread GitBox
Ngone51 commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions URL: https://github.com/apache/spark/pull/26629#discussion_r350508719 ## File path:

[GitHub] [spark] viirya commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions

2019-11-25 Thread GitBox
viirya commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions URL: https://github.com/apache/spark/pull/26629#discussion_r350507934 ## File path:

[GitHub] [spark] AngersZhuuuu edited a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AngersZh edited a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558387275 > @AngersZh, I think there's probably some thing wrong with your latest master merge...

[GitHub] [spark] viirya commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions

2019-11-25 Thread GitBox
viirya commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions URL: https://github.com/apache/spark/pull/26629#discussion_r350507204 ## File path:

[GitHub] [spark] huangtianhua commented on a change in pull request #26636: [SPARK-27721][BUILD] Switch to use right leveldbjni according to the platforms

2019-11-25 Thread GitBox
huangtianhua commented on a change in pull request #26636: [SPARK-27721][BUILD] Switch to use right leveldbjni according to the platforms URL: https://github.com/apache/spark/pull/26636#discussion_r350503735 ## File path: pom.xml ## @@ -3081,5 +3094,17 @@

[GitHub] [spark] AmplabJenkins removed a comment on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module URL: https://github.com/apache/spark/pull/26668#issuecomment-558411657 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module URL: https://github.com/apache/spark/pull/26668#issuecomment-558411651 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module URL: https://github.com/apache/spark/pull/26668#issuecomment-558411657 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] gengliangwang commented on issue #26639: [SPARK-29999][SS] Handle FileStreamSink metadata correctly for empty partition

2019-11-25 Thread GitBox
gengliangwang commented on issue #26639: [SPARK-2][SS] Handle FileStreamSink metadata correctly for empty partition URL: https://github.com/apache/spark/pull/26639#issuecomment-558411747 Yes, I think a PR containing two revert commits is OK

[GitHub] [spark] AmplabJenkins commented on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module URL: https://github.com/apache/spark/pull/26668#issuecomment-558411651 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module

2019-11-25 Thread GitBox
SparkQA removed a comment on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module URL: https://github.com/apache/spark/pull/26668#issuecomment-558368474 **[Test build #114431 has

[GitHub] [spark] SparkQA commented on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module

2019-11-25 Thread GitBox
SparkQA commented on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module URL: https://github.com/apache/spark/pull/26668#issuecomment-558411206 **[Test build #114431 has

[GitHub] [spark] HeartSaVioR commented on issue #26639: [SPARK-29999][SS] Handle FileStreamSink metadata correctly for empty partition

2019-11-25 Thread GitBox
HeartSaVioR commented on issue #26639: [SPARK-2][SS] Handle FileStreamSink metadata correctly for empty partition URL: https://github.com/apache/spark/pull/26639#issuecomment-558410989 Could I get some guidance here for revert? Because I have seen both approaches in community for

[GitHub] [spark] gengliangwang commented on issue #26639: [SPARK-29999][SS] Handle FileStreamSink metadata correctly for empty partition

2019-11-25 Thread GitBox
gengliangwang commented on issue #26639: [SPARK-2][SS] Handle FileStreamSink metadata correctly for empty partition URL: https://github.com/apache/spark/pull/26639#issuecomment-558408169 @HeartSaVioR Yes please revert both and keep the UT in this PR(maybe more UTs).

[GitHub] [spark] HeartSaVioR commented on a change in pull request #26590: [SPARK-29953][SS] Don't clean up source files for FileStreamSource if the files belong to the output of FileStreamSink

2019-11-25 Thread GitBox
HeartSaVioR commented on a change in pull request #26590: [SPARK-29953][SS] Don't clean up source files for FileStreamSource if the files belong to the output of FileStreamSink URL: https://github.com/apache/spark/pull/26590#discussion_r350493401 ## File path:

[GitHub] [spark] HeartSaVioR commented on issue #26639: [SPARK-29999][SS] Handle FileStreamSink metadata correctly for empty partition

2019-11-25 Thread GitBox
HeartSaVioR commented on issue #26639: [SPARK-2][SS] Handle FileStreamSink metadata correctly for empty partition URL: https://github.com/apache/spark/pull/26639#issuecomment-558407617 I'm OK with reverting both #23052 and this, and let me come up with another PR (maybe minor PR or

[GitHub] [spark] AmplabJenkins removed a comment on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module URL: https://github.com/apache/spark/pull/26668#issuecomment-558406962 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module URL: https://github.com/apache/spark/pull/26668#issuecomment-558406968 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module URL: https://github.com/apache/spark/pull/26668#issuecomment-558406968 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module URL: https://github.com/apache/spark/pull/26668#issuecomment-558406962 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module

2019-11-25 Thread GitBox
SparkQA removed a comment on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module URL: https://github.com/apache/spark/pull/26668#issuecomment-558359733 **[Test build #114430 has

[GitHub] [spark] SparkQA commented on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module

2019-11-25 Thread GitBox
SparkQA commented on issue #26668: [SPARK-30031][BUILD][SQL] Remove `hive-2.3` profile from `sql/hive` module URL: https://github.com/apache/spark/pull/26668#issuecomment-558406564 **[Test build #114430 has

[GitHub] [spark] HeartSaVioR commented on a change in pull request #26590: [SPARK-29953][SS] Don't clean up source files for FileStreamSource if the files belong to the output of FileStreamSink

2019-11-25 Thread GitBox
HeartSaVioR commented on a change in pull request #26590: [SPARK-29953][SS] Don't clean up source files for FileStreamSource if the files belong to the output of FileStreamSink URL: https://github.com/apache/spark/pull/26590#discussion_r350493401 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system.

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system. URL: https://github.com/apache/spark/pull/26670#issuecomment-558405253 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system.

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system. URL: https://github.com/apache/spark/pull/26670#issuecomment-558405247 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system.

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system. URL: https://github.com/apache/spark/pull/26670#issuecomment-558405253 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system.

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system. URL: https://github.com/apache/spark/pull/26670#issuecomment-558405247 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system.

2019-11-25 Thread GitBox
SparkQA commented on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system. URL: https://github.com/apache/spark/pull/26670#issuecomment-558404911 **[Test build #114434 has

[GitHub] [spark] vanzin opened a new pull request #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system.

2019-11-25 Thread GitBox
vanzin opened a new pull request #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system. URL: https://github.com/apache/spark/pull/26670 SPARK-25299 is introducing a new plugin interface for shuffle IO; currently, parts of that API provide lifecycle methods

[GitHub] [spark] AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558401260 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558401254 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #26649: [SPARK-29862][SQL] CREATE (OR REPLACE) ... VIEW should look up catalog/table like v2 commands

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26649: [SPARK-29862][SQL] CREATE (OR REPLACE) ... VIEW should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26649#issuecomment-558401009 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26649: [SPARK-29862][SQL] CREATE (OR REPLACE) ... VIEW should look up catalog/table like v2 commands

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26649: [SPARK-29862][SQL] CREATE (OR REPLACE) ... VIEW should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26649#issuecomment-558401013 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558401254 Merged build finished. Test PASSed. This is an automated message from

[GitHub] [spark] AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558401260 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26649: [SPARK-29862][SQL] CREATE (OR REPLACE) ... VIEW should look up catalog/table like v2 commands

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26649: [SPARK-29862][SQL] CREATE (OR REPLACE) ... VIEW should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26649#issuecomment-558401013 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #26649: [SPARK-29862][SQL] CREATE (OR REPLACE) ... VIEW should look up catalog/table like v2 commands

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26649: [SPARK-29862][SQL] CREATE (OR REPLACE) ... VIEW should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26649#issuecomment-558401009 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #26649: [SPARK-29862][SQL] CREATE (OR REPLACE) ... VIEW should look up catalog/table like v2 commands

2019-11-25 Thread GitBox
SparkQA removed a comment on issue #26649: [SPARK-29862][SQL] CREATE (OR REPLACE) ... VIEW should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26649#issuecomment-558317104 **[Test build #114427 has

[GitHub] [spark] SparkQA commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
SparkQA commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558400885 **[Test build #114433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114433/testReport)** for PR 26669 at

[GitHub] [spark] SparkQA commented on issue #26649: [SPARK-29862][SQL] CREATE (OR REPLACE) ... VIEW should look up catalog/table like v2 commands

2019-11-25 Thread GitBox
SparkQA commented on issue #26649: [SPARK-29862][SQL] CREATE (OR REPLACE) ... VIEW should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26649#issuecomment-558400567 **[Test build #114427 has

[GitHub] [spark] HyukjinKwon commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
HyukjinKwon commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558400085 Its alright. I noticed but thankfully that's part of our test :D This is

[GitHub] [spark] maropu commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-11-25 Thread GitBox
maropu commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#discussion_r350487326 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558399516 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dongjoon-hyun edited a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
dongjoon-hyun edited a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558399747 Opps. Sorry, I added the updated manifest, too. This is an

[GitHub] [spark] dongjoon-hyun commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
dongjoon-hyun commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558399747 Opps. Sorry, I added the manifest updated, too. This is an automated

[GitHub] [spark] SparkQA removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
SparkQA removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558399041 **[Test build #114432 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114432/testReport)** for PR

[GitHub] [spark] AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558399512 Merged build finished. Test FAILed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558399512 Merged build finished. Test FAILed. This is an automated message from

[GitHub] [spark] AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558399286 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] SparkQA commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
SparkQA commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558399495 **[Test build #114432 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114432/testReport)** for PR 26669 at

[GitHub] [spark] AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558399516 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] maropu commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-11-25 Thread GitBox
maropu commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#discussion_r350486805 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558399290 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] maropu commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-11-25 Thread GitBox
maropu commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#discussion_r350486670 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/TestUDT.scala

[GitHub] [spark] AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558399286 Merged build finished. Test PASSed. This is an automated message from

[GitHub] [spark] AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558399290 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
SparkQA commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558399041 **[Test build #114432 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114432/testReport)** for PR 26669 at

[GitHub] [spark] AmplabJenkins removed a comment on issue #26082: [SPARK-29431][WebUI] Improve Web UI / Sql tab visualization with cached dataframes.

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26082: [SPARK-29431][WebUI] Improve Web UI / Sql tab visualization with cached dataframes. URL: https://github.com/apache/spark/pull/26082#issuecomment-558398532 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26082: [SPARK-29431][WebUI] Improve Web UI / Sql tab visualization with cached dataframes.

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26082: [SPARK-29431][WebUI] Improve Web UI / Sql tab visualization with cached dataframes. URL: https://github.com/apache/spark/pull/26082#issuecomment-558398541 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] dongjoon-hyun opened a new pull request #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
dongjoon-hyun opened a new pull request #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce

[GitHub] [spark] AmplabJenkins commented on issue #26082: [SPARK-29431][WebUI] Improve Web UI / Sql tab visualization with cached dataframes.

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26082: [SPARK-29431][WebUI] Improve Web UI / Sql tab visualization with cached dataframes. URL: https://github.com/apache/spark/pull/26082#issuecomment-558398541 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26082: [SPARK-29431][WebUI] Improve Web UI / Sql tab visualization with cached dataframes.

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26082: [SPARK-29431][WebUI] Improve Web UI / Sql tab visualization with cached dataframes. URL: https://github.com/apache/spark/pull/26082#issuecomment-558398532 Merged build finished. Test PASSed.

[GitHub] [spark] maropu commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-11-25 Thread GitBox
maropu commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#discussion_r350485657 ## File path: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala

[GitHub] [spark] SparkQA removed a comment on issue #26082: [SPARK-29431][WebUI] Improve Web UI / Sql tab visualization with cached dataframes.

2019-11-25 Thread GitBox
SparkQA removed a comment on issue #26082: [SPARK-29431][WebUI] Improve Web UI / Sql tab visualization with cached dataframes. URL: https://github.com/apache/spark/pull/26082#issuecomment-558310694 **[Test build #114424 has

[GitHub] [spark] SparkQA commented on issue #26082: [SPARK-29431][WebUI] Improve Web UI / Sql tab visualization with cached dataframes.

2019-11-25 Thread GitBox
SparkQA commented on issue #26082: [SPARK-29431][WebUI] Improve Web UI / Sql tab visualization with cached dataframes. URL: https://github.com/apache/spark/pull/26082#issuecomment-558398129 **[Test build #114424 has

[GitHub] [spark] dongjoon-hyun commented on issue #26639: [SPARK-29999][SS] Handle FileStreamSink metadata correctly for empty partition

2019-11-25 Thread GitBox
dongjoon-hyun commented on issue #26639: [SPARK-2][SS] Handle FileStreamSink metadata correctly for empty partition URL: https://github.com/apache/spark/pull/26639#issuecomment-558397523 I'm also fine with the reverting #23052 if we keep these unit tests like @zsxwing 's advice. >

[GitHub] [spark] AmplabJenkins commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#issuecomment-558397201 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#issuecomment-558397201 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#issuecomment-558397206 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#issuecomment-558397206 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] zsxwing commented on issue #26639: [SPARK-29999][SS] Handle FileStreamSink metadata correctly for empty partition

2019-11-25 Thread GitBox
zsxwing commented on issue #26639: [SPARK-2][SS] Handle FileStreamSink metadata correctly for empty partition URL: https://github.com/apache/spark/pull/26639#issuecomment-558396649 I think the empty partition optimization seems overkill if every task needs to check file existence for

[GitHub] [spark] SparkQA removed a comment on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

2019-11-25 Thread GitBox
SparkQA removed a comment on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#issuecomment-558348406 **[Test build #114429 has

[GitHub] [spark] SparkQA commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

2019-11-25 Thread GitBox
SparkQA commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#issuecomment-558396544 **[Test build #114429 has

[GitHub] [spark] HeartSaVioR edited a comment on issue #26639: [SPARK-29999][SS] Handle FileStreamSink metadata correctly for empty partition

2019-11-25 Thread GitBox
HeartSaVioR edited a comment on issue #26639: [SPARK-2][SS] Handle FileStreamSink metadata correctly for empty partition URL: https://github.com/apache/spark/pull/26639#issuecomment-558395855 @gengliangwang Thanks for the pointer on root issue. Missed it. Based on the root issue, this

[GitHub] [spark] HeartSaVioR edited a comment on issue #26639: [SPARK-29999][SS] Handle FileStreamSink metadata correctly for empty partition

2019-11-25 Thread GitBox
HeartSaVioR edited a comment on issue #26639: [SPARK-2][SS] Handle FileStreamSink metadata correctly for empty partition URL: https://github.com/apache/spark/pull/26639#issuecomment-558395855 @gengliangwang Thanks for the pointer on root issue. Missed it. Based on the root issue, this

[GitHub] [spark] HeartSaVioR commented on issue #26639: [SPARK-29999][SS] Handle FileStreamSink metadata correctly for empty partition

2019-11-25 Thread GitBox
HeartSaVioR commented on issue #26639: [SPARK-2][SS] Handle FileStreamSink metadata correctly for empty partition URL: https://github.com/apache/spark/pull/26639#issuecomment-558396258 @dongjoon-hyun Sorry I saw your comment just after commenting mine. I'll craft a follow-up PR to

[GitHub] [spark] HeartSaVioR commented on issue #26639: [SPARK-29999][SS] Handle FileStreamSink metadata correctly for empty partition

2019-11-25 Thread GitBox
HeartSaVioR commented on issue #26639: [SPARK-2][SS] Handle FileStreamSink metadata correctly for empty partition URL: https://github.com/apache/spark/pull/26639#issuecomment-558395855 @gengliangwang Thanks for the pointer on root issue. Missed it. Based on the root issue, this issue

[GitHub] [spark] zsxwing commented on a change in pull request #26590: [SPARK-29953][SS] Don't clean up source files for FileStreamSource if the files belong to the output of FileStreamSink

2019-11-25 Thread GitBox
zsxwing commented on a change in pull request #26590: [SPARK-29953][SS] Don't clean up source files for FileStreamSource if the files belong to the output of FileStreamSink URL: https://github.com/apache/spark/pull/26590#discussion_r350482586 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #26639: [SPARK-29999][SS] Handle FileStreamSink metadata correctly for empty partition

2019-11-25 Thread GitBox
dongjoon-hyun commented on issue #26639: [SPARK-2][SS] Handle FileStreamSink metadata correctly for empty partition URL: https://github.com/apache/spark/pull/26639#issuecomment-558394612 Please create a follow-up for DSv1 with the similar test coverage~

[GitHub] [spark] AmplabJenkins removed a comment on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled URL: https://github.com/apache/spark/pull/26664#issuecomment-558390302 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled URL: https://github.com/apache/spark/pull/26664#issuecomment-558390308 Test PASSed. Refer to this link for build results (access rights

[GitHub] [spark] AmplabJenkins commented on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled URL: https://github.com/apache/spark/pull/26664#issuecomment-558390302 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled URL: https://github.com/apache/spark/pull/26664#issuecomment-558390308 Test PASSed. Refer to this link for build results

[GitHub] [spark] maryannxue commented on issue #26633: [SPARK-29994][CORE] Add WILDCARD task location

2019-11-25 Thread GitBox
maryannxue commented on issue #26633: [SPARK-29994][CORE] Add WILDCARD task location URL: https://github.com/apache/spark/pull/26633#issuecomment-558389814 Sure, @jiangxb1987 ! This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled

2019-11-25 Thread GitBox
SparkQA commented on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled URL: https://github.com/apache/spark/pull/26664#issuecomment-558389788 **[Test build #114423 has

[GitHub] [spark] SparkQA removed a comment on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled

2019-11-25 Thread GitBox
SparkQA removed a comment on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled URL: https://github.com/apache/spark/pull/26664#issuecomment-558304425 **[Test build #114423 has

[GitHub] [spark] jiangxb1987 commented on issue #26633: [SPARK-29994][CORE] Add WILDCARD task location

2019-11-25 Thread GitBox
jiangxb1987 commented on issue #26633: [SPARK-29994][CORE] Add WILDCARD task location URL: https://github.com/apache/spark/pull/26633#issuecomment-558387585 Could we please hold this PR for a couple more days to allow more eyes on it, since it's a critical improvement to Spark Core?

<    1   2   3   4   5   6   7   8   9   10   >